Commit Graph

3015 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
521b5c3fed
Merge pull request #80994 from verult/csi-deregistration-loglevel
Bump log level of CSI driver de-registration to match registration handler
2019-08-06 06:06:09 -07:00
Kubernetes Prow Robot
345e58b434
Merge pull request #75071 from mkimuram/issue/74552e2e
Fix volume reconstruction and add e2e tests
2019-08-06 06:05:55 -07:00
Kubernetes Prow Robot
16d9a659da
Merge pull request #80837 from rmweir/use-default-skuname
Use default skuname shared Azure Disk
2019-08-06 03:11:55 -07:00
Eytan Heidingsfeld
6a94d50fb3 Add -s to du commands to not traverse other file systems 2019-08-06 14:59:19 +08:00
Kubernetes Prow Robot
1bc3d1abde
Merge pull request #80866 from ethan-daocloud/dev-ethan-csi-log
cleanup: remove package csi duplicated error log
2019-08-05 18:18:19 -07:00
Matthew Wong
bd42e728a8 Return error returned by CSINode Get if initialization failed 2019-08-05 23:01:50 +00:00
Cheng Xing
da64ca0c54 Bumped log level of CSI driver de-registration to match registration handler 2019-08-05 15:55:28 -07:00
ethan
d26e352fe7 cleanup: remove package csi duplicated error log
return err directly in func; delete new line in error message

cleanup: use errors.New(log()) to uniform error message
2019-08-05 20:35:28 +08:00
Kubernetes Prow Robot
369b765052
Merge pull request #80446 from hantaowang/test-verify-attach
Test verify attach
2019-08-03 15:33:49 -07:00
Kubernetes Prow Robot
5c16a784c6
Merge pull request #80923 from davidz627/fix/pdAttachLimit
Reduce GCE PD Attach Limits by 1 because Node Boot Disk counts as 1 attached disk
2019-08-03 01:27:51 -07:00
Kubernetes Prow Robot
9f6ebf0feb
Merge pull request #79144 from tedyu/csi-x-recur
Remove recursion in csiAttacher#waitForVolumeAttachmentInternal
2019-08-03 00:05:51 -07:00
Kubernetes Prow Robot
36391966f2
Merge pull request #78736 from endocrimes/dani/comment-fix
csi: Fix socket extension comment
2019-08-02 20:27:53 -07:00
Hantao (Will) Wang
1da12e9435 add unit tests for attacher DisksAreAttached and BulkDisksAreAttached 2019-08-02 14:24:51 -07:00
David Zhu
9ed06e2cf9 Reduce GCE PD Attach Limits by 1 because Node Boot Disk counts as 1 attached disk 2019-08-02 13:37:10 -07:00
Masaki Kimura
c130b77a48 Move nil check for mapperPlugin earlier in reconstructVolume 2019-08-01 20:36:21 +00:00
Jan Safranek
bab81b809b Don't create mounter when reconstructing block volume
CSI mounter will create a new directory + json for a filesystem volume,
leading to even more orphaned files/directories.
2019-08-01 20:04:10 +00:00
Kubernetes Prow Robot
270d9529e0
Merge pull request #80844 from zgfh/patch-7
cleanup: log message typo fix
2019-08-01 09:46:51 -07:00
Danielle Lancashire
d4c189d52b
csi: Fix socket extension comment
The CSI socket has used a sock extension since 179d8e108e. This removes
the stale TODO for updating it.
2019-08-01 14:52:46 +02:00
Kubernetes Prow Robot
4ce69dd32e
Merge pull request #80848 from cwdsuzhou/Aug/fix_ut
Fix some unreasonable places int csi ut
2019-08-01 03:30:14 -07:00
caiweidong
7b5dac03ce Fix some unreasonable places int csi ut 2019-08-01 14:19:11 +08:00
caiweidong
7dee721a3e Fix host path test clean up 2019-08-01 13:58:06 +08:00
Kubernetes Prow Robot
3a4cda9def
Merge pull request #80522 from ethan-daocloud/patch-3
cleanup: remove duplicated logging error message in csi_mounter.go, also some typos.
2019-07-31 22:36:39 -07:00
Alan
f0b18f74b7
cleanup: log message typo fix 2019-08-01 12:10:46 +08:00
moriadry
bacda8aaca update codedellemc/goscaleio
update thecodeteam/goscaleio

fix problem
2019-08-01 11:49:53 +08:00
ethan
ec2c5dff43 fix some log typos in csi_mounter.go
cleanup: remove logging duplicated error message
fix error msg, include err in new returned errors.
Signed-off-by: ethan <guangming.wang@daocloud.io>
2019-08-01 02:39:32 +00:00
rmweir
e543f9b2fe Use default skuname shared Azure Disk
Shared blob disks are now created with default skuname value if the
referenced storage class possesses empty values for storageaccounttype
and skuname. Prior, the provisioning process would fail if a new
storage account needed to be created. This is because a storage account
may not be created with an empty sotrageaccounttype.
2019-07-31 18:26:35 -07:00
Kubernetes Prow Robot
fde94e931f
Merge pull request #78941 from jsafrane/fix-iscsi-logout
Fix iscsi logout issues
2019-07-31 08:54:23 -07:00
Kubernetes Prow Robot
dcf1eff767
Merge pull request #80612 from AllenZMC/patch-1
fix typos in csi_attacher.go
2019-07-30 10:09:18 -07:00
skarthiksrinivas
73271c1970 Provision vSphere volume as per selectedNode 2019-07-28 22:03:02 -07:00
Kubernetes Prow Robot
de73f62336
Merge pull request #80495 from adityadani/update_openstorage_to_v1.0.0
pkg/volume/portworx: Update vendor for libopenstorage/openstorage to v1.0.0
2019-07-26 03:23:59 -07:00
AllenZMC
8833e4072c
fix typos in csi_attacher.go 2019-07-26 09:48:51 +08:00
Kubernetes Prow Robot
a3750501b0
Merge pull request #79983 from pohly/persistent-and-ephemeral-csi-volumes
persistent and ephemeral csi volumes
2019-07-25 16:01:54 -07:00
Aditya Dani
ab72c09937 Update pkg/volume/portworx OWNERs 2019-07-25 14:39:24 -07:00
Kubernetes Prow Robot
0e3b593ded
Merge pull request #79851 from jparklab/master
Fix nil pointer dereference error in volume_stat_calculator
2019-07-25 14:33:58 -07:00
Patrick Ohly
555ff7ef10 CSI: allow drivers that can handle persistent and ephemeral volumes
The conceptual change is that the mode in which a volume gets handled
is derived from it's spec, not from the ability of the driver. In
practice, that is already how the code worked because it didn't
actually look at CSIDriver.Spec.Mode at all.

Therefore the code change itself is mostly just renaming "driver mode"
to "volume mode". In some places (CanDeviceMount, CanAttach) the
feature check that was used elsewhere seemed to be missing. Now their
code path for ephemeral volumes are also only entered if that feature
is enabled.

The sanity check whether a CSI driver is being used correctly still
needs to be implemented.

Related-to: https://github.com/kubernetes/kubernetes/issues/79624
2019-07-25 16:45:46 +02:00
Kubernetes Prow Robot
7aa5f9727b
Merge pull request #80347 from humblec/metrics
Remove unwanted string converstion in metrics errors
2019-07-25 07:35:55 -07:00
Jan Safranek
cdcd2e2821 Report error when iscsiadm fails during detach
Kubernetes should retry detaching iSCSI volumes on error. In addition, it
should not report an error when detaching a disk while the disk is already
detached.
2019-07-25 10:10:01 +02:00
Kubernetes Prow Robot
9c903376f3
Merge pull request #80091 from bertinatto/iscsi_ref_counter
Add new iSCSI refcounter
2019-07-24 13:49:52 -07:00
Kubernetes Prow Robot
030274eba3
Merge pull request #80443 from davidz627/fix/verifyMigration
Add migration shim for verifyvolumeattachment and bulk verify
2019-07-24 05:30:15 -07:00
Fabio Bertinatto
44d7510ee0 Add unit test for iSCSI refcounter 2019-07-24 14:21:36 +02:00
Fabio Bertinatto
0007c2abd4 Add new refcounter for iSCSI volumes 2019-07-24 13:40:10 +02:00
Kubernetes Prow Robot
da3daf2e8a
Merge pull request #80451 from cwdsuzhou/July/fix_error_override
Fix error override when saveVolumeData occurs error
2019-07-24 02:02:15 -07:00
caiweidong
a5bf98a43e Fix error overrided when saveVolumeData occurs error 2019-07-24 10:19:22 +08:00
Kubernetes Prow Robot
60c2d44129
Merge pull request #79552 from wongma7/windows-ebs
Add support for AWS EBS on windows
2019-07-23 17:14:28 -07:00
Ted Yu
f4fbfcb46a Remove recursion in csiAttacher#waitForVolumeAttachmentInternal 2019-07-23 14:29:24 -07:00
David Zhu
290a7f12ce Add migration shim for VerifyVolumesAreAttached and BulkVolumeVerify 2019-07-23 12:57:47 -07:00
Matthew Wong
51615f691d Add support for windows to AWS EBS 2019-07-23 19:28:14 +00:00
caiweidong
45c52d1314 Fix potential panic in nodeGetVolumeStatsV1 2019-07-23 13:47:35 +08:00
caiweidong
8789143062 Fix csi attacher unit tests using t.Run() 2019-07-22 15:42:31 +08:00
Hantao (Will) Wang
7ee5861fb9 add ability for gce to bulk verify attached disks 2019-07-19 10:41:46 -07:00
Humble Chirammal
3ccaeef758 Remove unwanted string converstion in metrics errors
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-07-19 11:29:47 +05:30
Kubernetes Prow Robot
748849bbb9
Merge pull request #75805 from brahmaroutu/nfs_metrics
Adding metrics to nfs driver
2019-07-18 08:34:13 -07:00
Kubernetes Prow Robot
4b2c96c952
Merge pull request #79977 from bertinatto/fix_iscsi_cleanup
Fix iSCSI storage plugin cleanup in block volumes
2019-07-17 12:20:25 -07:00
David Zhu
831cd29f4e Add passthrough for MountOptions for NodeStageVolume for CSI 2019-07-16 16:17:47 -07:00
Fabio Bertinatto
80652c8d37 Fix iSCSI storage plugin cleanup in block volumes 2019-07-16 15:41:11 +02:00
Jeremy Xu
d8fc13791a Avoid RbdDiskManager's DetachDisk never execute again 2019-07-16 18:13:38 +08:00
Kubernetes Prow Robot
10a1d1f5bd
Merge pull request #79920 from cwdsuzhou/July/block_not_support_attach
Bugfix: csi plugin supporting raw block that does not need attach mounted failed
2019-07-15 08:39:21 -07:00
caiweidong
0c628e101a Bugfix: csi raw block that does not need attach mounted failed
Add unit test

fix verify-test-featurefates failed
2019-07-15 10:34:12 +08:00
Kubernetes Prow Robot
2bf8ab13c4
Merge pull request #80048 from davidz627/fix/tests
Fixes mount/unmount paths for migrated inline volumes
2019-07-12 20:19:17 -07:00
Davanum Srinivas
7fa6fc7226 Add explicit warning for deprecation of Cinder and ScaleIO volume providers
We have had a warning for OpenStack in-tree cloud provider, Here we are
adding more fine grained WARNING for OpenStack cinder volume provider in
addition to that.

Also identified ScaleIO as something that has not had activity or
updates for a while, So we should deprecate that as well
2019-07-12 10:29:09 -04:00
Kubernetes Prow Robot
b67acd3706
Merge pull request #79415 from choury/patch-2
Use Join instead of concat it manually in cephfs.
2019-07-12 06:31:31 -07:00
Kubernetes Prow Robot
9915047d3d
Merge pull request #79113 from tedyu/stop-w-detach
Close watcher early for volume detachment
2019-07-12 06:31:18 -07:00
Kubernetes Prow Robot
4423ff5fdd
Merge pull request #79656 from humblec/heketi-error
If volume in delete request does not exist, return success.
2019-07-12 05:15:06 -07:00
David Zhu
2820c1d8c8 Add davidz627 (David Zhu) to Approvers for OperationExecutor and GCE PD 2019-07-11 13:14:31 -07:00
David Zhu
93d6356d2f Fixes mount/unmount paths for migrated inline volumes. Some minor fixes for GCE specific inline migrated volumes 2019-07-11 11:51:43 -07:00
Kubernetes Prow Robot
514a157adf
Merge pull request #74691 from cpuguy83/epoll_use_cloexec
Use EPOLL_CLOEXEC to prevent fd leaks.
2019-07-10 21:38:55 -07:00
Kubernetes Prow Robot
8a1c9e2b41
Merge pull request #79924 from cwdsuzhou/July/projected_test_cleanup
Fix projected volume test clean up
2019-07-10 18:49:44 -07:00
Kubernetes Prow Robot
021ad88ac4
Merge pull request #79894 from odinuge/csi-client-dead-code
Remove dead code from csi_client
2019-07-10 06:20:25 -07:00
caiweidong
94a2a42412 Fix projected volume test clean up 2019-07-10 10:14:36 +08:00
Kubernetes Prow Robot
d59a603f1b
Merge pull request #78267 from mucahitkurt/cleanup/operation-generator-migration-scenarios-unit-tests
unit tests for operationGenerator.GenerateUnmapVolumeFunc
2019-07-09 18:20:25 -07:00
Brian Goff
0051db89a7 Use O_CLOEXEC for volume subpath util
This prevents fd's from leaking to subprocesses.
2019-07-09 10:03:59 -07:00
Humble Chirammal
c22cc06b90 If volume in delete request does not exist, return success.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-07-09 19:43:40 +05:30
Odin Ugedal
542c335fca Remove dead code from csi_client
When removing a feature flag in
35bc5dc6b6, a few of the lines were
removed, resulting in some dead code.
2019-07-08 17:53:52 +02:00
Ji-Young Park
528521cfae Return MetricsError with ErrCodeNotSupported code
GetMetrics function expects MetricsError error
with ErrCodeNotSupported code when driver for the volume
does not support metrics
Updated csi_metrics to return error when underlying csi
driver does not have GET_VOLUME_STATS capability
2019-07-06 10:49:06 -04:00
Kubernetes Prow Robot
a3be4b6817
Merge pull request #79529 from andyzhangx/change-csi-timeout
fix: change default timeout value in csi plugin
2019-07-03 09:12:58 -07:00
Kubernetes Prow Robot
a5e3d74691
Merge pull request #79534 from odinuge/volume-util-fd
Fix possible fd leak and closing of dirs in doSafeMakeDir
2019-07-01 15:09:58 -07:00
Kubernetes Prow Robot
92ef26d651
Merge pull request #77795 from nagexiucai/glusterfs--backup-volfile-servers--option-warning
Remove selected IP from backup-volfile-servers list to avoid warning in mount logs.
2019-07-01 07:23:21 -07:00
choury
edc21ac27b Use Join instead of concat it manually in cephfs. 2019-07-01 20:09:43 +08:00
Kubernetes Prow Robot
2501a9083d
Merge pull request #68513 from codenrhoden/mount-refactor
Refactor util/mount interface in prep for moving out of k/k
2019-06-28 13:57:28 -07:00
Odin Ugedal
626a0f7b4b Fix closing of dirs in doSafeMakeDir
This fixes the issue where "childFD" from syscall.Openat is assigned to
a local variable inside the for loop, instead of the correct one in the
function scope. This results in that when trying to close the "childFD"
in the function scope, it will be equal to "-1", instead of the correct
value.
2019-06-28 18:21:12 +02:00
andyzhangx
d8c92f5c09 fix: change timeout value in csi plugin 2019-06-28 14:27:22 +00:00
Kubernetes Prow Robot
22fb6fd174
Merge pull request #77595 from bertinatto/volume_limits
Volume Scheduling Limits
2019-06-25 17:01:16 -07:00
Kubernetes Prow Robot
1215aa73d2
Merge pull request #79176 from verb/debug-iterate-containers
Add helpers for iterating containers in a pod
2019-06-25 09:32:52 -07:00
Fabio Bertinatto
33c8bacd41 Update nodeinfomanager to store volume limits in CSINode 2019-06-25 16:30:54 +02:00
draveness
35bc5dc6b6 feat: cleanup feature gates for KubeletPluginsWatcher 2019-06-23 16:59:36 +08:00
Lee Verberne
a0b57ad3db Update BUILD files for container helper 2019-06-21 08:32:04 +00:00
Lee Verberne
ee821e2a04 Create helpers for iterating containers in a pod 2019-06-21 08:32:04 +00:00
Ted Yu
005065f8fc Close watcher early for volume detachment 2019-06-17 15:09:43 -07:00
Kubernetes Prow Robot
365283e202
Merge pull request #78532 from cwdsuzhou/simplify_construct_volume_spec
Simplify func ConstructVolumeSpec
2019-06-17 11:05:49 -07:00
Kubernetes Prow Robot
e46b9ca656
Merge pull request #78754 from cwdsuzhou/June/csi_attach_close_chan
Avoid to keep the watcher open for too long
2019-06-17 04:36:37 -07:00
nagexiucai
63cb1d65ca Remove selected IP from backup-volfile-servers list to avoid warning in mount logs. 2019-06-17 16:36:53 +08:00
Kubernetes Prow Robot
5868ff8973
Merge pull request #78979 from Lah123/patch-1
Correct a typo 'concurrrent'
2019-06-15 03:46:36 -07:00
Kubernetes Prow Robot
bde744eb97
Merge pull request #78839 from tedyu/cleaner-err
Check correct error for cleanup in csiAttacher#MountDevice
2019-06-14 20:47:01 -07:00
Kubernetes Prow Robot
15c8df161e
Merge pull request #76356 from qingsenLi/k8s190410-fix-coresponding
fix error 'coresponding'
2019-06-14 20:46:10 -07:00
qingsenLi
7a0efd326b fix golint failures for pkg/volume/scaleio and pkg/volume/storageos 2019-06-15 10:53:50 +08:00
Kubernetes Prow Robot
9bef69a2b4
Merge pull request #78768 from humblec/cleanup
Remove unwanted newlines in glusterfs driver
2019-06-14 15:26:22 -07:00
Travis Rhoden
be7da5052f Refactor pkg/util/mount to be more reusable
This patch refactors pkg/util/mount to be more usable outside of
Kubernetes. This is done by refactoring mount.Interface to only contain
methods that are not K8s specific. Methods that are not relevant to
basic mount activities but still have OS-specific implementations are
now found in a mount.HostUtils interface.
2019-06-14 09:35:18 -06:00
Kubernetes Prow Robot
518f16636f
Merge pull request #78593 from RobertKrawitz/ephemeral-storage-quota-cleanup
Ephemeral storage quota cleanup
2019-06-14 05:33:18 -07:00
Kubernetes Prow Robot
70b46ca5fb
Merge pull request #78529 from cwdsuzhou/remove_verbose_err
Remove dead codes
2019-06-14 04:09:13 -07:00
Kubernetes Prow Robot
3a598d7f92
Merge pull request #75234 from andyzhangx/corrupt-mnt-fix
fix pod stuck issue due to corrupt mnt point in flexvol plugin
2019-06-13 20:36:34 -07:00
Srini Brahmaroutu
bbc7ba8f51 Adding metrics to nfs driver 2019-06-13 10:21:20 -07:00
Lah123
c86b6d1ec5
Correct a typo
From concurrrent to concurrent
2019-06-13 14:29:11 +02:00
Mucahit Kurt
db1c07750a unit tests for the volume plugin name that's used inside GeneratedUnmapVolumeFunc for csi migration on/off scenarios
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
2019-06-11 08:32:25 +03:00
Davanum Srinivas
e0821ca3dd
Remove ovirt/cloudstack/photon cloud providers
Change-Id: Iddb80bdc2a9d75d444b8a3cfe0b142acb78e9097
2019-06-10 12:50:53 -04:00
Ted Yu
de92897e26 Check correct error for cleanup 2019-06-09 21:29:28 -07:00
Kubernetes Prow Robot
3d4124f2e0
Merge pull request #68108 from wenjun93/iscsiVol
add lun info when construct iscsi volumeSpec from mountPath
2019-06-09 20:45:06 -07:00
caiweidong
0508bea9b6 Fix keep the watcher open for too long 2019-06-07 21:40:50 +08:00
Kubernetes Prow Robot
333081e79c
Merge pull request #78595 from gnufied/fix-aws-dangling-volumes
Add dangling volume as uncertain
2019-06-06 16:47:59 -07:00
Hemant Kumar
7bcebe98bb Add dangling volume as uncertain 2019-06-06 15:25:10 -04:00
Humble Chirammal
b867f601da Remove unwanted newlines in glusterfs driver
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-06-06 22:03:15 +05:30
caiweidong
4ce2f296f5 Simplify func ConstructVolumeSpec 2019-06-05 10:22:13 +08:00
Kubernetes Prow Robot
304a2b191d
Merge pull request #78522 from croomes/bugfix-78517-storageos-mountref
StorageOS volume driver: Remove call to clear mount info if already set
2019-06-04 14:33:50 -07:00
Kubernetes Prow Robot
8657b24d86
Merge pull request #78681 from yuxiangqian/e2efix
fix label mismatching which broke e2e serial test
2019-06-04 10:53:21 -07:00
xiangqian
d616c6fb5a fix label mismatching which broke e2e serial test 2019-06-03 23:33:37 -07:00
Hemant Kumar
0f62e3fbe8 Make language of error msgs and func names consistent: ExpandVolumeInUse
change feature flag
Fix the e2e test for online and offline expansion
2019-06-03 12:26:56 -04:00
caiweidong
b726db66d2 Remove dead codes 2019-06-03 22:15:53 +08:00
Kubernetes Prow Robot
8362e9c4f9
Merge pull request #78475 from humblec/iscsi-higher-timeout
Increase device discovery timeout to 30seconds/equal to checker_timeout
2019-06-01 02:54:30 -07:00
Kubernetes Prow Robot
f14b128ea6
Merge pull request #78276 from zhan849/ebs-get-zone-opt1
Use zone from node for topology aware aws-ebs volume creation
2019-05-31 22:03:12 -07:00
Kubernetes Prow Robot
b3c1bbb471
Merge pull request #78061 from yuxiangqian/metrics
Enhance to record more accurate e2e provision/deletion latency metric
2019-05-31 20:45:13 -07:00
Kubernetes Prow Robot
b7fa33ec15
Merge pull request #77703 from ddebroy/inline-mig-1
API changes to support migration of inline in-tree volumes to CSI
2019-05-31 12:23:19 -07:00
Robert Krawitz
bf1f0fa5d9 Remove pod UID from volumeMount, we can get it elsewhere 2019-05-31 14:25:01 -04:00
Robert Krawitz
10d37bb748 Rename pkg/volume/util/quota -> pkg/volume/util/fsquota 2019-05-31 13:57:44 -04:00
Kubernetes Prow Robot
cf76868b34
Merge pull request #66928 from RobertKrawitz/ephemeral-storage-quota-exp
Ephemeral storage monitoring via filesystem quotas
2019-05-30 20:44:26 -07:00
Humble Chirammal
d4ea88f3ce Increase device discovery timeout to 30seconds/equal to checker_timeout.
At present, iscsi plugin wait for 10seconds for a path to appear for a multipath
device, but at certain scenarios this may not be sufficient for device mapper
to get the path. The default multipath configuration has a configuation
called 'checker_timeout' which specify the timeout to user for path checkers
that issue scsi commands with an explicit timeout, in seconds;
default taken from /sys/block/sd*/device/timeout which is 30s.
This patch lift the timeout value from 10s to 30s.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-30 21:46:06 +05:30
Simon Croome
6d9f4659d8 Remove call to clear mount info if already set
https://github.com/kubernetes/kubernetes/pull/69782 introduced a change
to register the device attachment (in the StorageOS API) prior to the
volume attachment.  The volume attachment code would clear any mount
info, causing the StorageOS API to register the mount and then
immediately de-register it.

The code to clear the mount info on volume attach is no longer needed.
It was used to force-mount a volume if StorageOS thought it was already
mounted.  In practice it was not needed, and administrators have other
ways of clearing stale mount information if required.
2019-05-30 14:21:31 +01:00
Deep Debroy
de7be9d613 Populate InlineVolumeSpec in CSI attacher and translation library
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-05-30 09:35:22 +00:00
Kubernetes Prow Robot
ade661c7cb
Merge pull request #78356 from andyzhangx/csi-translation-azurefile
Add support for Azure File plugin to csi-translation-lib
2019-05-29 22:54:31 -07:00
Kubernetes Prow Robot
05df640f33
Merge pull request #77994 from gnufied/csi-resize-migration
Handle CSI volume resize migration.
2019-05-29 21:28:43 -07:00
andyzhangx
f5b319c088 add azure file CSI translation feature gate
fix build error

fix gofmt error
2019-05-30 00:54:39 +00:00
Kubernetes Prow Robot
8d5052eddf
Merge pull request #78330 from andyzhangx/csi-translation-azuredisk
Add support for Azure Disk to csi-translation-lib
2019-05-29 17:25:11 -07:00
xiangqian
9688511595 record provision and deletion latency metric
instead of using provisioner from storage class directly, uses plugin name firstly
2019-05-29 14:15:30 -07:00
Robert Krawitz
9f4a4d1f49 Log message rather than error if setting quota fails 2019-05-29 15:17:47 -04:00
Robert Krawitz
f8661d6240 Use xfs_quota command to apply quotas 2019-05-29 15:12:28 -04:00
Robert Krawitz
448e0c44c6 Apply quotas via syscalls using cgo. 2019-05-29 15:12:28 -04:00
Robert Krawitz
5b97b2860d Change fsGroup to mounterArgs in volume.SetUp() to allow for future extension. 2019-05-29 15:12:28 -04:00
Kubernetes Prow Robot
38468e4338
Merge pull request #70536 from mysunshine92/golint-hostpath
fix golint for pkg/volume/host_path
2019-05-29 11:25:46 -07:00
Kubernetes Prow Robot
cf1ccf1253
Merge pull request #78332 from qingsenLi/k8s-190525
fix klog format error
2019-05-29 09:44:51 -07:00
Hemant Kumar
7563b4d01b Address comments about retry in online resizing block 2019-05-29 11:01:45 -04:00
Hemant Kumar
d119899e22 handle review comments 2019-05-28 15:22:41 -04:00
andyzhangx
6f2902e0a3 add feature gate for azure disk
fix gofmt error
2019-05-28 15:38:52 +00:00
qingsenLi
9d487d9fd9 spelling error 'doen't' 2019-05-28 17:41:42 +08:00
Harry Zhang
90eb408142 Use zone from node for topology aware volume creation 2019-05-27 17:13:42 -07:00
qingsenLi
62dea14351 fix klog format error 2019-05-27 18:05:09 +08:00
Di Xu
f715d41635 fix bug for regular empty file 2019-05-27 14:35:24 +08:00
Hemant Kumar
4d481a0f29 Fix flake associated with time out volumes
This test is suspectible to flakes because sometimes
while we verify if volume is attached to a node, reconciler
loop can turn second time and it can confirm the volume as attached.
2019-05-23 13:33:37 -04:00
Kubernetes Prow Robot
b533613233
Merge pull request #77851 from andyzhangx/azuredisk-max-count
remove vmsizelist call in azure disk GetVolumeLimits
2019-05-23 03:28:26 -07:00
Kubernetes Prow Robot
d5876954e1
Merge pull request #76178 from humblec/endpoint
Create endpoint/service early to avoid unwanted create/delete volume transaction.
2019-05-22 09:58:09 -07:00
andyzhangx
fb81a28a47 fix flexvol stuck issue due to corrupted mnt point
fix comments about PathExists

fix comments

revert change in PathExists func
2019-05-22 08:52:58 +00:00
Hemant Kumar
0ab6bdfa36 Wait for waitforattach goroutine before exiting
This test suite fails in weird ways without waiting for the
goroutine
2019-05-21 09:57:47 -04:00
Hemant Kumar
33b95ebddb add some tests for expand controller
Update bazel file
2019-05-20 10:55:23 -04:00
andyzhangx
b962361536 remove vmsizelist call in azure disk
add one comment

add comments

use a new way to generate vm size list
2019-05-18 03:41:34 +00:00
Kubernetes Prow Robot
fad34e404e
Merge pull request #76188 from humblec/csi-in-m
csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call
2019-05-17 20:26:09 -07:00
Hemant Kumar
405d33eae4 Add code to handle in-tree to CSI migration for resizing 2019-05-17 10:57:44 -04:00
Humble Chirammal
c511c90b59 csi: Implement NodeServiceCapability_RPC_GET_VOLUME_STATS rpc call
and implement Metrics Provider for CSI driver

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-17 17:10:53 +05:30
Kubernetes Prow Robot
da4d6f5829
Merge pull request #77883 from gnufied/mat-expand-workqueue
Use workqueues for volume expansion
2019-05-17 02:04:18 -07:00
Hemant Kumar
4886e8782c name the queue properly and use lower case for error message 2019-05-16 21:34:57 -04:00
Hemant Kumar
673773cbde check for pvc objects 2019-05-16 12:23:52 -04:00
Kubernetes Prow Robot
6a9ecf71fd
Merge pull request #77912 from andyzhangx/fix-azuredisk-lun-error
Fix incorrect azuredisk lun error
2019-05-16 08:48:54 -07:00
andyzhangx
4213f4d797 fix azure disk lun error 2019-05-15 08:32:03 +00:00
Matthew Wong
c16a555654 Use workqueue model in expand controller
Add a test for patch creation
2019-05-14 16:42:06 -04:00
Mike Crute
7d62316f8f Migrate fake cloud provider to staging 2019-05-14 13:32:18 -07:00
Humble Chirammal
e47a7897ea Fail early if driver cant get kubeclient
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-14 10:29:59 +05:30
Ted Yu
2001feead2 Move the array of plugin names to inside the last if block in VolumePluginMgr#FindPluginBySpec 2019-05-14 05:48:24 +08:00
Kubernetes Prow Robot
ed239cefa6
Merge pull request #77483 from andyzhangx/azuredisk-waitforattach
remove VM API call dependency in azure disk WaitForAttach
2019-05-08 23:07:01 -07:00
Kubernetes Prow Robot
c2966f7c29
Merge pull request #77537 from cwdsuzhou/use_key_in_lugins
Use key in probedPlugin
2019-05-08 20:13:01 -07:00
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Kubernetes Prow Robot
291f2f863a
Merge pull request #77415 from Fedosin/allow_define_kubeconfig
Allow to define kubeconfig file for OpenStack cloud provider
2019-05-07 23:38:32 -07:00
Kubernetes Prow Robot
7aa57df279
Merge pull request #77374 from cheftako/gce-staging
Staging the GCE Cloud Provider
2019-05-07 17:52:32 -07:00
Kubernetes Prow Robot
2a7eaa30da
Merge pull request #77385 from humblec/gluster-error
Avoid duplicate error reporting in glusterfs
2019-05-07 14:31:28 -07:00
Walter Fender
796097ae40 Staging the GCE Cloud Provider
**What type of PR is this?**
/kind cleanup

**What this PR does / why we need it**:
Staging the GCE Cloud Provider as part of KEP [20190125-removing-in-tree-providers](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md). Staging repo setup here https://github.com/kubernetes/legacy-cloud-providers
Moves the GCE cloud provider implementation to staging.
This is in preparation for moving the cloud provider code out of tree entirely.
However we need it in staging while the code needs to be consumed both in/out of tree.

**Which issue(s) this PR fixes**:
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```
NONE
```

Updated import dependency tracking.
Factored in the cleanup from #77412
Minor fix to go.mod.
2019-05-07 13:17:52 -07:00
Kubernetes Prow Robot
e332051416
Merge pull request #77433 from cwdsuzhou/common_func_for_ad
Add common func for NewAttacher and NewDetacher
2019-05-07 09:51:56 -07:00
Kubernetes Prow Robot
2e6f58ddf8
Merge pull request #77431 from cwdsuzhou/Add_detacher_assert_check
Add detacher assertion for csiAttacher
2019-05-07 09:51:44 -07:00
caiweidong
cf1eeed30c Use key in probedPlugin 2019-05-07 18:43:26 +08:00
andyzhangx
9a8f07dd9f remove VM API call dep in azure disk WaitForAttach
add comment

add unit test for WaitForAttach fnc

add unit test for WaitForAttach Func
2019-05-07 06:21:44 +00:00
Kubernetes Prow Robot
a8787dac30
Merge pull request #76927 from mrkm4ntr/unnecessary-goroutine
Do not generate unnecessary goroutines
2019-05-06 21:31:53 -07:00
Kubernetes Prow Robot
56ceba5e30
Merge pull request #77352 from mcrute/move-aws-provider
Staging legacy AWS cloud provider
2019-05-06 15:30:19 -07:00
Kubernetes Prow Robot
e0d39be7b5
Merge pull request #76785 from dims/typo-extra-space-in-fatalf-format-string
typo - extra space - in Fatalf format string
2019-05-06 14:01:39 -07:00
Mike Crute
6f5cf1a6e0 Staging legacy AWS cloud provider 2019-05-06 09:34:13 -07:00
danielqsj
bdd5c15dee refer to constant to guarantee constant behavior 2019-05-05 11:17:42 +08:00
Mike Fedosin
bac2291141 Allow to define kubeconfig file for OpenStack cloud provider
Now, to build a kubernetes client, provider uses only in-cluster config,
but if kubelet is not running as a pod, then it doesn't work.

This commit adds an ability to specify a path to the kubeconfig file if
necessary. If no value was provided, then the provider falls back to
in-cluster config.
2019-05-05 00:31:14 +02:00
caiweidong
62fe5fe7b8 add common func for NewAttacher and NewDetacher 2019-05-04 11:08:28 +08:00
caiweidong
5d89ab26e9 Add detacher assert for csiAttacher 2019-05-04 10:43:46 +08:00
Jordan Liggitt
63ddfc1db9 Lock GCERegionalPersistentDisk feature on 2019-05-03 14:21:34 -04:00
Humble Chirammal
427df38c6b Avoid duplicate error reporting in glusterfs
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-03 13:42:36 +05:30
Kubernetes Prow Robot
ca21efd1c5
Merge pull request #76983 from humblec/rotate
Shuffle addresslist for random mount server and cleanup error messages.
2019-05-03 01:02:47 -07:00
Humble Chirammal
745f12837f Rename createEndpointService() to createOrGetEndpointService()
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-02 21:06:54 +05:30
Kubernetes Prow Robot
b07f311322
Merge pull request #76882 from SataQiu/fix-golint-controller-20190422
Fix golint failures of pkg/controller/certificates/approver, etc
2019-05-02 03:16:18 -07:00
Kubernetes Prow Robot
9e52832c52
Merge pull request #77317 from gnufied/fix-block-volume-resizing
Fix block volume expansion
2019-05-01 20:42:56 -07:00
SataQiu
d76f1a8fd6 fix golint failures of pkg/volume/util/recyclerclient 2019-05-02 10:27:56 +08:00
Kubernetes Prow Robot
b5c34d0c43
Merge pull request #74734 from codenrhoden/move-mountspath
Move MountsInGlobalPDPath from mount pkg to volume
2019-05-01 17:28:18 -07:00
Hemant Kumar
0eb68c5a22 Fix blockvolume expansion 2019-05-01 18:25:54 -04:00
Kubernetes Prow Robot
2b561456ce
Merge pull request #77101 from davidz627/feature/migrationTest
Add testing infra for checking whether an in-tree plugin is using backend that is shimmed to CSI
2019-05-01 14:32:30 -07:00
David Zhu
1271237d23 Add migration metrics checking to all test suites 2019-05-01 11:24:03 -07:00
Humble Chirammal
a3c1a6da02 Error message corrections
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-01 13:36:52 +05:30
Kubernetes Prow Robot
9466118e8f
Merge pull request #77229 from tedyu/csi-node-expansion
Return early when node expansion is determined
2019-04-30 17:31:25 -07:00
Kubernetes Prow Robot
55a052481d
Merge pull request #76944 from SataQiu/fix-golint-volume-20190423
Fix golint failures of pkg/volume/nfs
2019-04-30 17:31:12 -07:00
Kubernetes Prow Robot
a69702e83a
Merge pull request #76755 from ping035627/k8s-190418
delete some unused code for awsebs
2019-04-30 07:05:39 -07:00
Ted Yu
ebe499ec80 Remove variable nodeExpandSet 2019-04-30 06:44:29 -07:00
Kubernetes Prow Robot
1a52d4f6fe
Merge pull request #76977 from jingxu97/April/volumelimit
Update the dynamic volume limit in GCE PD
2019-04-29 22:49:47 -07:00
Ted Yu
565c88de14 Return early when node expansion is determined 2019-04-29 14:05:08 -07:00
Travis Rhoden
78d109e201 Always use filepath.Join instead of path.Join
This patch cleans up pkg/util/mount/* and pkg/util/volume/* to always
use filepath.Join instead of path.Join. filepath.Join is preferred
because path.Join can have issues on Windows.
2019-04-29 09:56:05 -06:00
Travis Rhoden
12b7f1450c Move MountsInGlobalPDPath from mount pkg to volume
Since pkg/util/mount is going to move out of k/k, this exported constant
that is Kubernetes specific needed to move somewhere else. Made sense to
move it to pkg/volume/util.

Update GetDeviceNameFromMount in the mount interface to now take a
pluginMountDir argument, which is volume plugin dir with the global
mount path appended to it already.
2019-04-29 09:56:00 -06:00
Stephen Augustus
2f74c90480 Staging the legacy Azure Cloud Provider
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
2019-04-25 20:03:45 -04:00
David Zhu
213cc99ead Operation generator migration metric fixes and test metrics retrieval code 2019-04-25 16:27:45 -07:00
Jing Xu
9926815246 Update the dynamic volume limit in GCE PD
Currently GCE PD support 128 maximum disks attached to a node for all
machines types except shared-core. This PR updates the limit number to
date.

Change-Id: Id9dfdbd24763b6b4138935842c246b1803838b78
2019-04-25 11:08:19 -07:00
Kubernetes Prow Robot
88992ba185
Merge pull request #75986 from mucahitkurt/improvement/reduce-event-spam-for-GenerateAttachVolumeFunc
Reduce event spam for function GenerateAttachVolumeFunc
2019-04-24 18:12:44 -07:00
Kubernetes Prow Robot
e4a57b77ec
Merge pull request #76719 from bertinatto/fix_vsphere_size
Fix Vsphere rouding up of volume size
2019-04-24 16:50:46 -07:00
yameiwang
f130e48deb fix golint errors in pkg/volume/host_path 2019-04-25 06:46:47 +08:00
Kubernetes Prow Robot
2e96bf597e
Merge pull request #76988 from andyzhangx/azurefile-create
specify azure file share name in azure file plugin
2019-04-24 14:21:09 -07:00
Kubernetes Prow Robot
e53118df1b
Merge pull request #76945 from SataQiu/fix-golint-volume-2019042302
Fix golint failures of pkg/volume/portworx
2019-04-24 14:20:58 -07:00
Mucahit Kurt
1c1da755dc reduce event spam for function GenerateAttachVolumeFunc
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
2019-04-24 23:45:28 +03:00
andyzhangx
ad9d033e50 add shareName param in azure file storage class
skip create azure file if it exists
2019-04-24 05:48:58 +00:00
Humble Chirammal
f30b14a408 Shuffle addresslist for random mount server and cleanup error messages.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2019-04-24 09:08:15 +05:30
Andrew Sy Kim
a58942625d staging the vsphere cloud provider under k8s.io/legacy-cloud-providers/vsphere
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-04-23 22:17:59 -05:00
SataQiu
a37adceadf fix golint failures of pkg/volume/portworx 2019-04-23 23:26:41 +08:00
SataQiu
d6d329b0eb fix golint failures of pkg/volume/nfs 2019-04-23 22:25:46 +08:00
Shintaro Murakami
f8e81337da Do not generate unnecessary goroutine 2019-04-23 16:22:14 +09:00
Kubernetes Prow Robot
b9606bef8d
Merge pull request #76860 from SataQiu/fix-golint-volume-20190420
Fix golint failures of pkg/volume/local
2019-04-22 20:44:07 -07:00
Pengfei Ni
c27ff9a11e Upgrade compute API to version 2019-03-01 2019-04-21 18:12:29 +08:00
SataQiu
1f40880615 fix golint failures of pkg/volume/local 2019-04-20 18:18:25 +08:00
Kubernetes Prow Robot
29163600fe
Merge pull request #76796 from dims/remove-unused-methods
Remove unused code
2019-04-19 11:09:55 -07:00
Davanum Srinivas
7b8c9acc09
remove unused code
Change-Id: If821920ec8872e326b7d85437ad8d2620807799d
2019-04-19 08:36:31 -04:00
Kubernetes Prow Robot
64a0441c2b
Merge pull request #76573 from andyzhangx/disk-backoff-refactor
fix detach azure disk back off issue which has too big lock in failure retry condition
2019-04-18 23:39:54 -07:00
Kubernetes Prow Robot
10fc2a11a0
Merge pull request #76089 from vladimirvivien/csi-device-mount-skip
CSI - Skips deviceMounter.MountDevice for ephemeral volumes
2019-04-18 19:36:09 -07:00
Kubernetes Prow Robot
fc545587e4
Merge pull request #76540 from ialidzhikov/glusterfs-uneffectual-assignment
Remove ineffectual assignment
2019-04-18 17:17:55 -07:00
Vladimir Vivien
d564d2e74d CSI - Prevents unsupported device mount with CanMountDevice(spec) check 2019-04-18 19:54:28 -04:00
Davanum Srinivas
22ffdc6063
typo - extra space - in Fatalf format string
Change-Id: Ifeff0ee29aa6ccdc4c3ebdd2a071cebfafaf937e
2019-04-18 14:42:21 -04:00
PingWang
64c84aa610 delete some unused code for awsebs
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2019-04-18 16:51:29 +08:00
Kubernetes Prow Robot
7e02769736
Merge pull request #75926 from cwdsuzhou/operation_generator_add_attach_detach
Add operation name for other volume operations
2019-04-18 00:26:08 -07:00
Kubernetes Prow Robot
32a49828fe
Merge pull request #76456 from codenrhoden/mv-exec-mounter
Move ExecMount to pkg/volume/util/exec
2019-04-17 12:16:20 -07:00
Fabio Bertinatto
c2fc91adc7 Fix rounding-up of Vsphere volume size 2019-04-17 14:56:39 +02:00
Humble Chirammal
c86828b74b Cleanup volume, ep/svc if endpoint update failed.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-04-16 11:50:42 +05:30
andyzhangx
6c70ca61be move disk lock process to azure cloud provider
fix comments

fix import keymux check error

add unit test for attach/detach disk funcs
2019-04-16 05:31:18 +00:00
Kubernetes Prow Robot
d424bedc9b
Merge pull request #76341 from harsh-px/fix-concurrent-access-master
Fix concurrent map write access in Portworx create volume call
2019-04-15 11:46:24 -07:00
ialidzhikov
98c976ae4f Clean ineffectual assignment
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2019-04-13 16:23:07 +03:00
andyzhangx
39c239c308 refactor detach azure disk retry operation 2019-04-13 12:45:32 +00:00
Vladimir Vivien
b138e6d1e2 CSI - Surfaces klog flags; common tests aggregation 2019-04-12 15:38:06 -04:00
caiweidong
7c9e567008 add operation name for other volume operations 2019-04-12 11:09:13 +08:00
Travis Rhoden
96476fd054 Fix linting issues for exec mounter 2019-04-11 13:22:14 -06:00
Travis Rhoden
f38d4938be Move ExecMount to pkg/volume/util/exec
This patch moves the ExecMounter found in pkg/util/mount to
pkg/volume/util/exec. This is done in preparation for pkg/util/mount to
move out of tree. This specific implemention of mount.Interface is only
used internally to K8s and does not need to move out of tree.
2019-04-11 12:19:55 -06:00
Humble Chirammal
58e65c053a Resolve merge conflict
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-04-10 20:51:02 +05:30
Humble Chirammal
7544b53693 Create endpoint/service early to avoid unwanted create/delete volume transaction.
At times, for some reason endpoint/service creation can fail in a setup. As we
currently create endpoint/service after volume creation, later we need rollback
of this volume transaction if endpoint/service creation failed. Considering
endpoint/service creation is light weight, this patch promote endpoint/service
creation to an early stage.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-04-10 19:06:27 +05:30
qingsenLi
f0cef5bd36 fix error 'coresponding' 2019-04-10 17:43:35 +08:00
Kubernetes Prow Robot
a2c200a57a
Merge pull request #76326 from andyzhangx/azuredisk-typo
fix typo in azure disk logging
2019-04-09 19:58:12 -07:00
Harsh Desai
17dd5989df Fix concurrent map access in Portworx create volume call
Fixes #76340

Signed-off-by: Harsh Desai <harsh@portworx.com>
2019-04-09 12:13:19 -07:00
Kubernetes Prow Robot
454666bca8
Merge pull request #76184 from humblec/pvc
Use pvc uid in endpoint/service label
2019-04-09 11:21:14 -07:00
Kubernetes Prow Robot
c62cd6e3a4
Merge pull request #76047 from codenrhoden/mv-nsenter-mount
Move nsenter mounter to pkg/volume/util/nsenter
2019-04-09 09:55:59 -07:00
andyzhangx
8d1578370a fix typo in azure disk logging 2019-04-09 09:01:52 +00:00
Vladimir Vivien
cfafde983b Volume AttachablePlugin.CanAttach() now returns both bool and error 2019-04-08 16:53:22 -04:00
Travis Rhoden
2253807760 Fix pkg/volume/util/nsenter linting errors 2019-04-08 10:43:54 -06:00
Travis Rhoden
1c045a09db Move nsenter mounter to pkg/volume/util/nsenter
As part of moving pkg/util/mount out of tree, the NSEnter implementation
of mount.Interface needs to be relocated out of pkg/util/mount, as it is
K8s specific. This patch relocates that mounter implementation to
pkg/volume/util/nsenter.

Since the NSEnter mounter shares a lot of its logic with the Linux
mounter implementation, many of the previously private methods of the
Linux mounter are now made public to maintain that shared code.

Additionaly, it was observed that *all* mount.Interface implemenations
were using the same common method for IsNotMountPoint, so this patch
removes that method from the mount.Interface definition and just exports
the common implementation instead.
2019-04-08 09:53:46 -06:00
Xing Yang
000ab86788 Move CSIDriver Lister to the controller 2019-04-05 12:20:11 -07:00
Humble Chirammal
6eae6bbac5 Use pvc uid in endpoint/service label
If the pvc name is more than 63 chars, the endpoint creation
will fail due to the validation of objectmeta length of fields ie 63 chars at max.
This patch introduce an enhancement where if the pvc name is >=63 the pvc uid
is recorded at label instead of name. To preserve backward compatibility, the pvcname
has been kept in endpoint metadata label if length of pvc name is <63chars.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-04-05 20:30:57 +05:30
Michelle Au
33bf81f22a Improve volume operation metrics 2019-04-03 11:59:21 -07:00
Kubernetes Prow Robot
60638c71bd
Merge pull request #75481 from mucahitkurt/refactor/nodeinfomanager-tests
Add expectedCSINode for csiNodeEnabled test cases on nodeinfomanager tests
2019-03-29 17:33:08 -07:00
Kubernetes Prow Robot
7a478a4609
Merge pull request #75844 from vladimirvivien/volume-skip-device-mount
Volume DeviceMountablePlugin.CanDeviceMount check when retrieving plugins
2019-03-29 13:02:13 -07:00
Mucahit Kurt
6113cd57bc add expectedCSINode and expectedNode for test cases to compare CSINode and Node object instead of field based comparisons
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
2019-03-29 23:01:26 +03:00
Kubernetes Prow Robot
861f1fcb2e
Merge pull request #75799 from msau42/csi-empty-devicepath
return empty devicepath for csi attach
2019-03-29 06:08:13 -07:00
Kubernetes Prow Robot
b1829dff0b
Merge pull request #74844 from leakingtapan/migration-raw-block
Implement CSI migration logic for block volume
2019-03-28 18:12:14 -07:00
Vladimir Vivien
3777514f83 Adds DeviceMountablePlugin.CanDeviceMount check when retrieving plugins 2019-03-28 10:39:32 -04:00
Michelle Au
ab6a2530fb return empty devicepath for csi attach 2019-03-27 17:28:21 -07:00
Cheng Pan
f7050a04ce Implement CSI migration logic for block volume 2019-03-26 22:22:03 +00:00
Kubernetes Prow Robot
055061637a
Merge pull request #75062 from Fedosin/openstack_config_from_secrets
Allow to read OpenStack config from the secret
2019-03-25 09:01:20 -07:00
Kubernetes Prow Robot
8da0c4af29
Merge pull request #75213 from gnufied/allow-different-operation-names-storage
Allow different operation names
2019-03-20 07:41:07 -07:00
Kubernetes Prow Robot
4bd421502e
Merge pull request #75211 from wongma7/csi-attacher-test-flake
Fix unit test volumeattachments watch not working
2019-03-20 00:55:14 -07:00
Hemant Kumar
97ec61561a Allow different operation names 2019-03-13 14:20:45 -04:00
Kubernetes Prow Robot
517922f31a
Merge pull request #75308 from msau42/csi-beta-e2e
ignore kubeclient nil in csi plugin init
2019-03-13 05:49:46 -07:00
Michelle Au
398777f261 ignore kubeclient nil in csi plugin init 2019-03-12 16:29:08 -07:00
Kubernetes Prow Robot
8477c486a8
Merge pull request #74652 from cofyc/fix72500
Delay CSI client initialization
2019-03-11 09:39:27 -07:00
Kubernetes Prow Robot
cd9e590178
Merge pull request #74520 from casusbelli/fix-qb-usermapping
Adds missing user mapping option for Quobyte mounts
2019-03-11 02:45:26 -07:00
Yecheng Fu
fa926ed6e0 Delay CSI client initialization 2019-03-09 13:45:03 +08:00
Matthew Wong
cfea406c1c Fix unit test volumeattachments watch not working 2019-03-08 15:20:31 -05:00
Vladimir Vivien
923ad369c8 CSI Inline Volume - Kubelet/Driver code impl 2019-03-08 12:40:09 -05:00
Hemant Kumar
a8f318779b Add CSI volume resizing tests
Add some tests for checking node expansion
Add new tests for expander
2019-03-08 09:23:18 -05:00
Hemant Kumar
529cd7119b Move resize function parameters to a new ResizeOptions type
This enables us to pass CSI volume phase
2019-03-08 09:21:44 -05:00
Hemant Kumar
63eb25eb4b Introduce feature gate for volume expansion
Update CSI library version
2019-03-08 09:21:44 -05:00
Hemant Kumar
89d1de9eb9 Rename ExandFS to NodeExpand
Handle resize error in online resizing
Use NodeExpandable plugin to mark volumes that require node expansion
2019-03-08 09:21:44 -05:00
David Zhu
41b3579345 Address review comments 2019-03-07 17:17:09 -08:00
David Zhu
7d2f4e97b8 Add ADC Fallback if Node doesn't have driver installed 2019-03-07 14:47:38 -08:00
David Zhu
34d9ee5b9b Add CSINode initialization for CSIMigration on node startup before pod ready 2019-03-07 14:47:38 -08:00
Mike Fedosin
cf8c193b87 Allow to read OpenStack config from the secret
Currently OpenStack cloud provider reads user credentials from config
file, where data is stored in clear text. This approach is not recommended,
as it is a serious security issue.

This commit add an ability to read the config from secrets, if necessary.
To do so, two new parameters are added to the config: SecretNamespace and
SecretName. If they are specified, the provider will try to read config
from the secret.
2019-03-07 19:20:54 +01:00
Kubernetes Prow Robot
8dd60281ff
Merge pull request #74653 from cofyc/fix74650-CheckVolumeExistenceOperation
Distinguish between volume path and mount path
2019-03-06 20:35:40 -08:00
Kubernetes Prow Robot
c80e45f892
Merge pull request #73840 from adisky/cinder-intree-migration
Add CSI Migration feature flags for Cinder In tree Driver
2019-03-06 14:45:16 -08:00
Kubernetes Prow Robot
b82868bb7e
Merge pull request #74787 from jianglingxia/fixbugiscsi
fix bug iscsi volume attach failed of /sys/class/iscsi_host dir not e…
2019-03-06 09:50:51 -08:00
Kubernetes Prow Robot
5a89793f8e
Merge pull request #74612 from jingxu97/windows
Add GcePD windows support
2019-03-05 21:42:22 -08:00
Kubernetes Prow Robot
d31427637b
Merge pull request #74926 from ddebroy/csiprov2
Add new CSI translation APIs required by CSI sidecars and unit tests
2019-03-05 14:54:21 -08:00
adisky
3090b63414 Add CSI Migration feature flags for Cinder In tree Driver 2019-03-05 06:21:36 +00:00
Deep Debroy
1fb4290c4e Update API names and references
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-03-04 19:13:05 -08:00
root
b6e8f71fe0 fix bug iscsi volume attach failed of /sys/class/iscsi_host dir not exist 2019-03-05 10:46:47 +08:00
Xing Yang
6265f4f78c CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
https://github.com/kubernetes/kubernetes/pull/73883
2019-03-04 16:41:58 -08:00
Kubernetes Prow Robot
711b310389
Merge pull request #74606 from andrewsykim/cleanup-volumeattachment
replace usage of v1beta1 VolumeAttachments with v1
2019-02-28 00:27:36 -08:00
Jing Xu
5e04d200ee Add GcePD windows support
This PR adds the support for GCEPD volume. For now, it uses a workaround
(https://github.com/pjh/gce-tools) to get disk number in windows for a given GCE PD name.
2019-02-27 17:00:32 -08:00
Kubernetes Prow Robot
84dce4d119
Merge pull request #74393 from codenrhoden/refactor-subpath
Refactor subpath out of pkg/util/mount
2019-02-27 15:54:36 -08:00
Andrew Kim
01933b02a3 replace usage of v1beta1 VolumeAttachments with v1 2019-02-27 15:42:12 -05:00
Yecheng Fu
8940976602 Distinguish volume path with mount path 2019-02-27 19:31:26 +08:00
Kubernetes Prow Robot
5c528d6e40
Merge pull request #74618 from davidz627/fix/featureGates
Add feature gate check for migration at beginning of useCSIPlugin check
2019-02-26 19:40:26 -08:00
Travis Rhoden
2c4d748bed Refactor subpath out of pkg/util/mount
This patch moves subpath functionality out of pkg/util/mount and into a
new package pkg/volume/util/subpath. NSEnter funtionality is maintained.
2019-02-26 19:59:53 -07:00
Kubernetes Prow Robot
32333b0fc7
Merge pull request #74524 from bertinatto/iscsi_iface_exists
Don't fail if iface is being used by iSCSI session
2019-02-26 12:44:57 -08:00
David Zhu
b0b6fd035a Add feature gate check for migration at beginning of useCSIPlugin check 2019-02-26 11:47:20 -08:00
Travis Rhoden
766cf26897 Move original mount files back
Move original mount files back into pkg/util/mount. This move is done to
preserve git history.
2019-02-26 12:18:25 -07:00
Travis Rhoden
f2438cacf5 Copy mount files to pkg/volume/util/subpath
Files in pkg/util/mount that contain significant code implementation for
subpaths are moved to a new package at pkg/volume/util/subpath. This
move is done in order to preserve git history.
2019-02-26 12:14:55 -07:00
Fabio Bertinatto
d60d7e905f Don't fail if iface is being used by iSCSI session 2019-02-26 17:13:29 +01:00
Jordan Liggitt
d1e865ee34 Update client callers to use explicit versions 2019-02-26 08:36:30 -05:00
Kubernetes Prow Robot
b3ca8262be
Merge pull request #74499 from andyzhangx/fix-parse-devicePath-issue
fix parse devicePath issue on Azure Disk
2019-02-26 00:35:47 -08:00
Kubernetes Prow Robot
6c5810c495
Merge pull request #74542 from gnufied/make-cinder-limits-via-openshift-conf
Allow cinder volume limits to be configurable
2019-02-25 21:48:52 -08:00
Hemant Kumar
7a46b30a7a Allow cinder volume limits to be configurable 2019-02-25 16:09:24 -05:00
Silvan Kaiser
1fd5bd7de9 Adds missing user mapping option for Quobyte mounts 2019-02-25 12:03:34 +01:00
andyzhangx
433ebe3616 fix parse devicePath issue on Azure Disk 2019-02-25 07:02:35 +00:00
Yecheng Fu
618917e210 VolumeSpec may be nil in volume reconstruction scenario 2019-02-25 13:52:21 +08:00
Xiang Dai
36065c6dd7 delete all duplicate empty blanks
Signed-off-by: Xiang Dai <764524258@qq.com>
2019-02-23 10:28:04 +08:00
Kubernetes Prow Robot
8d6f20ea43
Merge pull request #74191 from andyzhangx/get-account-timeout
fix get azure accounts timeout issue when there is no out-bound IP
2019-02-22 05:22:45 -08:00
andyzhangx
8cd09bb143 add timeout in GetVolumeLimits operation
add timeout for getAllStorageAccounts
2019-02-22 07:22:05 +00:00
Kubernetes Prow Robot
ad1e021dcd
Merge pull request #74306 from jsafrane/fix-iscsi-deployment
Fix scanning of failed targets
2019-02-21 22:17:46 -08:00
Kubernetes Prow Robot
3baab4dc35
Merge pull request #73284 from leakingtapan/kubelet-migration-aws-2
Add In-tree to CSI migration logic for Mount and Unmount
2019-02-20 16:40:02 -08:00
Kubernetes Prow Robot
23a085062c
Merge pull request #69782 from darkowlzz/storageos-updates
StorageOS attach device before volume attach
2019-02-20 12:51:57 -08:00
Jan Safranek
dc46f483b5 Fix scanning of failed targets
If a iSCSI target is down while a volume is attached, reading from
/sys/class/iscsi_host/host415/device/session383/connection383:0/iscsi_connection/connection383:0/address
fails with an error. Kubelet should assume that such target is not
available / logged in and try to relogin. Eventually, if such error
persists, it should continue mounting the volume if the other
paths are healthy instead of failing whole WaitForAttach().
2019-02-20 17:17:01 +01:00
Kubernetes Prow Robot
ad403f8e20
Merge pull request #73901 from danielqsj/73882
decrease the level of the warning log in volume plugins
2019-02-19 23:20:41 -08:00
Kubernetes Prow Robot
64f2630215
Merge pull request #74023 from jsafrane/fix-fc-reconstruction
Fix reconstruction of FC volumes
2019-02-19 09:55:33 -08:00
Kubernetes Prow Robot
b8b143410f
Merge pull request #74076 from bertinatto/reg_error
Don't return CSI driver unregistration error
2019-02-19 08:37:29 -08:00
skarthiksrinivas
a309d8a6c1 Provision vsphere volume honoring zones 2019-02-17 21:37:00 -08:00
Cheng Pan
6355186c3e Add In-tree to CSI migration logic for Mount and Unmount 2019-02-18 04:55:31 +00:00
Fabio Bertinatto
d6c642b46a Only return CSI driver registration error 2019-02-16 10:06:33 +01:00
Subramanian Neelakantan
ba9a9cf7c3 Applies zone labels to newly created vsphere volumes 2019-02-15 15:06:01 +05:30
Kubernetes Prow Robot
808f2cf0ef
Merge pull request #72525 from justinsb/owners_should_not_be_executable
Remove executable file permission from OWNERS files
2019-02-14 23:55:45 -08:00
Kubernetes Prow Robot
60943a7a08
Merge pull request #69830 from davidz627/feature/csiTranslationMigration
In-Tree to CSI Migration logic for PersistentVolume Attach/Detach
2019-02-14 22:43:05 -08:00
David Zhu
5dde1df1cd Migration shim logic for Persistent Volumes for Attach/Detach 2019-02-14 17:04:23 -08:00
Jan Safranek
662b683de4 Fix reconstruction of FC volumes
It should reconstruct all WWNs or WWIDs instead of just the first one.
On-disk directory name format had to be changed to contain all WWNs/WWIDs.
2019-02-13 14:57:16 +01:00
Kubernetes Prow Robot
19e57c616c
Merge pull request #73892 from smarterclayton/fix_container_message
Make container create, start, and stop events consistent
2019-02-12 20:01:36 -08:00
danielqsj
713925bf3e decrease the level of the warning log in volume plugins 2019-02-12 09:43:43 +08:00
Clayton Coleman
49250c6efc
Make container create, start, and stop events consistent
The messages for container lifecycle events are subtly inconsistent
and should be unified.

First, the field format for containers is hard to parse for a human,
so include the container name directly in the message for create
and start, and for kill remove the container runtime prefix.

Second, the pulling image event has inconsistent capitalization, fix
that to be sentence without punctuation.

Third, the kill container event was unnecessarily wordy and inconsistent
with the create and start events. Make the following changes:

* Use 'Stopping' instead of 'Killing' since kill is usually reserved for
  when we decide to hard stop a container
* Send the event before we dispatch the prestop hook, since this is an
  "in-progress" style event vs a "already completed" type event
* Remove the 'cri-o://' / 'docker://' prefix by printing the container
  name instead of id (we already do that replacement at the lower level
  to prevent high cardinality events)
* Use 'message' instead of 'reason' as the argument name since this is a
  string for humans field, not a string for machines field
* Remove the hash values on the container spec changed event because no
  human will ever be able to do anything with the hash value
* Use 'Stopping container %s(, explanation)?' form without periods to
  follow event conventions

The end result is a more pleasant message for humans:

```
35m         Normal    Created                       Pod    Created container
35m         Normal    Started                       Pod    Started container
10m         Normal    Killing                       Pod    Killing container cri-o://installer:Need to kill Pod
10m         Normal    Pulling                       Pod    pulling image "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-02-10-172026@sha256:3da5303d4384d24691721c1cf2333584ba60e8f82c9e782f593623ce8f83ddc5"
```

becomes

```
35m         Normal    Created                       Pod    Created container installer
35m         Normal    Started                       Pod    Started container installer
10m         Normal    Killing                       Pod    Stopping container installer
10m         Normal    Pulling                       Pod    Pulling image "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-02-10-172026@sha256:3da5303d4384d24691721c1cf2333584ba60e8f82c9e782f593623ce8f83ddc5"
```
2019-02-10 16:39:42 -05:00
Andrew Kim
a62ee8b0a9 clean up volume rounding functions and move to k8s.io/cloud-provider/volume 2019-02-09 01:16:55 -05:00
Andrew Kim
ca6a051b00 remove cloud provider dependencies to pkg/volume
Co-authored-by: Weibin Lin <linweibin1@huawei.com>
2019-02-09 01:16:55 -05:00
Kubernetes Prow Robot
f0b72df47e
Merge pull request #73789 from vladimirvivien/volume-plugin-can-attach
AttachableVolumePlugin CanAttach() method for attachable check
2019-02-08 09:06:17 -08:00
Kubernetes Prow Robot
b50c643be0
Merge pull request #73540 from rlenferink/patch-5
Updated OWNERS files to include link to docs
2019-02-08 09:05:56 -08:00
Vladimir Vivien
0a653b3b80 Adds method CanAttach() to check plugin attachability 2019-02-08 08:04:15 -05:00
Kubernetes Prow Robot
eac19a3ab9
Merge pull request #73616 from dims/move-part-of-kubelet-apis-well-known-lables
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
2019-02-07 19:44:34 -08:00
Kubernetes Prow Robot
6fc9a72f58
Merge pull request #73533 from babiel/fix-fsgroup-directory-permissions
Ensure directories are executable for fsGroup
2019-02-06 20:03:01 -08:00
Kubernetes Prow Robot
4bbad05972
Merge pull request #73391 from qingsenLi/k8s190128
fix some typos in /pkg/volume
2019-02-06 13:23:51 -08:00
Kubernetes Prow Robot
2d956389dc
Merge pull request #73313 from pivotal-k8s/csi-drivers-list
Refactor csiDriversStore
2019-02-06 09:31:06 -08:00
Kubernetes Prow Robot
f3a6dbceb2
Merge pull request #68925 from casusbelli/fix_65312
Adding Quobyte Tenant to QuobyteVolumeSource to enable deletion of persistent volumes
2019-02-05 12:08:37 -08:00
Davanum Srinivas
cf44bfa556
Move LabelMultiZoneDelimiter to pkg/volume/util
Change-Id: I098b210e44ac3bb1901e029ff7cd33aa0afbdc74
2019-02-05 13:39:07 -05:00
Davanum Srinivas
b975573385
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
Co-Authored-By: Weibin Lin <linweibin1@huawei.com>

Change-Id: I163b2f2833e6b8767f72e2c815dcacd0f4e504ea
2019-02-05 13:39:07 -05:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Kubernetes Prow Robot
c953daa3bc
Merge pull request #73604 from andrewsykim/gce-features
move GCERegionalPersistentDisk feature to k8s.io/cloud-provider/features
2019-02-01 17:14:36 -08:00
Andrew Kim
8be7963797 move GCERegionalPersistentDisk feature to k8s.io/cloud-provider 2019-01-31 15:19:52 -05:00
Kubernetes Prow Robot
8f1082c6af
Merge pull request #73455 from danielqsj/keymutex
Migrate to k8s.io/utils/keymutex and k8s.io/utils/strings
2019-01-31 09:56:19 -08:00
Kubernetes Prow Robot
9487d37666
Merge pull request #72873 from taragu/exponential-backoff-plugin-registration
Add exponential backoff for plugin registration
2019-01-31 08:07:12 -08:00
danielqsj
cf1fb8a1cd fix format issue 2019-01-31 22:01:13 +08:00
Daniel (Shijun) Qian
e72b32558c
Merge branch 'master' into keymutex 2019-01-31 20:50:57 +08:00
Kubernetes Prow Robot
1f7e9fd9a2
Merge pull request #73488 from andrewsykim/replace-utils-file
Replace pkg/util/file with k8s.io/utils/path
2019-01-30 17:50:16 -08:00
Maximilian Gaß
7a9f21bbb8 Ensure directories are executable for fsGroup 2019-01-30 18:07:38 +01:00
danielqsj
657a1a1a34 change import alias of utils/strings 2019-01-30 10:44:09 +08:00
danielqsj
093328e57f migrate to k8s.io/utils/strings 2019-01-30 10:24:00 +08:00
danielqsj
1add6b0cfa migrate to k8s.io/utils/keymutex 2019-01-30 10:23:59 +08:00
Tara Gu
1f822030a4 Correct error message 2019-01-29 21:14:26 -05:00
Tara Gu
ad4bd8bdac Add exponential backoff for plugin registration 2019-01-29 21:13:02 -05:00
Kubernetes Prow Robot
53ee46f9a9
Merge pull request #72201 from nmiculinic/secret_key
Print non-existent key reference in the secret
2019-01-29 12:49:39 -08:00
Andrew Kim
84191eb99b replace pkg/util/file with k8s.io/utils/path 2019-01-29 15:20:13 -05:00
Kubernetes Prow Robot
cc1be28943
Merge pull request #72624 from danielqsj/clean_unmount
Cleanup callers of deprecated functions in volume/util
2019-01-28 23:06:20 -08:00
Sunny
835183ad50
Add AttachDevice() to attach the device to a host
AttachDevice() ensures that the volume device is attached to the
host before they are used.
2019-01-28 22:58:07 +05:30
Sunny
a4cc754fb4
StorageOS update api library 2019-01-28 22:57:58 +05:30
qingsenLi
4b25a4fd93 fix some typos in /pkg/volume 2019-01-28 23:17:48 +08:00
Hannes Hörl
84c46629c5 Refactor to use new csi.DriversList & csi.Driver 2019-01-25 12:23:28 +00:00
Hannes Hörl
96aa4fb5d2 Implement DriversStore as a struct
This allows us to hide
- the mutex handling
- the initialization
as implementation details.

Signed-off-by: Maria Ntalla <mntalla@pivotal.io>
2019-01-25 12:23:15 +00:00
Masaki Kimura
732eb69597 Fix AWS driver fails to provision specified fsType 2019-01-23 05:17:06 +00:00
Silvan Kaiser
cc71b0aebd Adding Tenant to QuobyteVolumeSource
Adds the tenant id to the QuobyteVolumeSource type and
updates the quobyte api client to support looking up
volume ids.
2019-01-22 14:42:12 +01:00
Kubernetes Prow Robot
54c4428eb4
Merge pull request #71276 from jingxu97/Oct/uncertain
Handle failed attach operation leave uncertain volume attach state
2019-01-17 22:52:57 -08:00
Kubernetes Prow Robot
7f0e04a089
Merge pull request #73043 from davidz627/feature/migrationCommon
Add common functionality required for all in-tree to CSI Migration shim code pieces
2019-01-17 18:55:10 -08:00
David Zhu
384fce6bb1 Common Migration shim functaionality and flags 2019-01-17 14:43:59 -08:00
David Zhu
d8c9dc5bb5 Add IsMigratableToCSI to volume plugin interface 2019-01-17 14:43:52 -08:00
Kubernetes Prow Robot
493d3565d8
Merge pull request #72874 from humblec/iscsi
Update approver list.
2019-01-17 13:51:35 -08:00
Kubernetes Prow Robot
d6b7409103
Merge pull request #72980 from gnufied/cinder-pod-volumes
Add Cinder Max Volume Limit
2019-01-16 13:32:32 -08:00
Hemant Kumar
727b3097f9 Do not make Cinder Max volume predicate a default 2019-01-16 15:17:05 -05:00
Mike McRill
a88d1d3dcc Add Cinder Max Volume Limit
Also add place holder support for reporting limits from node.
2019-01-16 13:46:28 -05:00
Kubernetes Prow Robot
ce19aad22b
Merge pull request #70527 from qingsenLi/git181101
remove repetitive word in annotation
2019-01-15 20:19:09 -08:00
Humble Chirammal
a5c5502d23 Update approver list.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-01-14 11:45:26 +05:30
hchiramm
86761e524a Update volume plugin reviewers.
Signed-off-by: hchiramm <hchiramm@redhat.com>
2019-01-12 09:47:17 +05:30
Justin SB
dd19b923b7
Remove executable file permission from OWNERS files 2019-01-11 16:42:59 -08:00
Jing Xu
7bac6ca73a Address comments
This commit addressed the comment and also add a unit test.
2019-01-11 10:57:37 -08:00
Kubernetes Prow Robot
8743a0e3c6
Merge pull request #72033 from galexrt/more_logging_in_rbd_provisioner
rbd: log error when unable to get Secret
2019-01-08 07:48:57 -08:00
danielqsj
2426f0ee4e Cleanup IsCorruptedMnt callers 2019-01-08 22:16:11 +08:00
danielqsj
8092904e3c Cleanup PathExists callers 2019-01-08 22:16:11 +08:00
danielqsj
d94cd822b7 Cleanup UnmountPath/UnmountMountPoint callers 2019-01-08 22:13:50 +08:00
Kubernetes Prow Robot
ee10b45c3d
Merge pull request #72008 from oleksiys/master
Remove generic mount validation logic during unmount and rely on CSI driver
2019-01-07 12:09:03 -08:00
oleksiys
f6a0359c9d Fix CSI volume unmount and cleanup logic 2019-01-05 09:00:17 -08:00
Kubernetes Prow Robot
b006342c3b
Merge pull request #72229 from andyzhangx/azuredisk-hostcache
change azure disk host cache to ReadOnly by default
2019-01-04 20:11:11 -08:00
andyzhangx
53145d793e change azure disk host cache to ReadOnly by default
change cachingMode default value for azure disk PV

revert back to ReadWrite in azure disk PV setting
2019-01-04 02:37:12 +00:00
Michelle Au
7a4f906f25 Rename UnmountMountPoint to CleanupMountPoint 2019-01-03 16:35:54 -08:00
Michelle Au
002a4e33d8 Move unmount volume util from pkg/volume/util to pkg/util/mount 2019-01-03 16:34:53 -08:00
mlmhl
34a2f23dc1 use json format to get rbd image size 2018-12-29 19:45:13 +08:00
Jordan Liggitt
73dcfe12da Stop checking VolumeScheduling feature gate 2018-12-27 17:45:45 -05:00
Neven Miculinic
49a966cb1a Added missing secret key in the message 2018-12-19 13:03:11 +01:00
Kubernetes Prow Robot
cd02e752bf
Merge pull request #71509 from cofyc/fix71438
Fix device mountable volume names in DSW
2018-12-19 00:51:52 -08:00
Michelle Au
8954c11719 Cleanup volume approvers 2018-12-18 15:12:13 -08:00
Michelle Au
0b6fa24f65 Add msau42 to top-level volume approvers 2018-12-18 15:11:42 -08:00
andyzhangx
81a123dbed fix kubelet log flushing issue in azure disk 2018-12-12 08:20:00 +00:00
Yecheng Fu
67552a8f6e Add unit test to verify generated volume names. 2018-12-12 13:03:21 +08:00
Alexander Trost
f9e7ba07b7
rbd: log error when unable to get Secret
Signed-off-by: Alexander Trost <galexrt@googlemail.com>
2018-12-11 19:31:21 +01:00
Kubernetes Prow Robot
13985d2674
Merge pull request #70172 from WanLinghao/configmap_volume_support_monitor
Support more volume types in stats/summary endpoint including configm…
2018-12-09 18:36:58 -08:00
Kubernetes Prow Robot
83b3baaf58
Merge pull request #71581 from saad-ali/fixCSILogEventSpam
Reduce CSI log and event spam
2018-11-30 22:27:27 -08:00
Yecheng Fu
5ada29ac16 Rename GetUniqueVolumeNameForNonAttachableVolume to GetUniqueVolumeNameFromSpecWithPod 2018-12-01 12:25:32 +08:00
k8s-ci-robot
79e5cb2cb7
Merge pull request #71302 from liggitt/verify-unit-test-feature-gates
Split mutable and read-only access to feature gates, limit tests to readonly access
2018-11-29 21:45:12 -08:00
k8s-ci-robot
2fd1949b7f
Merge pull request #71294 from Chenditang/verify-golint
Fix golint verify errors.
2018-11-29 21:45:02 -08:00
saad-ali
2251bf0c21 Ensure volume mount err checking done inside op
Ensure volume mount error checking is done inside the operation so that
failures get handled with exponential backoff, etc.
2018-11-29 16:52:24 -08:00
k8s-ci-robot
6be4f1bbf3
Merge pull request #71471 from mshaverdo/panic_in_attach_detach_controller
Fix panic in attachDetachController
2018-11-29 09:30:21 -08:00
k8s-ci-robot
d80614d4a7
Merge pull request #70860 from humblec/getVolumeName
GlusterFS: Move GetVolumeName() to unimplemented func.
2018-11-29 07:36:28 -08:00
k8s-ci-robot
cc153a9cd5
Merge pull request #70612 from jianglingxia/jlx201811031409
delete new defined para name in fc volume
2018-11-29 07:36:07 -08:00
Mikhail Shaverdo
a29981640f Fix nil pointer dereference panic in attachDetachController
add check `attachableVolumePlugin == nil` to operationGenerator.GenerateDetachVolumeFunc()
2018-11-29 13:10:07 +03:00
k8s-ci-robot
d0e8e6b78f
Merge pull request #70613 from jianglingxia/jlx201811031619
fix golint problem of volume cephfs/iscsi/nfs
2018-11-29 02:01:13 -08:00
k8s-ci-robot
e5326f22ea
Merge pull request #70471 from xichengliudui/fix181031
Fix some typos
2018-11-29 00:48:16 -08:00
k8s-ci-robot
b548d92b7c
Merge pull request #70392 from harsh-px/cfg-port
Lookup PX api port from k8s service
2018-11-28 23:31:50 -08:00
saad-ali
18050e308c Allow CSI Drivers suporting 0.x/1.x to use old dir
Allow drivers implmenting both CSI 0.x and 1.x to use the old volume
plugin directory in addition to the the new volume plugin directory.
2018-11-28 11:11:37 -08:00
saad-ali
aa8244beb5 Modify CSI to handle both 0.3 and 1.0
Modify the CSI volume plugin to handle CSI version 0.x as well as 1.x
2018-11-21 18:37:31 -08:00
saad-ali
d1b44857ad Add missing feature gate to CSI driver uninstall 2018-11-21 18:37:31 -08:00
saad-ali
2b44ec5e9c Reduce csipb dependencies
Remove csipb dependency from everywhere except the CSI client in
preperation for supporting multiple CSI clients.
2018-11-21 18:37:31 -08:00
saad-ali
8f666d9e41 Modify kubelet watcher to support old versions
Modify kubelet plugin watcher to support older CSI drivers that use an
the old plugins directory for socket registration.
Also modify CSI plugin registration to support multiple versions of CSI
registering with the same name.
2018-11-21 18:37:31 -08:00
Jordan Liggitt
2498ca7606 drop VerifyFeatureGatesUnchanged 2018-11-21 11:51:33 -05:00
chendt.fnst
80de428f49 Fix golint verify errors.
**What type of PR is this?**
/kind cleanup

**What this PR does / why we need it**:
$ hack/verify-golint.sh
Errors from golint:
pkg/cloudprovider/providers/aws/aws_fakes.go:357:9: if block ends with a return statement, so drop this else and outdent its block
pkg/volume/util/util.go:204:9: if block ends with a return statement, so drop this else and outdent its block

**Which issue(s) this PR fixes** *(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)*:

**Special notes for your reviewer**:

**Release note**:
```
NONE
```
2018-11-21 09:11:20 +08:00
Jing Xu
562d0fea53 Handle failed attach operation leave uncertain volume attach state
This commit adds the unit tests for the PR. It also includes some files
that are affected by the function name changes.
2018-11-19 17:21:49 -08:00
Jing Xu
47331cf0a2 WIP: Handle failed attach operation leave uncertain volume attach state
This PR fixes issue #32727.

When an attach operation fails, it is still possible that the volume
will be attached to the node later. This PR adds the logic to record the
volume to node with attached state no matter whether the operation
succedded or not. If the operation fails, mark the attached state to
false. If the operation succeeded, mark the attached state to true. The
reconciler will still issue attach operation until it returns
successfully. If the pod is removed in the mean time, the reconciler
will issue detach operations for all the volumes no matter what is the
attached state.
2018-11-19 17:19:10 -08:00
jianglingxia
6159bab94a
Merge branch 'master' into jlx201811031619 2018-11-17 12:53:21 +08:00
jianglingxia
0094e05975 fix golint problem of volume cephfs/iscsi/nfs 2018-11-17 12:50:47 +08:00
k8s-ci-robot
ec2e767e59
Merge pull request #71167 from msau42/block-beta
Promote raw block volume support to beta
2018-11-16 20:28:03 -08:00
k8s-ci-robot
4821291398
Merge pull request #71095 from msau42/csi-devicepath
Remove devicePath dependency for CSI volumes
2018-11-16 18:22:24 -08:00
k8s-ci-robot
f877b2257a
Merge pull request #71074 from jsafrane/volume-manager-races
Fix race between MountVolume and UnmountDevice
2018-11-16 18:22:14 -08:00
Michelle Au
974d47ecf8 Remove devicePath dependency for CSI volumes 2018-11-16 15:40:35 -08:00
Cheng Xing
ca18690ceb Augmenting API call retry in nodeinfomanager 2018-11-16 13:00:22 -08:00
Matthew Wong
dd517c9ff2 Update all tests to account for BlockVolume enabled by default 2018-11-16 13:38:59 -05:00
Jordan Liggitt
248d661327 Add tests to ensure storage feature gate changes don't escape packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt
358c092abe fix storage unit tests leaking feature flag changes 2018-11-16 10:52:52 -05:00
Michelle Au
fd64c08240 Fix storage feature gate test setting 2018-11-16 10:49:40 -05:00
Jan Safranek
5283537401 Fixed clearing of devicePath after UnmountDevice
UnmountDevice must not clear devicepath, because such devicePath
may come from node.status (e.g. on AWS) and subsequent MountDevice
operation (that may be already enqueued) needs it.
2018-11-16 13:24:42 +01:00
k8s-ci-robot
6fc60428a7
Merge pull request #71020 from saad-ali/updateCSI10
Bump CSI Spec to 1.0.0 and gRPC to 1.13.0
2018-11-16 01:53:21 -08:00
k8s-ci-robot
cde4c9ebe1
Merge pull request #68635 from mkimuram/issue/68424
CSI block volume refactor to fix target path
2018-11-15 21:35:42 -08:00
jianglingxia
371088e83c delete new defined para name in fc volume 2018-11-16 09:40:11 +08:00
saad-ali
09d3dce38a Update CSI client to pick up CSI v1.0.0 changes 2018-11-15 16:39:59 -08:00
Masaki Kimura
9c56b53390 Fix the comment for csi block pathes to make look the same to filesystem 2018-11-15 23:26:19 +00:00
k8s-ci-robot
726c07eb26
Merge pull request #69929 from jsafrane/csi-ga
Promote CSIPersistentVolume feature to GA
2018-11-14 20:34:58 -08:00
Masaki Kimura
6d7b5f1d1b Delegate creation of publishPath to driver and allow creating device file directly 2018-11-15 01:14:12 +00:00
Masaki Kimura
d8c6fe5202 Change stagingPath to be a directory 2018-11-14 20:53:28 +00:00
k8s-ci-robot
5a84dffc75
Merge pull request #71007 from mikedanese/allowdefault
TokenRequestProjections should allow API server to default empty audience
2018-11-14 11:38:16 -08:00
Masaki Kimura
f0354ad605 Fix for adding block volume support to CSI RBD driver 2018-11-14 19:20:56 +00:00
Michelle Au
498cd61f41 Add volumeattachment status subresource 2018-11-14 14:01:16 +01:00
Mike Danese
3167b15908 TokenRequestProjections should allow API server to default empty audience 2018-11-13 20:25:16 -08:00
k8s-ci-robot
d3a21cf5a2
Merge pull request #70848 from cofyc/fix64590
Improve usability of CSI plugin metrics
2018-11-13 19:45:43 -08:00
Deep Debroy
05759a9091 Handle validation of drivers in Spec and Status
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-11-13 02:35:30 -08:00
Deep Debroy
af73d7bdc1 Add validation of CSINodeInfo before Create/Update calls
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2018-11-13 00:48:56 -08:00
Harsh Desai
fdc60629c9 Update portworx to move from glog to klog
Signed-off-by: Harsh Desai <harsh@portworx.com>
2018-11-12 10:59:57 -08:00
Harsh Desai
db93c5fcbe cache portworx API port
- reused client whenever possible
- refactor get client function into explicit cluster-wide and local functions

Signed-off-by: Harsh Desai <harsh@portworx.com>
2018-11-12 10:51:36 -08:00
Harsh Desai
c6a2d24fa2 Lookup PX api port from k8s service
Fixes #70033

Signed-off-by: Harsh Desai <harsh@portworx.com>
2018-11-12 10:50:12 -08:00