Kubernetes Prow Robot
9d41c13348
Merge pull request #107443 from mattcary/no-watch
...
Turn off informer for statefulset unit tests
2022-01-19 01:28:18 -08:00
Matthew Cary
f2861d7876
Turn off informer for statefulset unit tests
...
Change-Id: I353a2d5bd59963d5d2308eaf7d0e6f77d969fc25
2022-01-15 20:29:19 +00:00
Jordan Liggitt
c0af728f43
Handle invalid selectors properly
2022-01-14 12:11:02 -05:00
Wojciech Tyczyński
551790729f
Remove selflink references in different testing-related files
2022-01-14 12:58:05 +01:00
Kubernetes Prow Robot
3bd422dc76
Merge pull request #107293 from dims/jan-1-owners-cleanup
...
Cleanup OWNERS files - Jan 2021 Week 1
2022-01-13 10:30:30 -08:00
Andrew Sy Kim
845d4a4304
add myself as approver to pkg/controller
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2022-01-12 19:33:02 -05:00
Patrick Ohly
9eaa2dc554
avoid klog Info calls without verbosity
...
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:
if klog.V(5).Enabled() {
klog.Info("hello world")
}
Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.
Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
Kubernetes Prow Robot
1f382b171e
Merge pull request #107080 from sivchari/fix-misspell
...
fix curent to current
2022-01-11 13:56:53 -08:00
Kubernetes Prow Robot
ccccd90bbc
Merge pull request #107389 from jlsong01/refine_comments_quota_monitor
...
refine comments of quota monitor
2022-01-10 13:34:25 -08:00
Davanum Srinivas
ba1f853b5a
Add mwielgus back
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 09:02:53 -05:00
Davanum Srinivas
9682b7248f
OWNERS cleanup - Jan 2021 Week 1
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 08:14:29 -05:00
astraw99
a5a54754d5
refactor garbagecollection controllers to make forget impossible to forget
2022-01-09 15:19:10 +08:00
Kubernetes Prow Robot
3bebe8f6b5
Merge pull request #105264 from devincd/fix_typo
...
fix the log description
2022-01-06 17:40:29 -08:00
jlsong01
d6bf04d85f
refine comments of quota monitor
2022-01-06 23:08:53 +08:00
JUN YANG
13fa2b1949
replace all occurrences of "node", nodeName to "node", klog.KRef("", nodeName)
2022-01-06 21:19:29 +08:00
Kubernetes Prow Robot
65378e7747
Merge pull request #102636 from charlesxsh/svcacct-ctrl-test
...
fix a potential deadlock
2022-01-05 21:12:27 -08:00
Mengjiao Liu
beda4cafb6
kubelet: Remove the deprecated flag --experimental-check-node-capabilities-before-mount
2022-01-06 11:47:11 +08:00
Kubernetes Prow Robot
abfe397ceb
Merge pull request #107166 from jsafrane/fix-pv-controller-tests
...
Fix PV controller unit test 5-7
2022-01-04 23:03:27 -08:00
Jan Safranek
0f9832d095
Fix PV name in unit test
...
Test 5-5 should use PV with "5-5"i in the name. It makes log analysys
much easier.
2022-01-03 15:20:12 +01:00
Kubernetes Prow Robot
f0dbc32ed9
Merge pull request #106853 from gnufied/disable-exp-backoff-volume-not-inuse
...
When volume is not marked in-use, do not backoff
2021-12-22 19:46:37 -08:00
Arda Güçlü
ef39a89142
Remove deprecated discovery/ServerResources function
...
ServerResources function was deprecated and instead ServerGroupsAndResources
function is suggested.
This PR removes ServerResources function and move every place to use ServerGroupsAndResources.
2021-12-22 11:14:09 +03:00
Jan Safranek
045ca75c03
Deflake PV metrics unit test
...
Test 5-7 tries to delete a PVC at the very same time when it detects that
the PV controller started processing the PVC. The controller then sometimes
can't update the PVC and generate an event for it that the test expects.
From PV controller logs (not shown in CI):
> I1221 14:36:34.548160 104481 pv_controller.go:815] updating PersistentVolumeClaim[default/claim5-7] status: set phase Lost failed: cannot update claim claim5-7: claim not found
Typical error in CI:
> FAIL: TestControllerSync (83.22s)
> framework_test.go:202: Event "Warning ClaimLost" not emitted
Therefore wait for the PVC to be fully processed before deleting the PVC to
avoid races.
2021-12-21 15:36:44 +01:00
Jan Safranek
e323306ce0
Add new watchers to PV controller tests
...
Add fake Pod and Node watchers to the tests. It only reduces test noise:
Failed to watch *v1.Pod: unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:"", Verb:"watch", Resource:schema.GroupVersionResource{Group:"", Version:"v1", Resource:"pods"}, Subresource:""}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:""}}
2021-12-21 15:36:34 +01:00
Kubernetes Prow Robot
13e97453f9
Merge pull request #107091 from robscott/endpointslice-metrics-perf
...
Improving performance of EndpointSlice controller metrics cache
2021-12-21 01:08:45 -08:00
Rob Scott
242c33615e
Improving performance of EndpointSlice controller metrics cache
2021-12-20 10:26:47 -08:00
Hemant Kumar
7989f27044
use node informer to check volumes attachment status before backoff
...
fix unit tests
2021-12-20 11:57:05 -05:00
Kubernetes Prow Robot
8ade75465a
Merge pull request #104799 from RyanAoh/cronjob_dev
...
fix the error when cleaning up finished jobs for cronjob
2021-12-17 13:23:53 -08:00
sivchari
a5c5acf56e
fix curent to current
2021-12-17 03:33:22 +09:00
Kubernetes Prow Robot
1426587e08
Merge pull request #106436 from dims/cleanup-owners-files-no-activity-in-a-year
...
Cleanup OWNERS files (No Activity in the last year)
2021-12-15 12:07:51 -08:00
Davanum Srinivas
497e9c1971
Cleanup OWNERS files (No Activity in the last year)
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-15 10:34:02 -05:00
Kubernetes Prow Robot
8324868f89
Merge pull request #106950 from sunzhaochang/fix-unexpected-end-test
...
Fix unexpected end of TestDependentsRace
2021-12-14 15:16:49 -08:00
Kubernetes Prow Robot
ba200841fd
Merge pull request #106366 from cyclinder/evictions_number_stable
...
adding evictions_total metric and marking evictions_number deprecated
2021-12-12 23:19:59 -08:00
cyclinder
b88b51c6e5
adding evictions_total metric and marking evictions_number deprecated
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-13 10:36:02 +08:00
sunzhaochang
f0e74bfb7f
Fix unexpected end of TestDependentsRace
2021-12-10 20:07:37 +08:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Kubernetes Prow Robot
d16a5e5feb
Merge pull request #106673 from qmloong/qmloong/master
...
refactor: use utilerrors instead of join error msg
2021-12-07 18:27:22 -08:00
Kubernetes Prow Robot
12901b95c9
Merge pull request #106344 from ikeeip/fix_import_formatting
...
Fix golang imports in k8s.io/pkg/controller/volume/persistentvolume package
2021-12-07 17:26:40 -08:00
menglong.qi
ea31d7b813
refactor: use utilerrors instead of join error msg
2021-11-28 17:16:17 +08:00
Matthew Cary
0e2b901762
Clean up deep copy needed for UpdateStatefulSet
...
Change-Id: Id732358183d682d1a945cfee56f83bcaac0d7c31
2021-11-23 06:48:54 -08:00
Aohan Yang
ad4fe13528
fix the error when cleaning up jobs for cronjob
2021-11-22 17:06:22 +08:00
Kubernetes Prow Robot
084b28f6d5
Merge pull request #106510 from robscott/topology-ready-fix-controller
...
Updating TopologyCache to disregard unready endpoints in calculations
2021-11-19 17:07:11 -08:00
Rob Scott
9813ec7e8a
Updating TopologyCache to disregard unready endpoints in calculations
2021-11-18 13:54:09 -08:00
Matthew Cary
53b3a6c1d9
controller change for statefulset auto-delete (tests)
...
Change-Id: I16b50e6853bba65fc89c793d2b9b335581c02407
2021-11-17 16:48:50 -08:00
Matthew Cary
bce87a3e4f
controller change for statefulset auto-delete (implementation)
2021-11-17 16:48:50 -08:00
Kubernetes Prow Robot
39c76ba2ed
Merge pull request #106455 from soltysh/cronjob_warning
...
Add warning about using unsupported CRON_TZ
2021-11-16 17:44:31 -08:00
Kubernetes Prow Robot
165b581759
Merge pull request #105623 from ash2k/ash2k/resettable-rest-mapper
...
ResettableRESTMapper to make it possible to reset wrapped mappers
2021-11-16 16:36:08 -08:00
Kubernetes Prow Robot
6805e6ee41
Merge pull request #104722 from leiyiz/migration
...
turning on the CSIMigrationGCE feature flag
2021-11-16 15:28:32 -08:00
Kubernetes Prow Robot
f151a40d8d
Merge pull request #106154 from gnufied/recover-expansion-failure-123
...
Recover expansion failure
2021-11-16 13:21:34 -08:00
Léiyì Zhang
275fdf0884
fixing unit test failures induced by turning on CSIMigrationGCE
...
disable CSIMigrationGCE in some unit tests
2021-11-16 19:26:30 +00:00
Maciej Szulik
d0518848b5
Add warning about using unsupported CRON_TZ
...
CRON_TZ variable slipped in during upgrading github.com/robfig/cron
library. It allows setting a time zone which is a long requested
feature but one that is not officially supported. This adds warning
event since users should not rely on unsupported features.
2021-11-16 17:41:37 +01:00
Hemant Kumar
1ddd598d31
Implement controller and kubelet changes for recovery from resize
...
failures
2021-11-16 11:06:46 -05:00
Kubernetes Prow Robot
6d1d8c73ee
Merge pull request #106316 from josephburnett/controller-v2
...
Watch HPA v2 instead of v1.
2021-11-16 06:41:38 -08:00
Joseph Burnett
711f96e05e
Watch HPA v2 instead of v1.
2021-11-16 11:13:21 +01:00
Kubernetes Prow Robot
ce98eda406
Merge pull request #106376 from jsafrane/stabilize-unit-test
...
Fix deletion protection unit test
2021-11-15 13:04:48 -08:00
shawnhanx
acc55500bc
should omit comparison to bool constant in pkg/controller/controller_utils.go
2021-11-13 17:15:25 +08:00
Neha Lohia
fa1b6765d5
move pkg/util/node to component-helpers/node/util ( #105347 )
...
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
2021-11-12 07:52:27 -08:00
Jan Safranek
bb8157d780
Fix deletion protection unit test
...
The test should not depend on current set of default feature gates, it
should always ensure the ones necessary for the tests are set.
2021-11-12 10:47:15 +01:00
Kubernetes Prow Robot
2bd67845d4
Merge pull request #105550 from damemi/wire-contexts-rbac
...
Wire contexts to RBAC controllers
2021-11-11 15:15:25 -08:00
Konstantin Misyutin
7434fdf1d4
fix import formatting in k8s.io/pkg/controller/volume/persistentvolume package
...
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
2021-11-11 16:31:38 +08:00
Mike Dame
80c01707e0
Wire contexts to Batch controllers ( #105491 )
...
* Wire contexts to Batch controllers
* (hold) feedback + updates that overlap with Apps controllers
* fixup errors
2021-11-10 14:56:46 -08:00
Kubernetes Prow Robot
91ff1f9840
Merge pull request #101250 from evertrain/master
...
Bugfix: prevent daemon controller to adopt controller revisions of ot…
2021-11-10 09:19:26 -08:00
Kubernetes Prow Robot
9b083c4226
Merge pull request #105773 from deepakkinni/2680_fgate_v1
...
PV controller changes to support PV Deletion protection finalizer
2021-11-10 05:33:26 -08:00
Kubernetes Prow Robot
8e02b78873
Merge pull request #102534 from wangyysde/create-hpav2stable
...
Create HPA v2 Stable API
2021-11-09 10:27:48 -08:00
Kubernetes Prow Robot
376b2150d5
Merge pull request #105874 from cyclinder/Add_func_name_to_comment
...
fix some lint error
2021-11-09 08:29:47 -08:00
evertrain
a67f22c849
add ut for cluster-scoped controller case
2021-11-09 23:50:24 +08:00
wangyysde
d2abddd909
rename v2beta2 to v2
...
Signed-off-by: wangyysde <net_use@bzhy.com>
Generation swagger.json.
Use v2 path for hpa_cpu_field.
run update-codegen.sh
Signed-off-by: wangyysde <net_use@bzhy.com>
2021-11-09 10:34:54 +08:00
Deepak Kinni
bfd5f23a0b
PV controller changes to support PV Deletion protection finalizer
...
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
2021-11-08 10:35:58 -08:00
Mikhail Mazurskiy
de4598d0db
ResettableRESTMapper to make it possible to reset wrapped mappers
2021-11-06 10:44:02 +11:00
Manu Gupta
79a51090f9
fix: 81134: fix unsafe json for ReleaseControllerRevision ( #104049 )
...
* fix: 81134: fix unsafe json for ReleaseControllerRevision
1. Ensures that ReleaseControllerRevision returns a proper json by
marshalling an object into bytes. Otherwise, it returns an error.
2. Also, refactors the code to commonize the merge type
GenerateDeleteOwnerRefStrategicMergeBytes that returns a byte and is
used across ReleasePod, ReleaseControllerRevison
ReleaseReplicaSet.
* Move GeneratePatchBytesForDelete to controller_ref_manager
2021-11-05 06:33:52 -07:00
Kubernetes Prow Robot
ed42bbd722
Merge pull request #106126 from soltysh/remove_old_cronjob
...
Remove old cronjob controller
2021-11-04 20:35:53 -07:00
Maciej Szulik
5254493044
Remove old cronjob controller
2021-11-04 13:24:28 +01:00
Carl
b3e4fed844
only apply this check if the controller is actually namespaced
...
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
2021-11-04 13:08:47 +08:00
Kubernetes Prow Robot
4dfd739403
Merge pull request #105997 from robscott/mirroring-selector
...
Fixing how EndpointSlice Mirroring handles Service selector transitions
2021-11-03 12:48:32 -07:00
Kubernetes Prow Robot
aa0ea62489
Merge pull request #104903 from ikeeip/storageobjectinuseprotection_feature_ga_cleanup
...
Remove StorageObjectInUseProtection feature gate logic
2021-11-02 20:22:57 -07:00
Shihao Xia
afb0023ab3
fix potential deadlock
2021-11-02 20:46:06 -04:00
Kubernetes Prow Robot
3fdeb490e0
Merge pull request #105510 from damemi/wire-contexts-bootstrap
...
Wire contexts to Bootstrap controllers
2021-11-02 14:27:42 -07:00
Konstantin Misyutin
808c8f42d5
Remove StorageObjectInUseProtection feature gate logic
...
This feature has graduated to GA in v1.11 and will always be
enabled. So no longe need to check if enabled.
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
2021-11-03 00:13:50 +03:00
Kubernetes Prow Robot
9be67806cd
Merge pull request #102945 from chenchun/fake
...
Pass DeleteOptions down to the Reactor
2021-11-02 07:14:58 -07:00
Chun Chen
621970476f
Pass DeleteOptions down to the Reactor
...
Co-authored-by: Mo Khan <theenjeru@gmail.com>
2021-11-02 10:04:48 +08:00
evertrain
9ceb226c06
Bugfix prevent daemon controller to adopt controller revisions of other namespaces
2021-11-02 00:14:26 +08:00
Mike Dame
4960d0976a
Wire contexts to Core controllers
2021-11-01 10:29:00 -04:00
Rob Scott
794f0cb7f1
Fixing how EndpointSlice Mirroring handles Service selector transitions
2021-10-29 11:03:28 -07:00
Kubernetes Prow Robot
c592bd40f2
Merge pull request #105609 from pohly/generic-ephemeral-volume-ga
...
generic ephemeral volume GA
2021-10-28 17:36:50 -07:00
Kubernetes Prow Robot
8e37a3b324
Merge pull request #103868 from qingsenLi/210723-forget
...
Merge conditional assignment into variable declaration
2021-10-28 16:32:50 -07:00
Kubernetes Prow Robot
6edcb60d9f
Merge pull request #104915 from alculquicondor/job-ready
...
Track ready pods in Job status
2021-10-28 09:20:26 -07:00
Shuanglu
9bcfa71e31
Fix Daemonset controller role missing 'update pod' permission ( #104758 )
...
* fix_dsc_rbac_pod_update
* add test for DaemonSet Controller updates label of the pod after "DedupCurHistories"
* rebase
* update parameter of dsc.Run
2021-10-28 05:24:26 -07:00
cyclinder
ab47b8b94b
fix some lint error
...
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
2021-10-26 13:56:29 +08:00
Aldo Culquicondor
60fc90967b
Count ready pods in job controller
...
When the feature gate JobReadyPods is enabled.
Change-Id: I86f93914568de6a7029f9ae92ee7b749686fbf97
2021-10-19 15:18:37 -04:00
Konstantin Misyutin
dbc9d7b71a
Remove tests when StorageObjectInUseProtection feature is disabled
...
As well as feature gate are locked, the tests when this feature is
disabled will crash. So we should remove them together with locking
the feature.
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
2021-10-15 19:39:37 +08:00
Kubernetes Prow Robot
0bfa37dfcc
Merge pull request #105676 from alculquicondor/job-name
...
Fix name for Pods of NonIndexed Jobs
2021-10-14 10:50:12 -07:00
Aldo Culquicondor
4ef9d18abe
Fix name for Pods of NonIndexed Jobs
...
Change-Id: I0ea4685a82f4cdec0caab362d52144476652f95a
2021-10-14 10:55:46 -04:00
Kubernetes Prow Robot
3aafe75698
Merge pull request #105461 from damemi/wire-contexts-autoscaling
...
Wire contexts to Autoscaling controllers
2021-10-14 06:59:33 -07:00
Kubernetes Prow Robot
f27e4714ba
Merge pull request #105377 from damemi/wire-contexts-apps
...
Wire contexts to Apps controllers
2021-10-14 06:59:19 -07:00
Kubernetes Prow Robot
baaa53db64
Merge pull request #105211 from xiaopingrubyist/fix-pv-controller-claim-cache-issue
...
fix:claim cached in pvcontroller is not the newest may cause unexpected issue
2021-10-14 05:47:18 -07:00
Mike Dame
41fcb95f2f
Wire contexts to Apps controllers
2021-10-13 16:32:13 -04:00
torubylist
f28a8d7f2b
fix:cached claim is not the newest will cause unexpected issue
2021-10-13 20:03:00 +08:00
Mike Dame
7780024916
Wire contexts to Autoscaling controllers
2021-10-12 14:34:05 -04:00
Maciej Szulik
8322121434
Move test-related utils to test/utils
2021-10-12 14:52:19 +02:00
Maciej Szulik
1fb6bf8a14
Wire context instead of TODO
2021-10-12 13:21:45 +02:00
Patrick Ohly
a8c930ef46
generic ephemeral volume: graduation to GA
...
The feature gate gets locked to "true", with the goal to remove it in two
releases.
All code now can assume that the feature is enabled. Tests for "feature
disabled" are no longer needed and get removed.
Some code wasn't using the new helper functions yet. That gets changed while
touching those lines.
2021-10-11 20:54:20 +02:00