github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
107,351 Commits 1 Branch 31 Tags 1,019 MiB
78889cd1bb
Commit Graph

5652 Commits

Author SHA1 Message Date
Mike Dame
3f0b6d390c Wire contexts to RBAC controllers 2021-10-07 15:04:49 -04:00
Kubernetes Prow Robot
b0eac84937
Merge pull request #105345 from pohly/generic-ephemeral-volume-util 
generic ephemeral volume util, base code and controller
 2021-10-07 08:19:47 -07:00
Jordan Liggitt
81fa9855c1 Fix quota controller hotloop in integration tests 2021-10-06 11:34:32 -04:00
Mike Dame
6ce2924818 Wire contexts to Bootstrap controllers 2021-10-06 10:27:32 -04:00
Patrick Ohly
4ae0eecb34 controller: use generic ephemeral volume helper functions 
The name concatenation and ownership check were originally considered small
enough to not warrant dedicated functions, but the intent of the code is more
readable with them.

There also was a missing owner check in the attach controller.
 2021-10-06 14:01:44 +02:00
Kubernetes Prow Robot
debd6c1e9e
Merge pull request #104526 from jingxu97/aug/volumeattach 
Fix issue in node status updating VolumeAttached list
 2021-10-05 17:30:32 -07:00
Jing Xu
69b9f9b1f0 Fix issue in node status updating VolumeAttached list 
During volume detach, the following might happen in reconciler

1. Pod is deleting
2. remove volume from reportedAsAttached, so node status updater will
update volumeAttached list
3. detach failed due to some issue
4. volume is added back in reportedAsAttached
5. reconciler loops again the volume, remove volume from
reportedAsAttached
6. detach will not be trigged because exponential back off, detach call
will fail with exponential backoff error
7. another pod is added which using the same volume on the same node
8. reconciler loops and it will NOT try to tigger detach anymore

At this point, volume is still attached and in actual state, but
volumeAttached list in node status does not has this volume anymore, and
will block volume mount from kubelet.

The fix in first round is to add volume back into the volume list that
need to reported as attached at step 6 when detach call failed with
error (exponentical backoff). However this might has some performance
issue if detach fail for a while. During this time, volume will be keep
removing/adding back to node status which will cause a surge of API
calls.

So we changed to logic to check first whether operation is safe to retry which
means no pending operation or it is not in exponentical backoff time
period before calling detach. This way we can avoid keep removing/adding
volume from node status.

Change-Id: I5d4e760c880d72937d34b9d3e904ecad125f802e
 2021-10-05 09:44:35 -07:00
Kubernetes Prow Robot
519b164db1
Merge pull request #105222 from cyclinder/remove_node_lease_GA 
remove nodeLease feature GA
 2021-10-05 05:41:21 -07:00
Author cyclinder
e61b901628 remove nodeLease feature GA 
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
 2021-10-05 12:23:27 +08:00
Kubernetes Prow Robot
0a29e2a73a
Merge pull request #105197 from alculquicondor/job-tracking 
Roll-forward: Beta requirements for JobTrackingWithFinalizers
 2021-10-04 18:57:49 -07:00
Aldo Culquicondor
5929ccd391 Track expected removals of Pod finalizers 
Add the UIDs of Pods for which we are removing finalizers to an in-memory cache.

The controller removes UIDs from the cache as Pod updates or deletes come in.

This avoids double counting finished Pods when Pod updates arrive after Job status updates.

https://github.com/kubernetes/kubernetes/issues/105200
 2021-10-04 16:09:58 -04:00
Kubernetes Prow Robot
c724abae81
Merge pull request #105375 from jonyhy96/fix-clock-util 
node: test file use k8s.io/utils/clock instead
 2021-10-04 04:19:31 -07:00
Rob Scott
d7a640d831
Excluding Control Plane Nodes from Topology Hints calculations 2021-10-01 15:12:38 -07:00
haoyun
8d9fa1decc fix: use k8s.io/utils/clock instead 
Signed-off-by: haoyun <yun.hao@daocloud.io>
 2021-10-02 00:08:53 +08:00
Aldo Culquicondor
95c2a8024c Parallelize pod updates in job test 
To potentially reduce the number of job controller syncs.

Also reduce the maximum number of pods to sync in tests.
 2021-10-01 09:55:53 -04:00
Kubernetes Prow Robot
598a8829c1
Merge pull request #105267 from llhuii/fix-topology-hint-bug 
TopologyAwareHints: fix getHintsByZone bug
 2021-09-28 20:54:48 -07:00
llhuii
e7350d126e TopologyAwareHints: add getHintsByZone unit test 2021-09-29 10:39:03 +08:00
llhuii
528cd30145 TopologyAwareHints: fix getHintsByZone bug 
The bug could result in the EndpointSlice controller unnecessarily updating
EndpointSlices associated with a Service that had Topology Aware Hints enabled.
 2021-09-28 09:02:24 +08:00
Kubernetes Prow Robot
aec9acda68
Merge pull request #105214 from alculquicondor/job-update 
Remove GET job and retries for status updates
 2021-09-27 09:05:47 -07:00
devincd
e62aef4fc9 fix the log description 
Signed-off-by: devincd <505259926@qq.com>
 2021-09-27 14:20:33 +08:00
Khaled Henidak (Kal)
a53e2eaeab
move IPv6DualStack feature to stable. (#104691) 
* kube-proxy

* endpoints controller

* app: kube-controller-manager

* app: cloud-controller-manager

* kubelet

* app: api-server

* node utils + registry/strategy

* api: validation (comment removal)

* api:pod strategy (util pkg)

* api: docs

* core: integration testing

* kubeadm: change feature gate to GA

* service registry and rest stack

* move feature to GA

* generated
 2021-09-24 16:30:22 -07:00
Kubernetes Prow Robot
b6924839ca
Merge pull request #101987 from sky-philipalmeida/patch-1 
Log if PV is still in use trying to delete it
 2021-09-23 14:30:54 -07:00
Aldo Culquicondor
a438f16741 Revert "Revert "Add metric job_pod_finished"" 
This reverts commit 7868fbbe64.
 2021-09-23 12:56:29 -04:00
Aldo Culquicondor
47a957d163 Revert "Revert "Limit number of Pods counted in a single Job sync"" 
This reverts commit 8bcb780808.
 2021-09-23 12:56:29 -04:00
Aldo Culquicondor
01f27cd93e Fix log line for target number of running pods 2021-09-23 12:56:29 -04:00
Aldo Culquicondor
eebd678cda Remove GET job and retries for status updates. 
Doing a GET right before retrying has 2 problems:
- It can masquerade conflicts
- It adds an additional delay

As for retries, we are better of going through the sync backoff.

In the case of conflict, we know that there was a Job update that would trigger another sync, so there is no need to do a rate limited requeue.
 2021-09-23 11:48:34 -04:00
Kubernetes Prow Robot
372103f4b8
Merge pull request #100672 from wangyx1992/structured-log 
Structured Logging migration: modify logs of controller-manager
 2021-09-22 20:27:10 -07:00
Kubernetes Prow Robot
76c0573ff4
Merge pull request #105181 from alculquicondor/revert 
Revert #104739
 2021-09-21 16:54:00 -07:00
Aldo Culquicondor
7868fbbe64 Revert "Add metric job_pod_finished" 
This reverts commit a0e7a567c5.
 2021-09-21 15:16:54 -04:00
Aldo Culquicondor
8bcb780808 Revert "Limit number of Pods counted in a single Job sync" 
This reverts commit 7d9cb88fed.
 2021-09-21 15:16:50 -04:00
Phil
f1a9402082 Log if PV is still in use trying to delete it 
Similar to what we have in:
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/volume/pvcprotection/pvc_protection_controller.go#L181
The objective is to have a easy way to monitor if a PV will enter in Terminating state due to a failed removal when still in use.
This way we can capture the PV log and alert according.
The code is not tested.

Update pv_protection_controller.go

Change call to Infof
 2021-09-21 18:05:16 +01:00
Kubernetes Prow Robot
b34a735bbe
Merge pull request #102523 from stlaz/rootca_metrics_cleanup 
rootcacertpublisher: drop the namespace label from metrics to reduce its cardinality
 2021-09-20 13:54:24 -07:00
Kubernetes Prow Robot
353f0a5eab
Merge pull request #105095 from wojtek-t/migrate_clock_3 
Unify towards k8s.io/utils/clock - part 3
 2021-09-20 12:46:45 -07:00
Kubernetes Prow Robot
f55101913f
Merge pull request #105098 from Karthik-K-N/fix-error-format 
Fix incorrect format specifier in test files
 2021-09-20 08:56:09 -07:00
Shivanshu Raj Shrivastava
bbd809cbd0
Fixing incorrectly migrated structured logs (#105122) 
* added keys for structured logging

* used KObj
 2021-09-19 12:28:08 -07:00
wojtekt
d9b08c611d Migrate to k8s.io/utils/clock 2021-09-17 15:19:08 +02:00
Kubernetes Prow Robot
399656369f
Merge pull request #104739 from alculquicondor/job-tracking 
Beta requirements for JobTrackingWithFinalizers
 2021-09-17 04:57:00 -07:00
Karthik K N
c651d50202 Fix incorrect format specifier in test files 2021-09-17 16:27:53 +05:30
Stanislav Laznicka
b67bd722a9
rootcacertpublisher: drop the namespace label from metrics to reduce its cardinality 
The `root_ca_cert_publisher_sync_duration_seconds` metric tracks the sync
duration in the root CA cert publisher per code and namespace. In
clusters with a high namespace turnover (like CI clusters), this may
cause the kube-controller-manager to expose over 100k series to
Prometheus, which may cause degradation of that service.

Drop the `namespace` label to remove the metrics' cardinality, tracking
this metric by namespace does not justify the impact of keeping it.
 2021-09-16 14:05:32 +02:00
Aldo Culquicondor
a0e7a567c5 Add metric job_pod_finished 
To count the number of pods that the job controller successfully tracked with the JobTrackingWithFinalizers feature gate.
 2021-09-15 11:19:47 -04:00
Kubernetes Prow Robot
047a6b9f86
Merge pull request #104874 from wojtek-t/migrate_clock_1 
Unify towards k8s.io/utils/clock - part 1
 2021-09-13 19:09:20 -07:00
Kubernetes Prow Robot
8ac9526475
Merge pull request #101928 from alexanderConstantinescu/drain-workqueue 
client-go/workqueue: Drain work queue on shutdown
 2021-09-10 18:02:06 -07:00
Aldo Culquicondor
7d9cb88fed Limit number of Pods counted in a single Job sync 
This prevents big Jobs from starving smaller ones.
 2021-09-10 10:32:04 -04:00
wojtekt
e233feb99b Migrate to k8s.io/utils/clock in pkg/controller 2021-09-10 11:42:32 +02:00
Kubernetes Prow Robot
669de4b957
Merge pull request #104666 from alculquicondor/tracking-beta 
Fix Job tracking with finalizers for more than 500 pods
 2021-09-09 09:26:11 -07:00
Kubernetes Prow Robot
f9488f314a
Merge pull request #104741 from robscott/topology-logging 
Adding more detailed logging for Topology Hints
 2021-09-07 16:32:16 -07:00
Kubernetes Prow Robot
bcd2ffbdc1
Merge pull request #104590 from Jiawei0227/anno 
Add GA AnnStorageProvisioner annotation to PVC
 2021-09-03 06:09:49 -07:00
Rob Scott
f24d917d3c
Adding more detailed logging for Topology Hints 2021-09-02 15:46:14 -07:00
Aldo Culquicondor
23ea5d80d6 Fix Job tracking with finalizers for more than 500 pods 
When doing partial updates for uncountedTerminatedPods, the controller might have removed UIDs for Pods which still had finalizers.

Also make more space by removing UIDs that don't have finalizers at the beginning of the sync.
 2021-09-01 16:19:04 -04:00
Kubernetes Prow Robot
cd63952f13
Merge pull request #95885 from jiahuif/refactor/controller-manager 
refactor: controller manager: InitFunc and base controller interface.
 2021-08-27 15:40:52 -07:00
Kubernetes Prow Robot
fca3175df7
Merge pull request #104231 from astraw99/fix_unified_workers 
Unify controller worker num param `threadiness` to `workers`
 2021-08-27 09:34:05 -07:00
Jiawei Wang
8de0f11946 Add GA AnnStorageProvisioner annotation to PVC 
This PR adds GA AnnStorageProvisioner annotation to
a PVC if the PVC requires dynamic provisioning. This
also deprecates the beta AnnStorageProvisioner annotation
and it will be removed in a later release.
 2021-08-26 12:46:47 -07:00
Jiahui Feng
8f5771d243 use common controller interface in KCM. 2021-08-25 13:29:03 -07:00
Stephen Augustus
481cf6fbe7
generated: Run hack/update-gofmt.sh 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
 2021-08-24 15:47:49 -04:00
Kubernetes Prow Robot
4e832a7db9
Merge pull request #103630 from mysunshine92/controller_util-annotation 
Modify the wrong comment for controller_util.go
 2021-08-24 10:37:14 -07:00
Alexander Constantinescu
5b740f430e [queue] Implement ShutDownWithDrain allowing the queue to drain when shutting down 
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
 2021-08-20 13:59:12 +02:00
Antonio Ojea
0cd75e8fec run hack/update-netparse-cve.sh 2021-08-20 10:42:09 +02:00
Jordan Liggitt
87a4e082ac Change defaulter-gen input to package path 2021-08-14 11:00:18 -04:00
Konstantin Misyutin
29bd66d018 Remove "pkg/controller/volume/scheduling" dependency from "pkg/scheduler/framework/plugins" 
All dependencies of VolumeBinding plugin from
"k8s.io/kubernetes/pkg/controller/volume/scheduling" package moved to
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding" package:

- whole file pkg/controller/volume/scheduling/scheduler_assume_cache.go
- whole file pkg/controller/volume/scheduling/scheduler_assume_cache_test.go
- whole file pkg/controller/volume/scheduling/scheduler_binder.go
- whole file pkg/controller/volume/scheduling/scheduler_binder_fake.go
- whole file pkg/controller/volume/scheduling/scheduler_binder_test.go

Package "k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics" moved
to "k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding/metrics"
because it only used in VolumeBinding plugin and (e2e) tests.

More described in issue #89930 and PR #102953.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
 2021-08-13 19:08:45 +08:00
astraw99
e6df935fd3 unify worker num to workers 2021-08-09 15:46:04 +08:00
Kubernetes Prow Robot
7ab3e3c8c3
Merge pull request #102981 from SataQiu/add-ephemeral-config-v1alpha1 
Add --concurrent-ephemeralvolume-syncs flag for kube-controller-manager
 2021-08-05 20:55:12 -07:00
Kubernetes Prow Robot
6f73963fdf
Merge pull request #103756 from nakamasato/fix-typo-in-comment 
Fix typo in comment in endpoints_controller
 2021-08-04 22:12:37 -07:00
Kubernetes Prow Robot
06ae9a2ad7
Merge pull request #103259 from mamil/fix-typo 
fix typo for daemon_controller_test.go
 2021-08-04 19:00:07 -07:00
SataQiu
7fa0b9b6c1 add --concurrent-ephemeralvolume-syncs flag for kube-controller-manager 2021-07-25 21:36:57 +08:00
10177505
2740965dc9 Merge conditional assignment into variable declaration 2021-07-23 17:02:19 +08:00
Jordan Liggitt
236e72cf8a Make CSR cleaner tolerate objects with invalid status.certificate 2021-07-21 10:35:17 -04:00
Masato Naka
baf0bf831d Fix typo in comment in endpoints_controller 2021-07-18 21:56:34 +09:00
Aldo Culquicondor
5e1b5ec398 Revert counting deleted pods as failures for Job 
When JobTrackingWithFinalizers is disabled. To preserve existing behavior.

Change-Id: Id1752f96feed322911712fe9e918e91e42eca809
 2021-07-14 10:03:20 -04:00
wangyamei00221466
4a9896775d Modify the wrong comment for controller_util.go 2021-07-10 08:38:28 +08:00
Aldo Culquicondor
2dd2622188 Track Job Pods completion in status 
Through Job.status.uncountedPodUIDs and a Pod finalizer

An annotation marks if a job should be tracked with new behavior

A separate work queue is used to remove finalizers from orphan pods.

Change-Id: I1862e930257a9d1f7f1b2b0a526ed15bc8c248ad
 2021-07-08 17:48:05 +00:00
Kubernetes Prow Robot
16af282ee7
Merge pull request #103520 from swetharepakula/truncate-endpoints 
Truncate endpoints over a 1000 addresses
 2021-07-07 18:09:21 -07:00
Swetha Repakula
9bd857ca04 Truncate endpoints over a 1000 addresses 
* set `endpoints.kubernetes.io/over-capacity` to "truncated" when
 number of addresses has been truncated to a 1000
 * ready addresses are prioritized over non-ready addresses
 * addresses are proportionally truncated across subsets
 2021-07-07 12:48:43 -07:00
Kubernetes Prow Robot
ac6a1b1821
Merge pull request #103414 from ravisantoshgudimetla/fix-pdb-status 
[disruptioncontroller] Don't error for unmanaged pods
 2021-07-07 12:40:35 -07:00
ravisantoshgudimetla
2c116055f7 [disruptioncontroller] Don't error for unmanaged pods 
As of now, we allow PDBs to be applied to pods via
selectors, so there can be unmanaged pods(pods that
don't have backing controllers) but still have PDBs associated.
Such pods are to be logged instead of immediately throwing
a sync error. This ensures disruption controller is
not frequently updating the status subresource and thus
preventing excessive and expensive writes to etcd.
 2021-07-07 10:42:24 -04:00
Kubernetes Prow Robot
15222a599f
Merge pull request #103244 from verult/fsgroup-to-csi 
Delegate applying FSGroup to CSI driver through NodeStageVolume and NodePublishVolume
 2021-07-06 16:22:10 -07:00
Mike Dame
4b9230ed27 Promote LogarithmicScaleDown to beta 
This promotes the LogarithmicScaleDown feature gate to Beta, enabling it
by default. It also introduces a new metric, `sorting_deletion_age_ratio`,
intended to measure the efficacy of this new replica set scaledown behavior.
 2021-07-06 09:58:03 -04:00
Kubernetes Prow Robot
6acc62da75
Merge pull request #99997 from JornShen/extract_ep_and_epm_share_code_to_pkg 
Extracting same code of endpointslice and endpointslicemirror into a new shared EndpointSlice package
 2021-07-05 13:25:38 -07:00
Cheng Xing
0e315355df Pass FsGroup to MountDevice 2021-07-03 16:29:42 -07:00
Monis Khan
cd91e59f7c
csr: add expirationSeconds field to control cert lifetime 
This change updates the CSR API to add a new, optional field called
expirationSeconds.  This field is a request to the signer for the
maximum duration the client wishes the cert to have.  The signer is
free to ignore this request based on its own internal policy.  The
signers built-in to KCM will honor this field if it is not set to a
value greater than --cluster-signing-duration.  The minimum allowed
value for this field is 600 seconds (ten minutes).

This change will help enforce safer durations for certificates in
the Kube ecosystem and will help related projects such as
cert-manager with their migration to the Kube CSR API.

Future enhancements may update the Kubelet to take advantage of this
field when it is configured in a way that can tolerate shorter
certificate lifespans with regular rotation.

Signed-off-by: Monis Khan <mok@vmware.com>
 2021-07-01 23:38:15 -04:00
Chris Henzie
83e3ee780a Rename access mode contains helper method 
So it is consistent with other methods performing the same check (one
for internal and external types)
 2021-06-28 21:24:56 -07:00
Raymonder jin
03f9f75e88
fix typo for daemon_controller_test.go 2021-06-28 04:54:09 -07:00
Kubernetes Prow Robot
3a07d96d25
Merge pull request #99412 from enj/enj/i/ttl_backdate 
csr: correctly handle backdating of short lived certs
 2021-06-23 15:00:10 -07:00
Monis Khan
7e891e5d6c
csr: correctly handle backdating of short lived certs 
This change updates the backdating logic to only be applied to the
NotBefore date and not the NotAfter date when the certificate is
short lived. Thus when such a certificate is issued, it will not be
immediately expired.  Long lived certificates continue to have the
same lifetime as before.

Consolidated all certificate lifetime logic into the
PermissiveSigningPolicy.policy method.

Signed-off-by: Monis Khan <mok@vmware.com>
 2021-06-23 15:36:11 -04:00
Kubernetes Prow Robot
268cab5f44
Merge pull request #102022 from adtac/sbeta 
graduate SuspendJob to beta
 2021-06-22 17:18:10 -07:00
Kubernetes Prow Robot
81aaeee8a6
Merge pull request #102731 from sharmarajdaksh/lastappliedconfig-annotation-no-mirror 
fix: mirroring of last-applied-configuration annotation in EndpointSlices
 2021-06-15 13:41:55 -07:00
Kubernetes Prow Robot
a5be86fee7
Merge pull request #101316 from ravisantoshgudimetla/add-minReadySeconds-impl 
Add min ready seconds impl
 2021-06-15 13:41:43 -07:00
Kubernetes Prow Robot
270b66fb94
Merge pull request #102642 from alaypatel07/lastSuccessfulTime 
populate last successful time to cronjob status
 2021-06-15 11:31:35 -07:00
Dakshraj Sharma
211485c23d last-applied-config annotation no longer mirrored to endpoint slices 
Handles incorrect mirroring of endpoint annotations to created endpoint
slices, specifically the last-applied-config. Also updates tests
and adds test cases for the same
 2021-06-15 22:32:33 +05:30
ravisantoshgudimetla
ceb1dbd2f1 statefulsets: MinReadySeconds implementation 
https://github.com/kubernetes/kubernetes/pull/100842
introduced featuregate. This PR implements the logic
behind it.
 2021-06-15 12:59:54 -04:00
Kubernetes Prow Robot
8eef6438e6
Merge pull request #101055 from SimonCqk/master 
fix: inaccurate miss schedule times of cronjob v2.
 2021-06-15 08:38:01 -07:00
Davanum Srinivas
4b36a5cbe9
Switch to github.com/robfig/cron/v3 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-06-14 19:03:03 -04:00
Kubernetes Prow Robot
52eea971c5
Merge pull request #99279 from yangjunmyfm192085/run-test22 
Fix typo: Use uniform format of structured klog
 2021-06-11 19:22:59 -07:00
Kubernetes Prow Robot
4aae71695a
Merge pull request #102366 from cndoit18/fix-time-format 
fix(timezone): Change the time zone in the api data to UTC
 2021-06-11 06:54:59 -07:00
Antonio Ojea
3ac8d8c9ce endpointslicemirroring controller mirror address status 
Fix a bug on the endpoint slice mirroring controller where the
endpoints not ready addresses were mirrored as ready.
 2021-06-08 09:51:59 +02:00
Alay Patel
92b52a4fb5 populate last successful time to cronjob status 2021-06-06 16:14:16 -04:00
Kubernetes Prow Robot
e6a8bc9fbe
Merge pull request #90368 from serathius/remove-legacy-metrics 
Remove legacy metrics client from podautoscaler
 2021-06-05 08:44:38 -07:00
Marek Siarkowicz
4ebc0c94a4 Remove legacy metrics client from podautoscaler 2021-06-04 23:06:32 +02:00
Jordan Liggitt
ca279bbcc1 Fix race in attachdetach tests 2021-06-04 01:59:32 -04:00
Kubernetes Prow Robot
adf8df7b73
Merge pull request #102477 from yuzhiquan/master 
FIx failing tests: [sig-storage] Test_ADC_VolumeAttachmentRecovery/Deleted_Pod_with_migrated_PV
 2021-06-03 20:53:26 -07:00
yuzhiquan
0b8dc56408 fix volume failing test 2021-06-04 09:45:21 +08:00
Adhityaa Chandrasekar
ba708e5fc9 graduate SuspendJob to beta 
Also adds a label to two existing Job metrics.

Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
 2021-06-03 18:48:32 +00:00
cndoit18
51717256f9
fix(timezone): the timezone is standardized to UTC 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
 2021-06-03 23:55:39 +08:00
Kubernetes Prow Robot
043b3fc1e4
Merge pull request #101982 from hantmac/fix/need-handle-error 
handle Unmarshal error
 2021-06-02 13:43:03 -07:00
Tim Ebert
cd3709232f
Fix VolumeAttachment garbage collection for migrated PVs 2021-05-28 08:35:05 +02:00
Quan Tian
fc462857bb Add controllerUID index to improve ReplicaSetController performance 
Instead of listing all ReplicaSets in the namespace and checking their
controller UID, this patch adds a controllerUID index to the ReplicaSet
store and use it to get ReplicaSets with same controller, which reduces
the cost from O(#ReplicaSets) to O(1).

Benchmark results:
```
name                                 old time/op    new time/op    delta
GetReplicaSetsWithSameController-48    18.2µs ± 9%     0.4µs ± 5%  -97.64%  (p=0.008 n=5+5)

name                                 old alloc/op   new alloc/op   delta
GetReplicaSetsWithSameController-48    4.18kB ± 0%    0.05kB ± 0%  -98.85%  (p=0.008 n=5+5)

name                                 old allocs/op  new allocs/op  delta
GetReplicaSetsWithSameController-48      15.0 ± 0%       2.0 ± 0%  -86.67%  (p=0.008 n=5+5)
```
 2021-05-26 18:12:07 +08:00
Kubernetes Prow Robot
bc2b69b515
Merge pull request #101154 from basantsa1989/dual-stack 
Adding IPV6 (Dual Stack) support to handle IPV6 pod cidrs
 2021-05-25 13:46:43 -07:00
Basant Amarkhed
a013c6a2db Adding IPV6 (Dual Stack) support to handle IPV6 pod cidrs 2021-05-25 18:25:43 +00:00
Kubernetes Prow Robot
894803ab2e
Merge pull request #98199 from yangjunmyfm192085/run-test3 
fix mistake about [avaliable] for index_test.go
 2021-05-25 02:46:22 -07:00
Kubernetes Prow Robot
838a967be5
Merge pull request #101175 from lojies/cleanupforpvcontroller 
code cleanup:remove redundant return statement in pv_controller.go
 2021-05-24 21:48:49 -07:00
Aldo Culquicondor
d8aad7944c Remove unused util CreatePods 
And rename CreatePodsWithControllerRef to simply CreatePods
 2021-05-20 20:27:21 +00:00
Kubernetes Prow Robot
f4f238e038
Merge pull request #101601 from AliceZhang2016/indexed-job-stable-hostname 
specify pod name and hostname in indexed job
 2021-05-20 01:41:05 -07:00
Mengxue Zhang
e64e34e029 specify pod name and hostname in indexed job 2021-05-19 15:30:13 +00:00
Kubernetes Prow Robot
9558d0c5c2
Merge pull request #101984 from ravisantoshgudimetla/fix-ds-units 
[daemonSet]: Fix unit tests
 2021-05-18 23:32:51 -07:00
Kubernetes Prow Robot
89e0b2d185
Merge pull request #99398 from tnqn/ds-update-retry 
Fix DaemonSet status update retry
 2021-05-18 22:32:50 -07:00
Aldo Culquicondor
7c50cd762a Use aliases in sig apps and scheduling APIs OWNERS 
Add alculquicondor to sig-scheduling-api-reviewers and sig-apps-api-reviewers
 2021-05-17 17:56:20 +00:00
jornshen
6c63ef147c extract same code of es and esm to pkg 
migrate files:
endpointset.go
endpointslice_tracker.go
endpointslice_tracker_test.go
errors.go
 2021-05-14 15:15:35 +08:00
ravisantoshgudimetla
20f8654259 [daemonSet]: Fix unit tests 
We need to ensure that `DaemonSetUpdateSurge`
featuregate is both enabled and disabled when
running tests with Rolling update strategy.
 2021-05-13 10:31:28 -04:00
hantmac
619fff10ea handle Unmarshal error 
Signed-off-by: hantmac <hantmac@outlook.com>
 2021-05-13 21:22:59 +08:00
Kubernetes Prow Robot
22d120b4d6
Merge pull request #101156 from alculquicondor/unused_create_pod 
Remove unused CreatePodsOnNode function
 2021-05-12 10:41:28 -07:00
Kubernetes Prow Robot
c7be77935e
Merge pull request #101875 from ravisantoshgudimetla/fix-nil-check 
Fix nil check
 2021-05-11 11:52:37 -07:00
ravisantoshgudimetla
6f35e1aea0 Run unit test with DSMaxSurgeFlag enabled and disabled 2021-05-10 16:33:09 -04:00
ravisantoshgudimetla
ceeb05a3d7 DaemonSet: Fix surgeCount function 
If the surge is not requested, we should return
0. We are returning an error now as r.MaxSurge
is passed down as nil. This commit fixes the
issue by setting the surgeCount to 0 if r.MaxSurge
is nil.
 2021-05-10 16:10:59 -04:00
Kubernetes Prow Robot
548fb43643
Merge pull request #101292 from AliceZhang2016/job_controller_metrics 
Graduate indexed job to beta
 2021-05-07 13:31:44 -07:00
Kubernetes Prow Robot
a5cf298a95
Merge pull request #101737 from Jiawei0227/migration_fix 
Use CSI driver to determine unique name for migrated in-tree plugins
 2021-05-06 14:14:22 -07:00
Jiawei Wang
be583070d2 Use CSI driver to determine unique name for migrated in-tree plugins 2021-05-06 10:31:30 -07:00
Kubernetes Prow Robot
4f1bfe314e
Merge pull request #101163 from AliceZhang2016/indexed_job_pod_adoption 
indexed job: remove pods with invalid index
 2021-05-04 18:21:14 -07:00
Mengxue Zhang
2d2ee6bc3a change default feature gate value of IndexedJob 2021-04-30 14:36:15 +00:00
Mengxue Zhang
5fd4ab3dc3 add pod create/delete operation limitations per job sync 2021-04-27 18:51:38 +00:00
Mengxue Zhang
cda503fcc9 indexed job: add three metrics to job controller 2021-04-27 18:32:53 +00:00
Kubernetes Prow Robot
21ab9c4175
Merge pull request #95286 from SergeyKanzhelev/removePodUnknown 
Deprecating PodUnknown podPhase
 2021-04-27 11:21:38 -07:00
songxiao-wang87
30590a4160 Making a run test. 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2021-04-26 09:31:24 +08:00
wangyx1992
7175d82a27 Structured Logging migration: modify logs of controller-manager 
Signed-off-by: wangyx1992 <wang.yixiang@zte.com.cn>
 2021-04-25 11:27:44 +08:00
Kubernetes Prow Robot
0c054510a8
Merge pull request #101367 from BinacsLee/binacs-controller-endpointslice-cleanup 
code cleanup: append slice without check
 2021-04-23 19:28:00 -07:00
Kubernetes Prow Robot
fe88bdc1ab
Merge pull request #101304 from wangyx1992/capatial-log-controller 
cleanup: fix errors in wrapped format and log capitalization in controller
 2021-04-22 15:55:52 -07:00
BinacsLee
d7a4ed9c65 code cleanup: append slice without check 2021-04-22 18:29:30 +08:00
wangyx1992
fd51e654af cleanup: fix errors in wrapped format and log capitalization in controller 
Signed-off-by: wangyx1992 <wang.yixiang@zte.com.cn>
 2021-04-22 15:40:54 +08:00
Kubernetes Prow Robot
7ed02d61d1
Merge pull request #101235 from andyzhangx/azurefile-inline-ns-translation 
fix: azure file inline volume namespace issue in csi migration translation
 2021-04-21 19:15:44 -07:00
Kubernetes Prow Robot
5779fec3c4
Merge pull request #99959 from AliceZhang2016/nodeaffinity-cleanup 
Move nodeaffinity helpers to component-helpers package
 2021-04-21 17:03:53 -07:00
andyzhangx
e10d3948f5 fix: azure file namespace issue in csi translation 
fix build failure

fix comments
 2021-04-20 07:23:09 +00:00
Mengxue Zhang
4cf7e75841 indexed job: remove pods with invalid index 2021-04-19 14:07:07 +00:00
Kubernetes Prow Robot
df9ad4d7d2
Merge pull request #96094 from Hellcatlk/m 
Some comments' typos
 2021-04-16 11:54:22 -07:00
卢振兴10069964
8009823867 code cleanup:remove redundant return statement in pv_controller.go 2021-04-16 09:02:21 +08:00
Aldo Culquicondor
6fc5fc0c86 Remove unused CreatePodsOnNode function 
Remnant of old daemonset controller
 2021-04-15 18:53:36 +00:00
SimonCqk
b9d9cc38b5 fix: inaccurate miss schedule times of cronjob v2. 
Signed-off-by: SimonCqk <cqk0100@gmail.com>
 2021-04-13 13:59:27 +08:00
Kubernetes Prow Robot
d51f15ed0d
Merge pull request #100885 from enj/enj/i/auth_owners 
Update sig-auth OWNERS
 2021-04-12 22:18:49 -07:00
Kubernetes Prow Robot
d765ebd7a8
Merge pull request #100926 from deads2k/clarify 
include description of what kube-root-ca.crt can be used to verify
 2021-04-10 20:30:00 -07:00
JunYang
78323910db Fix typo: Use uniform format of structured klog 
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
 2021-04-10 12:00:00 +08:00
Kubernetes Prow Robot
1cedfef5c6
Merge pull request #100728 from robscott/topology-auto 
Updating Topology Aware Hints to support "Auto" value for annotation
 2021-04-09 05:20:38 -07:00
Kubernetes Prow Robot
4959cd6339
Merge pull request #100671 from Niekvdplas/spelling-mistakes 
Fixed several spelling mistakes
 2021-04-09 05:19:45 -07:00
Kubernetes Prow Robot
0172cbf56c
Merge pull request #99963 from alculquicondor/job_complete_active 
Remove active pods past completions
 2021-04-08 17:10:10 -07:00
Kubernetes Prow Robot
7807bb03ba
Merge pull request #99849 from jpbetz/apply-subresources 
Add subresource apply support to client-go
 2021-04-08 16:00:00 -07:00
Kubernetes Prow Robot
86fdf7b56e
Merge pull request #99487 from chymy/fix-staticcheck0226 
Fix staticcheck failures for pkg/controller/replicaset and pkg/kubelet/dockershim
 2021-04-08 14:28:17 -07:00
Kubernetes Prow Robot
e7dc0df323
Merge pull request #97650 from ialidzhikov/cleanup/redundant-imports 
Clean up some redundant imports
 2021-04-08 14:27:22 -07:00
David Eads
443e4ea0df include description of what kube-root-ca.crt can be used to verify 2021-04-08 10:43:41 -04:00
Monis Khan
bca4993004
Update auth OWNERS files to only use aliases 
Signed-off-by: Monis Khan <mok@vmware.com>
 2021-04-07 10:46:03 -04:00
Sergey Kanzhelev
4b05fe6644 podUnknown is marked as Obsolete 2021-04-06 22:43:08 +00:00
Joe Betz
29423501f0 Add apply subresource support to client-go's typed client 2021-04-05 12:27:42 -07:00
Rob Scott
50b377fe4e
Updating Topology Aware Hints to support "Auto" value for annotation 
Previously only "auto" was supported, a value that was inconsistent with
Kubernetes naming patterns.
 2021-03-31 15:58:42 -07:00
Niekvdplas
fec272a7b2 Fixed several spelling mistakes 2021-03-30 23:02:09 +02:00
Adhityaa Chandrasekar
0a21157c96 job controller: don't mutate shared cache object 
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
 2021-03-25 06:36:15 +00:00
Aldo Culquicondor
e6c3d7b34d Only default Job fields when feature gates are enabled 
Also use pointer for completionMode enum
 2021-03-12 20:46:52 +00:00
chymy
c28be0baab Fix staticcheck failures for pkg/controller/replicaset and pkg/kubelet/dockershim 2021-03-11 22:16:05 -05:00
Rob Scott
730d7dc1c0
Updating EndpointSlice controllers to avoid duplicate creations 
This updates the StaleSlices() method in EndpointSliceTracker to also
ensure that the tracker does not have more slices than have been
provided.

Co-Authored-By: Swetha Repakula <srepakula@google.com>
 2021-03-10 13:13:13 -08:00
Mengxue Zhang
bdda9728e7 move nodeaffinity helpers to component-helpers package 2021-03-10 20:19:25 +00:00
Aldo Culquicondor
4af432bab3 Remove active pods past completions 2021-03-10 14:55:40 +00:00
Kubernetes Prow Robot
410d092d8a
Merge pull request #99643 from pohly/generic-ephemeral-volume-beta 
generic ephemeral volume beta
 2021-03-09 17:39:26 -08:00
Kubernetes Prow Robot
05c4febbe7
Merge pull request #99975 from robscott/endpoints-over-capacity 
Adding new EndpointsOverCapacity annotation for Endpoints controller
 2021-03-09 16:08:48 -08:00
Kubernetes Prow Robot
0aa2e543d4
Merge pull request #99865 from alculquicondor/index-job-success 
Fix completed indexed job with repeated indexes
 2021-03-09 16:08:23 -08:00
Aldo Culquicondor
8ae0ad2b2f Fix completed indexed job with repeated indexes 2021-03-09 19:22:45 +00:00
Kubernetes Prow Robot
67fbcccad8
Merge pull request #99462 from jpbetz/apply-cluster-role-aggregator 
Migrate cluster role aggregator to apply
 2021-03-09 11:05:30 -08:00
Kubernetes Prow Robot
5155865ae2
Merge pull request #99326 from sunpa93/fs_resize_fix 
fix: use pv annotation to trigger filesystem resize when necessary
 2021-03-09 11:05:18 -08:00
Kubernetes Prow Robot
046ad61479
Merge pull request #99290 from mortent/PromotePDBsToGA 
Promote PodDisruptionBudget to policy/v1
 2021-03-09 11:05:05 -08:00
Rob Scott
8a3f72074e
Adding new EndpointsOverCapacity annotation for Endpoints controller 
Now that the EndpointSlice API and controllers are GA, the Endpoints
controller will use this annotation to warn when Endpoints are over
capacity. In a future release, this warning will be replaced with
truncation.
 2021-03-09 09:48:53 -08:00
Kubernetes Prow Robot
207c75c6f7
Merge pull request #99522 from robscott/topology-hints 
Adding support for Topology Aware Hints
 2021-03-09 09:19:12 -08:00
Kubernetes Prow Robot
dc74b9d0c7
Merge pull request #98753 from Jiawei0227/length 
Relax csiNodeIDMaxLength to longer limit
 2021-03-09 09:19:00 -08:00
Morten Torkildsen
21fba79d45 Promote PDBs to GA 2021-03-09 10:29:11 -05:00
Joe Betz
24f95667bf Migrate clusterroleaggregation controller to apply 2021-03-09 07:15:14 -08:00
Kubernetes Prow Robot
a56fa34d6b
Merge pull request #99942 from jsafrane/refactor-migration-featuregates 
Refactor CSI migration plugin manager to get featureGates as a parameter
 2021-03-09 04:27:46 -08:00
Sung Jun Park
5f69cf74d8 fix: when newly binding pvc to a pv, adjust pvc.status.capacity to pv's annotation that denotes the pre-resize capacity of the original pvc that pv was bound to if it has one 
test: confirm that pvc's status capacity is adjusted if pv has a pre-resize capacity annotation
 2021-03-09 07:55:10 +00:00
Patrick Ohly
555d4a12bf generic ephemeral volumes: drop ReadOnly field 
As discussed during the alpha review, the ReadOnly field is not really
needed because volume mounts can also be read-only. It's a historical
oddity that can be avoided for generic ephemeral volumes as part
of the promotion to beta.
 2021-03-09 08:22:48 +01:00
Kubernetes Prow Robot
7eb99191a1
Merge pull request #98116 from aojea/mirror_dual 
slice mirroring controller should mirror annotations (but endpoints.kubernetes.io/last-change-trigger-time annotation) and labels
 2021-03-08 20:47:12 -08:00
Kubernetes Prow Robot
a0341d7471
Merge pull request #98727 from adtac/suspend 
batch API: add suspended job
 2021-03-08 16:26:59 -08:00
Rob Scott
1dcf09c1bf
Adding support for TopologyAwareHints to EndpointSlice Controller 2021-03-08 15:37:46 -08:00
Antonio Ojea
c421e22e2c slice mirroring controller mirror annotations 
Add support to the endpoint slice mirroring controller to mirror
annotations, in addition to labels, but don´t mirror endpoint
triggertime annotation.

Also, fix a bug in the endpointslice mirroring controller, that
wasn't updating the mirrored slice with the new labels, in case
that only the endpoint labels were modified.
 2021-03-08 23:20:08 +01:00
Jiawei Wang
1e16615fb0 Relax csiNodeIDMaxLength to longer limit 
Update csiNodeIDMaxLength to 192 bytes
 2021-03-08 13:52:43 -08:00
Adhityaa Chandrasekar
a0844da8f7 batch: add suspended job 
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
 2021-03-08 20:08:21 +00:00
Patrick Ohly
3fa43540b6 CSIStorageCapacity: check MaximumVolumeSize during scheduling 
If available, then the MaximumVolumeSize is a better indicator whether
creating a volume has a chance to succeed than the total (?) Capacity,
which is potentially larger and less well-defined.
 2021-03-08 20:52:51 +01:00
Patrick Ohly
5ca0814165 CSIStorageCapacity: use beta API 2021-03-08 20:52:50 +01:00
Quan Tian
60bb2a3a6f Fix DaemonSet status update retry 
It's easy to get update conflict when processing a DaemonSet
continuously. storeDaemonSetStatus had a retry logic that it gets the
resource from apiserver to update the DaemonSet with the latest resource
version. However, it never really retried because of a wrong check and
always made an useless get call. This patch fixes the logic to allow
the function retry once on update error.
 2021-03-09 00:39:25 +08:00
Jan Safranek
219cbc818a Refactor CSI migration plugin manager to get featureGates as a parameter 
This allows caller to provide fake ones for testing of various corner cases
(migration on A/D controller disabled while enabled on kubelet).
 2021-03-08 13:50:01 +01:00
Kubernetes Prow Robot
e688f22da0
Merge pull request #99214 from jpbetz/apply-client-go-builders2-typedclient 
Add Apply to client-go's typed client
 2021-03-06 22:17:41 -08:00
Joe Betz
293e07a836 Add Apply functions to client-gen 2021-03-06 20:49:06 -05:00
Swetha Repakula
1925d94b18 Graduate EndpointSlice Controllers to GA 
- EndpointSlice controller will stop writing to Topology field
 - EndpointSlice controller will only provide NodeName and Zone on
 EndpointSlices
 2021-03-06 15:58:47 -08:00
Kubernetes Prow Robot
170c6a9833
Merge pull request #99806 from alculquicondor/job-adoption-unit 
Merge tests for getPodsForJob
 2021-03-06 12:50:29 -08:00
Kubernetes Prow Robot
bf67ba1c0e
Merge pull request #99791 from soltysh/simplify_unittests 
Simplify cronjob v2 controller tests
 2021-03-06 12:50:21 -08:00
Kubernetes Prow Robot
bf448a1eaa
Merge pull request #99212 from damemi/alculquicondor-log-timestamp 
Logarithmic timestamp comparison for downscaling
 2021-03-06 09:47:41 -08:00
Kubernetes Prow Robot
377ed3c2a6
Merge pull request #96441 from smarterclayton/daemonset_surge_impl 
DaemonSet controller respects MaxSurge during update
 2021-03-06 08:23:42 -08:00
Kubernetes Prow Robot
ed6b9addbf
Merge pull request #96347 from cofyc/kep1845 
Prioritizing nodes based on volume capacity
 2021-03-05 14:45:43 -08:00
Aldo Culquicondor
a8d105ab72 Logarithmic timestamp comparison for ReplicSet downscaling 
Change-Id: I0657ea0ce41b98fdee1a5307b5826a10deaff98c
 2021-03-05 15:58:26 -05:00
Maciej Szulik
0a8417e161
Simplify cronjob v2 controller tests 2021-03-05 19:25:51 +01:00