Commit Graph

12497 Commits

Author SHA1 Message Date
Uwe Krueger
932f98acaf add comment describing the race condition + TODO for appropriate test 2021-03-05 17:59:36 +01:00
Uwe Krueger
d8ee8e427e fix sync problem in streamwatcher
The streamwatcher has a synchronization problem that may lead to
a go routine blocking forever when closing a stream watch.

This occasionally happens, when informers are cancelled together with the
watch request using the stop channel, which leads to an increaing
number of blocked go routines, if imformers are dynamicaly created and deleted
again.

The function `receive` checks under a lock whether the watch has been stopped,
before an error is reported to the result channel.
The problem here is, that in between the watcher might be stopped by
calling the `Stop` method. In the actual code this is done by the
`cache.Reflector` using the streamwatcher by a defer which is executed after
the caller already stopped reading from the result channel.
As a result the stopping flag might be set after the check
and trying to send the error event blocks this send operation forever,
because there will never be a receiver again.

The fix introduces a dedicated local stop channel that is closed by the
`Stop` method and used in a select statement together with the send
operation to finally abort the loop.
2021-03-05 17:14:32 +01:00
Kubernetes Prow Robot
8306eeab75 Merge pull request #99837 from aojea/revertgce
Revert "fix a bug where only service with less than 100 ports can hav…
2021-03-05 07:46:22 -08:00
Kubernetes Prow Robot
feab32b220 Merge pull request #99817 from liggitt/zero-value
Fix zero-value custom resource validation with go1.16
2021-03-05 06:44:23 -08:00
Kubernetes Prow Robot
9067b5691d Merge pull request #97818 from damemi/remove-util-node-dep
Scheduler: remove direct dependency for k8s.io/kubernetes/pkg/util/node
2021-03-05 04:06:32 -08:00
Antonio Ojea
e08a46cafa Revert "fix a bug where only service with less than 100 ports can have GCE load balancer"
This reverts commit be7ee01f2f.
2021-03-05 12:30:43 +01:00
Kubernetes Prow Robot
066600f105 Merge pull request #99525 from kagaya85/fix-staticcheck
fix staticcheck for k8s.io/apiserver/pkg/endpoints
2021-03-05 01:56:34 -08:00
Kubernetes Prow Robot
66cbf0196b Merge pull request #98277 from XudongLiuHarold/add-loadbalancerclass-field
Add LoadBalancerClass field in service
2021-03-04 23:56:21 -08:00
Kubernetes Prow Robot
7a49140145 Merge pull request #98127 from mortent/AddConditionsToPDBs
Add conditions to PDB status
2021-03-04 22:30:21 -08:00
Kubernetes Prow Robot
af703cf86c Merge pull request #99743 from freehan/firewall-fix
fix a bug where only service with less than 100 ports can have GCE LB
2021-03-04 20:32:34 -08:00
Jordan Liggitt
b02b3c5828 Add test for zero-value custom resource validation 2021-03-04 22:57:26 -05:00
Kubernetes Prow Robot
31fe241c6e Merge pull request #99456 from dabaooline/dabaooline-patch-1
Update Staging's README.md
2021-03-04 19:32:33 -08:00
Kubernetes Prow Robot
6499f20d21 Merge pull request #98749 from pandaamanda/kubectl_patch_error
fix kubectl patch command error message
2021-03-04 19:32:21 -08:00
xiongzhongliang
99f0369f9d fix kubectl patch command error message 2021-03-05 17:05:10 +08:00
Jordan Liggitt
5515157f82 Update k8s.io/kube-openapi 2021-03-04 22:15:21 -05:00
Morten Torkildsen
b08eb95168 generated 2021-03-04 19:03:00 -08:00
Morten Torkildsen
1e2a7f381f Add conditions to PDB status 2021-03-04 18:52:02 -08:00
Kubernetes Prow Robot
110b9272f2 Merge pull request #99782 from liggitt/race-tests
Fix or remove tests that don't work in race mode
2021-03-04 18:34:48 -08:00
Xudong Liu
72da0b1bb0 Add LoadBalancerClass field in service
KEP-1959: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/1959-service-lb-class-field
2021-03-04 17:11:50 -08:00
Kubernetes Prow Robot
03d242665d Merge pull request #99012 from jpbetz/apply-client-go-builders2
Apply Builders for client-go's typed client
2021-03-04 14:40:55 -08:00
Kubernetes Prow Robot
a2157b36b7 Merge pull request #98806 from rikatz/remove-extension-prune
Remove extensions v1beta1 from addon manager and kubectl prune
2021-03-04 14:40:47 -08:00
Kubernetes Prow Robot
a8476e5570 Merge pull request #99792 from logicalhan/owners
add myself to owners for etcd metrics
2021-03-04 13:39:31 -08:00
Kubernetes Prow Robot
cdaf2bec84 Merge pull request #98774 from freehan/nodesync
Optimize and parallelize LoadBalancer Host update
2021-03-04 12:40:09 -08:00
Kubernetes Prow Robot
e959ecc1e6 Merge pull request #99681 from shiyajuan123/master
add descriptions to these event/types.go files
2021-03-04 11:01:07 -08:00
Kubernetes Prow Robot
30906bebc8 Merge pull request #99344 from wzshiming/fix/server-filters-flake
Fix staging/src/k8s.io/apiserver/pkg/server/filters flake test timeout
2021-03-04 11:00:09 -08:00
Joe Betz
86184be5f1 Support references to external types for 3rd party use 2021-03-04 10:31:38 -08:00
Joe Betz
c541c69331 generate applied configurations 2021-03-04 10:31:34 -08:00
Joe Betz
09cc895c84 Add apply configuration generator 2021-03-04 10:29:54 -08:00
Minhan Xia
4af1f4b30b Optimize and parallelize LoadBalancer Host update 2021-03-04 10:01:55 -08:00
Han Kang
5bc56ef4e6 add myself to owners for etcd metrics 2021-03-04 09:26:32 -08:00
Kubernetes Prow Robot
60a714058b Merge pull request #98673 from ehashman/storage-labels
Add labels for SIG storage components
2021-03-04 09:20:08 -08:00
Kubernetes Prow Robot
e22e9b4f83 Merge pull request #99755 from lala123912/out_of_range
fix RemoveStatusCondition()  cap out of range
2021-03-04 07:44:49 -08:00
Kubernetes Prow Robot
832ba9cc76 Merge pull request #99633 from CaoDonghui123/kubectllog1
remove duplicate kubectl logs
2021-03-04 07:44:41 -08:00
Kubernetes Prow Robot
d2d9b0e112 Merge pull request #98250 from brianpursley/kubectl-685
Add warning if client/server version difference exceeds the supported skew
2021-03-04 07:44:20 -08:00
Kubernetes Prow Robot
da85ff10cc Merge pull request #98194 from julianvmodesto/dry-run-openapi
Cache the OpenAPI schema for kubectl server-side dry run
2021-03-04 07:44:09 -08:00
Mike Dame
af045087d9 Move GetZoneKey function to component-helpers 2021-03-04 10:32:38 -05:00
Jordan Liggitt
68bb8b827b Fix or remove tests that don't work in race mode 2021-03-04 09:51:52 -05:00
Kubernetes Prow Robot
0f109b6958 Merge pull request #99362 from deads2k/confirm-beta
Use a versioner to convert an internal type into an external type for beta serving
2021-03-04 06:42:09 -08:00
Kubernetes Prow Robot
0b64461104 Merge pull request #99617 from wzshiming/fix/ctl-make-regexp-array
Fix MakeRegexpArray handling empty strings
2021-03-04 05:42:09 -08:00
Kubernetes Prow Robot
4d5868afc3 Merge pull request #99741 from liggitt/client-go-install
Update client-go install instructions
2021-03-04 02:08:56 -08:00
Kubernetes Prow Robot
f63cac6cdf Merge pull request #99738 from YoyinZyc/unbounded_metric
Enforce metric cardinality check to Gauge, Histogram and Summary metric
2021-03-04 00:30:03 -08:00
Kubernetes Prow Robot
cdd80af120 Merge pull request #99719 from jsafrane/cinder-label-ga
Promote Cinder topology labels to GA
2021-03-04 00:29:55 -08:00
Kubernetes Prow Robot
457d8576e5 Merge pull request #99660 from deads2k/bump-burst-for-kcm-discovery
increase discovery burst for kube-controller-manager
2021-03-04 00:28:55 -08:00
Kubernetes Prow Robot
cd54b1931d Merge pull request #98892 from ankeesler/exec-plugin-metrics
exec credential provider: add rest_client_exec_plugin_call_total metric
2021-03-04 00:28:29 -08:00
Kubernetes Prow Robot
5106581d23 Merge pull request #98858 from carlory/fix-98035
deprecate audit.k8s.io/v1[alpha|beta]1 versions
2021-03-04 00:28:21 -08:00
lala123912
b96e7f5a8a fix RemoveStatusCondition() cap out of range 2021-03-04 14:13:41 +08:00
Abdullah Gharaibeh
3c5f018f8e Add CrossNamespacePodAffinity quota scope and PodAffinityTerm.NamespaceSelector APIs, and CrossNamespacePodAffinity quota scope implementation. 2021-03-03 22:52:43 -05:00
brianpursley
0c28cad8d1 Add warning if client/server version difference exceeds the supported skew 2021-03-03 20:56:55 -05:00
Minhan Xia
be7ee01f2f fix a bug where only service with less than 100 ports can have GCE load balancer 2021-03-03 17:16:38 -08:00
Jordan Liggitt
41c12a847c Update client-go install instructions 2021-03-03 19:24:07 -05:00