Kubernetes Prow Robot
410d092d8a
Merge pull request #99643 from pohly/generic-ephemeral-volume-beta
...
generic ephemeral volume beta
2021-03-09 17:39:26 -08:00
Kubernetes Prow Robot
05c4febbe7
Merge pull request #99975 from robscott/endpoints-over-capacity
...
Adding new EndpointsOverCapacity annotation for Endpoints controller
2021-03-09 16:08:48 -08:00
Kubernetes Prow Robot
0aa2e543d4
Merge pull request #99865 from alculquicondor/index-job-success
...
Fix completed indexed job with repeated indexes
2021-03-09 16:08:23 -08:00
Aldo Culquicondor
8ae0ad2b2f
Fix completed indexed job with repeated indexes
2021-03-09 19:22:45 +00:00
Kubernetes Prow Robot
67fbcccad8
Merge pull request #99462 from jpbetz/apply-cluster-role-aggregator
...
Migrate cluster role aggregator to apply
2021-03-09 11:05:30 -08:00
Kubernetes Prow Robot
5155865ae2
Merge pull request #99326 from sunpa93/fs_resize_fix
...
fix: use pv annotation to trigger filesystem resize when necessary
2021-03-09 11:05:18 -08:00
Kubernetes Prow Robot
046ad61479
Merge pull request #99290 from mortent/PromotePDBsToGA
...
Promote PodDisruptionBudget to policy/v1
2021-03-09 11:05:05 -08:00
Rob Scott
8a3f72074e
Adding new EndpointsOverCapacity annotation for Endpoints controller
...
Now that the EndpointSlice API and controllers are GA, the Endpoints
controller will use this annotation to warn when Endpoints are over
capacity. In a future release, this warning will be replaced with
truncation.
2021-03-09 09:48:53 -08:00
Kubernetes Prow Robot
207c75c6f7
Merge pull request #99522 from robscott/topology-hints
...
Adding support for Topology Aware Hints
2021-03-09 09:19:12 -08:00
Kubernetes Prow Robot
dc74b9d0c7
Merge pull request #98753 from Jiawei0227/length
...
Relax csiNodeIDMaxLength to longer limit
2021-03-09 09:19:00 -08:00
Morten Torkildsen
21fba79d45
Promote PDBs to GA
2021-03-09 10:29:11 -05:00
Joe Betz
24f95667bf
Migrate clusterroleaggregation controller to apply
2021-03-09 07:15:14 -08:00
Kubernetes Prow Robot
a56fa34d6b
Merge pull request #99942 from jsafrane/refactor-migration-featuregates
...
Refactor CSI migration plugin manager to get featureGates as a parameter
2021-03-09 04:27:46 -08:00
Sung Jun Park
5f69cf74d8
fix: when newly binding pvc to a pv, adjust pvc.status.capacity to pv's annotation that denotes the pre-resize capacity of the original pvc that pv was bound to if it has one
...
test: confirm that pvc's status capacity is adjusted if pv has a pre-resize capacity annotation
2021-03-09 07:55:10 +00:00
Patrick Ohly
555d4a12bf
generic ephemeral volumes: drop ReadOnly field
...
As discussed during the alpha review, the ReadOnly field is not really
needed because volume mounts can also be read-only. It's a historical
oddity that can be avoided for generic ephemeral volumes as part
of the promotion to beta.
2021-03-09 08:22:48 +01:00
Kubernetes Prow Robot
7eb99191a1
Merge pull request #98116 from aojea/mirror_dual
...
slice mirroring controller should mirror annotations (but endpoints.kubernetes.io/last-change-trigger-time annotation) and labels
2021-03-08 20:47:12 -08:00
Kubernetes Prow Robot
a0341d7471
Merge pull request #98727 from adtac/suspend
...
batch API: add suspended job
2021-03-08 16:26:59 -08:00
Rob Scott
1dcf09c1bf
Adding support for TopologyAwareHints to EndpointSlice Controller
2021-03-08 15:37:46 -08:00
Antonio Ojea
c421e22e2c
slice mirroring controller mirror annotations
...
Add support to the endpoint slice mirroring controller to mirror
annotations, in addition to labels, but don´t mirror endpoint
triggertime annotation.
Also, fix a bug in the endpointslice mirroring controller, that
wasn't updating the mirrored slice with the new labels, in case
that only the endpoint labels were modified.
2021-03-08 23:20:08 +01:00
Jiawei Wang
1e16615fb0
Relax csiNodeIDMaxLength to longer limit
...
Update csiNodeIDMaxLength to 192 bytes
2021-03-08 13:52:43 -08:00
Adhityaa Chandrasekar
a0844da8f7
batch: add suspended job
...
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
2021-03-08 20:08:21 +00:00
Patrick Ohly
3fa43540b6
CSIStorageCapacity: check MaximumVolumeSize during scheduling
...
If available, then the MaximumVolumeSize is a better indicator whether
creating a volume has a chance to succeed than the total (?) Capacity,
which is potentially larger and less well-defined.
2021-03-08 20:52:51 +01:00
Patrick Ohly
5ca0814165
CSIStorageCapacity: use beta API
2021-03-08 20:52:50 +01:00
Quan Tian
60bb2a3a6f
Fix DaemonSet status update retry
...
It's easy to get update conflict when processing a DaemonSet
continuously. storeDaemonSetStatus had a retry logic that it gets the
resource from apiserver to update the DaemonSet with the latest resource
version. However, it never really retried because of a wrong check and
always made an useless get call. This patch fixes the logic to allow
the function retry once on update error.
2021-03-09 00:39:25 +08:00
Jan Safranek
219cbc818a
Refactor CSI migration plugin manager to get featureGates as a parameter
...
This allows caller to provide fake ones for testing of various corner cases
(migration on A/D controller disabled while enabled on kubelet).
2021-03-08 13:50:01 +01:00
Kubernetes Prow Robot
e688f22da0
Merge pull request #99214 from jpbetz/apply-client-go-builders2-typedclient
...
Add Apply to client-go's typed client
2021-03-06 22:17:41 -08:00
Joe Betz
293e07a836
Add Apply functions to client-gen
2021-03-06 20:49:06 -05:00
Swetha Repakula
1925d94b18
Graduate EndpointSlice Controllers to GA
...
- EndpointSlice controller will stop writing to Topology field
- EndpointSlice controller will only provide NodeName and Zone on
EndpointSlices
2021-03-06 15:58:47 -08:00
Kubernetes Prow Robot
170c6a9833
Merge pull request #99806 from alculquicondor/job-adoption-unit
...
Merge tests for getPodsForJob
2021-03-06 12:50:29 -08:00
Kubernetes Prow Robot
bf67ba1c0e
Merge pull request #99791 from soltysh/simplify_unittests
...
Simplify cronjob v2 controller tests
2021-03-06 12:50:21 -08:00
Kubernetes Prow Robot
bf448a1eaa
Merge pull request #99212 from damemi/alculquicondor-log-timestamp
...
Logarithmic timestamp comparison for downscaling
2021-03-06 09:47:41 -08:00
Kubernetes Prow Robot
377ed3c2a6
Merge pull request #96441 from smarterclayton/daemonset_surge_impl
...
DaemonSet controller respects MaxSurge during update
2021-03-06 08:23:42 -08:00
Kubernetes Prow Robot
ed6b9addbf
Merge pull request #96347 from cofyc/kep1845
...
Prioritizing nodes based on volume capacity
2021-03-05 14:45:43 -08:00
Aldo Culquicondor
a8d105ab72
Logarithmic timestamp comparison for ReplicSet downscaling
...
Change-Id: I0657ea0ce41b98fdee1a5307b5826a10deaff98c
2021-03-05 15:58:26 -05:00
Maciej Szulik
0a8417e161
Simplify cronjob v2 controller tests
2021-03-05 19:25:51 +01:00
Kubernetes Prow Robot
06a4b6f342
Merge pull request #99423 from soltysh/cronjob_controller
...
Switch cronjob controller to batch/v1
2021-03-05 10:00:22 -08:00
Yecheng Fu
d791f7feef
Prioritizing nodes based on volume capacity: unit tests
2021-03-05 23:59:25 +08:00
Yecheng Fu
21a43586e7
Prioritizing nodes based on volume capacity
2021-03-05 23:59:25 +08:00
Maciej Szulik
78f51f8fa5
Switch cronjob controller to batch/v1
2021-03-05 14:03:34 +01:00
Kubernetes Prow Robot
9067b5691d
Merge pull request #97818 from damemi/remove-util-node-dep
...
Scheduler: remove direct dependency for k8s.io/kubernetes/pkg/util/node
2021-03-05 04:06:32 -08:00
Morten Torkildsen
1e2a7f381f
Add conditions to PDB status
2021-03-04 18:52:02 -08:00
Kubernetes Prow Robot
ba0817b746
Merge pull request #99789 from alculquicondor/indexed-job-unit
...
Test for removal of invalid and repeated indexes
2021-03-04 14:41:29 -08:00
Kubernetes Prow Robot
4f1bf2558a
Merge pull request #99796 from swetharepakula/remove-nodeName-gate
...
Remove EndpointSliceNodeName feature gate logic
2021-03-04 13:40:04 -08:00
Kubernetes Prow Robot
fde28141e6
Merge pull request #99756 from robscott/endpointslicemirroring-tracker
...
Updating EndpointSliceMirroring controller to wait for cache to be updated
2021-03-04 13:39:22 -08:00
Kubernetes Prow Robot
de9821c6d0
Merge pull request #98128 from mortent/AvoidErrOnNonScale
...
Avoid sending events for every non-conformant pod in disruption controller
2021-03-04 13:38:30 -08:00
Aldo Culquicondor
f0f9f1d540
Merge tests for getPodsForJob
2021-03-04 21:09:33 +00:00
Kubernetes Prow Robot
7afa538f18
Merge pull request #99626 from pohly/generic-ephemeral-volume-protection-controller-cleanup
...
PVC protection controller: clarify pod shutdown
2021-03-04 11:00:58 -08:00
Kubernetes Prow Robot
a238698ea0
Merge pull request #99446 from pohly/generic-ephemeral-enablement
...
Generic ephemeral volume enablement
2021-03-04 11:00:30 -08:00
Swetha Repakula
6f5329d4c0
Remove EndpointSliceNodeName feature gate logic
...
- feature gate has graduated to GA and will always be enabled, so no
longer need to check if enabled
2021-03-04 09:57:15 -08:00
Rob Scott
06db357e06
Updating EndpointSliceMirroring controller to wait for cache to be updated
...
This matches the recent updates to the EndpointSliceTracker for the
EndpointSlice controller in #99345 that accomplished the same thing.
2021-03-04 09:16:41 -08:00
Aldo Culquicondor
2dd0c73056
Test for removal of invalid and repeated indexes
...
in Indexed Job
2021-03-04 16:39:34 +00:00
Mike Dame
af045087d9
Move GetZoneKey function to component-helpers
2021-03-04 10:32:38 -05:00
Kubernetes Prow Robot
c8fe1d9c06
Merge pull request #99614 from mengjiao-liu/update_cronjob_test_desc
...
modify the TestController2_updateCronJob test method description
2021-03-04 06:42:29 -08:00
Kubernetes Prow Robot
cc4bd511bb
Merge pull request #99746 from swetharepakula/nodeName-feature-gate-ga
...
Graduate EndpointSliceNodeName feature gate to GA
2021-03-04 02:09:03 -08:00
Kubernetes Prow Robot
180d9cfa8b
Merge pull request #99632 from pohly/storage-capacity-enablement
...
volume binder: storage capacity enablement
2021-03-04 02:08:20 -08:00
Kubernetes Prow Robot
9fa33ada4b
Merge pull request #99514 from mikkeloscar/hpa-no-scale-down-some-broken-metrics
...
hpa: Don't scale down if at least one metric was invalid
2021-03-04 02:08:08 -08:00
Kubernetes Prow Robot
3ce93161fe
Merge pull request #97507 from aldudko/controller-logging
...
Migrate deployment controller log messages to structured logging
2021-03-03 22:49:59 -08:00
mengjiao.liu
f80a799a45
modify the TestController2_updateCronJob test method description
2021-03-04 11:20:33 +08:00
Swetha Repakula
be2ef551d1
Graduate EndpointSliceNodeName feature gate to GA
...
- Feature gate can be removed when EndpointSlice v1beta1 is removed
- Remove test cases where feature gate is disabled
2021-03-03 18:13:51 -08:00
Aldo Culquicondor
8812531b8c
Add completion index to Job Pods
...
When .spec.completionMode="Indexed"
2021-03-03 22:45:53 +00:00
Kubernetes Prow Robot
7b0ad65d4d
Merge pull request #99288 from supriya-premkumar/ineffassign
...
Adds ineffassign to GO linter script.
2021-03-03 14:40:46 -08:00
Kubernetes Prow Robot
53492f79df
Merge pull request #98756 from pacoxu/ut/faster
...
networking nodeipam UT: set node poll interval to 1s in UT
2021-03-03 14:40:31 -08:00
Kubernetes Prow Robot
59f8ba5ffa
Merge pull request #98595 from SergeyKanzhelev/nodelifecycleSchedulerUnitTestsSpeedUp
...
sped up scheduler tests by using fake clock
2021-03-03 14:40:21 -08:00
Kubernetes Prow Robot
90ac9cfc58
Merge pull request #97881 from ialidzhikov/nit/unnecessary-type-conversion
...
Nit: Remove unnecessary type conversion
2021-03-03 14:39:49 -08:00
Sergey Kanzhelev
d24ed4ace1
sped up scheduler tests by using fake clock
2021-03-03 19:12:53 +00:00
Supriya Premkumar
e52e5e486c
Adds ineffassign to GO linter script.
...
Changes:
- Enables ineffassign check in the verify scripts.
- Fixes lint errs.
2021-03-03 08:28:10 -08:00
Patrick Ohly
512401a8a2
scheduler: tests for generic ephemeral volumes
...
This covers some failure scenarios and feature gate enablement.
2021-03-03 10:13:05 +01:00
Patrick Ohly
d2cc70ee2c
scheduler: fail when a pod uses disabled generic ephemeral volumes
...
Without this error, kube-scheduler was simply ignoring the special
volume source and scheduled the pod. This was unlikely to work in
practice because the volume might have needed binding or the feature
is also disabled on kubelet which then doesn't know what to do with
the volume.
2021-03-03 10:13:05 +01:00
pacoxu
cef6e81fb3
set node poll interval to 10ms in UT
...
Signed-off-by: pacoxu <paco.xu@daocloud.io>
2021-03-03 16:39:57 +08:00
Mikkel Oscar Lyderik Larsen
fef092b417
hpa: Don't scale down if at least one metric was invalid
...
Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
2021-03-03 07:53:01 +01:00
Kubernetes Prow Robot
ee90db514c
Merge pull request #99345 from robscott/endpointslice-wait-for-cache
...
Updating EndpointSlice controller to wait for cache to be updated
2021-03-02 13:23:20 -08:00
Kubernetes Prow Robot
d1a2af554a
Merge pull request #99115 from pohly/ephemeral-volume-metrics
...
generic ephemeral volume: add metrics
2021-03-02 12:15:59 -08:00
Kubernetes Prow Robot
a89d783b27
Merge pull request #99553 from alaypatel07/fix-flaky-unit-test
...
cronjob: fix flaky unit test TestController2_updateCronJob
2021-03-02 11:11:31 -08:00
Rob Scott
e1542606c2
Updating EndpointSlice controller to wait for cache to be updated
...
This updates the EndpointSlice controller to make use of the
EndpointSlice tracker to identify when expected changes are not present
in the cache yet. If this is detected, the controller will wait to sync
until all expected updates have been received. This should help avoid
race conditions that would result in duplicate EndpointSlices or failed
attempts to update stale EndpointSlices. To simplify this logic, this
also moves the EndpointSlice tracker from relying on resource versions
to generations.
2021-03-02 09:43:46 -08:00
Alay Patel
08bc827e66
cronjob_controller: add metrics for job creation skew duration
2021-03-02 10:38:59 -05:00
Patrick Ohly
98f75290ba
generic ephemeral volume: simpler metrics
...
A CounterVector with status as label may create unnecessary overhead
and using the success case with the empty label value wasn't
easy. It's better to have two seperate counters, one for total number
of calls and one for failed calls.
2021-03-02 12:01:37 +01:00
Patrick Ohly
6cb28fd1b4
generic ephemeral volume: add metrics
...
As discussed during the production readiness review, a metric for the
PVC create operations is useful. The "ephemeral_volume" workqueue
metrics were already added in the initial implementation.
The new code follows the example set by the endpoints controller.
2021-03-02 12:01:37 +01:00
Patrick Ohly
e98c40a6f9
volume binder: test different CSIStorageCapacity/CSIDriver combinations
...
When the feature is disabled either in the scheduler or the CSIDriver,
the scheduler is expected to schedule pods without considering whether
storage capacity is available.
2021-03-02 11:08:57 +01:00
Patrick Ohly
1f3ede50f7
PVC protection controller: clarify pod shutdown
...
The code was correct and now the comment references the code in
kubelet to illustrate how pod shutdown works.
2021-03-02 08:31:12 +01:00
Kubernetes Prow Robot
2e055dac58
Merge pull request #99163 from ahg-g/ahg-pod-deletion
...
Implements pod deletion cost
2021-03-01 18:19:21 -08:00
Kubernetes Prow Robot
1b88c2ee47
Merge pull request #98912 from wzshiming/ut/speed-up-volume-scheduling
...
Speed up pkg/controller/volume/scheduling unit tests
2021-03-01 13:58:16 -08:00
Alay Patel
602435ccb9
cronjob: fix flaky unit test TestController2_updateCronJob
2021-03-01 15:45:32 -05:00
Abdullah Gharaibeh
d7e80ab038
Implement pod deletion cost
2021-03-01 13:45:58 -05:00
Clayton Coleman
8d8884a907
daemonset: Remove unnecessary error returns in strategy code
...
The nodeShouldRunDaemonPod method does not need to return an error
because there are no scenarios under which it fails. Remove the
error return path for its direct calls as well.
2021-03-01 13:23:18 -05:00
Clayton Coleman
9f296c133d
daemonset: Simplify the logic for calculating unavailable pods
...
In order to maintain the correct invariants, the existing maxUnavailable
logic calculated the same data several times in different ways. Leverage
the simpler structure from maxSurge and calculate pod availability only
once, as well as perform only a single pass over all the pods in the
daemonset. This changed no behavior of the current controller, and
has a structure that is almost identical to maxSurge.
2021-03-01 13:23:16 -05:00
Clayton Coleman
18f43e4120
daemonset: Implement MaxSurge on daemonset update
...
If MaxSurge is set, the controller will attempt to double up nodes
up to the allowed limit with a new pod, and then when the most recent
(by hash) pod is ready, trigger deletion on the old pod. If the old
pod goes unready before the new pod is ready, the old pod is immediately
deleted. If an old pod goes unready before a new pod is placed on that
node, a new pod is immediately added for that node even past the MaxSurge
limit.
The backoff clock is used consistently throughout the daemonset controller
as an injectable clock for the purposes of testing.
2021-03-01 13:21:12 -05:00
Clayton Coleman
8e6f58b0bd
daemonset: Prevent accidental omissions of test condition checks
...
It is too easy to omit checking the return value for the
syncAndValidateDaemonSet test in large suites. Switch the method
type to be a test helper and fatal/error directly. Also rename
a method that referenced the old name 'Rollback' instead of
'RollingUpdate'.
2021-03-01 13:20:58 -05:00
Kubernetes Prow Robot
5498ee641b
Merge pull request #99561 from BenTheElder/remove-bazel
...
Remove Bazel
2021-03-01 09:55:27 -08:00
Kubernetes Prow Robot
f6152d1521
Merge pull request #97086 from xing-yang/check_datasource
...
Only CSI plugin can have a DataSource
2021-03-01 06:53:26 -08:00
wzshiming
67e4ba0797
Speed up pkg/controller/volume/scheduling unit tests
2021-03-01 11:53:45 +08:00
Morten Torkildsen
5ad4280c09
Avoid sending events for every non-conformant pod in disruption controller
2021-02-28 19:43:25 -08:00
Benjamin Elder
56e092e382
hack/update-bazel.sh
2021-02-28 15:17:29 -08:00
Kubernetes Prow Robot
c200a8f9b7
Merge pull request #98433 from damemi/remove-helper-from-volume-zone
...
Move GetPersistentVolumeClaimClass to component-helpers
2021-02-26 12:38:15 -08:00
chymy
d2868af029
Fix pkg/controller/replicaset/replica_set_test.go variable reference error
...
Signed-off-by: chymy <chang.min1@zte.com.cn>
2021-02-26 03:30:06 -05:00
Kubernetes Prow Robot
c198632a12
Merge pull request #97098 from alaypatel07/cronjob-controller-2-follow-up-2
...
fix the case of time drift and re-implement next schedule calculation
2021-02-25 12:21:40 -08:00
xing-yang
676a3a7012
Only CSI plugin can have a DataSource
2021-02-25 15:27:26 +00:00
Kubernetes Prow Robot
8feec9bf94
Merge pull request #99351 from CaoDonghui123/fixissues3
...
Remove deadcode
2021-02-24 15:29:34 -08:00
Alay Patel
cebbc6b487
cronjob: use the same schedule Parser for tests as the reconcile loop
2021-02-24 13:50:03 -05:00
Alay Patel
6290a23ceb
cronjob_controllerv2: gracefully handle 0 seconds between schedules
2021-02-24 13:48:56 -05:00
xiaofei.sun
fd62f32125
Scheduler: remove pkg/apis/core/field_constants.go
2021-02-24 18:06:29 +08:00
Kubernetes Prow Robot
1af99c4b21
Merge pull request #99274 from serathius/fix
...
Fix usage of klog.InfoS
2021-02-23 15:23:03 -08:00
caodonghui
f435e24403
Remove deadcode
2021-02-23 17:58:47 +08:00
Kubernetes Prow Robot
186f934e4c
Merge pull request #98346 from mortent/checkForScalePDBs
...
Check if resources implement scale in disruption controller
2021-02-22 13:58:03 -08:00
Alay Patel
4d7d14d249
update bazel
2021-02-22 12:11:04 -05:00
Alay Patel
0e171969e2
refine the test case for time drift, calculate next schedule with math
2021-02-22 12:11:04 -05:00
Shihang Zhang
1095778dcc
remove secret-based sa token client builder
2021-02-21 22:00:40 -08:00
Kubernetes Prow Robot
031f2afbba
Merge pull request #98931 from michaelbeaumont/kubelet_well_known
...
Move pkg/kubelet/apis to k8s.io/kubelet/pkg/apis
2021-02-20 11:55:41 -08:00
Marek Siarkowicz
7b1f3584f5
Fix usage of klog.InfoS
2021-02-20 19:22:16 +01:00
Shihang Zhang
bbce0468d4
add metrics for rootcacertpublisher controller
2021-02-16 21:56:41 -08:00
Kubernetes Prow Robot
aa28a3563b
Merge pull request #99050 from Jiawei0227/storage_metrics
...
Add migrated field to storage_operation_duration_seconds metric
2021-02-16 18:21:06 -08:00
Nikhita Raghunath
b11516d69f
*: move gmarek to emeritus_approvers
2021-02-16 10:59:19 +05:30
Alex Dudko
dcdde707ab
Migrate deployment controller log messages to structured logging
2021-02-14 11:09:52 -08:00
Jiawei Wang
3d61b56bcd
update bazel
2021-02-12 17:50:40 -08:00
Jiawei Wang
6a7222cf4e
Add migrated field to storage_operation_duration_seconds metric
2021-02-12 17:35:01 -08:00
Kubernetes Prow Robot
002fb9fc5e
Merge pull request #98676 from ahg-g/ahg-ttl
...
JobDeletionDurationSeconds metric in TTLAfterFinished controller
2021-02-12 16:57:05 -08:00
Abdullah Gharaibeh
181e2173cf
Added time to deletion metric to ttl-after-finidhed controller
2021-02-12 13:02:17 -05:00
Khaled (Kal) Henidak
3e56ddae67
upgrade IPv6DualStack feature to beta and turn on by default
2021-02-10 23:14:05 +00:00
Kubernetes Prow Robot
18605d8814
Merge pull request #98792 from wzshiming/ut/speed-up-persistentvolume
...
Speed up pkg/controller/volume/persistentvolume unit tests
2021-02-10 01:06:59 -08:00
Michael Beaumont
a5a6762d33
Move pkg/kubelet/apis to k8s.io/kubelet/pkg/apis
2021-02-09 21:37:39 +01:00
Kubernetes Prow Robot
425d29b39a
Merge pull request #98688 from wangkai1994/fix/pvc_protection_controller_log
...
migrate pkg/controller/volume/pvc_protection_controller.go to structured logs
2021-02-06 20:13:11 -08:00
Kubernetes Prow Robot
c15851b777
Merge pull request #98793 from wzshiming/ut/speed-up-endpointslice
...
Speed up pkg/controller/endpointslice unit tests
2021-02-05 17:51:11 -08:00
Kubernetes Prow Robot
036cab71a6
Merge pull request #98691 from pacoxu/cronjob-ut
...
run cronjob every 1minute in UT
2021-02-05 11:34:52 -08:00
Kubernetes Prow Robot
6dc0047396
Merge pull request #98259 from tanjing2020/taint_manager_log
...
migrate scheduler/taint_manager.go structured logging
2021-02-04 23:50:51 -08:00
wzshiming
98eb869d63
Speed up pkg/controller/endpointslice unit tests
2021-02-05 15:28:37 +08:00
wzshiming
fb518af0fc
Speed up pkg/controller/volume/persistentvolume unit tests
2021-02-05 15:09:36 +08:00
Kubernetes Prow Robot
4eb9d825d5
Merge pull request #98489 from alculquicondor/job-testtable
...
Make sync Job test tables more readable
2021-02-04 15:55:16 -08:00
Morten Torkildsen
b63342af70
Fix nil pointer dereference in disruption controller
2021-02-03 21:04:29 -08:00
Morten Torkildsen
96ea28aa77
Check if resources implement scale in disruption controller
2021-02-03 20:19:35 -08:00
wangkai1994
7edf9e0155
change to kref and kobj
2021-02-03 17:45:38 +08:00
pacoxu
81e0ebcde9
run cronjob every 1minute(means 1s) in UT
2021-02-02 18:54:50 +08:00
wangkai1994
ab11816570
migrate pkg/controller/volume/pvcprotection.go to structured logs
2021-02-02 17:42:20 +08:00
Kubernetes Prow Robot
f27318c0da
Merge pull request #98445 from damemi/taint-toleration-internal-helpers
...
Move Taint/Toleration helpers to component-helpers repo
2021-02-01 17:50:27 -08:00
Aldo Culquicondor
609116b147
Test failed pod recreation
...
Change-Id: I31a2e667e9d96c385a921e25347ebeb5a8424e62
2021-02-01 13:20:03 -05:00
Mike Dame
578ff3ec34
Move Taint/Toleration helpers to component-helpers repo
...
This is part of the goal for scheduling to remove dependencies on internal
packages for the scheduling framework. It also provides these functions in an
external location for other components and projects to import.
2021-02-01 11:06:03 -05:00
Mike Dame
ba72411aa2
Move GetPersistentVolumeClaimClass to component-helpers
...
The goal of this move is related to issue 89930, to break the dependence
of scheduling plugins on internal helpers. This function can easily move to
component-helpers where it will be used by other components as well.
2021-02-01 10:48:38 -05:00
Rob Scott
4c9c9bb5a0
Adding myself as an approver for EndpointSlice controller
...
This also adds me as a reviewer for the Endpoints controller.
2021-01-31 22:34:39 -08:00
Aldo Culquicondor
dbf9e3b2d3
Make sync Job test tables more readable
...
And use t.Run to improve debugging experience
Change-Id: Ia91adbfe9c419cc640abe0efe287f5b9ab715e87
2021-01-27 16:56:41 -05:00
Kubernetes Prow Robot
ed4025a47b
Merge pull request #96328 from qingsenLi/201107-tc
...
test: Add comment for the redundant define name
2021-01-26 10:30:32 -08:00
tanjing2020
e144c4e1e9
migrate scheduler/taint_manager.go structured logging
2021-01-25 10:06:41 +08:00
Kubernetes Prow Robot
73fbd3da09
Merge pull request #97407 from waynepeking348/clean_rs_by_revision_instead_of_creat_timestamp
...
clean rs by revision instead of creation timestamp in deployment controller
2021-01-21 20:15:27 -08:00
Kubernetes Prow Robot
889b0ef004
Merge pull request #98107 from andrewsykim/controllers-owner
...
add myself as reviewer in pkg/controller/OWNERS
2021-01-19 22:18:20 -08:00
JunYang
f241036d2b
fix mistake about [avaliable] for index_test.go
...
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
2021-01-20 08:37:50 +08:00
waynepeking348
b2de3507d0
add dependency in bazel BUILD file
2021-01-16 22:25:37 +08:00
Kubernetes Prow Robot
8bf42039e6
Merge pull request #96552 from pandaamanda/klog_fmt
...
use klog.Info and klog.Warning when had no format
2021-01-15 17:57:43 -08:00
Andrew Sy Kim
fdc9790b2d
add myself as reviewer in pkg/controller/OWNERS
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2021-01-15 17:21:35 -05:00
Jordan Liggitt
1e71a28490
Clean up namespaced children of missing virtual parents with incorrectly cluster-scoped nodes
2021-01-14 11:29:31 -05:00
Jordan Liggitt
65d43faf3a
Add unit test for child scope mismatch with missing parent
2021-01-14 10:45:56 -05:00
Kubernetes Prow Robot
8f09066809
Merge pull request #97788 from heqg/expect-scheduler_binder
...
fix typo of [expect] in pkg/controller/../scheduler_binder.go
2021-01-13 18:43:03 -08:00
Kubernetes Prow Robot
1209c59612
Merge pull request #96876 from howieyuen/no-execute-taint-missing
...
fix nodelifecyle controller not add NoExecute taint bug
2021-01-13 14:17:03 -08:00
Kubernetes Prow Robot
51f31bd42c
Merge pull request #97113 from 249043822/bugfix-job-log111
...
Optimize log output for job controller
2021-01-11 20:52:38 -08:00
ialidzhikov
e1e7c39b47
Remove unnecessary type conversion
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2021-01-09 22:43:29 +02:00
Kubernetes Prow Robot
5a6f9ed550
Merge pull request #97721 from aojea/slicelog
...
fix slice controller logging for services ipfamily
2021-01-07 09:34:40 -08:00
he.qingguo
b72da953be
fix typo of [expect] in pkg/controller/../scheduler_binder.go
...
Signed-off-by: he.qingguo <he.qingguo@zte.com.cn>
2021-01-07 12:23:14 +08:00
Kubernetes Prow Robot
e8b3a02fd2
Merge pull request #97572 from gavinfish/gc-test-typo
...
Cleanup: fix typos in garbagecollector_test.go
2021-01-05 15:11:53 -08:00
Kubernetes Prow Robot
571a7ce2c1
Merge pull request #97348 from josephburnett/bistable-review
...
Up and down scale stabilize with envelope.
2021-01-05 12:39:59 -08:00
Kubernetes Prow Robot
0300aa712e
Merge pull request #97543 from pacoxu/fix/94495-ga
...
remove LegacyNodeRoleBehavior and mv ServiceNodeExclusion to GA
2021-01-05 11:46:45 -08:00
Kubernetes Prow Robot
07bd985724
Merge pull request #96561 from ialidzhikov/cleanup/csi-node-info
...
Remove CSINodeInfo feature gate
2021-01-05 11:46:00 -08:00
pacoxu
441985afb6
set LegacyNodeRoleBehavior to false and mv ServiceNodeExclusion to GA
...
Signed-off-by: pacoxu <paco.xu@daocloud.io>
2021-01-05 22:34:18 +08:00
Antonio Ojea
561133ccf1
fix slice controller logging for services ipfamily
2021-01-05 12:52:04 +01:00
ialidzhikov
1b74f28ed8
Clean up some redundant imports
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2021-01-02 01:09:22 +02:00
drfish
4a839fa6d3
Fix typos in garbagecollector_test.go
2020-12-29 23:20:18 +08:00
Kubernetes Prow Robot
f11c3b475d
Merge pull request #94858 from waynepeking348/master
...
fix bugs when copying deployment annotations to replicaSet if value is empty
2020-12-22 19:08:26 -08:00
Kubernetes Prow Robot
83156c6246
Merge pull request #92335 from farah/farah/remove-unused-interface
...
Delete unused interface
2020-12-21 14:50:25 -08:00
Joseph Burnett
16133c2b77
Up and down scale stabilize with envelope.
...
The HPA controller keeps a flat history of recommendations for
stabilization. However when both up and down scale stabilization are
configured, the interpretation of the history changes depending on the
direction of movement. What we want is to keep the stabilized
recommendation within the envelope of the minimum and maximum over
configured stabilization windows. We should only move when the
envelope forces a move.
2020-12-21 14:36:13 +01:00
waynepeking348
c8f9858920
add unit test cases
2020-12-20 17:05:48 +08:00
waynepeking348
ab1be93809
clean rs by revision instead of creat timestamp
2020-12-20 17:05:42 +08:00
waynepeking348
6c36a48550
fix bugs when copying deployment annotations to replicaSet if value is empty
2020-12-20 13:46:26 +08:00
Kubernetes Prow Robot
efb9489acb
Merge pull request #96617 from yuga711/dangling
...
Recover CSI volumes from dangling attachments
2020-12-16 14:54:30 -08:00
Kubernetes Prow Robot
c5efee02ac
Merge pull request #89465 from shibataka000/84142-cm
...
Fix HPA bug about unintentional scale out during updating deployment when using PodMetric.
2020-12-16 04:44:21 -08:00
Kubernetes Prow Robot
b97aa71519
Merge pull request #96825 from roycaihw/storage-version/conditions
...
storage-version: update conditions
2020-12-14 14:01:51 -08:00
Hao Yuan
5569db4902
fix nodelifecyle controller not add NoExecute taint bug
2020-12-14 09:34:57 +08:00
Jayasekhar Konduru
9b2b73600d
Recover CSI volumes from dangling attachments
...
Change-Id: I72105d67d8a4069ab19bfa4638a7ac365cf4194c
2020-12-11 18:31:53 -08:00
ialidzhikov
bc432124a2
Remove CSINodeInfo feature gate
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-12-10 09:58:22 +02:00
Kubernetes Prow Robot
ce7ac8442e
Merge pull request #94599 from verult/adc-op-asw-race
...
Fixes Attach Detach Controller reconciler race reading ActualStateOfWorld and operation pending states
2020-12-08 16:28:53 -08:00
Kubernetes Prow Robot
0ee9c391f1
Merge pull request #92827 from yuanhuaiwang/disruptionresync
...
Remove resync period for disruption controller
2020-12-08 16:28:26 -08:00
KeZhang
67b40a50c6
Optimize log output
2020-12-08 11:20:24 +08:00
Haowei Cai
7a28ca419e
generated
2020-12-02 14:32:50 -08:00
Haowei Cai
d13fe474f9
storage-version: update conditions
2020-12-02 14:32:34 -08:00
Kubernetes Prow Robot
248c116963
Merge pull request #96417 from hvenev-vmware/fix-ipam
...
Fix double counting of IP addresses
2020-11-23 07:45:33 -08:00
Hristo Venev
c8c81be8af
range_allocator: Test (lack of) double counting
2020-11-22 23:09:09 -08:00
Hristo Venev
ee581278bd
cidrset: Add test for double counting
2020-11-22 23:09:09 -08:00
Hristo Venev
4d28391c24
Fix double counting of IP addresses
...
The range allocator in pkg/controller/nodeipam/ipam/range_allocator.go
may call Occupy() on the same range twice:
1. Just before subscribing to the NodeInformer
2. From a callback given to the NodeInformer soon after registration
2020-11-22 23:09:09 -08:00
Jordan Liggitt
e491c3bc70
Add GC unit tests
...
Adds unit tests covering the problematic scenarios identified
around conflicting data in child owner references
Before After
package level 51% 68%
garbagecollector.go 60% 75%
graph_builder.go 50% 81%
graph.go 50% 68%
Added/improved coverage of key functions that had lacking unit test coverage:
* attemptToDeleteWorker
* attemptToDeleteItem
* processGraphChanges (added coverage of all added code)
2020-11-17 10:49:32 -05:00
Jordan Liggitt
603a0b016e
Log cluster-scoped owners referencing namespaced owners, avoid retrying lookups forever
...
If a cluster-scoped dependent references a namespace-scoped owner,
this is an invalid relationship, and the lookup will never succeed in attemptToDelete.
Short-circuit requeueing in attemptToDelete and log.
2020-11-17 10:49:30 -05:00
Jordan Liggitt
221e4aa2c2
Queue non-matching children for deletion when a virtual node is marked as observed
...
When we observe valid coordinates for a previously virtual node,
if there are dependents that do not agree with those coordinates,
add them to the attemptToDelete queue.
This queue will check the dependent's ownerReferences using the coordinates specified by the dependent.
If all of the owners can be verified absent, the dependent will be deleted.
If some are still present, or if there are errors looking them up, the dependent will not be deleted.
If the verified owner is namespaced, and the dependent is not in the same namespace,
an event will be recorded for user visibility, since cross-namespace ownerReferences are not supported.
2020-11-17 10:49:27 -05:00
Jordan Liggitt
b655f22509
Handle virtual delete events when children don't agree on owner coordinates
...
If a virtual delete event is received for a node whose dependents disagree on the parent's coordinates:
1. propagate the delete to children that matched the verified absent coordinates
2. if the existing node is virtual, select a new set of coordinates from the remaining dependents
3. do not delete the parent node from the graph if the parent node is non-virtual,
or if there are dependents that do not agree with the virtual delete event coordinates
2020-11-17 10:49:07 -05:00
Jordan Liggitt
b8d7ecf73b
Make node removal conditional in processGraphChanges
2020-11-17 10:49:04 -05:00
Jordan Liggitt
ac8d419b4c
Enqueue dependents for deletion when their ownerReference does not match observed parent coordinates
...
When adding a dependent to the graph, we ensure there is a node representing each owner reference,
and add the dependent to each parent node.
If the parent node already exists, and the dependent's ownerReference
coordinates disagree with the verified coordinates, add the dependent to the attemptToDelete queue.
This queue will check the dependent's ownerReferences using the coordinates specified by the dependent.
If all of the owners can be verified absent, the dependent will be deleted.
If some are still present, or if there are errors looking them up, the dependent will not be deleted.
If the parent node has been observed via informer event (so we know the coordinates are accurate),
and the verified owner is namespaced, and the dependent is not in the same namespace,
an event will be recorded for user visibility, since cross-namespace ownerReferences are not supported.
2020-11-17 10:47:39 -05:00
Jordan Liggitt
78317edb8b
Short-circuit attemptToDelete loop for virtual nodes that are removed or observed
...
Virtual nodes are added to the attemptToDelete queue, and continue getting requeued
until they are successfully verified absent or are observed via informer.
In the meantime, if the real object associated with that UID is observed via informer,
or is observed to be deleted via informer, the graph node for that UID can be removed
or marked as observed. In that case, we should stop retrying to get the virtual node coordinates.
2020-11-17 10:46:00 -05:00
Jordan Liggitt
cae56bea0a
Replace virtual node with observed node if identity differs
...
If the graph contains a virtual node (because some child object referenced it in an OwnerRef),
and a real informer event is observed for that uid at different coordinates,
we want to fix the coordinates of the node in the graph to match the actual coordinates.
The safe way to do this is to clone the node, replace the identity in the clone,
then replace the node with the clone.
Modifying the identity directly is not safe because it is accessed lock-free from many code paths.
Replacing the node in the graph from processGraphChanges is safe because it is the only graph writer.
2020-11-17 10:42:48 -05:00
Jordan Liggitt
cb7b9ed532
Refactor identityFromEvent
2020-11-17 10:42:48 -05:00
Jordan Liggitt
30eb6683e6
Avoid marking virtual nodes as observed when they haven't been
...
Virtual nodes can be added to the GC graph in order to represent objects
which have not been observed via an informer, but are referenced via ownerReferences.
These virtual nodes are requeued into attemptToDelete until they are observed via an informer,
or successfully verified absent via a live lookup. Previously, both of those code paths
called markObserved() to stop requeuing into attemptToDelete.
Because it is useful to know whether a particular node has been observed via
a real informer event, this commit does the following:
* adds a `virtual bool` attribute to graph events so we know which ones came from a real informer
* limits the markObserved() call to the code path where a real informer event is observed
* uses an alternative mechanism to stop requeueing into attemptToDelete when a virtual node is verified absent via a live lookup
2020-11-17 10:42:48 -05:00
Jordan Liggitt
445f20dbdb
Switch GC absentOwnerCache to full reference
...
Before deleting an object based on absent owners, GC verifies absence of those owners with a live lookup.
The coordinates used to perform that live lookup are the ones specified in the ownerReference of the child.
In order to performantly delete multiple children from the same parent (e.g. 1000 pods from a replicaset),
a 404 response to a lookup is cached in absentOwnerCache.
Previously, the cache was a simple uid set. However, since children can disagree on the coordinates
that should be used to look up a given uid, the cache should record the exact coordinates verified absent.
This is a [apiVersion, kind, namespace, name, uid] tuple.
2020-11-17 10:42:48 -05:00
Jordan Liggitt
09bdf76b8a
Plumb event recorder to garbage collector controller
2020-11-17 10:42:45 -05:00
xiongzhongliang
90f4aeeea4
use klog.Info and klog.Warning when had no format
2020-11-14 00:55:06 +08:00
Kubernetes Prow Robot
da75c26648
Merge pull request #95978 from roycaihw/storage-version/gc
...
Storage version garbage collector
2020-11-12 18:36:37 -08:00
Haowei Cai
1d5a8f8f24
fixup! add storage version garbage collector
2020-11-12 16:34:27 -08:00
Haowei Cai
f675dac440
generated
2020-11-12 16:25:22 -08:00
Haowei Cai
ee9ace14c2
add storage version garbage collector
2020-11-12 16:21:00 -08:00
Kubernetes Prow Robot
765d949bfc
Merge pull request #96440 from robscott/endpointslice-pre-ga
...
Adding NodeName to EndpointSlice API, deprecation updates
2020-11-12 16:03:13 -08:00
Kubernetes Prow Robot
798eb07720
Merge pull request #96443 from alaypatel07/cronjob-controller-2-follow-up
...
handle slow cronjob lister in cronjob controller v2 and improve memory footprint
2020-11-12 13:16:52 -08:00
Kubernetes Prow Robot
4b46d44e0c
Merge pull request #96327 from robscott/app-protocol-ga
...
Graduating AppProtocol to GA
2020-11-12 13:16:39 -08:00
Kubernetes Prow Robot
55856ed727
Merge pull request #93130 from zshihang/master
...
plumb service account token down to csi driver
2020-11-12 13:16:25 -08:00
Rob Scott
84e4b30a3e
Updates related to PR feedback
...
- Remove feature gate consideration from EndpointSlice validation
- Deprecate topology field, note that it will be removed in future
release
- Update kube-proxy to check for NodeName if feature gate is enabled
- Add comments indicating the feature gates that can be used to enable
alpha API fields
- Add comments explaining use of deprecated address type in tests
2020-11-12 12:30:50 -08:00
Kubernetes Prow Robot
e38b1b94f8
Merge pull request #96399 from andrewsykim/service-config
...
move service controller config to k8s.io/cloud-provider/controllers/service/config
2020-11-12 11:21:57 -08:00
Shihang Zhang
d2859cd89b
plumb service account token down to csi driver
2020-11-12 09:26:43 -08:00
Rob Scott
d985438772
Updating EndpointSlice controllers to support NodeName field
2020-11-11 16:50:36 -08:00
Alay Patel
15089aab94
update bazel
2020-11-11 19:47:11 -05:00
Alay Patel
d6ca5b8d14
handle the case for slow cronjob lister, add unit tests
2020-11-11 18:48:57 -05:00
Alay Patel
41c82e69ed
convert to stardard lister, use []*batchv1.Job instead of []batchv1.Job
2020-11-11 18:48:57 -05:00
Kubernetes Prow Robot
667d1c2c3f
Merge pull request #93370 from alaypatel07/add-new-cronjob-controller
...
Add cronjob controller v2
2020-11-11 15:42:50 -08:00
Kubernetes Prow Robot
423f8731ef
Merge pull request #95719 from tsmetana/add-pv_collector-provisioner-metric
...
PV Controller: Add plugin name and volume mode to PV metrics
2020-11-11 01:49:49 -08:00
10177505
c9abf09136
Remove the redundant define name
2020-11-11 12:00:57 +08:00
Alay Patel
38bb53555e
update violation_exceptions.list and make generated
2020-11-10 17:32:06 -05:00
Alay Patel
8d7dd4415e
add cronjob_controllerv2.go
2020-11-10 17:32:06 -05:00
Andrew Sy Kim
b1e0decce1
move service controller config to k8s.io/cloud-provider/controllers/service/config
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-10 14:59:44 -05:00
Rob Scott
b044fadf66
Graduating AppProtocol to GA
2020-11-09 11:08:19 -08:00
Tim Hockin
819ff9b087
Use topology labels instead of old beta names ( #96033 )
...
* Rename const for topology.../zone
* Rename const for topology.../region
* Rename const for failure-domain.../zone
* Rename const for failure-domain.../region
* Restore old names for compat
2020-11-05 20:26:50 -08:00
Andrew Sy Kim
7cf19e5fb7
endpointslice API: rename 'accepting' condition to 'serving' condition
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-05 19:18:45 -05:00
Andrew Sy Kim
17cf1b4415
endpointslice controller: add test cases to TestSyncServiceFull for terminating endpoints
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-05 19:18:45 -05:00
Andrew Sy Kim
2947f5ce4f
endpointslice controller: refactor TestSyncServiceFull to use test tables
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-05 19:18:45 -05:00
Andrew Sy Kim
1c603e90ef
endpointslice controller: set new conditions 'accepting' and 'terminating'
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-11-05 19:18:45 -05:00
Kubernetes Prow Robot
2d6cd683bd
Merge pull request #95541 from cofyc/fix95538
...
volume binding: report UnschedulableAndUnresolvable status instead of an error when bound PVs not found
2020-11-05 15:16:51 -08:00
Shihang Zhang
2c378beb64
abort if namespace doesn't exist or terminating
2020-11-05 11:12:15 -08:00
Yecheng Fu
0961891a7a
report UnschedulableAndUnresolvable status instead of an error when PVCs can't find bound
...
persistent volumes
This is an user error. We should't report an error.
2020-11-05 10:28:40 +08:00
Shihang Zhang
d40f0c43c4
separate RootCAConfigMap from BoundServiceAccountTokenVolume
2020-11-04 17:10:39 -08:00
Kubernetes Prow Robot
096819c963
Merge pull request #95909 from pohly/pv-controller-delete-pv-fix
...
PV controller: don't delete PVs when PVC is not known yet
2020-11-02 02:00:52 -08:00
zouyu
7dd4622c84
Some comments' typos
...
Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
2020-11-02 15:05:23 +08:00
Kubernetes Prow Robot
4b65f70652
Merge pull request #95740 from cici37/moveCCM
...
Move cloud-controller-manager to staging k8s.io/cloud-provider
2020-10-30 13:48:51 -07:00
cici37
9465d95ea6
Move CCM to staging k8s.io/cloud-provider
2020-10-29 20:50:23 -07:00
Cheng Xing
d9a629fe3a
IsVolumeAttachedToNode() renamed to GetAttachState(), and returns 3 states instead of combining "uncertain" and "detached" into "false"
2020-10-29 13:24:51 -07:00
cici37
a91a2cdad6
Move informer_factory to staging
2020-10-29 12:20:33 -07:00
Patrick Ohly
24f5764787
pv controller test: more test cases
...
The main goal was to cover retrieval of a PVC from the apiserver when
it isn't known yet. This is achieved by adding PVCs and (for the sake
of completeness) PVs to the reactor, but not the controller, when a
special annotation is set. The approach with a special annotation was
chosen because it doesn't affect other tests.
The other test cases were added while checking the existing tests
because (at least at first glance) the situations seemed to be not
covered.
2020-10-28 10:52:11 +01:00
Patrick Ohly
22f81e9e0b
pv controller test: use sub tests
...
This makes it possible to run individual tests.
2020-10-28 10:39:59 +01:00
Patrick Ohly
06f934ea1f
pv controller test: enable klog output
...
This makes it possible to run tests with -v=5 and thus actually get
some output.
2020-10-28 10:39:10 +01:00
Cheng Xing
a61743b125
Fixes Attach Detach Controller reconciler race reading ActualStateOfWorld and operation pending states; fixes reconciler_test mock detach to account for multiple attaches on a node
2020-10-27 23:51:55 -07:00
Kubernetes Prow Robot
554319cce8
Merge pull request #95410 from benhxy/staticcheck
...
Fix static check for pkg/controller/podautoscaler
2020-10-27 10:36:14 -07:00
Patrick Ohly
5686664a1d
PV controller: don't delete PVs when PVC is not known yet
...
Normally, the PV controller knows about the PVC that triggers the
creation of a PV before it sees the PV, because the PV controller must
set the volume.beta.kubernetes.io/storage-provisioner annotation that
tells an external provisioner to create the PV.
When restarting, the PV controller first syncs its caches, so that
case is also covered.
However, the creator of a PVC might decided to set that annotation
itself to speed up volume creation. While unusual, it's not forbidden
and thus part of the external Kubernetes API. Whether it makes sense
depends on the intentions of the user.
When that is done and there is heavy load, an external provisioner
might see the PVC and create a PV before the PV controller sees the
PVC. If the PV controller then encounters the PV before the PVC, it
incorrectly concludes that the PV needs to be deleted instead of being
bound.
The same issue occurred earlier for external binding and the existing
code for looking up a PVC in the cache or in the apiserver solves the
issue also for volume provisioning, it just needs to be enabled also
for PVs without the pv.kubernetes.io/bound-by-controller annotation.
2020-10-27 11:26:58 +01:00
Khaled Henidak (Kal)
6675eba3ef
dual stack services ( #91824 )
...
* api: structure change
* api: defaulting, conversion, and validation
* [FIX] validation: auto remove second ip/family when service changes to SingleStack
* [FIX] api: defaulting, conversion, and validation
* api-server: clusterIPs alloc, printers, storage and strategy
* [FIX] clusterIPs default on read
* alloc: auto remove second ip/family when service changes to SingleStack
* api-server: repair loop handling for clusterIPs
* api-server: force kubernetes default service into single stack
* api-server: tie dualstack feature flag with endpoint feature flag
* controller-manager: feature flag, endpoint, and endpointSlice controllers handling multi family service
* [FIX] controller-manager: feature flag, endpoint, and endpointSlicecontrollers handling multi family service
* kube-proxy: feature-flag, utils, proxier, and meta proxier
* [FIX] kubeproxy: call both proxier at the same time
* kubenet: remove forced pod IP sorting
* kubectl: modify describe to include ClusterIPs, IPFamilies, and IPFamilyPolicy
* e2e: fix tests that depends on IPFamily field AND add dual stack tests
* e2e: fix expected error message for ClusterIP immutability
* add integration tests for dualstack
the third phase of dual stack is a very complex change in the API,
basically it introduces Dual Stack services. Main changes are:
- It pluralizes the Service IPFamily field to IPFamilies,
and removes the singular field.
- It introduces a new field IPFamilyPolicyType that can take
3 values to express the "dual-stack(mad)ness" of the cluster:
SingleStack, PreferDualStack and RequireDualStack
- It pluralizes ClusterIP to ClusterIPs.
The goal is to add coverage to the services API operations,
taking into account the 6 different modes a cluster can have:
- single stack: IP4 or IPv6 (as of today)
- dual stack: IPv4 only, IPv6 only, IPv4 - IPv6, IPv6 - IPv4
* [FIX] add integration tests for dualstack
* generated data
* generated files
Co-authored-by: Antonio Ojea <aojea@redhat.com>
2020-10-26 13:15:59 -07:00
Ben Hu
4e62298c1b
Fix static checks for pkg/controller/podautoscaler
2020-10-23 18:53:07 +00:00
Kubernetes Prow Robot
ec453ffb1a
Merge pull request #90691 from arjunrn/container-resource-hpa
...
Add container based scaling to HPA
2020-10-23 05:51:51 -07:00
Tomas Smetana
0c4e05a245
PV Controller: PV plugin and mode metrics
2020-10-23 14:35:35 +02:00
Kubernetes Prow Robot
106ee38796
Merge pull request #95647 from JoshuaAndrew/master
...
Horizontal Pod Autoscaler doesn`t automatically scale the number of pods correctly
2020-10-23 04:05:59 -07:00
Kubernetes Prow Robot
1257bc5acb
Merge pull request #91474 from cici37/pkgController
...
Cleanup CCM dependencies
2020-10-22 23:17:45 -07:00
Kubernetes Prow Robot
afa941b8e1
Merge pull request #95789 from qingsenLi/k8s201023
...
remove unused const failedExpiration
2020-10-22 22:17:35 -07:00
Kubernetes Prow Robot
153d33091b
Merge pull request #95632 from mrkm4ntr/remove-redundant-variable
...
Remove redundant variable
2020-10-22 22:16:48 -07:00
qingsenLi
30bfa7d078
remove unused const failedExpiration
2020-10-22 18:57:36 +08:00
weiwei
b19a115f42
If we set SelectPolicy MinPolicySelect on scaleUp behavior or scaleDown behavior,Horizontal Pod Autoscaler doesn`t automatically scale the number of pods correctly
...
Signed-off-by: weiwei <weiwei@tenxcloud.com>
2020-10-22 18:00:49 +08:00
Arjun Naik
0fec7b0f7e
Added functionality and API for pod autoscaling based on container resources
...
Signed-off-by: Arjun Naik <anaik@redhat.com>
2020-10-21 21:10:05 +02:00
Kubernetes Prow Robot
163b23f163
Merge pull request #95529 from cici37/cleanup
...
Add back openapi gen for generic types and clean up doc.go
2020-10-20 11:22:34 -07:00
Kubernetes Prow Robot
3175b59ac2
Merge pull request #94489 from ialidzhikov/fix/volume-expand
...
Do not assume storageclass is still in-tree after csi migration
2020-10-19 15:08:07 -07:00
cici37
95acec5a3b
Move client_builder to k8s.io/controller-manager
2020-10-19 14:48:22 -07:00
cici37
0d2002229f
Add back openapi gen for generic types and clean up doc.go
2020-10-16 10:54:15 -07:00
Shintaro Murakami
acc970399d
Remove redundant variable
...
The variable firstUnhealthyOrdinal is redundant because replicas and condemned are already sorted in ascending order.
2020-10-16 09:53:34 +09:00
Joseph Burnett
1ccaaa768d
Ignore deleted pods.
...
When a pod is deleted, it is given a deletion timestamp. However the
pod might still run for some time during graceful shutdown. During
this time it might still produce CPU utilization metrics and be in a
Running phase.
Currently the HPA replica calculator attempts to ignore deleted pods
by skipping over them. However by not adding them to the ignoredPods
set, their metrics are not removed from the average utilization
calculation. This allows pods in the process of shutting down to drag
down the recommmended number of replicas by producing near 0%
utilization metrics.
In fact the ignoredPods set is misnomer. Those pods are not fully
ignored. When the replica calculator recommends to scale up, 0%
utilization metrics are filled in for those pods to limit the scale
up. This prevents overscaling when pods take some time to startup. In
fact, there should be 4 sets considered (readyPods, unreadyPods,
missingPods, ignoredPods) not just 3.
This change renames ignoredPods as unreadyPods and leaves the scaleup
limiting semantics. Another set (actually) ignoredPods is added to
which delete pods are added instead of being skipped during
grouping. Both ignoredPods and unreadyPods have their metrics removed
from consideration. But only unreadyPods have 0% utilization metrics
filled in upon scaleup.
2020-10-14 16:45:06 +02:00
Kubernetes Prow Robot
8647eece9c
Merge pull request #95113 from Git-Jiro/lint_ttlcontroller
...
Lint ttl_controller
2020-10-13 22:51:53 -07:00
Kubernetes Prow Robot
ea896a2e64
Merge pull request #95224 from Git-Jiro/lint_endpoint
...
Fix lint errors in pkg/contoller/endpoint
2020-10-13 12:06:27 -07:00
cici37
ae8ce0d190
Move cmd/controller-manager to k8s.io/controller-manager and cloud specific configs to k8s.io/cloud-provider.
2020-10-08 13:23:16 -07:00
Kubernetes Prow Robot
f30d6a463d
Merge pull request #93779 from yodarshafrir1/fix_restart_job_failure_with_restart_policy_never
...
Fix job backoff limit for restart policy Never
2020-10-06 10:02:44 -07:00
Kubernetes Prow Robot
1a66eb7b8a
Merge pull request #89482 from renatoviana12/master
...
fixed percentage behaviour in instr
2020-10-05 20:00:19 -07:00
Kubernetes Prow Robot
60dd999b48
Merge pull request #94443 from aojea/slicesLabels
...
endpointslice controller should mirror parent service labels
2020-10-02 18:23:04 -07:00
Martin Schimandl
104ad794e5
Fix lint errors in pkg/contoller/endpoint
...
Also mark reason for lint errors in:
pkg/controller/endpoint/config/v1alpha1,
pkg/controller/endpointslice/config/v1alpha1
pkg/controller/endpointslicemirroring/config/v1alpha1
2020-10-01 09:11:00 +02:00
Renato Viana
316eff8dee
Fixed percentage behavior in instr
...
fixed syntax, wrote a test
fixed a test
.
1
Update staging/src/k8s.io/apimachinery/pkg/util/intstr/intstr_test.go
Co-Authored-By: Joel Speed <Joel.speed@hotmail.co.uk>
added test
.
fix
fix test
fixed a test
gofmt
lint
fix
function name
validation fix
.
godocs added
.
2020-09-30 21:23:05 +01:00
Martin Schimandl
600d621ce6
Lint ttl_controller
2020-09-28 14:22:37 +02:00
Kubernetes Prow Robot
2d9a0b64d1
Merge pull request #95013 from soltysh/fix_context
...
Use pager's context instead of TODO
2020-09-24 08:16:20 -07:00
Kubernetes Prow Robot
63d4a03270
Merge pull request #94947 from phillc/master
...
Replace 'the the ' with 'the '
2020-09-23 20:28:04 -07:00
Maciej Szulik
d91a1f7e92
Use pager's context instead of TODO
2020-09-23 20:18:03 +02:00
Kubernetes Prow Robot
dd466bccde
Merge pull request #94527 from brahmaroutu/mount-utils-2
...
Change code to use staging/k8s.io/mount-utils
2020-09-21 17:46:47 -07:00
phillc
adbc7c2172
find . -type f \( -name "*.go" -or -name "*.md" \) -print0 | xargs -0 gsed -i 's/the the /the /g'
2020-09-21 16:37:12 -04:00
Antonio Ojea
b7d8045b81
endpoinslices must mirror services labels
...
Implement, in the endpoint slice controller, the same logic
used for labels in the legacy endpoints controller.
The labels in the endpoint and in the parent must be equivalent.
Headless services add the well-known IsHeadlessService label.
Slices must have two well known labels: LabelServiceName and
LabelManagedBy.
2020-09-21 19:50:15 +02:00
ialidzhikov
3bc560225e
Do not assume storageclass is still in-tree after csi migration
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-09-19 17:33:19 +03:00
Kubernetes Prow Robot
97e4059092
Merge pull request #94730 from robscott/endpointslice-service-fix
...
Ensuring EndpointSlices are recreated after Service recreation
2020-09-18 18:38:27 -07:00
Matthew Cary
f2e23afcf1
Adds filtering of hosts to DialContexts.
...
The provided DialContext wraps existing clients' DialContext in an attempt to
preserve any existing timeout configuration. In some cases, we may replace
infinite timeouts with golang defaults.
- scaleio: tcp connect/keepalive values changed from 0/15 to 30/30
- storageos: no change
2020-09-18 00:07:32 +00:00
Srini Brahmaroutu
fbe5daed73
Change code to use staging/k8s.io/mount-utils
2020-09-16 21:51:24 -07:00
Kubernetes Prow Robot
09b3f6dbb3
Merge pull request #93214 from trashhalo/prefer-error
...
test: prefer NoError/Error over Nil/NotNil
2020-09-16 15:10:45 -07:00
Rob Scott
de02323a9d
Ensuring EndpointSlices are recreated after Service recreation
...
This fixes a bug that occurred when a Service was rapidly recreated.
This relied on an unfortunate series of events:
1. When the Service is deleted, the EndpointSlice controller removes it
from the EndpointSliceTracker along with any associated EndpointSlices.
2. When the Service is recreated, the EndpointSlice controller sees that
there are still appropriate EndpointSlices for the Service and does
nothing. (They have not yet been garbage collected).
3. When the EndpointSlice is deleted, the EndpointSlice controller
checks with the EndpointSliceTracker to see if it thinks we should have
this EndpointSlice. This check was intended to ensure we wouldn't
requeue a Service every time we delete an EndpointSlice for it.
This adds a check in reconciler to ensure that EndpointSlices it is
working with are owned by a Service with a matching UID. If not, it will
mark those EndpointSlices for deletion (assuming they're about to be
garbage collected anyway) and create new EndpointSlices.
2020-09-15 21:37:15 -07:00
Kubernetes Prow Robot
965137a992
Merge pull request #94692 from alculquicondor/wrap_errors_min
...
Wrap errors from VolumeBinding and DefaultBinder plugins
2020-09-15 18:27:34 -07:00
Kubernetes Prow Robot
e7b9453972
Merge pull request #93537 from timuthy/enhancement.move-resourcequota
...
Move ResourceQuota admission to k8s.io/apiserver lib
2020-09-15 12:26:58 -07:00
Kubernetes Prow Robot
983265aeaa
Merge pull request #94739 from knight42/fix/TestExpectationsOnRecreate
...
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
2020-09-15 11:18:07 -07:00
knight42
e89e72b637
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-15 16:02:35 +08:00
David Eads
c0c033b12f
generated
2020-09-14 09:24:41 -04:00
David Eads
c7911a384c
remove pod presets
2020-09-14 09:24:40 -04:00
Kubernetes Prow Robot
d39214ade1
Merge pull request #94603 from wojtek-t/migrate_leader_election_to_leases_todos
...
Migrate scheduler, controller-manager and cloud-controller-manager to use LeaseLock
2020-09-11 00:08:14 -07:00
Kubernetes Prow Robot
c7d6f796fe
Merge pull request #94144 from gnufied/prevent-stale-pv-read
...
Reduce offline volume expansion flake
2020-09-10 14:22:31 -07:00
Aldo Culquicondor
7fb40fc03c
Wrap errors on VolumeBinding plugin
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I23053528ac6857124fddd7f9fa26e122202ff4bd
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-09-10 16:22:16 -04:00
Hemant Kumar
bad8a51b9a
Read PV object from apiserver to prevent flake
2020-09-10 10:03:08 -04:00
wojtekt
805c1753cd
Migrate scheduler, controller-manager and cloud-controller-manager to lease lock.
2020-09-10 11:57:18 +02:00
Kubernetes Prow Robot
1f708f6e62
Merge pull request #94112 from damemi/sort-endpoints
...
Remove canonicalization of endpoints by endpoints controller for better comparison
2020-09-04 22:13:40 -07:00
Stephen Solka
203679cc61
prefer NoError/Error over Nil/NotNil
2020-09-04 18:35:52 -04:00
Tim Usner
cc0b86fa3c
Add more tests for LRU cache lookup
2020-09-04 15:09:03 +02:00
Tim Usner
70d440bc7e
Move ResourceQuota admission to k8s.io/apiserver
2020-09-04 14:53:52 +02:00
Mike Dame
44d1976f8d
Remove HeadlessService label in endpoints controller before comparing
2020-09-03 09:55:18 -04:00
Kubernetes Prow Robot
8296643fad
Merge pull request #94371 from bbyrne5/bmb-resourcequota-staticcheck-errorfix
...
fix staticcheck errors in resourcequota
2020-09-03 03:41:41 -07:00
Kubernetes Prow Robot
dd6c53d035
Merge pull request #93946 from alexzimmer96/68026-pkg-controller-resourcequota
...
Refactor pkg/controllers/resourcequota to fix golint errors
2020-09-01 19:41:06 -07:00
Kubernetes Prow Robot
ea7cd3b354
Merge pull request #92796 from andyxning/code_clean_for_podgc
...
code clean for podgc
2020-09-01 15:35:06 -07:00
Kubernetes Prow Robot
e23d83eead
Merge pull request #93710 from Jiawei0227/attachable2non
...
Detect volume attach-ability in the middle of attaching
2020-08-31 17:39:50 -07:00
Kubernetes Prow Robot
fe67e85bbf
Merge pull request #93457 from ymmt2005/aware-deleting-pvc
...
Do not create StatefulSet pods when PVC is being deleted
2020-08-31 14:47:50 -07:00
Brian Byrne
a820a82785
fix staticcheck errors in resourcequota
2020-08-31 12:27:23 -04:00
Kubernetes Prow Robot
5ce93a2ab5
Merge pull request #93673 from zhouya0/pv_controller_test_add_time_out
...
Cleanup wait forever loops in pv_controller_test.go
2020-08-28 08:04:17 -07:00
Kubernetes Prow Robot
24ec90d23c
Merge pull request #93015 from gnufied/remove-resize-map
...
Remove resize map code - unused code
2020-08-28 00:46:53 -07:00
Kubernetes Prow Robot
215d2c6bce
Merge pull request #92983 from iotty/csr.clean
...
[pkg/controller/certificates]: remove staled func comments
2020-08-27 19:08:23 -07:00
Kubernetes Prow Robot
67a7509ef3
Merge pull request #92430 from wangkai1994/fix/garbagecollector-staticcheck
...
Fix staticcheck failures for pkg/controller/garbagecollector/garbagecollector_test.go
2020-08-27 17:57:22 -07:00
Kubernetes Prow Robot
2fbde4f5d2
Merge pull request #93739 from mrkm4ntr/pv-class-name
...
Use v1helper.GetPersistentVolumeClass for compatibility
2020-08-27 16:07:17 -07:00
knight42
02236580a6
test(endpointslice): deflake TestSyncEndpoints
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-08-25 15:40:29 +08:00
Jiawei Wang
a6d8e6c5c2
Detect change of volume attachability in the middle of attaching
...
- Add Unit tests for both volumemanager and attach/detach controller
- Add E2E test
2020-08-24 17:15:11 -07:00
Rob Scott
3c804502d7
Updating EndpointSliceMirroring controller to listen for Service changes
...
This fixes a bug that could occur if a custom Endpoints resource was
created before a Service was created.
2020-08-24 17:09:42 -07:00
Alexander Zimmermann
86dc0364f4
Refactored pkg/controllers/resourcequota
...
* Fixed golint issues
* Removed redundant package import names
* Improved some variables and names
Co-authored-by: Mike Danese <mikedanese@gmail.com>
2020-08-20 14:37:27 +02:00
Rob Scott
9180cf2346
Updating EndpointSlice controller to wait for all caches to be synced
...
Previously the EndpointSlice controller was not waiting for
EndpointSlices or Nodes to be synced.
2020-08-18 12:11:44 -07:00
ymmt
17af029bc5
do not create StatefulSet pods when PVC is being deleted
...
Pod with PVC will not be scheduled if the PVC is being deleted.
This can happen when the PVC has finalizers of storage plugins.
Such a pod becomes pending. Unfortunately, after the finalizer
finishes and PVC is deleted, the pod remains pending forever.
The StatefulSet controller does nothing for this pending pod.
This commit prevents the StatefulSet controller from creating
such pods when PVC is to be deleted.
2020-08-17 22:50:42 +00:00
Rob Scott
4cfe4403b4
Updating EndpointSlice controllers to return if error encountered
...
Previously the controllers would proceed with additional creates,
updates, or deletes if 1 failed. That could potentially result in
scenarios where an EndpointSlice create or update failing while a delete
worked. This updates the logic so that removals will not happen if
additions fail.
2020-08-12 09:58:03 -07:00
yodarshafrir1
24010022ef
Number of failed jobs should exceed the backoff limit and not big equal.
...
Remove patch in e2e test of backoff limit due to usage of NumRequeues
2020-08-11 11:06:09 +03:00
Kubernetes Prow Robot
15a3d46db1
Merge pull request #93030 from swetharepakula/endpoint-tracker
...
Requeue Service after Endpoint Deletion
2020-08-10 18:28:16 -07:00
Kubernetes Prow Robot
37cda82c35
Merge pull request #93722 from liggitt/taint-evict
...
Do not evict pods which tolerate all NoExecute taints
2020-08-09 20:42:19 -07:00
Jordan Liggitt
648c591fff
Fix namespace controller cleanup orphaning
2020-08-07 13:26:28 -04:00
yodarshafrir1
ca420ddada
Fix job's backoff limit for restart policy Never, rely on number of failures instead of number of NumRequeues
2020-08-07 14:22:40 +03:00
Kubernetes Prow Robot
f5334fad48
Merge pull request #93617 from liggitt/deflake-ds-test
...
Deflake TestExpectationsOnRecreate
2020-08-06 09:35:43 -07:00
Shintaro Murakami
b7792711f5
Use v1helper.GetPersistentVolumeClass for compatibility
2020-08-06 09:26:21 +09:00
Kubernetes Prow Robot
382107e6c8
Merge pull request #93441 from robscott/endpointslicemirroring-tracker-fix
...
Fixing memory leak in EndpointSliceMirroring EndpointSlice tracker
2020-08-05 11:54:28 -07:00
Swetha Repakula
23a3353a6a
Requeue service after endpoint deletion
...
- ensure endpoints that have been deleted and are desired are recreated
despite a possibly out of date endpoint cache
2020-08-05 11:50:23 -07:00
Jordan Liggitt
892bdf9a15
Do not evict pods which tolerate all NoExecute taints
2020-08-05 12:50:43 -04:00
zhouya0
8724a8ea6b
Cleanup wait forever loops in pv_controller_test.go
2020-08-04 16:19:32 +08:00
Kubernetes Prow Robot
9d8a87b5c7
Merge pull request #93442 from robscott/endpointslicemirroring-labels
...
Updating EndpointSliceMirroring controller to copy labels from Endpoints
2020-08-04 01:14:19 -07:00
Rob Scott
52894d7bfb
Updating EndpointSliceMirroring controller to copy labels from Endpoints
...
The KEP specifies that the controller will "mirror all labels from the
Endpoints resource and all endpoints and ports from the corresponding subset".
I'd missed that in my initial implementation, this should fix that.
2020-08-03 14:12:30 -07:00
Jordan Liggitt
c4c946d35d
Deflake TestControllerSync
2020-08-03 11:56:14 -04:00
Jordan Liggitt
8e6a8669c0
Deflake TestExpectationsOnRecreate
2020-07-31 18:12:01 -04:00
Jordan Liggitt
1420b377e4
Add providerless tags
2020-07-30 13:48:40 -04:00
Kubernetes Prow Robot
72a62bcade
Merge pull request #92948 from cheftako/owners
...
Adding cheftako to pkg/controller/OWNERS
2020-07-30 05:56:30 -07:00
knight42
a3b772b442
test: deflake TestRecycleSlices test
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-07-27 21:41:02 +08:00
Rob Scott
98b63ad3a6
Fixing memory leak in EndpointSliceMirroring EndpointSlice tracker
...
This mirrors an earlier fix to the EndpointSlice controller. I'll make a
follow up PR to move this component to a shared package, but that seems
beyond the scope of a bug fix PR.
2020-07-24 17:21:36 -07:00
Nikhita Raghunath
c00dae0607
Revert "Merge pull request #93156 from logicalhan/triage-api-machinery"
...
This reverts commit 32438cf269
, reversing
changes made to bb6a6aa391
.
2020-07-24 13:01:02 +05:30
Kubernetes Prow Robot
32438cf269
Merge pull request #93156 from logicalhan/triage-api-machinery
...
automatically assign triage labels to api-machinery tagged PRs
2020-07-21 19:52:34 -07:00
Kubernetes Prow Robot
5a529aa3a0
Merge pull request #91399 from danwinship/endpoint-ipfamily
...
multiple IPv6/dual-stack endpoint fixes
2020-07-20 13:31:14 -07:00
Kubernetes Prow Robot
05f6812c2d
Merge pull request #90822 from deads2k/csr-separate-signer-flags-02
...
allow setting different certificates for kube-controller-managed CSR signers
2020-07-18 03:10:50 -07:00
Dan Winship
e46572ef4b
Improve EndpointController's handling of headless services under dual-stack
...
EndpointController was accidentally requiring all headless services to
be IPv4-only in clusters with IPv6DualStack enabled.
This still leaves "legacy" (ie, IPFamily-less) headless services as
always IPv4-only because the controller doesn't currently have easy
access to the information that would allow it to fix that.
(EndpointSliceController had the same problem already, and still
does.) This can be fixed, if needed, by manually setting IPFamily,
and the proposed API for 1.20 will handle this situation better.
2020-07-17 15:26:21 -04:00
Dan Winship
9023d19c57
Improve EndpointController dual-stack testing
...
Rewrite some of the test helpers to better support single-stack IPv4
vs single-stack IPv6 vs dual-stack IPv4 primary vs dual-stack IPv6
primary, and update TestPodToEndpointAddressForService to test some
more cases.
2020-07-17 15:26:21 -04:00
Dan Winship
9fb6e2ef55
Fix Endpoint/EndpointSlice pod change detection
...
The endpoint controllers responded to Pod changes by trying to figure
out if the generated endpoint resource would change, rather than just
checking if the Pod had changed, but since the set of Pod fields that
need to be checked depend on the Service and Node as well, the code
ended up only checking for a subset of the changes it should have.
In particular, EndpointSliceController ended up only looking at IPv4
Pod IPs when processing Pod update events, so when a Pod went from
having no IP to having only an IPv6 IP, EndpointSliceController would
think it hadn't changed.
2020-07-17 15:22:59 -04:00
Han Kang
9129dbc98b
automatically assign triage labels to api-machinery tagged PRs
...
Change-Id: Ifcc8a85d190d6370423af27f6e6c4c90b8472981
2020-07-16 13:13:59 -07:00
Hemant Kumar
2ccd645d71
Remove resize map code
...
This code is not used anywhere
2020-07-13 08:24:10 -04:00
Kubernetes Prow Robot
67ec4b3cd7
Merge pull request #92838 from tnqn/endpointslicetrack-leak
...
Fix memory leak in endpointSliceTracker
2020-07-11 20:56:13 -07:00
Zhou Peng
80519cee5b
[pkg/controller/certificates]: remove staled func comments
...
This was introduced by commit: f04ce3cfba
Since this func is simple and clear enough, just not comment it anymore.
Signed-off-by: Zhou Peng <p@ctriple.cn>
2020-07-11 17:08:28 +08:00
Kubernetes Prow Robot
0cb7e320a5
Merge pull request #92784 from pohly/generic-ephemeral-inline-volumes
...
generic ephemeral inline volumes
2020-07-10 15:41:46 -07:00
Kubernetes Prow Robot
4efed03276
Merge pull request #91637 from robscott/endpointslice-mirroring
...
Adding new EndpointSlice Mirroring Controller
2020-07-10 10:19:48 -07:00
wfender
22dafd9406
Adding cheftako to pkg/controller/OWNERS
2020-07-09 16:10:59 -07:00
Patrick Ohly
ff3e5e06a7
GenericEphemeralVolume: initial implementation
...
The implementation consists of
- identifying all places where VolumeSource.PersistentVolumeClaim has
a special meaning and then ensuring that the same code path is taken
for an ephemeral volume, with the ownership check
- adding a controller that produces the PVCs for each embedded
VolumeSource.EphemeralVolume
- relaxing the PVC protection controller such that it removes
the finalizer already before the pod is deleted (only
if the GenericEphemeralVolume feature is enabled): this is
needed to break a cycle where foreground deletion of the pod
blocks on removing the PVC, which waits for deletion of the pod
The controller was derived from the endpointslices controller.
2020-07-09 23:29:24 +02:00
David Eads
1233a6f63e
generated
2020-07-09 08:14:55 -04:00
David Eads
e88fecf26b
allow setting different certificates for kube-controller-managed CSR signers
2020-07-09 08:14:55 -04:00
Kubernetes Prow Robot
55d77ade67
Merge pull request #92489 from alculquicondor/sig-storage-ownership
...
Add SIG storage owner aliases
2020-07-09 00:05:20 -07:00
Kubernetes Prow Robot
94a08e159a
Merge pull request #92387 from pohly/csi-storage-capacity
...
CSI storage capacity check
2020-07-09 00:04:59 -07:00
Kubernetes Prow Robot
c2e6e147be
Merge pull request #92160 from YuikoTakada/add_deprecated_description_scheduling_duration_seconds
...
Add Deprecated description to metrics scheduling_duration_seconds
2020-07-09 00:04:48 -07:00
Quan Tian
087682584d
Fix memory leak in endpointSliceTracker
...
endpointSliceTracker creates a set of resource versions for each
service, the resource versions in the set could be deleted when
endpointslices are deleted, but the set and its key in the map is never
deleted, leading to memory leak.
This patch deletes the set if the service is deleted, and stops
initializing an empty set when "read-only" methods "Has" and "Stale" are
called.
2020-07-08 00:15:30 +08:00
Aldo Culquicondor
27ec356d76
Add SIG storage owner aliases
...
And give ownership to pkg/scheduler/framework/plugins/volumebinding
Signed-off-by: Aldo Culquicondor <acondor@google.com>
Change-Id: I4bd89b1745a2be0e458601056ab905bdd6692195
2020-07-07 10:26:16 -04:00
wangkai1994
b3b95f5ab5
add defer
2020-07-07 10:20:19 +08:00
Rob Scott
fa59370e93
Adding new logging, event, and metric to better capture when mirroring addresses is skipped
2020-07-06 12:43:35 -07:00
Rob Scott
e701cb0205
Enabling the EndpointSliceMirroring controller, adding related config
2020-07-06 12:43:34 -07:00
Rob Scott
8691466059
Adding EndpointSliceMirroring controller
...
This will mirror custom Endpoints to EndpointSlices to ensure that
applications will not need to maintain both separately.
2020-07-06 12:43:33 -07:00
Patrick Ohly
0efbbe8555
CSIStorageCapacity: check for sufficient storage in volume binder
...
This uses the information provided by a CSI driver deployment for
checking whether a node has access to enough storage to create the
currently unbound volumes, if the CSI driver opts into that checking
with CSIDriver.Spec.VolumeCapacity != false.
This resolves a TODO from commit 95b530366a
.
2020-07-06 19:20:10 +02:00
yuanhuaiwang
8e1e1e9be2
Remove resync period for disruption controller
...
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The disruption controller is resyncing all ssets every 30 seconds, this is not necessary, and make the depth of disruption workqueue longer and can cause delays processing actual updates when large amounts of disruptions exist.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Disruption controllers no longer force a resync every 30 seconds when nothing has changed.
2020-07-06 20:31:28 +08:00
andyxning
2e22ef50ea
code clean for podgc
2020-07-04 23:01:16 +08:00
Kubernetes Prow Robot
393f9e94e4
Merge pull request #92417 from wawa0210/ipam-staticcheck
...
Ipam staticcheck
2020-07-04 00:30:48 -07:00
Kubernetes Prow Robot
7f78c330c0
Merge pull request #92421 from wawa0210/deployment-staticcheck
...
fix pkg/controller/deployment staticcheck
2020-07-02 06:41:29 -07:00
Kubernetes Prow Robot
e37c04bd7c
Merge pull request #92684 from cofyc/volume-scheduling-cleanup
...
cleanup in volume scheduling
2020-07-02 04:17:38 -07:00
wawa0210
444cdc2944
fix pkg/controller/nodeipam staticcheck
2020-07-02 18:32:13 +08:00
Kubernetes Prow Robot
406671910a
Merge pull request #92415 from wawa0210/statefulset-staticcheck
...
fix pkg/controller/statefulset staticcheck
2020-07-01 23:12:58 -07:00
Yuiko Mori
97bca0ec59
Add Deprecated description to metrics scheduling_duration_seconds
2020-07-02 00:14:49 +00:00
Kubernetes Prow Robot
07586f67d9
Merge pull request #91311 from robscott/endpointslice-garbage-collection
...
Fixing race condition with EndpointSlice controller garbage collection
2020-07-01 16:22:00 -07:00
Rob Scott
3f593710a7
Ensuring EndpointSlice controller does not create EndpointSlices for Services that are being deleted.
...
This should ensure that the controller does not conflict with garbage collection.
2020-07-01 12:45:49 -07:00
Yecheng Fu
2cdc63aeaa
cleanup in volume scheduling pkg
...
- remove duplicated function claimToClaimKey
- cache Lister
- don't add indexer for PVCAssumeCache
2020-07-01 15:01:10 +08:00
Kubernetes Prow Robot
180af4240c
Merge pull request #90288 from aojea/cidrsets
...
Add metrics to the cidr_sets used by the nodeipam range allocator
2020-06-30 19:24:06 -07:00
wawa0210
d360be0f7c
fix pkg/controller/statefulset staticcheck
2020-06-26 00:00:41 +08:00
Yecheng Fu
22d874993c
build files
2020-06-23 22:18:33 +08:00
Yecheng Fu
4627b419b4
tests only
2020-06-23 22:18:33 +08:00
Yecheng Fu
ee4d7410be
Share pod volume binding cache via framework.CycleState
2020-06-23 22:18:33 +08:00
wawa0210
7d8aae51df
fix pkg/controller/deployment staticcheck
2020-06-23 19:32:20 +08:00
Kubernetes Prow Robot
00d6255f44
Merge pull request #91712 from KobayashiD27/structured-logging-in-event
...
Migrate log to klog.InfoS for staging/src/k8s.io/client-go
2020-06-22 23:53:40 -07:00
Kobayashi Daisuke
4ecbec75a6
Run update-bazel.sh
2020-06-22 10:49:15 +09:00
fatkun
eb9bca5f06
Fixed a bug that mistake use newObj as oldObj in endpoint slice update
2020-06-21 16:43:12 +08:00
Ali Farah
cac933934b
Delete unused interface
2020-06-20 20:12:46 +10:00
Kubernetes Prow Robot
9c3f648300
Merge pull request #91705 from mrkm4ntr/revert-assumed-in-unreserve
...
Revert assumed PVs and PVCs in unreserve extension point
2020-06-19 21:50:54 -07:00
Kubernetes Prow Robot
be31023a95
Merge pull request #87155 from kolorful/patch-3
...
Fix a comment in job_controller
2020-06-19 08:51:58 -07:00
Shintaro Murakami
79ab958996
Revert assumed PVs and PVCs in unreserve extension point
2020-06-19 17:39:42 +09:00
Kubernetes Prow Robot
694566d06d
Merge pull request #91915 from tnozicka/fix-ds-recreate
...
Fix DS expectations on recreate
2020-06-18 19:05:11 -07:00
Tomas Nozicka
5cf3f8b79c
Fix DS expectations on recreate
2020-06-17 09:22:17 +02:00
Kubernetes Prow Robot
a84784cbe5
Merge pull request #91730 from tnozicka/fix-sig-apps-owners
...
Add sig-apps-approvers and reviewers
2020-06-16 19:22:25 -07:00
Antonio Ojea
069707f75a
refactor and instrument range_allocator cidr_sets
...
refactor and add the following metrics to the cidr_sets used by the range
allocator:, under the subsystem: node_ipam_controller
cidrset_cidrs_allocations_total
cidrset_cidrs_releases_total
cidrset_usage_cidrs
cidrset_allocation_tries_per_request
2020-06-17 00:03:49 +02:00
Kubernetes Prow Robot
98f250f883
Merge pull request #91307 from yuga711/attach
...
CSI: Modify VolumeAttachment check to use Informer/Cache
2020-06-15 08:10:10 -07:00
Kobayashi Daisuke
4ae11dac2e
Replace StartLogging(klog.Infof) with StartStructuredLogging(0)
2020-06-15 17:48:35 +09:00
Yecheng Fu
814a6f2acd
remove FakeVolumeBinderConfig and test new statues and states
2020-06-12 10:00:19 +08:00
Yecheng Fu
c4138361e4
Fail fast in PreFilter phase and return UnschedulableAndUnresolvable if immediate PVCs are not bound
2020-06-12 10:00:19 +08:00
Jayasekhar Konduru
2a89577659
CSI: Modify VolumeAttachment check to use Informer/Cache
...
Change-Id: Ie70c8b6657c67eefbf13042f36d56ca84a2e42bb
2020-06-11 10:34:09 -07:00
Kubernetes Prow Robot
1f299e7b99
Merge pull request #91574 from cofyc/fix91436
...
share a common pod indexer among volume controllers
2020-06-10 22:42:56 -07:00
Lukasz Szaszkiewicz
50db32cf8c
GC doesn't have to create monitors in the constructor
2020-06-10 14:59:45 +02:00
Kubernetes Prow Robot
11fe6e815f
Merge pull request #91713 from liggitt/csr-v1-manager
...
CSR v1 - switch controllers
2020-06-09 14:49:30 -07:00
Kubernetes Prow Robot
a1c351cd28
Merge pull request #91576 from tahsinrahman/migrate-klog
...
Migrate to log calls to klog.InfoS and klog.ErroS for pkg/controller
2020-06-09 14:48:47 -07:00
Andrew Sy Kim
41dc075a85
move pkg/controller/cloud/node_lifecycle_controller.go to k8s.io/cloud-provider/controllers/nodelifecycle for easier external consumption
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Andrew Sy Kim
6d4a19b31c
move pkg/controller/cloud/node_controller.go to k8s.io/cloud-provider/controllers/node for easier external consumption
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Andrew Sy Kim
99d9dda5a7
move pkg/controller/route to k8s.io/cloud-provider/controllers/route for easier external consumption
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Andrew Sy Kim
d06cd7ee4f
move pkg/controller/service to k8s.io/cloud-provider/controllers/service for easier external consumption
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-06-08 17:34:01 -04:00
Jordan Liggitt
db4ca87d9d
Switch CSR approver/signer/cleaner controllers to v1
2020-06-05 18:45:34 -04:00
tahsinrahman
78318c7a26
Migrate to log calls to klog.InfoS and klog.ErroS for pkg/controller
2020-06-05 13:23:01 +08:00
KeZhang
884f94ad92
Do not swallow NotFound error for DeletePod in dsc.manage
2020-06-04 16:41:38 +08:00
Tomas Nozicka
1d3654fcbd
Add sig-apps-approvers and reviewers
2020-06-03 15:00:26 +02:00
Yecheng Fu
8422044f17
sharing a common pod pvc indexer among volume controllers
2020-06-03 14:51:21 +08:00
Yecheng Fu
eaf2f54bba
auto-generated files
2020-06-03 14:51:21 +08:00
Kubernetes Prow Robot
2bf8e27737
Merge pull request #91455 from cofyc/fix88229
...
Emit correct event when unbound delay binding claim is used by pod
2020-06-02 18:11:36 -07:00
Kubernetes Prow Robot
462742fcf6
Merge pull request #91443 from littleroad/clean_annotation
...
deployment: remove annotation for non-exist parameter 'podMap'
2020-06-02 18:11:24 -07:00
Kubernetes Prow Robot
99a56f6ace
Merge pull request #91604 from iobuf/review.job
...
[pkg/controller/job]: fix comment typo
2020-06-01 23:34:29 -07:00
Zhou Peng
bc9bff0d9e
[pkg/controller/job]: fix comment typo
...
Signed-off-by: Zhou Peng <p@ctriple.cn>
2020-05-30 23:09:10 +08:00
Yecheng Fu
32df4300ef
emit correct event when unbound delay binding claim is used by pod
2020-05-29 19:36:13 +08:00
Jordan Liggitt
7049149181
Generated files
2020-05-28 16:53:23 -04:00
Jordan Liggitt
94fd1d76ca
Switch issued check to inspect certificate length
2020-05-28 12:20:40 -04:00
Jordan Liggitt
d33a19cee7
Clean failed CSRs
2020-05-28 12:20:40 -04:00
Jordan Liggitt
57eddd5e04
Record Failed condition in signer controller
2020-05-28 12:20:40 -04:00
Lu Fengqi
0d04485a52
deployment: remove annotation for non-exist parameter 'podMap'
...
Since the parameter 'podMap' has been removed by commit 831a2d1129
("deployment: remove unused parameter 'podMap'"), the related annotation
also should be removed.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
2020-05-26 16:49:52 +08:00
Kubernetes Prow Robot
779f875243
Merge pull request #91180 from PengJi/fix_golint_failures
...
fix golint errors in pkg/controller/volume/events/event
2020-05-25 06:27:12 -07:00
Kubernetes Prow Robot
d94acda5ee
Merge pull request #91296 from cofyc/fix90962-cleanup-volumescheduling
...
volumescheduling: update comments to reflect latest change
2020-05-20 19:42:10 -07:00
Yecheng Fu
36d1365af5
update comments in volumescheduling pkg to reflect latest change
2020-05-20 22:23:08 +08:00
Yecheng Fu
f685af32e2
SchedulerVolumeBinder: don't modify assumed pod in AssumePodVolumes
2020-05-20 21:18:43 +08:00
Kubernetes Prow Robot
fdbb960354
Merge pull request #90934 from iobuf/cronjob
...
CronJob: cleanup legacy ScheduledJob vars,docs
2020-05-19 20:35:11 -07:00
pengji
69999a6d54
fix golint in pkg/controller/volume/events/event.go
2020-05-17 23:34:02 +08:00
Davanum Srinivas
07d88617e5
Run hack/update-vendor.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:33 -04:00
Davanum Srinivas
442a69c3bd
switch over k/k to use klog v2
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:27 -04:00
Kubernetes Prow Robot
8a9206c9b2
Merge pull request #91046 from wawa0210/remove-beta-os-label
...
kubelet no longer registers "beta.kubernetes.io/os" and "beta.kubernetes.io/arch" node labels to apiserver
2020-05-15 02:48:58 -07:00
wawa0210
54c0f8b677
Remove the 'beta' version of the node label (os and arch types)
2020-05-13 22:51:52 +08:00
Kubernetes Prow Robot
977aeab3e5
Merge pull request #90987 from andrewsykim/service-controller-fixup
...
service controller: clean up unit tests
2020-05-13 00:19:13 -07:00
Andrew Sy Kim
758c25de2f
service controller: store feature gate in local fields for better testability
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-05-12 13:40:54 -04:00
Kubernetes Prow Robot
70948498bc
Merge pull request #90769 from andrewsykim/service-controller-node-sync
...
service controller: only sync LB node pools when relevant fields change
2020-05-12 03:30:21 -07:00
Andrew Sy Kim
b3419e0ccf
service controller: remove duplicate unit test TestGetNodePredicate (Test_getNodeConditionPredicate already exists)
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-05-11 16:59:12 -04:00
Andrew Sy Kim
55292cf3b4
service controller: remove pkg/controller dep in unit tests
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-05-11 16:59:12 -04:00
Kubernetes Prow Robot
2b2cf8df30
Merge pull request #80700 from mrkm4ntr/add-error-check
...
Add missing error check
2020-05-11 00:37:51 -07:00
Zhou Peng
b33e202397
CronJob: cleanup legacy ScheduledJob vars,docs
...
Signed-off-by: Zhou Peng <p@ctriple.cn>
2020-05-10 00:45:21 +08:00
Kubernetes Prow Robot
ba3bf32300
Merge pull request #90662 from nilo19/cleanup/decouple-cloud-testutils
...
Remove the deps to testutils in pkg/controller/cloud.
2020-05-09 02:17:51 -07:00
Kubernetes Prow Robot
8d718b1ef5
Merge pull request #90731 from deads2k/csr-separate-signer-flags
...
refactor the CSR controller into distinct controllers to allow easy
2020-05-09 00:44:05 -07:00
t-qini
fd4f3c6323
Remove the deps of testutils in pkg/controller/cloud.
2020-05-09 10:23:14 +08:00
Andrew Sy Kim
80a8a8df1c
service controller: only sync LB node pools when relevant fields change
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-05-08 15:45:24 -04:00
cici37
32411016cc
Copy RemoveTaintOffNode logic to k8s.io/cloud-provider
2020-05-05 16:47:09 -07:00
Indeed
3117b6a084
fix case where node exists but shutdown.
2020-05-05 08:57:58 -07:00
Indeed
78ace24670
check node existence before shutdown status.
2020-05-05 08:57:58 -07:00
Indeed
84dfaace5d
add test about shutdown but non-existing node.
2020-05-05 08:51:21 -07:00
David Eads
83035890ad
refactor the CSR controller into distinct controllers to allow easy configuration of multiple signing keys
2020-05-05 10:18:04 -04:00
Kubernetes Prow Robot
e8d6d3768e
Merge pull request #90561 from cici37/util
...
Copy patchNodeStatus logic to cloud-provider
2020-05-04 13:46:43 -07:00
wccsama
c776e80109
using case name instead
2020-04-30 13:55:50 +08:00
cici37
b8bac0206d
Copy patchNodeStatus logic to cloud-provider
2020-04-29 15:51:55 -07:00
wccsama
7d45e12523
use sub test in gc_controller_test.go
2020-04-29 11:12:35 +08:00
Aaron Crickenberger
81881e4a12
prune .import-restrictions
...
specifically:
- cmd/kubeadm/.import-restrictions
- we don't need to explicitly allow k8s.io repos (external or published)
- rm pkg/controller/.import-restrictions
- pkg/client/unversioned was removed in 59042
- pkg/kubectl/.import-restrictions
- pkg/printers is no longer used
- pkg/api was masking all of the pkg/apis prefixes
- rm staging/src/k8s.io/code-generator/cmd/lister-gen/.import-restrictions
- noop / empty file
- test/e2e/framework/.import-restrictions
- we don't need to explicitly allow k8s.io repos (external or published)
2020-04-28 08:41:36 -07:00
Aaron Crickenberger
f306a0dbb4
convert .import-restrictions to yaml
...
yaml has comments, so we can explain why we have certain rules or
certain prefixes
for those files that weren't already commented yaml, I converted them to
yaml and took a best guess at comments based on the PRs that introduced
or updated them
2020-04-28 08:41:36 -07:00
Kubernetes Prow Robot
775feed217
Merge pull request #90018 from wojtek-t/deprecate_default_conversions
...
Deprecate default conversions
2020-04-23 10:23:10 -07:00
Kubernetes Prow Robot
fc08288bd9
Merge pull request #89609 from gavinfish/improve-discruption
...
Continue label is no more needed for countHealthyPods()
2020-04-22 17:02:12 -07:00
Kubernetes Prow Robot
85ee5fdd90
Merge pull request #87743 from u2takey/master
...
log pod event when node not ready
2020-04-21 17:25:52 -07:00
wojtekt
3758ab62d1
Avoid unnecessary GCE API calls for IP-alias calls
...
This is to avoid unnecessary GCE API calls done by getInstanceByName
helper, which is iterating over all zones to find in which zone the
VM exists.
ProviderID already contains all the information - it's in the form:
gce://<VM URL> (VM URL contains project, zone, VM name).
ProviderID is propagated by Kubelet on node registration and in case
of bugs backfilled by node-controller.
2020-04-20 20:47:11 +02:00
Kubernetes Prow Robot
c70e3e93bd
Merge pull request #89845 from yuga711/pvc-pv
...
Added events for failures in PV/PVC processing.
2020-04-18 02:51:35 -07:00
Jayasekhar Konduru
5a4f1be19d
Added events for failures in PV/PVC processing:
...
- PV has a dangling reference to a PVC
- PVC is trying to bind to a PV that already references a different PVC
Change-Id: Ic509d39808763149b02b4dd52347edb74a8803fd
2020-04-16 22:11:02 -07:00
Kubernetes Prow Robot
3a0417cc4b
Merge pull request #81185 from andrewsykim/service-controller-node-resync
...
service controller: add node event handlers for faster LB backend sync
2020-04-15 22:28:44 -07:00
Kubernetes Prow Robot
b86297c837
Merge pull request #89669 from yangkev/yangkev-make-tests-table-driven-patch
...
allow running cronjob controller unit tests individually by name
2020-04-15 13:14:58 -07:00
Kubernetes Prow Robot
ec79307b04
Merge pull request #90057 from ialidzhikov/fix/gcp-ccm
...
Fix Node initialization for GCP cloud provider
2020-04-15 11:36:24 -07:00
Kubernetes Prow Robot
28c442ee2f
Merge pull request #90126 from smarterclayton/features_default
...
Promote service exclusion and legacy node role to beta
2020-04-15 01:12:03 -07:00
Kubernetes Prow Robot
d0183703cb
Merge pull request #90059 from ahg-g/ahg-nodeinfo2
...
Cleanup obsolete NodeInfo methods
2020-04-14 17:32:04 -07:00
Kubernetes Prow Robot
344130a574
Merge pull request #89870 from gaurav1086/controller_nil_ptr_check
...
[Controller]: cidr nil ptr dereference
2020-04-14 14:02:17 -07:00
ialidzhikov
5c276a451d
Fix Node initialization for GCP cloud provider
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-04-14 21:01:26 +03:00
Clayton Coleman
d70b31e282
Remove the legacy load balancer exclusion annotation
...
alpha.service-controller.kubernetes.io/exclude-balancer is now
removed, deployers should use
node.kubernetes.io/exclude-from-external-load-balancers.
2020-04-13 21:01:11 -04:00
Kubernetes Prow Robot
b17ddac4df
Merge pull request #78944 from avorima/golint_fix_job
...
Fix golint errors in pkg/controller/job
2020-04-12 21:57:47 -07:00
Abdullah Gharaibeh
bed9b2f23b
Cleanup obsolete NodeInfo methods
2020-04-12 18:13:46 -04:00
wojtekt
f624314f91
Fix multiple conversion tests
2020-04-10 17:03:35 +02:00
leiiwang
c6c18c8fed
event pod event when node not ready
2020-04-07 18:24:00 +08:00
Gaurav Singh
4cbdb7bf97
[Controller]: cidr nil ptr dereference
2020-04-05 19:03:07 -04:00
Kubernetes Prow Robot
873fe1478a
Merge pull request #89207 from wccsama/service-controller-test
...
clean up the awkward pattern in service_controller_test
2020-04-03 02:09:46 -07:00
wccsama
8daf9ec2d4
clean up the pattern
2020-04-02 15:04:58 +08:00
Andrew Sy Kim
e2bc3a755f
move well-known kubelet cloud provider annotations to k8s.io/cloud-provider ( #88631 )
...
* move well-known kubelet cloud provider annotations to k8s.io/cloud-provider
Signed-off-by: andrewsykim <kim.andrewsy@gmail.com>
* cloud provider: rename AnnotationProvidedIPAddr to AnnotationAlphaProvidedIPAddr to indicate alpha status
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-03-31 23:01:27 -07:00
Kevin Yang
58a21399c5
wrap table driven tests in t.Run to allow running individual tests
...
This makes debugging individual test cases much easier. For example:
go test -p 1 ./pkg/controller/cronjob -run TestSyncOne_Status/prev_ran_but_done,_is_time,_past_deadline -v
2020-03-30 14:58:28 -07:00
drfish
251706ceb4
Continue label is no more needed for countHealthyPods()
2020-03-28 09:57:25 +08:00
Kubernetes Prow Robot
3cf4832d09
Merge pull request #89320 from andrewsykim/node-controller-fake-client
...
cloud node controller: refactor tests to not depend on controller/testutils
2020-03-25 16:34:25 -07:00
Rob Scott
94e5537fa0
Lengthening initial backoff time for EndpointSlice controller
...
The EndpointSlice controller has the potential to manage a large number of resources that are updated frequently. Without proper backoffs in place, there is potential for it to unnecessarily overload the API Server with requests. This makes two significant changes: Increasing the base backoff from 5ms to 1s and making all syncs triggered by EndpointSlice changes delayed by at least 1 second to enable batching.
2020-03-25 11:00:00 -07:00
shibataka000
dbd0d566ed
Fix bug about unintentional scale out during updating deployment.
...
This commit fix bug in calcPlainMetricReplicas function.
Same bug in GetResourceReplicas function was fixed in #85027 .
2020-03-25 15:47:40 +09:00
Andrew Sy Kim
f34b32f5d0
cloud node controller: refactor tests to not depend on controller/testutils
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-03-24 13:36:10 -04:00
Kubernetes Prow Robot
c441a1a7dc
Merge pull request #85027 from shibataka000/fix-bug-about-unintentional-scale-out-during-updating-deployment
...
Fix HPA bug about unintentional scale out during updating deployment.
2020-03-24 04:50:46 -07:00
Kubernetes Prow Robot
0641e0c6d8
Merge pull request #89059 from chenkaiyue/Reconcile-NoExecute-Taint
...
Reconcile NoExecute Taint
2020-03-23 00:14:45 -07:00
wccsama
3c22575e66
clean up the awkward pattern in service_controller_test
2020-03-18 13:50:36 +08:00
Kubernetes Prow Robot
1827fe444e
Merge pull request #87895 from alexzimmer96/68026-lint-pkg-controller-autoscaler
...
Fix Golint errors in pkg/controller/podautoscaler
2020-03-17 16:19:53 -07:00
kaiyuechen
b3637c9670
Reconcile NoExecute Taint
2020-03-13 11:44:12 +08:00
Andrew Sy Kim
366dd4af44
EndpointSlice and Endpoints should treat terminating pods the same
...
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
2020-03-11 13:03:18 -04:00
skilxn-go
6b8fc8dc5e
Move TaintBasedEvictions feature gates to GA
2020-03-09 10:49:00 +08:00
Jordan Liggitt
d8abacba40
client-go: update expansions callers
2020-03-06 16:50:41 -05:00
Kubernetes Prow Robot
f52cbea102
Merge pull request #88910 from liggitt/metadata-context
...
Metadata client: plumb context
2020-03-06 13:18:04 -08:00
Kubernetes Prow Robot
ef672c1c2d
Merge pull request #88678 from verult/slow-rxm-attach
...
Parallelize attach operations across different nodes for volumes that allow multi-attach
2020-03-06 13:17:21 -08:00
Kubernetes Prow Robot
179fe40d06
Merge pull request #88599 from julianvmodesto/scale-ctx-opts
...
Add context and options to scale client
2020-03-06 13:17:08 -08:00
Jordan Liggitt
04a72d5ef9
client-go metadata: update callers
2020-03-06 11:07:54 -05:00
Christian Huffman
c6fd25d100
Updated CSIDriver references
2020-03-06 08:21:26 -05:00
Cheng Xing
ef3d66b98b
Parallelize attach operations across different nodes for volumes that allow multi-attach
2020-03-05 22:22:05 -08:00
Mike Danese
76f8594378
more artisanal fixes
...
Most of these could have been refactored automatically but it wouldn't
have been uglier. The unsophisticated tooling left lots of unnecessary
struct -> pointer -> struct transitions.
2020-03-05 14:59:47 -08:00
Mike Danese
aaf855c1e6
deref all calls to metav1.NewDeleteOptions that are passed to clients.
...
This is gross but because NewDeleteOptions is used by various parts of
storage that still pass around pointers, the return type can't be
changed without significant refactoring within the apiserver. I think
this would be good to cleanup, but I want to minimize apiserver side
changes as much as possible in the client signature refactor.
2020-03-05 14:59:46 -08:00
Mike Danese
c58e69ec79
automated refactor
2020-03-05 14:59:46 -08:00
Kubernetes Prow Robot
0836b583f7
Merge pull request #85289 from serathius/remove-prometheus-controller-endpointslice
...
Remove prometheus references from pkg/controller/endpointslice
2020-03-05 02:58:37 -08:00
Kubernetes Prow Robot
4d19c6f2ad
Merge pull request #87537 from uthark/oatamanenko/apiversion
...
Fixes #87506 Add apiVersion to involvedObject
2020-03-04 02:31:47 -08:00
Kubernetes Prow Robot
9d0cbb7503
Merge pull request #88673 from jsafrane/block-feature-ga
...
Promote block volumes to GA
2020-03-03 12:17:12 -08:00
Kubernetes Prow Robot
62dc3ea6d1
Merge pull request #87368 from 928234269/fix_staticcheck01
...
fix staticcheck errors in pkg/controller/daemon.
2020-03-03 12:15:28 -08:00
Kubernetes Prow Robot
c86aec0564
Merge pull request #88745 from mborsz/slice3
...
Implement simple endpoint slice batching
2020-03-03 03:03:38 -08:00
Maciej Borsz
49b11b5431
Implement simple endpoint slice batching
2020-03-03 08:16:42 +01:00
Jan Safranek
3af671011a
Generated API
2020-03-02 22:21:42 +01:00
Kubernetes Prow Robot
62e993ce09
Merge pull request #88401 from gongguan/volume_binder
...
refactor volume binder
2020-03-02 09:16:44 -08:00
Julian V. Modesto
da3c3432d8
Add context and options to scale client
2020-03-02 00:03:26 -05:00
Marek Siarkowicz
4ea52da628
Remove prometheus references from pkg/controller/endpointslice
2020-02-29 15:10:23 +01:00
Kubernetes Prow Robot
03b7f272c8
Merge pull request #88246 from munnerz/csr-signername-controllers
...
Update CSR controllers & kubelet to respect signerName field
2020-02-28 23:38:39 -08:00
louisgong
c6b94e4606
refactor volume binder
2020-02-29 12:03:39 +08:00
Jan Safranek
2c1b743766
Promote block volume features to GA
2020-02-28 20:48:38 +01:00
Patrick Ohly
6329b17d2f
volume scheduler: introduce special string type
...
This makes it possible to search for the special strings more easily
(https://github.com/kubernetes/kubernetes/pull/88230#discussion_r382367043 ).
2020-02-28 10:09:19 +01:00
Patrick Ohly
6eb0b034ac
volume scheduler: move reason strings into volume code
...
The scheduler doesn't really need to know in detail which reasons
rendered a node unusable for a node. All it needs from the volume
binder is a list of reasons that it then can present to the user.
This seems a bit cleaner. But the main reason for the change is that
it simplifies the checking of CSI inline volumes and perhaps later
capacity checking. Both will lead to new failure reasons, which then
can be added without changing the interface.
2020-02-28 10:09:18 +01:00
James Munnelly
d5dae04898
certificates: update controllers to understand signerName field
...
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
2020-02-27 15:54:31 +00:00
James Munnelly
a983356caa
Add signerName field to CSR resource spec
...
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
2020-02-27 10:17:55 +00:00
Kubernetes Prow Robot
f3d38fcd4f
Merge pull request #88516 from boddumanohar/issues/87447
...
Use servicePatch methods from cloud-provider repo in service-controller
2020-02-26 19:39:44 -08:00
Kubernetes Prow Robot
55f2d91c8c
Merge pull request #88447 from taesunny/pkg/controller
...
Fix pkg/controller typos in some error messages, comments etc
2020-02-26 19:39:19 -08:00
Kubernetes Prow Robot
a726c9c9cb
Merge pull request #88435 from andrewsykim/ccm-clean-up
...
move well known cloud provider taints to k8s.io/cloud-provider/api
2020-02-26 13:33:41 -08:00
Kubernetes Prow Robot
d98975217a
Merge pull request #88525 from mborsz/bench3
...
Reorder conditions in FindMatchingVolume to avoid calling volumeutil.CheckNodeAffinity in trivial cases
2020-02-26 09:46:40 -08:00
taesun_lee
79680b5d9b
Fix pkg/controller typos in some error messages, comments etc
...
- applied review results by LuisSanchez
- Co-Authored-By: Luis Sanchez <sanchezl@redhat.com>
genernal -> general
iniital -> initial
initalObjects -> initialObjects
intentionaly -> intentionally
inforer -> informer
anotother -> another
triger -> trigger
mutli -> multi
Verifyies -> Verifies
valume -> volume
unexpect -> unexpected
unfulfiled -> unfulfilled
implenets -> implements
assignement -> assignment
expectataions -> expectations
nexpected -> unexpected
boundSatsified -> boundSatisfied
externel -> external
calcuates -> calculates
workes -> workers
unitialized -> uninitialized
afater -> after
Espected -> Expected
nodeMontiorGracePeriod -> NodeMonitorGracePeriod
estimateGrracefulTermination -> estimateGracefulTermination
secondrary -> secondary
ShouldRunDaemonPodOnUnscheduableNode -> ShouldRunDaemonPodOnUnschedulableNode
rrror -> error
expectatitons -> expectations
foud -> found
epackage -> package
succesfulJobs -> successfulJobs
namesapce -> namespace
ConfigMapResynce -> ConfigMapResync
2020-02-27 00:15:33 +09:00
Maciej Borsz
7d59ea8394
Reorder conditions in FindMatchingVolume to avoid checking NodeAffinity
...
in trivial cases.
2020-02-26 09:20:38 +01:00
Rob Scott
6a33727632
Adding AppProtocol to Service and Endpoints Ports
2020-02-25 17:42:34 -08:00
Manohar Reddy
7b2a0a4260
update bazel
2020-02-26 06:14:19 +05:30
Manohar Reddy
08473a4949
remote patch.go and patch_test.go files
2020-02-25 20:13:43 +05:30
Manohar Reddy
1c0a78a4fd
Use servicePatch methods from cloud-provider repo in service-controller
2020-02-25 16:28:37 +05:30
andrewsykim
8c633356df
move well known cloud provider taints to k8s.io/cloud-provider/api
...
Signed-off-by: andrewsykim <kim.andrewsy@gmail.com>
2020-02-23 19:54:59 -05:00
Andrew Sy Kim
8b490dea3a
service controller: add OnAdd and OnDelete node event handlers
...
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2020-02-20 12:56:47 -05:00
s-ito-ts
e6b9a7a309
Fix golint errors in pkg/controller/garbagecollector
2020-02-20 04:46:02 +00:00
Kubernetes Prow Robot
da9f47eadf
Merge pull request #88146 from gnufied/avoid-multiple-pv-delete
...
Prevent deletion of PVs that are already deleted
2020-02-19 12:40:48 -08:00
Kubernetes Prow Robot
3a24c32345
Merge pull request #87980 from tnqn/endpointslicetracker
...
EndpointSliceTracker should track updated resource version
2020-02-18 19:10:25 -08:00
Hemant Kumar
d9f7a1f311
Don't call delete for already deleted volumes
2020-02-18 15:59:47 -05:00
Nan Yu
89bb7d8454
Honor the RevisionHistoryLimit in StatefulSetSpec
...
The StatefulSet controller cleans up ControllerRevisions at the end of
the reconcile loop. If something goes wrong during reconcile, it bails
out without actually performing this step. This commit moves the cleanup
to a deferred function call to guarantee it will be executed.
Fixes issue: https://github.com/kubernetes/kubernetes/issues/85690
2020-02-18 10:42:38 -08:00
Kubernetes Prow Robot
1a0f923a65
Merge pull request #87712 from alena1108/jan30kubelet
...
Ineffassign fixes for pkg/controller and kubelet
2020-02-14 14:29:27 -08:00
Kubernetes Prow Robot
7fe64ccb82
Merge pull request #84984 from cofyc/fix84942
...
apps/StatefulSets: Garbage collector should be able to orphan ControllerRevisions too
2020-02-14 01:06:18 -08:00
David Zhu
81668cb887
Change migrated-to annoation key to follow best practices by removing beta and using 'pv' prefix
2020-02-12 10:33:08 -08:00
Quan Tian
c2d3e54551
EndpointSliceTracker should track updated resource version
...
During EndpointSlice reconcilation, EndpointSliceTracker is supposed to
track expected EndpointSlice resource versions so that external changes
to them can be detected. But it actually tracked the stale resource
version and resulted in every Service was handled twice as it always
received an EndpointSlice update with a different resource version but
was actually created/updated by itself during the first processing.
2020-02-10 21:47:07 +08:00
Yecheng Fu
bb2b50f3db
Garbage collector should orphan ControllerRevisions too
...
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
2020-02-10 20:58:28 +08:00
Mike Danese
bfc75d9a5c
manual fixes
2020-02-08 12:32:33 -05:00
Mike Danese
25651408ae
generated: run refactor
2020-02-08 12:30:21 -05:00
Mike Danese
2637772298
some manual fixes
2020-02-07 18:17:40 -08:00
Mike Danese
3aa59f7f30
generated: run refactor
2020-02-07 18:16:47 -08:00
Kubernetes Prow Robot
8215619ba4
Merge pull request #87642 from pohly/volume-binder-testing
...
volume binder testing
2020-02-07 05:56:39 -08:00
Alexander Zimmermann
e0b1e9206d
Clarified comments
2020-02-07 09:09:49 +01:00
Kubernetes Prow Robot
9c1e124b15
Merge pull request #87823 from tallclair/test-tokens
...
Ensure testing credentials are labeled as such
2020-02-06 17:47:29 -08:00
Kubernetes Prow Robot
04e28b3674
Merge pull request #87098 from davidz627/feature/migratedRollback
...
Add annotation updating for migration for PVs and PVCs
2020-02-06 17:45:32 -08:00
Alexander Zimmermann
a1c837022c
Fixed Golint errors in pkg/controller/podautoscaler
2020-02-06 17:16:38 +01:00
Tim Allclair
9d3670f358
Ensure testing credentials are labeled as such
2020-02-04 10:36:05 -08:00
Kubernetes Prow Robot
fa4bc10ef1
Merge pull request #86793 from prameshj/gce-finalizer
...
Attach a new finalizer in GCE ILB creation.
2020-01-30 21:20:32 -08:00
Alena Prokharchyk
6c3093f970
Ineffassign fixes for pkg/controller and kubelet
2020-01-30 14:35:10 -08:00
Kubernetes Prow Robot
7164152844
Merge pull request #87664 from liggitt/revert-parallel-volume
...
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
2020-01-29 22:12:01 -08:00
Jordan Liggitt
cd1059e3c4
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
...
This reverts commit 15c3f1b119
, reversing
changes made to 52d7614a8c
.
2020-01-29 14:58:32 -05:00
Mike Danese
968adfa993
cleanup req.Context() and ResponseWrapper
2020-01-29 08:50:45 -08:00
Mike Danese
d55d6175f8
refactor
2020-01-29 08:50:45 -08:00
Patrick Ohly
a3c434510d
volume binder: enable klog flags in test
...
When debugging the test runs it is useful to increase the log level:
go test -v ./pkg/controller/volume/scheduling -args -v 5
2020-01-29 10:37:39 +01:00
Patrick Ohly
5c8929d95e
volume binder: convert to sub-tests
...
Using t.Run() has some advantages:
- individual sub-tests can be selected with -run
- test failures are automatically associated with
the scenario, therefore the test name no longer
needs to be passed around
A "run" function is used primarily to avoid large indention changes,
but also because this can be used to extend the test with additional
parameters later on.
2020-01-29 10:37:27 +01:00
Kubernetes Prow Robot
f5a008746a
Merge pull request #83526 from eloyekunle/feat/gengo-reverse-import
...
import-boss reverse import
2020-01-28 18:50:13 -08:00
Pavithra Ramesh
1de2327afc
Attach a new finalizer in GCE ILB creation.
...
Add logic in service_controller to skip create/update
if finalizer from a different controller is found.
The newly added finalizer will be checked by other controllers
implementing ILB services to determine if a given service is
already being managed by service_controller.
Moved finalizer check into cloudprovider code.
added unit test to verify new finalizer.
Modified existing unit test to create a fake service so that
attach/remove finalizer step can be tested.
2020-01-28 15:02:19 -08:00
Oleg Atamanenko
427f0f9463
Add apiVersion to involvedObject
2020-01-28 09:24:08 -08:00
Elijah Oyekunle
07e3cca6d0
update existing import-restrictions files
2020-01-28 10:51:45 +01:00
David Zhu
b7817a2981
Add annotation annealing for migration for PVs and PVCs during syncVolume and syncClaim. This allows external-provisioners to pick up and delete volumes when they have been rolled up from previous kubernetes versions.
2020-01-27 16:14:53 -08:00
Cheng Xing
c6a03fa5be
Parallelize attach operations across different nodes for volumes that allow multi-attach
2020-01-27 15:02:25 -08:00
Kubernetes Prow Robot
dc090f80d1
Merge pull request #87406 from haosdent/remove-algo
...
Remove `scheduler/algorithm/priorities` in import-restrictions
2020-01-23 11:34:24 -08:00
Kubernetes Prow Robot
c5d981583a
Merge pull request #87308 from KobayashiD27/fix-staticcheck
...
Fix staticcheck in pkg/controller/podgc
2020-01-23 11:34:11 -08:00
David Eads
5c2d2c5ef1
rename dynamic cert loading to be more accurate
2020-01-22 15:00:46 -05:00
David Eads
6ccfc3aecf
add dynamic reloading for CSR signing controllers
2020-01-22 15:00:46 -05:00
Kubernetes Prow Robot
e4926e2d70
Merge pull request #85421 from terrytangyuan/patch-1
...
Fix grammar: have -> has
2020-01-22 08:40:58 -08:00
Haosdent Huang
b09e35257a
Remove scheduler/algorithm/priorities
in import-restrictions
2020-01-22 11:54:28 +08:00
yiyang5055
53aff819e0
fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion
2020-01-20 09:10:46 +00:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon.
...
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-19 21:09:05 +08:00
Kubernetes Prow Robot
073da1588a
Merge pull request #86801 from likakuli/fix_syncsts_orphanrevision
...
fix a bug that orphan revision cannot be adopted and statefulset cannot be synced
2020-01-19 00:07:35 -08:00
Kobayashi Daisuke
ed1381e35f
Fix staticcheck in pkg/controller/podgc
2020-01-17 15:42:38 +09:00
Paul Morie
afaea605f4
Remove Brad Childs from OWNERS files
2020-01-16 15:21:34 -05:00
Jordan Liggitt
054e3846fc
Use v1 subjectaccessreview API in controller-manager CSR approver
2020-01-13 15:55:52 -05:00
Kewei Ma
34fce9faee
Fix a comment in job_controller
2020-01-13 10:09:06 -06:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo
...
Fix a comment typo in legacyNodeRoleBehaviorFeature
2020-01-10 17:17:38 -08:00
Kubernetes Prow Robot
240782c7f7
Merge pull request #87043 from zjs/topic/propagate-providerid-errors
...
Ensure a provider ID is set on a node if expected
2020-01-10 14:33:50 -08:00
Zach Shepherd
2b554079af
Ensure a provider ID is set on a node if expected
...
A transient issue might occur that causes an error to be returned by
InstanceID(). When this is ignored, the external cloud provider taint
will be removed and neither AddCloudNode() nor UpdateCloudNode() will
try to set a provider ID in the future.
By returning the error we can ensure that the external cloud provider
taint is not removed prematurely, allowing the operation to be retried
(until the provider ID can be set).
Preserve support for external cloud providers that do not use IDs by
continuing if a NotImplemented error is returned, making a distinction
between lack of support for provider IDs and an actual error.
Introduce pair of unit tests that show a provider ID will eventually
be set if an error is returned, unless that error is a NotImplemented,
in which case the external cloud provider taint will be removed.
2020-01-10 11:00:54 -08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags
...
feat: remove several feature gates in 1.18
2020-01-09 13:28:50 -08:00
Kubernetes Prow Robot
1e0bfae887
Merge pull request #86871 from gosoon/master
...
fix log message error in nodelifecycle
2020-01-08 02:58:33 -08:00
likakuli
10864d3366
fix a bug that orphan revision cannot be adopted and sts cannot be synced
2020-01-08 17:56:41 +08:00
Kubernetes Prow Robot
f3df7a2fdb
Merge pull request #86727 from mattjmcnaughton/mattjmcnaughton/remove-recorder-PastEventf
...
Remove `recorder.PastEventf` method
2020-01-07 04:38:49 -08:00
tianfeiyu
fddf50cf88
fix log message error in nodelifecycle
2020-01-06 21:02:08 +08:00
Abdullah Gharaibeh
041e5b5560
addressed comments
2020-01-04 01:14:24 -05:00
Abdullah Gharaibeh
7d604c318c
Break DS controller on scheduler predicates and predicate errors
2020-01-03 13:05:07 -05:00
mattjmcnaughton
92940fa80d
Remove recorder.PastEventf
method
...
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316 )
shows, this `timestamp` was never actually used.
In other words, `PastEventf` is identical to `Eventf`.
We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.
Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
2019-12-30 12:00:23 -05:00
Kubernetes Prow Robot
d4ba10ec80
Merge pull request #85703 from robscott/endpointslice-controller-race-fix
...
Fixing Potential Race Condition in EndpointSlice Controller.
2019-12-26 17:59:52 -08:00
Rob Scott
c75787bb77
Fixing Potential Race Condition in EndpointSlice Controller.
...
This adds a new EndpointSlice tracker to keep track of the expected resource versions of EndpointSlices associated with each Service managed by the EndpointSlice controller. This should prevent a potential race where a syncService call could happen with an incomplete view of EndpointSlices if additions or deletions hadn't fully propagated to the cache yet. Additionally, this ensures that external changes to EndpointSlices will be handled by the EndpointSlice controller.
2019-12-26 12:15:38 -08:00
danielqsj
5bc0e26c19
unify alias of api errors under pkg and staging
2019-12-26 16:42:28 +08:00
Alvaro Aleman
18fa7bdb6e
Cloud node controller: Only call once into cloud provider
2019-12-17 20:03:27 +01:00
Kubernetes Prow Robot
42fe74cd2c
Merge pull request #86142 from raz-bn/add-complete-event
...
Adding new job completed event
2019-12-16 23:43:58 -08:00
raz-bn
0224c48120
Job completed event added
2019-12-16 21:41:15 +00:00
Kubernetes Prow Robot
69410eca4b
Merge pull request #86256 from liggitt/testapi
...
Remove use of testapi package
2019-12-13 12:55:50 -08:00
Jordan Liggitt
5d5b444c4d
Remove use of testapi codecs, selflink, resourcepath functions
2019-12-13 11:56:29 -05:00
Kubernetes Prow Robot
f67d3b1a7d
Merge pull request #86229 from ahg-g/ahg-ds
...
Remove daemonset controller's dependency on scheduler metadata
2019-12-13 00:26:54 -08:00
Kubernetes Prow Robot
ae717afc0d
Merge pull request #86140 from yutedz/rs-rm-timeout
...
Do not swallow timeout in manageReplicas
2019-12-12 18:33:07 -08:00
Abdullah Gharaibeh
288609ecf5
remove ds dependeny on scheduler metadata
2019-12-12 19:04:36 -05:00
Ted Yu
9cff345770
Do not swallow timeout in manageReplicas
2019-12-12 11:27:36 -08:00
draveness
dcea6ff065
fix: remove TaintNodesByCondition feature gate in daemon controller
2019-12-12 18:17:14 +08:00
Kubernetes Prow Robot
928817a26a
Merge pull request #74525 from gliush/configurable-hpa-limits
...
Configurable HorizontalPodAutoscaler
2019-12-11 03:18:05 -08:00
Arjun Naik
8ab226263a
Adds tests
...
Signed-off-by: Arjun Naik <arjun@arjunnaik.in>
2019-12-10 18:09:20 +01:00
Ivan Glushkov
27ffe439b6
Adds the algorithm implementation for the Configurable HPA
2019-12-10 20:37:33 +04:00
Kubernetes Prow Robot
fcc35b0468
Merge pull request #85899 from gongguan/slim_down_lister
...
slim down some lister expansions
2019-12-09 07:20:17 -08:00
louisgong
7f5076d8ee
slim down some lister expansions
2019-12-07 08:27:06 +08:00
Nan Yu
1fb0dd4ec5
Rename PodDisruptionsAllowed to DisruptionsAllowed in type PodDisruptionBudgetStatus
2019-12-03 14:26:35 -08:00
Kubernetes Prow Robot
41757d673e
Merge pull request #85521 from gaorong/check-return-value
...
check service status value returned by EnsureLoadBalancer
2019-11-25 22:51:10 -08:00
Rob Scott
4229b99203
Deep copying EndpointSlices in reconciler before modifying them.
2019-11-23 20:57:50 -08:00
Rong Gao
99603e105a
check service status value returned by EnsureLoadBalancer
...
when service status returned by EnsureLoadBalancer is nil, return the
function directly to avoid NPE
2019-11-22 09:19:06 +08:00
Benjamin Elder
cf510ac285
fix multiple node cidr masks in providerless build
2019-11-19 09:47:45 -08:00
Yuan Tang
dd308ca576
Fix grammar: have -> has
2019-11-18 11:17:58 -05:00
Kubernetes Prow Robot
c3f8d700ac
Merge pull request #85367 from aramase/node-cidr-followup
...
[kube controller manager] add comments for compatibility
2019-11-15 19:09:54 -08:00
Kubernetes Prow Robot
9c26a752a9
Merge pull request #85231 from davidz627/flags
...
Flip CSIMigration and CSIMigrationGCE to Beta
2019-11-15 17:57:41 -08:00
Kubernetes Prow Robot
9859e73433
Merge pull request #85361 from liggitt/endpoint-label
...
Fix label mutation in endpoints controller
2019-11-15 16:17:49 -08:00
Anish Ramasekar
128f33b26e
add comments for compatibility
2019-11-15 15:38:06 -08:00
Jordan Liggitt
08b5c809d2
Fix label mutation in endpoints controller
2019-11-15 16:24:10 -05:00
Rob Scott
7085d692b7
Reverting managed-by-setup annotation
...
This ended up causing far more problems than it was worth, especially
given that it just attempted to provide backwards compatibility with
the alpha release.
2019-11-15 11:50:58 -08:00
David Zhu
41c65f4740
Jump out of spec translation early if the spec is not migratable. Unit tests work after all!
2019-11-15 11:23:32 -08:00
David Zhu
6e716af89e
Add CSINodes to AttachDetachControllerRecovery test
2019-11-15 11:23:32 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree)
...
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
2019-11-15 08:29:12 -07:00
Kubernetes Prow Robot
ded6ee953c
Merge pull request #79993 from aramase/controller-manager-multiple-cidr
...
Allow multiple node cidr masks in kube-controller-manager
2019-11-14 23:23:42 -08:00
Kubernetes Prow Robot
372ebd24f5
Merge pull request #83098 from ddebroy/disable-intree
...
CSI Migration phase 2: disable probing of in-tree plugins
2019-11-14 20:51:42 -08:00
Anish Ramasekar
796faba4ac
Allow multiple node cidr masks in cm
...
update tests
add comment
amend var name
update comment
add check for empty slice
fix tests
fix mask size in test
review feedback
add ipv4 and ipv6 flag for mask sizes
add to violation exception list
remove import alias
run update-openapi-spec
review feedback
run update-bazel
review feedback
review feedback
2019-11-14 20:04:31 -08:00
YAMAMOTO Takashi
361cd7212e
Fix a comment typo in legacyNodeRoleBehaviorFeature
2019-11-15 11:30:34 +09:00
Deep Debroy
129f15328b
Disable in-tree plugins migrated to CSI
...
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-11-14 17:28:21 -08:00
Kubernetes Prow Robot
ba9f7419f9
Merge pull request #84732 from khenidak/fix-disable-dualstack
...
Fix a CM panic when ipam tries to lock an out of range pre existing cidr
2019-11-14 11:19:35 -08:00
Kubernetes Prow Robot
5e30d32d2c
Merge pull request #83394 from bertinatto/convert_pv_no_affinity
...
Convert existing PVs to use volume topology in VolumeBinderPredicate
2019-11-13 21:45:56 -08:00
Kubernetes Prow Robot
565566f4b2
Merge pull request #85153 from codenrhoden/mount-no-exec-int
...
Retire mount.Exec for k8s.io/utils/exec
2019-11-13 17:28:32 -08:00
Kubernetes Prow Robot
072cf5bd58
Merge pull request #85023 from MrHohn/svc-lb-ga
...
Promote service load balancer finalizer to GA
2019-11-13 17:28:21 -08:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta
2019-11-13 14:20:19 -08:00
Travis Rhoden
367f879131
Retire mount.Exec for k8s.io/utils/exec
...
This patch removes mount.Exec entirely and instead uses the common
utility from k8s.io/utils/exec.
The fake exec implementation found in k8s.io/utils/exec differs a bit
than mount.Exec, with the ability to pre-script expected calls to
Command.CombinedOutput(), so tests that previously relied on a callback
mechanism to produce specific output have been updated to use that
mechanism.
2019-11-13 14:09:57 -07:00
Fabio Bertinatto
bbfc6ef450
Convert volume binder to use CSINode GA
2019-11-13 14:01:01 +01:00
Fabio Bertinatto
7cba40fb09
Use CSI translation lib in VolumeBinderPredicate
2019-11-13 14:01:01 +01:00
Zihong Zheng
0833e8840e
Amend service controller code/test regarding finalizer GA
2019-11-12 15:04:07 -08:00
Rob Scott
0fa9981e01
Splitting IP address type into IPv4 and IPv6 for EndpointSlices
2019-11-12 09:03:53 -08:00
Kubernetes Prow Robot
5dc87d2919
Merge pull request #83965 from robscott/endpointslice-managed-by
...
Adding new label to indicate what is managing an EndpointSlice
2019-11-12 03:08:07 -08:00
Kubernetes Prow Robot
7d1f9b440e
Merge pull request #83815 from howardjohn/appprotocol
...
Add appProtocol to EndpointSlice.Port
2019-11-11 17:48:06 -08:00
Kubernetes Prow Robot
01e014c7d6
Merge pull request #85012 from alculquicondor/feat/predicate_factory
...
Add MetadataProducerFactory for predicates
2019-11-11 14:46:36 -08:00
Kubernetes Prow Robot
709a0c4f7b
Merge pull request #85067 from takanattie/fix_typo
...
Fix a typo in pkg/controller
2019-11-11 12:56:48 -08:00
Aldo Culquicondor
6a98c93f3c
Add MetadataProducerFactory for predicates
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2019-11-11 11:27:44 -05:00
Kubernetes Prow Robot
b2fb0f77ad
Merge pull request #82572 from tnozicka/fix-rs-expectations
...
Fix RS expectations for recreate case
2019-11-11 05:49:42 -08:00
Tomas Nozicka
ce52643f12
Update Bazel
2019-11-11 09:11:43 +01:00
Tomas Nozicka
6754b93f6b
Fix RS informer handlers and handling expectations on delete
2019-11-11 09:11:43 +01:00
Takashi Natsume
e5ad39fbe0
Fix a typo in pkg/controller
2019-11-10 11:24:10 +00:00
shibataka000
b7122770f8
Fix bug about unintentional scale out during updating deployment.
...
During rolling update with maxSurge=1 and maxUnavailable=0,
len(metrics) is greater than currentReplcas
and it may cause unintentional scale out.
2019-11-09 06:24:31 +00:00
Rob Scott
6b8b2ff975
Adding new label to indicate what is managing an EndpointSlice
...
This adds a new Label to EndpointSlices that will ensure that multiple
controllers or entities can manage subsets of EndpointSlices. This
label provides a way to indicate the controller or entity responsible
for managing an EndpointSlice.
To provide a seamless upgrade from the alpha release of EndpointSlices
that did not support this label, a temporary annotation has been added
on Services to indicate that this label has been initially set on
EndpointSlices. That annotation will be set automatically by the
EndpointSlice controller with this commit once appropriate Labels have
been added on the corresponding EndpointSlices.
2019-11-08 15:34:44 -08:00
Kubernetes Prow Robot
9cf309ed59
Merge pull request #82049 from andrewsykim/ga-node-instance-type-label
...
Promote Node Instance Type Label to GA
2019-11-08 13:47:58 -08:00
Khaled Henidak(Kal)
2de6b2e52c
unit tests
2019-11-08 18:29:08 +00:00
Khaled Henidak(Kal)
e07402f7dc
fix a panic when ipam tries to allocate an out of range pre-existing cidr
2019-11-08 18:29:08 +00:00
John Howard
d00794ca60
Add appProtocol to EndpointSlice.Port
2019-11-08 09:22:50 -08:00
Kubernetes Prow Robot
f0184f0921
Merge pull request #84933 from krzysied/node_controller_v_level
...
Bumping up log level for not updated node
2019-11-08 09:00:40 -08:00
Kubernetes Prow Robot
ae15368355
Merge pull request #84351 from wojtek-t/promote_node_lease_to_GA
...
Promote node lease to GA
2019-11-08 09:00:15 -08:00
Andrew Sy Kim
55e40b8dc1
cloud node controller: apply stable instance-type label with backfill to existing nodes
...
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-11-08 10:50:52 -05:00
Kubernetes Prow Robot
d366d2eaa3
Merge pull request #84896 from RainbowMango/pr_migrate_custom_collector_scheduler
...
Migrate custom collector for kube-scheduler
2019-11-08 01:04:14 -08:00
Kubernetes Prow Robot
3ee195f0e9
Merge pull request #81431 from andrewsykim/ga-node-topology
...
Promote Node Zone/Region Topology Labels to GA
2019-11-07 22:00:20 -08:00
Andrew Sy Kim
07229d6c51
pkg/util/node: update GetZoneKey to check both beta and GA labels
...
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-11-07 21:22:04 -05:00
Andrew Sy Kim
3032c81187
node controller: set both deprecated Beta and GA labels for Zone/Region topology
...
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-11-07 20:08:11 -05:00
Rob Scott
0c7548f020
Setting Hostname from Pods on EndpointSlice to match Endpoints behavior.
...
This was an oversight in the initial EndpointSlice release. This update
will ensure that Endpoints and EndpointSlices use the same logic to set
the Hostname attribute.
2019-11-07 13:22:54 -08:00
Kubernetes Prow Robot
f7c3fa8324
Merge pull request #84860 from wojtek-t/remove_conversion_funcs_4
...
Eliminate couple default conversions
2019-11-07 09:05:30 -08:00
Kubernetes Prow Robot
06a7e9a1f3
Merge pull request #84763 from hwdef/fix-staticcheck6
...
pkg/controller: fix staticcheck warning
2019-11-07 09:05:17 -08:00
Krzysztof Siedlecki
4e63b9a032
bumping up log level for not updated node
2019-11-07 17:59:26 +01:00
Kubernetes Prow Robot
8841624982
Merge pull request #81167 from krzysied/node_controller_list
...
Avoid listing pods in NodeLifecycleController
2019-11-07 07:53:10 -08:00
Kubernetes Prow Robot
1183771545
Merge pull request #84748 from hvaara/fix-golint-controller-volume-persistentvolume-options
...
Fix golint issues in pkg/controller/volume/persistentvolume/options
2019-11-07 04:35:53 -08:00
Kubernetes Prow Robot
ca836256c4
Merge pull request #84573 from robscott/endpointslice-publishnotready
...
Updating EndpointSlices to use PublishNotReadyAddresses from Services.
2019-11-07 04:35:10 -08:00
Krzysztof Siedlecki
9406e5bf2a
adding pods lister
2019-11-07 12:02:21 +01:00
hwdef
38256df718
pkg/controller: fix staticcheck warning
2019-11-07 16:46:47 +08:00
Kubernetes Prow Robot
24fb2c1afd
Merge pull request #84280 from gongguan/service_selector_cache
...
add service selector cache in endpoint and endpointSlice controller
2019-11-06 18:47:00 -08:00
RainbowMango
09dc221d7b
Deal with auto-generated files.
...
Update bazel by hack/update-bazel.sh
2019-11-07 10:30:12 +08:00
RainbowMango
9efabe8124
Migrate custom collector to stablility framework
2019-11-07 10:26:27 +08:00
Kubernetes Prow Robot
46472773cb
Merge pull request #84836 from yuxiaobo96/k8s-checks
...
Correct spelling mistakes
2019-11-06 12:21:11 -08:00
Kubernetes Prow Robot
b09b962d96
Merge pull request #84746 from Huang-Wei/move-sched-constrants
...
Move out const strings in pkg/scheduler/api/well_known_labels.go
2019-11-06 12:20:06 -08:00
Rob Scott
ff3cbdb0ad
Updating EndpointSlices to use PublishNotReadyAddresses from Services.
...
The Service spec includes a PublishNotReadyAddresses field which has
been used by Endpoints to report all matching resources ready. This may
or may not have been the initial purpose of the field, but given the
desire to provide backwards compatibility with the Endpoints API here,
it seems to make sense to continue to provide the same functionality.
2019-11-06 09:11:31 -08:00
wojtekt
ccded14941
Eliminate some default conversions
2019-11-06 14:08:15 +01:00
yuxiaobo
81e9f21f83
Correct spelling mistakes
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-11-06 20:25:19 +08:00
Wei Huang
019d7497a5
bazel files
2019-11-05 20:57:21 -08:00
Wei Huang
dd74205bcf
Move out const strings in pkg/scheduler/api/well_known_labels.go
2019-11-05 20:56:21 -08:00
louisgong
2133f9e9ff
add service selector cache in endpoint controller and endpointSlice controller
2019-11-06 10:55:26 +08:00
Kubernetes Prow Robot
0c32aa8910
Merge pull request #83257 from robscott/endpointslice-metrics
...
Adding initial EndpointSlice metrics.
2019-11-05 15:30:31 -08:00
Kubernetes Prow Robot
268e331c70
Merge pull request #84527 from robscott/endpoint-util-owners
...
Adding owners file for Endpoint controller utils
2019-11-05 06:28:39 -08:00
wojtekt
ffad401b4e
Promote NodeLease feature to GA
2019-11-05 09:01:12 +01:00
Kubernetes Prow Robot
aaa5707896
Merge pull request #84677 from mikedanese/cfssl
...
remove cfssl dependencies
2019-11-04 15:28:53 -08:00
Kubernetes Prow Robot
1d1385af91
Merge pull request #83474 from msau42/topology-ga
...
CSI Topology ga
2019-11-04 15:28:27 -08:00
Roy Hvaara
dffcf7c8cd
Fix golint issues in pkg/controller/volume/persistentvolume/options
2019-11-04 21:45:21 +01:00
Mike Danese
6a004d0c18
support URI SANs in local signer
2019-11-04 10:56:06 -08:00
Mike Danese
fe51712288
refactor into seperate authority package
2019-11-04 10:56:06 -08:00
Mike Danese
4bd2c3998f
don't use cfssl in signer
2019-11-04 10:56:06 -08:00
Kubernetes Prow Robot
6a19261e96
Merge pull request #84123 from smarterclayton/terminating_cause
...
Handle namespace deletion more gracefully in built-in controllers
2019-11-04 07:55:41 -08:00
Kubernetes Prow Robot
5e33f3db5f
Merge pull request #84445 from krzysied/node_controller_retry_fix
...
NodeLifecycleController - MarkPodsNotReady retry fix
2019-11-03 20:15:40 -08:00
Kubernetes Prow Robot
b55440dcf8
Merge pull request #84637 from zhipengzuo/master
...
fix log and note :cidr mask size must be <= node mask
2019-11-03 18:53:40 -08:00
Kubernetes Prow Robot
d8ab3f26e7
Merge pull request #84323 from draveness/feature/remove-suspended-daemon-pods
...
feat: remove suspendedDaemonPods from daemon controller
2019-11-02 23:41:40 -07:00
Kubernetes Prow Robot
6e0c915f43
Merge pull request #84060 from yutedz/gc-ref-diff
...
Traverse OwnerReference maps more efficiently
2019-11-01 18:07:41 -07:00
zhipengzuo
1e0b019062
fix log and annotation :cidr mask size must be <= node mask
2019-11-01 17:26:23 +08:00
Krzysztof Siedlecki
3a82f50b2e
adding test for retrying MarkPodsNotReady
2019-10-31 16:56:54 +01:00
Krzysztof Siedlecki
9759a982c5
MarkPodsNotReady retry fix
2019-10-31 16:56:54 +01:00
Ryan Phillips
f87da3fdfa
fixes for tests to pass with FIPS compiler
...
* use P256 ECDSA key since P224 is not supported
* regen test certs to be 2048bits
2019-10-30 10:10:11 -05:00
Rob Scott
40423cf18e
Adding owners file for Endpoint controller utils
2019-10-29 11:01:49 -07:00
Andrew Sy Kim
897b8d7476
improve error handling in cloud node controller
...
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-10-28 20:23:12 -04:00
Michelle Au
fb6dfeb718
Convert attach-detach controller to use v1.CSINode
2019-10-28 13:41:13 -07:00
wojtekt
ce499ac286
Migrate components to EndpointsLeases leader election lock
2019-10-28 09:09:03 +01:00
Kubernetes Prow Robot
d379ab2697
Merge pull request #84288 from wojtek-t/cleanup_conversions_registrations
...
Cleanup conversions registrations
2019-10-25 22:53:22 -07:00
draveness
dc437a7890
feat: remove suspendedDaemonPods from daemon controller
2019-10-25 09:16:48 +08:00
wojtekt
7b6bcdf780
Autogenerated code
2019-10-24 20:21:00 +02:00
Kubernetes Prow Robot
2c4cba8aa0
Merge pull request #82365 from jkaniuk/pod-gc
...
Pod GC controller - use node lister
2019-10-24 03:13:06 -07:00
Rob Scott
724b142f07
Adding initial EndpointSlice metrics.
2019-10-23 17:33:17 -07:00
Kubernetes Prow Robot
ed5a3847a2
Merge pull request #83856 from mrbobbytables/update-autoscaling-owners
...
Prune inactive owners from autoscaling related OWNERS files.
2019-10-23 15:53:34 -07:00
Kubernetes Prow Robot
4f63f61c36
Merge pull request #84193 from ahg-g/ahg-list
...
Separate scheduler listers into their own package
2019-10-23 12:51:30 -07:00
Kubernetes Prow Robot
7dc298af42
Merge pull request #82795 from draveness/feature/remove-schedule-daemonset-pods
...
feat(scheduler): graduate ScheduleDaemonSetPods to GA
2019-10-23 12:49:12 -07:00
Kubernetes Prow Robot
65fa4c979a
Merge pull request #82152 from misterikkit/disruption
...
Fix retry logic in DisruptionController
2019-10-23 12:48:58 -07:00
Jacek Kaniuk
39883f08bf
Pod GC controller - use node lister
2019-10-23 16:54:54 +02:00
draveness
35d772e354
feat: graduate ScheduleDaemonSetPods to GA
2019-10-23 21:34:47 +08:00