Commit Graph

466 Commits

Author SHA1 Message Date
Fabio Bertinatto
eb2adaa32f Fix panic in Kubelet
Currently, the Kubelet panics when it's started with the
`enable-controller-attach-detach=false` option set and a
volume is attached to a node.

This patch adds a check that prevents the Kubelet from trying to attach
or detach CSI volumes and report a proper error warning the user that this
use case is not supported.
2022-01-31 17:29:25 -03:00
Kubernetes Prow Robot
c175418281 Merge pull request #107065 from saikat-royc/fix-node-stage-path
change node staging path for csi driver to PV agnostic
2022-01-21 01:31:58 -08:00
Saikat Roychowdhury
80e0501e89 change staging path for csi driver to pv agnostic 2022-01-20 22:59:29 +00:00
Kubernetes Prow Robot
42436c877e Merge pull request #107462 from dims/next-step-in-csi-migration-for-openstack-take-2
Next step in CSI migration for openstack
2022-01-12 19:57:07 -08:00
Kubernetes Prow Robot
e22ec17057 Merge pull request #99441 from CKchen0726/csi-client
migrate volume/csi/csi-client.go logs to structured logging
2022-01-12 11:52:13 -08:00
Davanum Srinivas
7fd97433f0 Next step in CSI migration for openstack
delete/modify tests that use intree cinder as well.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 22:07:44 -05:00
Kubernetes Prow Robot
31898fc504 Merge pull request #101856 from prateekpandey14/fix-staticcheck
fix static check of importing the same package multiple times
2022-01-05 14:55:47 -08:00
Jan Safranek
516633d67f Remove AttachID matching from Detach
Detach() always gets CSI volume unique ID and never attachment ID. Related
code has been removed from Kubernetes in
129f15328b.
2021-12-14 15:37:17 +01:00
prateekpandey14
f9cf14f3f6 fix static check of importing the same package multiple times
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
2021-12-14 11:06:44 +05:30
Kubernetes Prow Robot
8174b0923c Merge pull request #105127 from astraw99/fix-dup-kubeClient
Fix duplicate CSI kube client
2021-12-07 17:25:30 -08:00
Kubernetes Prow Robot
8d9e424f73 Merge pull request #103447 from trierra/csi-translation-portworx
Csi translation portworx
2021-11-16 17:43:53 -08:00
Oksana Naumov
3af11fc12d Add support for Portworx to csi-translation lib
Signed-off-by: Oksana Naumov <trierra.dev@gmail.com>
2021-11-16 13:26:09 -08:00
Kubernetes Prow Robot
f151a40d8d Merge pull request #106154 from gnufied/recover-expansion-failure-123
Recover expansion failure
2021-11-16 13:21:34 -08:00
Hemant Kumar
1ddd598d31 Implement controller and kubelet changes for recovery from resize
failures
2021-11-16 11:06:46 -05:00
Kubernetes Prow Robot
66c342ba63 Merge pull request #95361 from humblec/rbd-migration
RBD in-tree plugin migration to CSI driver using migration translation lib
2021-11-15 19:53:25 -08:00
Humble Chirammal
7c40eb9ae0 Add support for rbd plugin to csi-translation-lib
In support of csi-migration proposal here:
https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md

Will help with migration of in-tree RBD plugin ( kubernetes.io/rbd)
to RBD CSI driver ( rbd.csi.ceph.com ).

Fixes https://github.com/kubernetes/enhancements/issues/2923

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-11-15 23:46:29 +05:30
Neha Lohia
fa1b6765d5 move pkg/util/node to component-helpers/node/util (#105347)
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
2021-11-12 07:52:27 -08:00
Kubernetes Prow Robot
7b9f4f18fe Merge pull request #105135 from astraw99/fix-nil-mergeMap
Fix nil check in map merge
2021-11-12 02:26:27 -08:00
astraw99
9fe2c30609 fix nil merge map 2021-11-11 10:56:55 +08:00
Kubernetes Prow Robot
6d9008b1b0 Merge pull request #105934 from jsafrane/dont-ignore-selinux
Don't guess SELinux support on error
2021-11-05 12:44:51 -07:00
Jonathan Dobson
082cb15648 Move CSIVolumeFSGroupPolicy feature to GA 2021-11-02 15:22:33 -06:00
Jan Safranek
186810eb47 Don't guess SELinux support on error
When GetSELinuxSupport() fails, don't assume a mounted filesystem does not
support SELinux at all. Try again instead in the next SetUp retry.

This may hurt performance a bit, since kubelet will call NodePublishVolume
again, but it's better than providing wrong information to the container
runtime that will then skip relabeling of the volume.
2021-10-27 12:00:07 +02:00
Kubernetes Prow Robot
30a32a39a4 Merge pull request #105136 from astraw99/fix-csi-mount-log
Fix CSI `mounter.TearDownAt` log msg
2021-10-14 11:54:55 -07:00
astraw99
5e789f157c fix CSI mount log 2021-10-14 10:27:50 +08:00
xing-yang
2833aee8ff Bubble up to pkg/volume/OWNERS file 2021-09-30 14:01:28 +00:00
astraw99
f24e7ccf6a fix duplicate kube client 2021-09-19 11:30:15 +08:00
CKchen0726
6505b41f25 migrate csi/csi_client.go logs to structured logging 2021-09-18 09:57:55 +08:00
wojtekt
d9b08c611d Migrate to k8s.io/utils/clock 2021-09-17 15:19:08 +02:00
Kubernetes Prow Robot
a7af9f6e0e Merge pull request #101475 from ash2k/ash2k/stop-timer
Stop timer and correctly drain it
2021-08-09 09:35:31 -07:00
Cheng Xing
c50b3074fe Moved VOLUME_MOUNT_GROUP capability check from NodeStageVolume to MountDevice; added log message in SetupAt to indicate FSGroup is delegated to driver 2021-07-03 16:29:42 -07:00
Cheng Xing
794a925a85 Pass FsGroup to NodeStageVolume 2021-07-03 16:29:42 -07:00
Cheng Xing
0e315355df Pass FsGroup to MountDevice 2021-07-03 16:29:42 -07:00
Cheng Xing
ae5668edef Pass FsGroup to NodePublishVolume 2021-07-03 16:29:42 -07:00
Cheng Xing
65db13a3a5 Combine capability check implementations 2021-07-03 16:29:42 -07:00
Chris Henzie
b7d732d3d6 Map PV access modes to CSI access modes 2021-06-28 21:25:38 -07:00
Chris Henzie
8db83c89aa CSI client helpers for NodeGetCapabilities 2021-06-28 21:25:37 -07:00
Kubernetes Prow Robot
a0f9c8c277 Merge pull request #103001 from zshihang/csi
CSIServiceAccountToken ga
2021-06-26 19:31:23 -07:00
Pushkar Joglekar
1e250610b2 Fix panic in pkg/volume/csi tests
When run as non-root user, TestAttacherMountDevice fails, because of missing
nil check that induces a panic. Fixed by doing err nil check
before using the returned user value from user.Current()
2021-06-24 10:14:20 -07:00
Shihang Zhang
8231a3e921 CSIServiceAccountToken ga 2021-06-21 11:35:24 -07:00
Kubernetes Prow Robot
278f856144 Merge pull request #102653 from wzshiming/fix/npe
Fix NPE for CSI mounter
2021-06-09 10:17:26 -07:00
Kubernetes Prow Robot
8b787f3a22 Merge pull request #100741 from mengjiao-liu/fix-test-err
Fix  incorrect test code in pkg/volume/csi/csi_attacher_test.go file
2021-06-08 08:33:12 -07:00
Kubernetes Prow Robot
0322d34a3e Merge pull request #100937 from mengjiao-liu/fix-metrics-nil-pointer
Fix csi_client_test.go metrics nil pointer dereference
2021-06-08 07:27:14 -07:00
Shiming Zhang
1eb8060dd6 Add test for CSI mounter 2021-06-08 18:42:31 +08:00
Shiming Zhang
c065d7c7b3 Fix NPE for CSI mounter 2021-06-08 10:29:46 +08:00
Kubernetes Prow Robot
dff5940ac3 Merge pull request #97534 from heqg/typo01
fix Spelling error for klog
2021-06-06 22:24:39 -07:00
刁浩 10284789
5908cd0d90 simplify returning boolean expression in /pkg/volume
Signed-off-by: 刁浩 10284789 <diao.hao@zte.com.cn>
2021-05-25 02:39:55 +00:00
Niels de Vos
b997e0e4d6 Add SupportsMetrics() for Block-mode volumes
Volumes that are provisioned with `VolumeMode: Block` often have a
MetrucsProvider interface declared in their type. However, the
MetricsProvider should implement a GetMetrics() function. In the cases
where the storage drivers do not implement GetMetrics(), a panic can
occur.

Usual type-assertions are not sufficient in this case. All assertions
assume the interface is present. There is no straight forward way to
verify that a valid GetMetrics() function is provided.

By adding SupportsMetrics(), storage driver implementations require
careful reviewing for metrics support.
2021-05-20 17:10:23 +02:00
Kubernetes Prow Robot
4ad08fa5b6 Merge pull request #101115 from wangyx1992/capital-log
cleanup: fix log capitalization in volume package
2021-05-06 03:51:16 -07:00
Kubernetes Prow Robot
7f8539ff20 Merge pull request #101441 from dobsonj/101332-deprecate-mount-path-removal
Deprecate removal of CSI nodepublish path by kubelet (#101332)
2021-04-28 10:32:50 -07:00
Jonathan Dobson
260426bf44 clarify deprecation comment 2021-04-27 17:52:40 -06:00