github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
121,863 Commits 1 Branch 31 Tags 1,019 MiB
f90461c43e
Commit Graph

6449 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
6f3856f953
Merge pull request #118883 from danielvegamyhre/kep-4017-job 
Add completion index as pod label for indexed jobs
 2023-07-14 12:23:50 -07:00
Michal Wozniak
9564bdc39d Ensure final diff is used for setting expectations for Job pod creation 2023-07-14 19:09:39 +02:00
Kubernetes Prow Robot
5c72df7281
Merge pull request #118953 from mskrocki/escLib 
Convert EndpointSlice Reconciler to a library in staging.
 2023-07-13 17:13:34 -07:00
Kubernetes Prow Robot
be2cfc9697
Merge pull request #118228 from carlory/move-non-graceful-node-shutdown-to-GA 
move non-graceful node shutdown to GA
 2023-07-13 15:47:37 -07:00
Daniel Vega-Myhre
037091284e fix unit test bug 2023-07-13 22:38:21 +00:00
Kubernetes Prow Robot
bea27f82d3
Merge pull request #118209 from pohly/dra-pre-scheduled-pods 
dra: pre-scheduled pods
 2023-07-13 14:43:37 -07:00
Daniel Vega-Myhre
a1a5f49bb9 remove statefulset label added to wrong branch 2023-07-13 21:07:17 +00:00
Daniel Vega-Myhre
1ae60c0ed1 use job completion index annotation as label 2023-07-13 21:04:37 +00:00
Jiahui Feng
049614f884
ValidatingAdmissionPolicy controller for Type Checking (#117377) 
* [API REVIEW] ValidatingAdmissionPolicyStatucController config.

worker count.

* ValidatingAdmissionPolicyStatus controller.

* remove CEL typechecking from API server.

* fix initializer tests.

* remove type checking integration tests

from API server integration tests.

* validatingadmissionpolicy-status options.

* grant access to VAP controller.

* add defaulting unit test.

* generated: ./hack/update-codegen.sh

* add OWNERS for VAP status controller.

* type checking test case.
 2023-07-13 13:41:50 -07:00
Patrick Ohly
80ab8f0542 dra: handle scheduled pods in kube-controller-manager 
When someone decides that a Pod should definitely run on a specific node, they
can create the Pod with spec.nodeName already set. Some custom scheduler might
do that. Then kubelet starts to check the pod and (if DRA is enabled) will
refuse to run it, either because the claims are still waiting for the first
consumer or the pod wasn't added to reservedFor. Both are things the scheduler
normally does.

Also, if a pod got scheduled while the DRA feature was off in the
kube-scheduler, a pod can reach the same state.

The resource claim controller can handle these two cases by taking over for the
kube-scheduler when nodeName is set. Triggering an allocation is simpler than
in the scheduler because all it takes is creating the right
PodSchedulingContext with spec.selectedNode set. There's no need to list nodes
because that choice was already made, permanently. Adding the pod to
reservedFor also isn't hard.

What's currently missing is triggering de-allocation of claims to re-allocate
them for the desired node. This is not important for claims that get created
for the pod from a template and then only get used once, but it might be
worthwhile to add de-allocation in the future.
 2023-07-13 21:27:11 +02:00
Patrick Ohly
cffbb1f1b2 dra controller: enhance testing 
The allocation mode is relevant when clearing the reservedFor: for delayed
allocation, deallocation gets requested, for immediate allocation not. Both
should get tested.

All pre-defined claims now use delayed allocation, just as they would if
created normally.
 2023-07-13 21:27:11 +02:00
Patrick Ohly
5cec6d798c dra: revamp event handlers in kube-controller-manager 
Enabling logging is useful to track what the code is doing.

There are some functional changes:
- The pod handler checks for existence of claims. This
  avoids adding pods to the work queue in more cases
  when nothing needs to be done, at the cost of
  making the event handlers a bit slower. This will become
  more important when adding more work to the controller
- The handler for deleted ResourceClaim did not check for
  cache.DeletedFinalStateUnknown.
 2023-07-13 21:27:11 +02:00
Kubernetes Prow Robot
4fa97eae1b
Merge pull request #119291 from mimowo/use-jobctx-for-first-pending 
Pass Job context down to firstPendingIndexes
 2023-07-13 09:57:05 -07:00
Michal Wozniak
7e3b53042b Pass Job context down to firstPendingIndexes 2023-07-13 16:11:06 +02:00
Kubernetes Prow Robot
cd9215915b
Merge pull request #118480 from carlory/gc_metrics 
podgc metrics should count all pod deletion behaviors
 2023-07-13 06:52:05 -07:00
Jordan Liggitt
12a874d227
Preserve resourcequota informers for groups with discovery resolution errors only 2023-07-12 12:29:33 -04:00
Jordan Liggitt
c9a084d59c
Fix duplicate GC event handlers getting added if discovery flutters 2023-07-12 12:29:31 -04:00
Patrick Ohly
98ba89d31d resourceclaim controller: avoid caching deleted pod unnecessarily 
We don't need to remember that a pod got deleted when it had no resource claims
because the code which checks the cached UIDs only checks for pods which have
resource claims.
 2023-07-12 16:57:17 +02:00
Patrick Ohly
7d064812bb kube-controller-manager: finish conversion to contextual logging 
This removes all exceptions and fixes the remaining unconverted log calls.
 2023-07-12 14:57:29 +02:00
Patrick Ohly
1b8ddf6b79 podgc controller: convert to contextual logging 2023-07-12 13:45:10 +02:00
Mengjiao Liu
19869478c1 Migrate /pkg/controller/disruption to structured and contextual logging 2023-07-12 11:30:45 +08:00
Maciej Skrocki
7c873327b6 Convert controller name to reconciler variable. 2023-07-11 18:08:25 +00:00
Maciej Skrocki
29fad383da move endpointslice reconciler to staging endpointslice repo 2023-07-11 18:08:12 +00:00
Kubernetes Prow Robot
a6890b361d
Merge pull request #119193 from mimowo/sync-job-context 
Introduce syncJobContext to limit the number of function parameters
 2023-07-11 10:33:30 -07:00
Kubernetes Prow Robot
e0dafe57a3
Merge pull request #117351 from pohly/dra-generated-resource-claim-names 
DRA: generated resource claim names
 2023-07-11 10:33:11 -07:00
Patrick Ohly
fec25785ee dra: store generated ResourceClaims in cache 
This addresses the following bad sequence of events:
- controller creates ResourceClaim
- updating pod status fails
- pod gets retried before the informer receives
  the created ResourceClaim
- another ResourceClaim gets created

Storing the generated ResourceClaim in a MutationCache ensures that the
controller knows about it during the retry.

A positive side effect is that ResourceClaims now get index by pod owner and
thus iterating over existing ones becomes a bit more efficient.
 2023-07-11 14:23:49 +02:00
Patrick Ohly
444d23bd2f dra: generated name for ResourceClaim from template 
Generating the name avoids all potential name collisions. It's not clear how
much of a problem that was because users can avoid them and the deterministic
names for generic ephemeral volumes have not led to reports from users. But
using generated names is not too hard either.

What makes it relatively easy is that the new pod.status.resourceClaimStatus
map stores the generated name for kubelet and node authorizer, i.e. the
information in the pod is sufficient to determine the name of the
ResourceClaim.

The resource claim controller becomes a bit more complex and now needs
permission to modify the pod status. The new failure scenario of "ResourceClaim
created, updating pod status fails" is handled with the help of a new special
"resource.kubernetes.io/pod-claim-name" annotation that together with the owner
reference identifies exactly for what a ResourceClaim was generated, so
updating the pod status can be retried for existing ResourceClaims.

The transition from deterministic names is handled with a special case for that
recovery code path: a ResourceClaim with no annotation and a name that follows
the Kubernetes <= 1.27 naming pattern is assumed to be generated for that pod
claim and gets added to the pod status.

There's no immediate need for it, but just in case that it may become relevant,
the name of the generated ResourceClaim may also be left unset to record that
no claim was needed. Components processing such a pod can skip whatever they
normally would do for the claim. To ensure that they do and also cover other
cases properly ("no known field is set", "must check ownership"),
resourceclaim.Name gets extended.
 2023-07-11 14:23:48 +02:00
Kubernetes Prow Robot
8f1852bb44
Merge pull request #115295 from Namanl2001/pkg/controller/endpointslice 
Migrated `pkg/controller/endpointslice` and `pkg/controller/endpointslicemirroring` to contextual logging
 2023-07-11 03:19:12 -07:00
Michal Wozniak
bf48165232 Remarks to syncJobCtx 2023-07-11 09:44:08 +02:00
Michal Wozniak
990339d4c3 Introduce syncJobContext to limit the number of function parameters 2023-07-11 09:27:21 +02:00
carlory
f443c458af move non-graceful node shutdown to GA 2023-07-11 13:51:51 +08:00
Kubernetes Prow Robot
986171d388
Merge pull request #119185 from xing-yang/metrics_attach 
Add reason to force detach metric
 2023-07-10 14:03:18 -07:00
Naman
645cb90732 migrated pkg/controller/endpointslicemirroring to contextual logging 
Signed-off-by: Naman <namanlakhwani@gmail.com>
 2023-07-11 01:43:30 +05:30
Daniel Vega-Myhre
98c6e25c37 update name of pod index label 2023-07-10 20:11:52 +00:00
Naman
09849b09cf migrated pkg/controller/endpointslice to contextual logging 
Signed-off-by: Naman <namanlakhwani@gmail.com>
 2023-07-11 01:28:22 +05:30
Kubernetes Prow Robot
10a12165de
Merge pull request #116755 from my-git9/feat/endpoint/logging 
Migrated `pkg/controller/endpoint` to contextual logging
 2023-07-10 05:37:05 -07:00
Kubernetes Prow Robot
64939b66c6
Merge pull request #119146 from xuexu6666/xuexu6666/ControllerUtilUseCmpDiff 
Use cmp diff in controller_util_test.go
 2023-07-10 02:41:18 -07:00
xing-yang
cca6601106 Add reason to force detach metric 2023-07-10 06:30:05 +00:00
Aldo Culquicondor
f7a1fb76f4
Only declare job as finished after removing all finalizers 
Change-Id: Id4b01b0e6fabe24134e57e687356e0fc613cead4
 2023-07-07 14:08:19 -04:00
xuexu6666
d7708e79d3 Use cmp diff 2023-07-06 23:01:06 -05:00
Heba Elayoty
2fe38f93e5
feat: Append job creation timestamp to cronjob annotations (#118137) 
* Append job name to job annotations

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

* Update annotation description, remove timezone, and fix time

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

* Remove unused ctx

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

* code review comments

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

* code review comments

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

* Add timezone back

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

---------

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
 2023-07-06 14:39:04 -07:00
Daniel Vega-Myhre
3a02ecb341 check test case param instead of feature flag in unit test code 2023-07-06 17:30:40 +00:00
Kubernetes Prow Robot
6f9d1d38d8
Merge pull request #118817 from pohly/dra-delete-claims 
DRA: improve handling of completed pods
 2023-07-06 10:15:15 -07:00
Kubernetes Prow Robot
7e5506de8d
Merge pull request #119111 from kannon92/remove-equal-ready-job 
remove equalReady and replace with k8 util function
 2023-07-06 09:13:16 -07:00
Ziqi Zhao
dfc1838379 Migrated pkg/controller/volume|util|replicaset|nodeipam to contextual logging 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-07-06 07:39:52 +08:00
xin.li
6c0387d004 Migrated pkg/controller/endpoint to contextual logging 
Signed-off-by: xin.li <xin.li@daocloud.io>
 2023-07-06 07:36:51 +08:00
xin.li
3cf2822bc5 Migrated pkg/controller/garbagecollector to contextual logging 
Signed-off-by: xin.li <xin.li@daocloud.io>
 2023-07-06 07:36:51 +08:00
Kubernetes Prow Robot
916c3466b9
Merge pull request #118940 from soltysh/drop_missedschedules 
Hide numberOfMissedSchedules as an algorithm internal number
 2023-07-05 16:27:02 -07:00
kannon92
921b7e6e8f remove equalReady and replace with k8 util function 2023-07-05 20:11:48 +00:00
Daniel Vega-Myhre
a647f9febb default enabled pod index for test cases, add test case disabling it 2023-07-05 18:47:45 +00:00
carlory
322da7c1aa fix gc metrics 2023-07-06 02:06:03 +08:00
Kubernetes Prow Robot
91698fe900
Merge pull request #114061 from Octopusjust/k8s-pr15 
testutil: use contextual logging
 2023-07-05 08:38:57 -07:00
Maciej Szulik
1240a29af9
Hide numberOfMissedSchedules as an algorithm internal number 2023-07-05 16:58:28 +02:00
Patrick Ohly
a514f40131 dra resourceclaim controller: delete generated claims when pod is done 
When a pod is done, but not getting removed yet for while, then a claim that
got generated for that pod can be deleted already. This then also triggers
deallocation.
 2023-07-05 16:10:20 +02:00
Patrick Ohly
e8a0c42212 dra resourceclaim controller: remove reservation for completed pods 
When a pod is known to never run (again), the reservation for it also can be
removed. This is relevant in particular for the job controller.
 2023-07-05 16:10:20 +02:00
Patrick Ohly
7f5a02fc7e dra resourceclaim controller: enhance logging 
Adding logging to event handlers makes it more obvious why (or why not) claims
and pods need to be processed.
 2023-07-05 16:10:20 +02:00
Patrick Ohly
d1ba893ad8 dra resourceclaim controller: refactor isPodDone 
This covers pods that get deleted before running and will be used more than
once soon.
 2023-07-05 16:09:41 +02:00
Kubernetes Prow Robot
229dd79efd
Merge pull request #117865 from aleksandra-malinowska/parallel-sts-3 
Parallel StatefulSet pod create & delete
 2023-07-03 10:16:51 -07:00
Kubernetes Prow Robot
0a82bdbfdb
Merge pull request #118173 from huiwq1990/feat-autoscale-variable 
hpa: cleanup `currentReplicas` code
 2023-07-02 23:00:50 -07:00
Kubernetes Prow Robot
ec87834bae
Merge pull request #118936 from pohly/dra-deallocate-when-unused 
DRA: for delayed allocation, deallocate when no longer used
 2023-07-01 12:56:48 -07:00
Kubernetes Prow Robot
52b1247b28
Merge pull request #118232 from luckymrwang/style 
style: correct the sentence
 2023-06-30 01:51:59 -07:00
Kubernetes Prow Robot
9af93df9b0
Merge pull request #117845 from ctripcloud/fix-hpa-plain-calc 
fix HPA plain metric calculate
 2023-06-30 01:51:47 -07:00
Kubernetes Prow Robot
68b9ccc511
Merge pull request #117554 from yanggangtony/clean-endpoint-controller 
clean endpoint controller typo logs
 2023-06-29 16:23:44 -07:00
Daniel Vega-Myhre
e0af0a5a45 add test case param for feature flag 2023-06-29 21:51:15 +00:00
Patrick Ohly
1b47e6433b dra delayed allocation: deallocate when a pod is done 
This releases the underlying resource sooner and ensures that another consumer
can get scheduled without being influenced by a decision that was made for the
previous consumer.

An alternative would have been to have the apiserver trigger the deallocation
whenever it sees the `status.reservedFor` getting reduced to zero. But that
then also triggers deallocation when kube-scheduler removes the last
reservation after a failed scheduling cycle. In that case we want to keep the
claim allocated and let the kube-scheduler decide on a case-by-case basis which
claim should get deallocated.
 2023-06-29 09:47:30 +02:00
Aleksandra Malinowska
d616cf72a3 Add unit tests for parallel StatefulSet create & delete 2023-06-28 16:55:38 +02:00
Kubernetes Prow Robot
74bd77a9df
Merge pull request #118917 from kmala/daemonsetfix 
increase the log level for the GetTargetNodeName error message
 2023-06-28 00:08:32 -07:00
Kubernetes Prow Robot
960830bc66
Merge pull request #118102 from RomanBednar/retro-sc-assignment-ga 
graduate RetroactiveDefaultStorageClass feature to GA in 1.28
 2023-06-27 20:46:32 -07:00
yanggang
860aab842d
fix a reference to the wrong variable name 
Signed-off-by: yanggang <gang.yang@daocloud.io>
 2023-06-28 06:12:44 +08:00
Daniel Vega-Myhre
a9afaa1eee add feature gate 2023-06-27 18:07:17 +00:00
Aldo Culquicondor
a4519665fe
Skip terminal Pods with a deletion timestamp from the Daemonset sync (#118716) 
* Skip terminal Pods with a deletion timestamp from the Daemonset sync

Change-Id: I64a347a87c02ee2bd48be10e6fff380c8c81f742

* Review comments and fix integration test

Change-Id: I3eb5ec62bce8b4b150726a1e9b2b517c4e993713

* Include deleted terminal pods in history

Change-Id: I8b921157e6be1c809dd59f8035ec259ea4d96301
 2023-06-27 08:56:33 -07:00
Maciej Szulik
af1c9e49c4
Update schedule logic to properly calculate missed schedules 
Before this change we've assumed a constant time between schedule runs,
which is not true for cases like "30 6-16/4 * * 1-5".
The fix is to calculate the potential next run using the fixed schedule
as the baseline, and then go back one schedule back and allow the cron
library to calculate the correct time.

This approach saves us from iterating multiple times between last
schedule time and now, if the cronjob for any reason wasn't running for
significant amount of time.
 2023-06-27 11:29:30 +02:00
Keerthan Reddy Mala
0033f65808 increase the log level for the GetTargetNodeName error message 2023-06-26 17:31:50 -07:00
Daniel Vega-Myhre
2176053415 add completion index as pod label 2023-06-26 19:53:14 +00:00
Kubernetes Prow Robot
a48bcc06fe
Merge pull request #117064 from RomanBednar/multiple-defaults 
storage class assignment should not ignore errors
 2023-06-23 03:09:23 -07:00
Kubernetes Prow Robot
9325a57125
Merge pull request #118765 from mimowo/job-controller-unit-tests 
Do not set jm.syncJobBatchPeriod=0 if not needed
 2023-06-22 10:25:41 -07:00
Michal Wozniak
8ed23558b4 Do not set jm.syncJobBatchPeriod=0 if not needed 2023-06-22 11:10:53 +02:00
Kubernetes Prow Robot
28296ba59e
Merge pull request #113994 from mengjiao-liu/contextual-logging-controller-certificates 
certificate controller: use contextual logging
 2023-06-21 09:03:42 -07:00
Roman Bednar
1bd3f072fa stop ignoring storage class selection errors 
The GetDefaultClass() was fixed in scope of this issue:
https://github.com/kubernetes/kubernetes/issues/110514

Before this change assignDefaultStorageClass() was ignoring errors from
this function since it could mean there are multiple defaults - assign
could safely continue and do nothing.

This is no longer true because we always choose one from multiple
defaults - any errors returned from GetDefaultClass() are real errors
and should not be ignored.
 2023-06-21 13:09:05 +02:00
Aleksandra Malinowska
63e5b6bdb2 Parallel StatefulSet pod create & delete 2023-06-20 12:15:21 +02:00
Aleksandra Malinowska
2fb472c83c Refactor StatefulSet controller update logic 2023-06-20 12:14:25 +02:00
Michal Wozniak
784a309b91 Do not error in Job controller sync when there are pod failures 2023-06-20 11:31:24 +02:00
wangxiang
12b370cbbb bugfix(namespace-controller): Correctly cascade ctx when making API calls 2023-06-20 15:34:23 +08:00
Aldo Culquicondor
c9b01dd977
Fix race in logging expectations 
Change-Id: I27da7cae741935da6f0815639a54bfd597a2a6c6
 2023-06-19 13:26:39 -04:00
ialidzhikov
958c8fb695 Make use of k8s.io/utils/pointer.Duration 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
 2023-06-18 21:46:26 +03:00
Michal Wozniak
74c5ff97f1 Lower the constants for the rate limiter in Job controller 2023-06-16 17:00:04 +02:00
Michal Wozniak
c51a422d78 Cleanup job controller handling of backoff 2023-06-16 14:53:27 +02:00
aimuz
396c8a6783
test: TestPodDeletionEvent 
Signed-off-by: aimuz <mr.imuz@gmail.com>
 2023-06-16 10:31:33 +08:00
aimuz
975b2c6611
scheduler: Fix field apiVersion is missing from events reported from taint manager 
Signed-off-by: aimuz <mr.imuz@gmail.com>
 2023-06-16 09:51:25 +08:00
Kubernetes Prow Robot
58d7a794d2
Merge pull request #113504 from pacoxu/taint-unit-test 
AddOrUpdateTaintOnNode: if node does not exists, return an error
 2023-06-15 17:48:19 -07:00
Kubernetes Prow Robot
47e79b8156
Merge pull request #116910 from fatsheep9146/job-controller-contextual-logging 
Migrated pkg/controller/job to contextual logging
 2023-06-14 08:00:18 -07:00
Ziqi Zhao
7bc449d7e0 add contextual logging to job-controller 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-06-14 13:40:02 +08:00
carlory
5e048041e4 remove helper function for unused storage feature in pkg/proxy/util 2023-06-13 09:22:59 +08:00
Kubernetes Prow Robot
8a0b1bbf24
Merge pull request #118095 from carlory/patch-002 
remove unused pv informer from expand_controller
 2023-06-12 11:43:58 -07:00
xin.li
325205efb7 Migrated pkg/controller/endpoint to contextual logging 
Signed-off-by: xin.li <xin.li@daocloud.io>
 2023-06-11 20:12:07 +08:00
Kubernetes Prow Robot
a5332a839d
Merge pull request #118470 from mimowo/job-controller-fix-delay 
Ensure Job sync invocations are batched by 1s periods
 2023-06-07 12:02:13 -07:00
Michal Wozniak
2f6b1d3c0f Ensure Job sync invocations are batched by 1s periods 2023-06-07 17:32:46 +02:00
Kubernetes Prow Robot
3fbf67a403
Merge pull request #116732 from czybjtu/cleanup_map_to_sets 
Cleanup: use Set instead of map in endpointSlice utils
 2023-06-07 07:38:13 -07:00
Roman Bednar
ac15d69757 remove RetroactiveDefaultStorageClass feature gate checks 2023-06-07 14:31:16 +02:00
Roman Bednar
6afb363ca1 test: remove RetroactiveDefaultStorageClass feature gate 
Since the feature is GA and locked to true, tests can no longer set it
to false. Cleaning up by removing all references to this feature gate
from tests.

Feature gate will be removed in v1.29.
 2023-06-07 14:31:16 +02:00
Michal Wozniak
71ab7dc791 Remarks 2023-06-05 10:48:32 +02:00
Michal Wozniak
70d3bb43e5 Adjust the algorithm for computing the pod finish time 
Change-Id: Ic282a57169cab8dc498574f08b081914218a1039
 2023-06-05 10:06:56 +02:00
SataQiu
01861282b1 controller: fix the help information format of sorting_deletion_age_ratio metric 2023-06-01 23:28:42 +08:00
ZhangYu
f9ae3e774d testutil: use contextual logging 2023-05-30 10:07:04 +08:00
Kubernetes Prow Robot
c35a2775b2
Merge pull request #115554 from yt2985/cleanSA 
LegacyServiceAccountTokenCleanUp alpha
 2023-05-26 08:54:53 -07:00
Kubernetes Prow Robot
1c9f08a1c5
Merge pull request #118262 from torredil/pv-controller 
Improve Clarity of Provisioner Waiting Message
 2023-05-26 07:57:04 -07:00
Kubernetes Prow Robot
a874f587b4
Merge pull request #118071 from kerthcet/cleanup/use-contextual-logging-in-statefulset 
Chore: Apply to use contextual logging for all loggers in statefulSet
 2023-05-26 07:56:53 -07:00
torredil
5d18f47149
Improve clarity and guidance in provisioner waiting message 
Signed-off-by: torredil <torredil@amazon.com>
 2023-05-25 17:26:06 +00:00
tinatingyu
133eff3df4 implement LegacyServiceAccountTokenCleanUp alpha 2023-05-24 23:20:17 +00:00
Cookie Wang
e2ed8f8c3c style: correct the sentence 2023-05-24 20:24:36 +08:00
guangli.bao
931cc96b8d remote windows condition when #116693 is merged 
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
 2023-05-24 14:54:22 +08:00
Kubernetes Prow Robot
484645e817
Merge pull request #116659 from claudiubelu/skip-flaky-tests-2 
unit tests: Skip flaky tests on Windows (part 2)
 2023-05-23 20:04:48 -07:00
huiwq1990
048938f1d8 hpa: cleanup currentReplicas code 
Signed-off-by: huiwq1990 <huiwq1990@163.com>
 2023-05-22 20:37:49 +08:00
Michal Wozniak
0fe27a06f9 Cleanup the Job controller handling of terminating pods 2023-05-19 09:52:08 +02:00
kerthcet
3f1d8e7aeb Apply to use contextual logging for all loggers in statefulSet 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2023-05-18 16:55:19 +08:00
carlory
bea71a3e4e remove unused pv informer from expand_controller 2023-05-18 15:58:38 +08:00
Joe Betz
f0f92853ad Add api-machinery TL owners permissions for jpbetz 2023-05-15 11:09:54 -04:00
Kubernetes Prow Robot
8479db5876
Merge pull request #117946 from lavalamp/lavalamp-taking-a-break 
lavalamp is taking a long break
 2023-05-12 14:34:47 -07:00
Kubernetes Prow Robot
02659772cb
Merge pull request #117931 from tklauser/cidrset-rm-getindexforcidr 
cidrset, multicidrset: directly use getIndexForIP method
 2023-05-11 10:59:36 -07:00
Daniel Smith
1ffe3f467e lavalamp is taking a long break 2023-05-11 16:43:38 +00:00
SataQiu
3fa55d469c fix a bug where the AttachedVolume is not printed correctly in the log 2023-05-11 22:04:30 +08:00
Tobias Klauser
e7c679c362
cidrset, multicidrset: directly use getIndexForIP method 
Instead of constructing a *net.IPnet whose .Mask field is never used,
call the getIndexForIP method of *CidrSet and *MultiCIDRSet directly.
 2023-05-11 10:53:03 +02:00
zach593
e3d5feb76c fix HPA plain metric calculate 
fix inconsistency in plain metric replica calculator when usageRatio == 1.0, keep same with resource replicas
 2023-05-10 11:14:29 +08:00
Yuki Iwai
e4340f0d9b Job: Use generic Set in controller 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
 2023-05-08 15:02:23 +09:00
Kante Yin
a7035f5459 Pass Context to StartTestServer 
Signed-off-by: Kante Yin <kerthcet@gmail.com>
 2023-05-04 10:25:09 +08:00
Akhil Velagapudi
69eccd41b8 endpointslice: reduce visibility of vars/funcs 
Reduce the visibility of various public identifiers that are only used
within the scope of a package.

This was originally motivated by KEP-3685 in order to reduce the public
API surface and improve supportability.
 2023-05-02 15:58:07 -07:00
Kubernetes Prow Robot
42799903af
Merge pull request #117626 from skitt/intstr-fromint32-cloud-network 
Network: use new intstr functions
 2023-05-02 08:18:59 -07:00
Stephen Kitt
1c4b97ea27
network: replace intstr.FromInt with intstr.FromInt32 
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
 2023-05-01 09:17:30 +02:00
Stephen Kitt
5bfe738af2
apps: replace intstr.FromInt with intstr.FromInt32 
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
 2023-05-01 09:17:05 +02:00
Sheng Zhan
892ebf2d25
Ensure version "*" is passed instead of "" for all authz checks (#116937) 
* ensure version * is passed instead of  for all authz checks

* unexport match function

* remove allversion constant
 2023-04-25 09:06:18 -07:00
Kubernetes Prow Robot
29fe2c70b1
Merge pull request #117252 from alculquicondor/node-lifecycle-owner 
Add SIG ownership to controller/nodelifecycle
 2023-04-17 14:10:57 -07:00
Hao Ruan
c4e1b01416 replace spew methods with dump methods 2023-04-14 08:05:53 +08:00
Claudiu Belu
0979d55443 unit tests: Skip flaky tests on Windows (part 2) 
Some of the unit tests are currently flaky on Windows. This commit
skips them until they are resolved.
 2023-04-13 12:07:18 +00:00
Kubernetes Prow Robot
c3e3ff989a
Merge pull request #116896 from thockin/apimachinery_util_diff_cleanup 
apimachinery util/diff cleanups
 2023-04-13 02:26:37 -07:00
Kubernetes Prow Robot
5550bd5eac
Merge pull request #117249 from tnqn/fix-data-race 
Fix a data race in TopologyCache
 2023-04-12 16:28:30 -07:00
Kubernetes Prow Robot
9082903f94
Merge pull request #117245 from tnqn/fix-topology-hint 
Fix TopologyAwareHint not working when zone label is added after Node creation
 2023-04-12 13:24:44 -07:00
Aldo Culquicondor
b23ab389b4
Add SIG ownership to controller/nodelifecycle 
Change-Id: I31a329d9ca08bdf12a428cae44a5f061afa01e73
 2023-04-12 15:42:06 -04:00
Quan Tian
d567d61aa5 Fix a data race in TopologyCache 
The member variable `cpuRatiosByZone` should be accessed with the lock
acquired as it could be be updated by `SetNodes` concurrently.

Signed-off-by: Quan Tian <qtian@vmware.com>
Co-authored-by: Antonio Ojea <aojea@google.com>
 2023-04-13 02:03:16 +08:00
Quan Tian
a62563f130 Fix TopologyAwareHint not working when zone label is added after Node creation 
The topology.kubernetes.io/zone label may be added by could provider
asynchronously after the Node is created. The previous code didn't
update the topology cache after receiving the Node update event, causing
TopologyAwareHint to not work until kube-controller-manager restarts or
other Node events trigger the update.

Signed-off-by: Quan Tian <qtian@vmware.com>
 2023-04-13 01:47:55 +08:00
Tim Hockin
bc302fa414
Replace uses of ObjectReflectDiff with cmp.Diff 
ObjectReflectDiff is already a shim over cmp.Diff, so no actual output
or behavior changes
 2023-04-12 08:48:03 -07:00
Tim Hockin
9627c50ef3
Replace uses of ObjectGoPrintDiff with cmp.Diff 
ObjectGoPrintDiff is already a shim over cmp.Diff, so no actual output
or behavior changes
 2023-04-12 08:46:16 -07:00
Tim Hockin
29c0b73d64
Replace uses of diff.ObjectDiff with cmp.Diff 
ObjectDiff is already a shim over cmp.Diff, so no actual output or
behavior changes
 2023-04-12 08:46:12 -07:00
Andrea Tosatto
d09842e0ad
node-lifecycle-controller: improve monitorNodeHealth test-coverage (#116687) 
* node-lifecycle-controller: refactor monitorNodeHealth tests to improve test-coverage

* address PR review comments

* dedupe test logic
 2023-04-12 07:02:33 -07:00
Kubernetes Prow Robot
4e2977d462
Merge pull request #117178 from gjtempleton/SIG-Autoscaling-Cleanup-HPA-OWNERS 
HPA Controller - Update Owners
 2023-04-11 21:17:42 -07:00
Kubernetes Prow Robot
8cdc7fa542
Merge pull request #116675 from pacoxu/volume-flake 
deflake: Add retry with timeout to wait for final conditions
 2023-04-11 18:19:09 -07:00
Kubernetes Prow Robot
32cb4a6dc5
Merge pull request #115100 from HirazawaUi/delte-pkg-controller-unused-functions 
delete unused functions in pkg/controller directory
 2023-04-11 15:35:12 -07:00
Kubernetes Prow Robot
4e6da50c56
Merge pull request #113800 from pacoxu/patch-4 
add sig/storage label for pkg/controller/volume package PR
 2023-04-11 15:34:31 -07:00
Guy Templeton
d102a6fea5
HPA Controller - Update Owners 
Move josephburnett to emeritus status
 2023-04-09 22:44:20 +01:00
Harshal Patil
1972dd1005 Do not log entire pod struct while attaching the volume 
Signed-off-by: Harshal Patil <harpatil@redhat.com>
 2023-04-05 20:24:12 -04:00
Michal Wozniak
b5dd5f1f3a Investigate and fix the handling of Succeeded pods in DaemonSet 2023-04-04 19:21:15 +02:00
Paco Xu
8e36e948ce verifyVolumeNoStatusUpdateNeeded may cause flake and so only keep the last ones 2023-03-30 10:44:45 +08:00
HirazawaUi
397cc73dc9 delete unused functions in pkg/controller directory 2023-03-28 22:41:20 +08:00
Paco Xu
ade63dd764 cronjob: add ut for namespace terminating cause no extra log 2023-03-23 21:40:33 +08:00
Paco Xu
c14068c202 deflake: Add retry with timeout to wait for final conditions 2023-03-22 11:24:09 +08:00
mantuliu
0567c93b2a Improve the performance of map usage 
Signed-off-by: mantuliu <240951888@qq.com>
 2023-03-21 20:37:53 +08:00
czybjtu
10b36075df Cleanup: use Set instead of map in endpointSlice utils 2023-03-18 22:43:03 +08:00
Sathyanarayanan Saravanamuthu
c84c8add70
Decouple batch/job back-off logic from workqueues (#114768) 
* batch/job: decouple backoff from workqueue

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>

* Resolving review comments

* Resolving more review comments

* Resolving review comments

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>

* Computing finish time to now when FinishedAt is unix epoch

* Addressing review comments

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>

---------

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
 2023-03-16 10:15:21 -07:00
Mengjiao Liu
017bb93887 certificate controller: use contextual logging 2023-03-15 11:26:08 +08:00
Kensei Nakada
543f15d10c HPA: expose the metrics "metric_computation_duration_seconds" and "metric_computation_total" from HPA controller 2023-03-14 22:47:24 +00:00
Kubernetes Prow Robot
27e23bad7d
Merge pull request #116529 from pohly/controllers-with-name 
kube-controller-manager: convert to structured logging
 2023-03-14 14:12:55 -07:00
Kubernetes Prow Robot
c0ef73222f
Merge pull request #116522 from robscott/topology-1-27-updates 
Introducing Topology Mode Annotation, Deprecating Topology Hints Annotation
 2023-03-14 14:12:48 -07:00
Ziqi Zhao
d1aa73312c
pkg/controller/util support contextual logging (#115049) 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-03-14 12:38:14 -07:00
Patrick Ohly
99151c39b7 kube-controller-manager: convert to structured logging 
Most of the individual controllers were already converted earlier. Some log
calls were missed or added and then not updated during a rebase. Some of those
get updated here to fill those gaps.

Adding of the name to the logger used by each controller gets
consolidated in this commit. By using the name under which the
controller is registered we ensure that the names in the log
are consistent.
 2023-03-14 19:16:32 +01:00
Kubernetes Prow Robot
6a111bebe2
Merge pull request #116377 from kinvolk/rata/userns 
KEP-127: user namespace support for stateless pods
 2023-03-14 10:40:43 -07:00
Kubernetes Prow Robot
49649c89ea
Merge pull request #113584 from yangjunmyfm192085/volume-contextual-logging 
volume: use contextual logging
 2023-03-14 10:40:16 -07:00
Kensei Nakada
b49b34c03a
HPA: expose the metrics "reconciliations_total" and "reconciliation_duration_seconds" from HPA controller (#116010) 2023-03-14 09:39:42 -07:00
Kubernetes Prow Robot
f769c66aa8
Merge pull request #113622 from 249043822/br-context-logging-daemon 
daemonset: use contextual logging
 2023-03-14 09:38:28 -07:00
Patrick Ohly
29941b8d3e api: resource.k8s.io v1alpha1 -> v1alpha2 
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (https://github.com/kubernetes/kubernetes/issues/114283)
- extend ResourceClaimStatus (https://github.com/kubernetes/enhancements/pull/3802)

We need to switch from v1alpha1 to v1alpha2 for that.
 2023-03-14 07:52:03 +01:00
Rob Scott
e23af041f5
Introducing Topology Mode Annotation, Deprecating Topology Hints 
Annotation

As part of this change, kube-proxy accepts any value for either
annotation that is not "disabled".

Change-Id: Idfc26eb4cc97ff062649dc52ed29823a64fc59a4
 2023-03-14 02:23:11 +00:00
ZhangKe10140699
7198bcffcd daemonset: use contextual logging 2023-03-14 08:50:27 +08:00
杨军10092085
361e4ff0fa volume: use contextual logging 2023-03-14 08:37:30 +08:00
Damien Grisonnet
ac394c5c19 Cleanup deprecated metrics 
Remove the following deprecated metrics:
- node_collector_evictions_number
- scheduler_e2e_scheduling_duration_seconds

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
 2023-03-13 22:55:34 +01:00
Rodrigo Campos
8af3cce7fe
kubelet: remove GetHostIDsForPod() 
Now KEP-127 relies on idmap mounts to do the ID translation and we won't
do any chowns in the kubelet.

This patch just removes the usage of GetHostIDsForPod() in
operationexecutor to do the chown, and also removes the
GetHostIDsForPod() method from the kubelet volume interface.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2023-03-13 22:28:03 +01:00
Kubernetes Prow Robot
c237ddb226
Merge pull request #116045 from sanposhiho/sanposhiho/message 
fix(HPA): make a difference in SuccessfulRescale  events between the resource metric and the container resource metric
 2023-03-13 13:24:47 -07:00
Kubernetes Prow Robot
02a654a635
Merge pull request #116043 from sanposhiho/featuregate-check 
fix(HPA): ignore the container resource metrics in HPA controller when the feature gate is disabled
 2023-03-13 12:14:50 -07:00
Kubernetes Prow Robot
a0b1bee7c5
Merge pull request #115840 from atosatto/remove-taint-manager-cli 
Remove enable-taint-manager and pod-eviction-timeout CLI flags
 2023-03-13 08:13:10 -07:00
Kubernetes Prow Robot
492a08c916
Merge pull request #113525 from 249043822/br-context-logging-deployment 
deployment controller: use contextual logging
 2023-03-13 08:13:02 -07:00
Kubernetes Prow Robot
185cd95b9c
Merge pull request #113443 from yangjunmyfm192085/namespace-contextual-logging 
namespace controller: use contextual logging
 2023-03-13 04:34:44 -07:00
ZhangKe10140699
66bda6c092 deployment controller: use contextual logging 2023-03-13 19:00:44 +08:00
JunYang
f5bd8c86d4 namespace controller: use contextual logging 2023-03-13 14:59:17 +08:00
Kubernetes Prow Robot
16bc942a6b
Merge pull request #113464 from mengjiao-liu/contextual-logging-controller-bootstrap 
Migrate `pkg/controller/bootstrap` to contextual logging
 2023-03-12 20:12:42 -07:00
Mengjiao Liu
e56f3e0781 Migrate pkg/controller/bootstrap to contextual logging 2023-03-13 10:18:40 +08:00
Kensei Nakada
fafbed3b1d
fix the error message 2023-03-12 14:48:48 +09:00
Kubernetes Prow Robot
7529178924
Merge pull request #111372 from HeavenTonight/master 
code cleanup
 2023-03-10 11:44:40 -08:00
Kubernetes Prow Robot
c88b61f553
Merge pull request #113910 from mengjiao-liu/contextual-logging-pkg-controller-certificates 
clusterroleaggregation: use contextual logging
 2023-03-10 04:34:50 -08:00
Kubernetes Prow Robot
cb00077cd3
Merge pull request #113471 from ncdc/gc-contextual-logging 
garbagecollector: use contextual logging
 2023-03-10 04:34:39 -08:00
Kubernetes Prow Robot
ccba890df9
Merge pull request #114420 from bzsuni/bz/optimization 
Cleanup: fix variable names in comments
 2023-03-09 21:33:37 -08:00
Kubernetes Prow Robot
c9bbb6553d
Merge pull request #116422 from aojea/nodeslect 
unexport buggy function nodeSelectorAsSelector
 2023-03-09 10:06:03 -08:00
Antonio Ojea
fd62265d19 unexport buggy function nodeSelectorAsSelector 
Change-Id: I1e48ac0dd0b33c367fa9be4f4adb11a4531849f9
 2023-03-09 16:58:25 +00:00
Patrick Ohly
cbf7d96a85 garbagecollector: structured logging of objectReference 
When using JSON as output format, we want objectReference values to be
represented as a struct. For example, "item" is such a value:

{"ts":1678135015708.349,"caller":"garbagecollector/garbagecollector.go:595","msg":"classify object references","v":5,"item":{"name":"dra-test-driver-g4tkd","namespace":"dra-1830","apiVersion":"v1","uid":"c3f88616-7282-488c-887c-3f04291e6f4f"},"solid":null,"dangling":[{"apiVersion":"apps/v1","kind":"ReplicaSet","name":"dra-test-driver","uid":"dbe9a90c-9dfd-4ad0-8395-e5fa228f9851","controller":true,"blockOwnerDeletion":true}],"waitingForDependentsDeletion":null}
 2023-03-08 08:37:56 -05:00
Andy Goldstein
26e3dab78b garbagecollector: use contextual logging 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
 2023-03-08 08:37:56 -05:00
ZhangKe10140699
a239b9986b Migrated the StatefulSet controller (within `kube-controller-manager) to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging) 2023-03-08 18:57:57 +08:00
Paco Xu
0e6636eb33 nodeipam: return error instead of panics 2023-03-08 12:47:14 +08:00
Paco Xu
4fdca4c5f6 node ipam ut: run test in parallel to avoid timeout; and optimize the panic check 2023-03-08 11:10:51 +08:00
Andrea Tosatto
cae19f9e85 Remove deprecated pod-eviction-timeout flag from controller-manager 2023-03-07 18:14:18 +00:00
kerthcet
e5c812bbe7 Remove CLI flag enable-taint-manager 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2023-03-07 18:11:49 +00:00
Kubernetes Prow Robot
37326f7cea
Merge pull request #112670 from yangjunmyfm192085/delklogV0 
use contextual logging（nodeipam and nodelifecycle part）
 2023-03-07 09:40:33 -08:00
Kubernetes Prow Robot
e28b191581
Merge pull request #116167 from borgerli/pr/kcm-podgc 
delete Evicted pods first during pod gc
 2023-03-07 07:21:04 -08:00
Kubernetes Prow Robot
2225ee5dd3
Merge pull request #115904 from soltysh/cronjob_tz_ga 
Promote CronJob TZ to GA
 2023-03-07 07:20:47 -08:00
Kubernetes Prow Robot
637bd66165
Merge pull request #115332 from obaranov1/ttlafterfinished-logging-migration 
Migrate /pkg/controller/ttlafterfinished to structured and contextual logging
 2023-03-07 04:20:08 -08:00
Naman Lakhwani
b6f9a65558
Migrating pkg/controller/serviceaccount to contextual logging (#114918) 
* migrating pkg/controller/serviceaccount to contextual logging

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nit

Signed-off-by: Naman <namanlakhwani@gmail.com>

* capitalising first letter of error

Signed-off-by: Naman <namanlakhwani@gmail.com>

* addressed review comments

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nit to add key

Signed-off-by: Naman <namanlakhwani@gmail.com>

---------

Signed-off-by: Naman <namanlakhwani@gmail.com>
 2023-03-07 04:19:59 -08:00
Naman Lakhwani
8f45b64c93
Migrated pkg/controller/replicaset to contextual logging (#114871) 
* migrated controller/replicaset to contextual logging

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nits

Signed-off-by: Naman <namanlakhwani@gmail.com>

* addressed changes

Signed-off-by: Naman <namanlakhwani@gmail.com>

* small nit

Signed-off-by: Naman <namanlakhwani@gmail.com>

* taking t as input

Signed-off-by: Naman <namanlakhwani@gmail.com>

---------

Signed-off-by: Naman <namanlakhwani@gmail.com>
 2023-03-07 04:19:51 -08:00
Kubernetes Prow Robot
4aaa4df840
Merge pull request #113986 from songxiao-wang87/runwxs-test2 
Migrate StorageVersionGC to contextual logging
 2023-03-07 04:19:43 -08:00
Kubernetes Prow Robot
471b392f43
Merge pull request #113916 from songxiao-wang87/runwxs-test1 
Migrate ttl_controller to contextual logging
 2023-03-07 04:18:30 -08:00
Maciej Szulik
1b825c179b
Promote CronJob TZ to GA 2023-03-07 12:58:57 +01:00
Kubernetes Prow Robot
3489796d5c
Merge pull request #113428 from mengjiao-liu/contextual-logging-controller-cronjob 
Update `pkg/controller/cronjob/` for contextual logging
 2023-03-07 01:28:18 -08:00
JunYang
780ef3afb0 use klog.InfoS instead of klog.V(0),Info 2023-03-07 15:50:01 +08:00
Li Bo
749d2ba8ae delete Evicted pods first during pod gc 2023-03-07 10:11:01 +08:00
Claudiu Belu
5ba74c81ca unit tests: Skip flaky tests on Windows 
Some of the unit tests are currently flaky on Windows. This commit
skips them until they are resolved.
 2023-03-06 20:46:05 +00:00
Kubernetes Prow Robot
0270fc75d0
Merge pull request #116256 from atiratree/unmanaged-pods 
improve message, log level and testing for unmanaged pods in disruption controller
 2023-03-06 08:19:14 -08:00
torredil
6aebda9b1e Remove AWS legacy cloud provider + EBS in-tree storage plugin 
Signed-off-by: torredil <torredil@amazon.com>
 2023-03-06 14:01:15 +00:00
Kensei Nakada
f76258f0ff fix based on the suggestion 2023-03-05 15:01:34 +00:00
Filip Křepinský
747ffe785d improve message, log level and testing for unmanaged pods in disruption controller 
- set higher severity and log level when unmanaged pods found and improve testing
- do not mention unsupported controller when triggering event for
  unmanaged pods (this is covered by CalculateExpectedPodCountFailed
event)
- test unsupported controller
- make testing for events non blocking when event not found
 2023-03-03 23:03:06 +01:00
Kubernetes Prow Robot
9f0b491953
Merge pull request #113270 from rrangith/fix/create-pvc-for-pending-pod 
Automatically recreate PVC for pending STS pod
 2023-03-03 10:24:58 -08:00
Kubernetes Prow Robot
6fd488a4e6
Merge pull request #115861 from JayKayy/inform-unsupported-pdb 
Add a warning event when pdb has found a unmanaged pod
 2023-03-03 03:16:58 -08:00
Kubernetes Prow Robot
3835c7aecd
Merge pull request #115882 from binacs/binacs/controller-use-issuperset 
cleanup(controller): use IsSuperset to avoid interim slice
 2023-03-02 17:00:57 -08:00
John Kwiatkoski
1f42ebc013 Add a warning event when pdb has found a unmanaged pod 2023-03-01 20:14:10 -05:00
weizhichen
4d6be42c1a add unit test 2023-03-01 06:48:37 +00:00
weizhichen
d06c0995cb fix 116028 2023-02-27 12:49:44 +00:00
Kensei Nakada
33daba24fb fix(HPA): ignore the container resource metrics in HPA controller when the feature gate is disabled 2023-02-25 23:04:07 +00:00
Kubernetes Prow Robot
a34f8423a7
Merge pull request #115907 from qinqon/svc-same-address-different-pod 
svc: Support pods with same address
 2023-02-24 19:00:05 -08:00
Kensei Nakada
2ea50fc200 fix(HPA): make a difference in SuccessfulRescale events between the resource metric and the container resource metric 2023-02-24 14:47:38 +00:00
Enrique Llorente
697ea476e2 svc: Support pods with same address 
If different pods with same address are exposed by the same service if
some of the endpointslices endpoints are overwriten. This change add the
pod name to the hash function to ensure that all the endpoints are in
place.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
 2023-02-23 11:37:57 +01:00
Daniel Vega-Myhre
d41302312e update validation logic so completions is mutable iff completions is modified in tandem with parallelsim so completions == parallelism 2023-02-23 03:25:16 +00:00
kannon92
32ac4a9581 left over uncounted from tracking cleanup 2023-02-22 16:45:53 +00:00
Paco Xu
a890724f9e cronjob: return immediately when failed to create job for the namespace is terminating 2023-02-22 17:37:31 +08:00
Paco Xu
37aff025ff cleanup: remove Clear for fake job controller 2023-02-22 17:17:47 +08:00
obaranov1
21adaa1490 logging migration of the ttlafterfinished 
Signed-off-by: Oksana Baranova <oksana.baranova@intel.com>
 2023-02-21 14:55:03 +02:00
binacs
84ff621309 cleanup(controller): use IsSuperset to avoid interim slice 2023-02-19 21:49:58 +08:00
Kubernetes Prow Robot
d9ed2ff4b0
Merge pull request #114687 from freddie400/migrate-hpa 
Migrate pkg/controller/podautoscaler to contextual logging
 2023-02-17 05:44:03 -08:00
Freddie
dee494ece1 squashing without rebase 2023-02-17 01:47:52 +05:30
Patrick Ohly
0e1139d027 dra: avoid goroutine leaks from event broadcaster 
When using these controllers in test/integration/scheduler_perf, the goroutine
leak check there pointed out that broadcaster.Shutdown function wasn't called
and thus goroutines leaked during a test.
 2023-02-15 15:14:27 +01:00
Andy Goldstein
71ec5ed81d
resourcequota: use contexual logging (#113315) 
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
 2023-02-14 07:19:31 -08:00
Kubernetes Prow Robot
49babf218a
Merge pull request #115464 from sunnylovestiramisu/fixCSIMigrationBug 
Remove check for CSI driver running on node for CSI migration attach operations
 2023-02-13 12:49:30 -08:00
mantuliu
f2aeb3b0d9 Improve lock performance 
Signed-off-by: mantuliu <240951888@qq.com>
 2023-02-13 00:43:30 +08:00
Kubernetes Prow Robot
2c37b470b3
Merge pull request #113794 from littlejiancc/feature_stateful_cleanup 
Simplify case conditions
 2023-02-09 20:37:39 -08:00
Sunny Song
98f944f55d Remove check for CSI driver running on node for CSI migration attach operations 2023-02-09 02:45:02 +00:00
Antonio Ojea
3bb203e7eb replace nodeipam custom logic by a workqueue 
Change-Id: I242174b9d92606b1225a4af29a0730b7cd7d3c03
 2023-02-06 19:34:29 +00:00
Mengjiao Liu
6f2cd1b5bd Update pkg/controller/cronjob/ for contextual logging 2023-02-02 14:27:13 +08:00
Sarvesh Rangnekar
c791d69b3e Fix the nodeSelector key creation mechanism 
Fixes the issue caused when multile ClusterCIDR objects have the same
nodeSelector values, order of the requirements in the nodeSelector is
not preserved when nodeSelector is marshalled and converted to a string.
 2023-02-01 13:48:07 +00:00
Kubernetes Prow Robot
bd63a912d6
Merge pull request #115349 from danielvegamyhre/job-controller-changes 
Update previous succeeded indexes for Indexed jobs unconditionally
 2023-01-31 15:51:04 -08:00
Daniel Vega-Myhre
2a81337e7c update prev succeeded indexes for indexed jobs unconditionally 2023-01-31 19:15:53 +00:00
Kubernetes Prow Robot
fb9884577e
Merge pull request #115345 from gnufied/ignore-error-when-unable-find-plugin 
Ignore error when we can't find plugin capable of expanding the volum…
 2023-01-31 05:24:50 -08:00
Sarvesh Rangnekar
a8f120b76c Fix the delete flow for ClusterCIDR objects 
Fixes the deletion of ClusterCIDR object, when a Node is associated(has
Pod CIDRs allocated from this ClusterCIDR) with it. Currently the
ClusterCIDR finalizer is never cleaned up as there is no reconciliation
happening after the associated Node has been deleted. This commit fixes
the issue by adding workitems from all events to a worker queue and
reconcile until the delete is successful.
 2023-01-30 19:35:41 +00:00
Kubernetes Prow Robot
ad2a9f2f33
Merge pull request #113863 from msau42/owners 
update sig-storage owners
 2023-01-30 10:10:50 -08:00
Hemant Kumar
c9fc35c496 reword the warning that gets printed on external expansion 2023-01-30 11:37:30 -05:00
songxiao-wang87
8c7f3c2116 Making a run test. 
Signed-off-by: songxiao-wang87 <wang.xiaosong23@zte.com.cn>
 2023-01-28 03:14:57 +00:00
Hemant Kumar
1e57dae5ec Ignore error when we can't find plugin capable of expanding the volume intre 2023-01-26 14:39:05 -05:00
Patrick Ohly
bc6c7fa912 logging: fix names of keys 
The stricter checking with the upcoming logcheck v0.4.1 pointed out these names
which don't comply with our recommendations in
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#name-arguments.
 2023-01-23 14:24:29 +01:00
Kubernetes Prow Robot
c63434aaff
Merge pull request #110838 from soltysh/cronjob_improvements 
CronJob controller cleanups
 2023-01-18 09:44:34 -08:00