Commit Graph

5681 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
f3d38fcd4f
Merge pull request #88516 from boddumanohar/issues/87447
Use servicePatch methods from cloud-provider repo in service-controller
2020-02-26 19:39:44 -08:00
Kubernetes Prow Robot
55f2d91c8c
Merge pull request #88447 from taesunny/pkg/controller
Fix pkg/controller typos in some error messages, comments etc
2020-02-26 19:39:19 -08:00
Kubernetes Prow Robot
a726c9c9cb
Merge pull request #88435 from andrewsykim/ccm-clean-up
move well known cloud provider taints to k8s.io/cloud-provider/api
2020-02-26 13:33:41 -08:00
Kubernetes Prow Robot
d98975217a
Merge pull request #88525 from mborsz/bench3
Reorder conditions in FindMatchingVolume to avoid calling volumeutil.CheckNodeAffinity in trivial cases
2020-02-26 09:46:40 -08:00
taesun_lee
79680b5d9b Fix pkg/controller typos in some error messages, comments etc
- applied review results by LuisSanchez
- Co-Authored-By: Luis Sanchez <sanchezl@redhat.com>

genernal -> general
iniital -> initial
initalObjects -> initialObjects
intentionaly -> intentionally
inforer -> informer
anotother -> another
triger -> trigger
mutli -> multi
Verifyies -> Verifies
valume -> volume
unexpect -> unexpected
unfulfiled -> unfulfilled
implenets -> implements
assignement -> assignment
expectataions -> expectations
nexpected -> unexpected
boundSatsified -> boundSatisfied
externel -> external
calcuates -> calculates
workes -> workers
unitialized -> uninitialized
afater -> after
Espected -> Expected
nodeMontiorGracePeriod -> NodeMonitorGracePeriod
estimateGrracefulTermination -> estimateGracefulTermination
secondrary -> secondary
ShouldRunDaemonPodOnUnscheduableNode -> ShouldRunDaemonPodOnUnschedulableNode
rrror -> error
expectatitons -> expectations
foud -> found
epackage -> package
succesfulJobs -> successfulJobs
namesapce -> namespace
ConfigMapResynce -> ConfigMapResync
2020-02-27 00:15:33 +09:00
Maciej Borsz
7d59ea8394 Reorder conditions in FindMatchingVolume to avoid checking NodeAffinity
in trivial cases.
2020-02-26 09:20:38 +01:00
Rob Scott
6a33727632
Adding AppProtocol to Service and Endpoints Ports 2020-02-25 17:42:34 -08:00
Manohar Reddy
7b2a0a4260 update bazel 2020-02-26 06:14:19 +05:30
Manohar Reddy
08473a4949 remote patch.go and patch_test.go files 2020-02-25 20:13:43 +05:30
Manohar Reddy
1c0a78a4fd Use servicePatch methods from cloud-provider repo in service-controller 2020-02-25 16:28:37 +05:30
andrewsykim
8c633356df move well known cloud provider taints to k8s.io/cloud-provider/api
Signed-off-by: andrewsykim <kim.andrewsy@gmail.com>
2020-02-23 19:54:59 -05:00
Andrew Sy Kim
8b490dea3a service controller: add OnAdd and OnDelete node event handlers
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2020-02-20 12:56:47 -05:00
s-ito-ts
e6b9a7a309 Fix golint errors in pkg/controller/garbagecollector 2020-02-20 04:46:02 +00:00
Kubernetes Prow Robot
da9f47eadf
Merge pull request #88146 from gnufied/avoid-multiple-pv-delete
Prevent deletion of PVs that are already deleted
2020-02-19 12:40:48 -08:00
Kubernetes Prow Robot
3a24c32345
Merge pull request #87980 from tnqn/endpointslicetracker
EndpointSliceTracker should track updated resource version
2020-02-18 19:10:25 -08:00
Hemant Kumar
d9f7a1f311 Don't call delete for already deleted volumes 2020-02-18 15:59:47 -05:00
Nan Yu
89bb7d8454 Honor the RevisionHistoryLimit in StatefulSetSpec
The StatefulSet controller cleans up ControllerRevisions at the end of
the reconcile loop. If something goes wrong during reconcile, it bails
out without actually performing this step. This commit moves the cleanup
to a deferred function call to guarantee it will be executed.

Fixes issue: https://github.com/kubernetes/kubernetes/issues/85690
2020-02-18 10:42:38 -08:00
Kubernetes Prow Robot
1a0f923a65
Merge pull request #87712 from alena1108/jan30kubelet
Ineffassign fixes for pkg/controller and kubelet
2020-02-14 14:29:27 -08:00
Kubernetes Prow Robot
7fe64ccb82
Merge pull request #84984 from cofyc/fix84942
apps/StatefulSets: Garbage collector should be able to orphan ControllerRevisions too
2020-02-14 01:06:18 -08:00
David Zhu
81668cb887 Change migrated-to annoation key to follow best practices by removing beta and using 'pv' prefix 2020-02-12 10:33:08 -08:00
Quan Tian
c2d3e54551 EndpointSliceTracker should track updated resource version
During EndpointSlice reconcilation, EndpointSliceTracker is supposed to
track expected EndpointSlice resource versions so that external changes
to them can be detected. But it actually tracked the stale resource
version and resulted in every Service was handled twice as it always
received an EndpointSlice update with a different resource version but
was actually created/updated by itself during the first processing.
2020-02-10 21:47:07 +08:00
Yecheng Fu
bb2b50f3db Garbage collector should orphan ControllerRevisions too
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
2020-02-10 20:58:28 +08:00
Mike Danese
bfc75d9a5c manual fixes 2020-02-08 12:32:33 -05:00
Mike Danese
25651408ae generated: run refactor 2020-02-08 12:30:21 -05:00
Mike Danese
2637772298 some manual fixes 2020-02-07 18:17:40 -08:00
Mike Danese
3aa59f7f30 generated: run refactor 2020-02-07 18:16:47 -08:00
Kubernetes Prow Robot
8215619ba4
Merge pull request #87642 from pohly/volume-binder-testing
volume binder testing
2020-02-07 05:56:39 -08:00
Alexander Zimmermann
e0b1e9206d
Clarified comments 2020-02-07 09:09:49 +01:00
Kubernetes Prow Robot
9c1e124b15
Merge pull request #87823 from tallclair/test-tokens
Ensure testing credentials are labeled as such
2020-02-06 17:47:29 -08:00
Kubernetes Prow Robot
04e28b3674
Merge pull request #87098 from davidz627/feature/migratedRollback
Add annotation updating for migration for PVs and PVCs
2020-02-06 17:45:32 -08:00
Alexander Zimmermann
a1c837022c
Fixed Golint errors in pkg/controller/podautoscaler 2020-02-06 17:16:38 +01:00
Tim Allclair
9d3670f358 Ensure testing credentials are labeled as such 2020-02-04 10:36:05 -08:00
Kubernetes Prow Robot
fa4bc10ef1
Merge pull request #86793 from prameshj/gce-finalizer
Attach a new finalizer in GCE ILB creation.
2020-01-30 21:20:32 -08:00
Alena Prokharchyk
6c3093f970 Ineffassign fixes for pkg/controller and kubelet 2020-01-30 14:35:10 -08:00
Kubernetes Prow Robot
7164152844
Merge pull request #87664 from liggitt/revert-parallel-volume
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
2020-01-29 22:12:01 -08:00
Jordan Liggitt
cd1059e3c4 Revert "Merge pull request #87258 from verult/slow-rxm-attach"
This reverts commit 15c3f1b119, reversing
changes made to 52d7614a8c.
2020-01-29 14:58:32 -05:00
Mike Danese
968adfa993 cleanup req.Context() and ResponseWrapper 2020-01-29 08:50:45 -08:00
Mike Danese
d55d6175f8 refactor 2020-01-29 08:50:45 -08:00
Patrick Ohly
a3c434510d volume binder: enable klog flags in test
When debugging the test runs it is useful to increase the log level:

go test -v ./pkg/controller/volume/scheduling -args -v 5
2020-01-29 10:37:39 +01:00
Patrick Ohly
5c8929d95e volume binder: convert to sub-tests
Using t.Run() has some advantages:
- individual sub-tests can be selected with -run
- test failures are automatically associated with
  the scenario, therefore the test name no longer
  needs to be passed around

A "run" function is used primarily to avoid large indention changes,
but also because this can be used to extend the test with additional
parameters later on.
2020-01-29 10:37:27 +01:00
Kubernetes Prow Robot
f5a008746a
Merge pull request #83526 from eloyekunle/feat/gengo-reverse-import
import-boss reverse import
2020-01-28 18:50:13 -08:00
Pavithra Ramesh
1de2327afc Attach a new finalizer in GCE ILB creation.
Add logic in service_controller to skip create/update
if finalizer from a different controller is found.

The newly added finalizer will be checked by other controllers
implementing ILB services to determine if a given service is
already being managed by service_controller.

Moved finalizer check into cloudprovider code.

added unit test to verify new finalizer.

Modified existing unit test to create a fake service so that
attach/remove finalizer step can be tested.
2020-01-28 15:02:19 -08:00
Oleg Atamanenko
427f0f9463 Add apiVersion to involvedObject 2020-01-28 09:24:08 -08:00
Elijah Oyekunle
07e3cca6d0 update existing import-restrictions files 2020-01-28 10:51:45 +01:00
David Zhu
b7817a2981 Add annotation annealing for migration for PVs and PVCs during syncVolume and syncClaim. This allows external-provisioners to pick up and delete volumes when they have been rolled up from previous kubernetes versions. 2020-01-27 16:14:53 -08:00
Cheng Xing
c6a03fa5be Parallelize attach operations across different nodes for volumes that allow multi-attach 2020-01-27 15:02:25 -08:00
Kubernetes Prow Robot
dc090f80d1
Merge pull request #87406 from haosdent/remove-algo
Remove `scheduler/algorithm/priorities` in import-restrictions
2020-01-23 11:34:24 -08:00
Kubernetes Prow Robot
c5d981583a
Merge pull request #87308 from KobayashiD27/fix-staticcheck
Fix staticcheck in pkg/controller/podgc
2020-01-23 11:34:11 -08:00
David Eads
5c2d2c5ef1 rename dynamic cert loading to be more accurate 2020-01-22 15:00:46 -05:00
David Eads
6ccfc3aecf add dynamic reloading for CSR signing controllers 2020-01-22 15:00:46 -05:00
Kubernetes Prow Robot
e4926e2d70
Merge pull request #85421 from terrytangyuan/patch-1
Fix grammar: have -> has
2020-01-22 08:40:58 -08:00
Haosdent Huang
b09e35257a Remove scheduler/algorithm/priorities in import-restrictions 2020-01-22 11:54:28 +08:00
yiyang5055
53aff819e0 fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion 2020-01-20 09:10:46 +00:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon.
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-19 21:09:05 +08:00
Kubernetes Prow Robot
073da1588a
Merge pull request #86801 from likakuli/fix_syncsts_orphanrevision
fix a bug that orphan revision cannot be adopted and statefulset cannot be synced
2020-01-19 00:07:35 -08:00
Kobayashi Daisuke
ed1381e35f Fix staticcheck in pkg/controller/podgc 2020-01-17 15:42:38 +09:00
Paul Morie
afaea605f4 Remove Brad Childs from OWNERS files 2020-01-16 15:21:34 -05:00
Jordan Liggitt
054e3846fc Use v1 subjectaccessreview API in controller-manager CSR approver 2020-01-13 15:55:52 -05:00
Kewei Ma
34fce9faee
Fix a comment in job_controller 2020-01-13 10:09:06 -06:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo
Fix a comment typo in legacyNodeRoleBehaviorFeature
2020-01-10 17:17:38 -08:00
Kubernetes Prow Robot
240782c7f7
Merge pull request #87043 from zjs/topic/propagate-providerid-errors
Ensure a provider ID is set on a node if expected
2020-01-10 14:33:50 -08:00
Zach Shepherd
2b554079af
Ensure a provider ID is set on a node if expected
A transient issue might occur that causes an error to be returned by
InstanceID(). When this is ignored, the external cloud provider taint
will be removed and neither AddCloudNode() nor UpdateCloudNode() will
try to set a provider ID in the future.

By returning the error we can ensure that the external cloud provider
taint is not removed prematurely, allowing the operation to be retried
(until the provider ID can be set).

Preserve support for external cloud providers that do not use IDs by
continuing if a NotImplemented error is returned, making a distinction
between lack of support for provider IDs and an actual error.

Introduce pair of unit tests that show a provider ID will eventually
be set if an error is returned, unless that error is a NotImplemented,
in which case the external cloud provider taint will be removed.
2020-01-10 11:00:54 -08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags
feat: remove several feature gates in 1.18
2020-01-09 13:28:50 -08:00
Kubernetes Prow Robot
1e0bfae887
Merge pull request #86871 from gosoon/master
fix log message error in nodelifecycle
2020-01-08 02:58:33 -08:00
likakuli
10864d3366 fix a bug that orphan revision cannot be adopted and sts cannot be synced 2020-01-08 17:56:41 +08:00
Kubernetes Prow Robot
f3df7a2fdb
Merge pull request #86727 from mattjmcnaughton/mattjmcnaughton/remove-recorder-PastEventf
Remove `recorder.PastEventf` method
2020-01-07 04:38:49 -08:00
tianfeiyu
fddf50cf88
fix log message error in nodelifecycle 2020-01-06 21:02:08 +08:00
Abdullah Gharaibeh
041e5b5560 addressed comments 2020-01-04 01:14:24 -05:00
Abdullah Gharaibeh
7d604c318c Break DS controller on scheduler predicates and predicate errors 2020-01-03 13:05:07 -05:00
mattjmcnaughton
92940fa80d
Remove recorder.PastEventf method
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316)
shows, this `timestamp` was never actually used.

In other words, `PastEventf` is identical to `Eventf`.

We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.

Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
2019-12-30 12:00:23 -05:00
Kubernetes Prow Robot
d4ba10ec80
Merge pull request #85703 from robscott/endpointslice-controller-race-fix
Fixing Potential Race Condition in EndpointSlice Controller.
2019-12-26 17:59:52 -08:00
Rob Scott
c75787bb77
Fixing Potential Race Condition in EndpointSlice Controller.
This adds a new EndpointSlice tracker to keep track of the expected resource versions of EndpointSlices associated with each Service managed by the EndpointSlice controller. This should prevent a potential race where a syncService call could happen with an incomplete view of EndpointSlices if additions or deletions hadn't fully propagated to the cache yet. Additionally, this ensures that external changes to EndpointSlices will be handled by the EndpointSlice controller.
2019-12-26 12:15:38 -08:00
danielqsj
5bc0e26c19 unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
Alvaro Aleman
18fa7bdb6e Cloud node controller: Only call once into cloud provider 2019-12-17 20:03:27 +01:00
Kubernetes Prow Robot
42fe74cd2c
Merge pull request #86142 from raz-bn/add-complete-event
Adding new job completed event
2019-12-16 23:43:58 -08:00
raz-bn
0224c48120 Job completed event added 2019-12-16 21:41:15 +00:00
Kubernetes Prow Robot
69410eca4b
Merge pull request #86256 from liggitt/testapi
Remove use of testapi package
2019-12-13 12:55:50 -08:00
Jordan Liggitt
5d5b444c4d Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
Kubernetes Prow Robot
f67d3b1a7d
Merge pull request #86229 from ahg-g/ahg-ds
Remove daemonset controller's dependency on scheduler metadata
2019-12-13 00:26:54 -08:00
Kubernetes Prow Robot
ae717afc0d
Merge pull request #86140 from yutedz/rs-rm-timeout
Do not swallow timeout in manageReplicas
2019-12-12 18:33:07 -08:00
Abdullah Gharaibeh
288609ecf5 remove ds dependeny on scheduler metadata 2019-12-12 19:04:36 -05:00
Ted Yu
9cff345770 Do not swallow timeout in manageReplicas 2019-12-12 11:27:36 -08:00
draveness
dcea6ff065 fix: remove TaintNodesByCondition feature gate in daemon controller 2019-12-12 18:17:14 +08:00
Kubernetes Prow Robot
928817a26a
Merge pull request #74525 from gliush/configurable-hpa-limits
Configurable HorizontalPodAutoscaler
2019-12-11 03:18:05 -08:00
Arjun Naik
8ab226263a Adds tests
Signed-off-by: Arjun Naik <arjun@arjunnaik.in>
2019-12-10 18:09:20 +01:00
Ivan Glushkov
27ffe439b6
Adds the algorithm implementation for the Configurable HPA 2019-12-10 20:37:33 +04:00
Kubernetes Prow Robot
fcc35b0468
Merge pull request #85899 from gongguan/slim_down_lister
slim down some lister expansions
2019-12-09 07:20:17 -08:00
louisgong
7f5076d8ee slim down some lister expansions 2019-12-07 08:27:06 +08:00
Nan Yu
1fb0dd4ec5 Rename PodDisruptionsAllowed to DisruptionsAllowed in type PodDisruptionBudgetStatus 2019-12-03 14:26:35 -08:00
Kubernetes Prow Robot
41757d673e
Merge pull request #85521 from gaorong/check-return-value
check service status value returned by EnsureLoadBalancer
2019-11-25 22:51:10 -08:00
Rob Scott
4229b99203
Deep copying EndpointSlices in reconciler before modifying them. 2019-11-23 20:57:50 -08:00
Rong Gao
99603e105a check service status value returned by EnsureLoadBalancer
when service status returned by EnsureLoadBalancer is nil, return the
function directly to avoid NPE
2019-11-22 09:19:06 +08:00
Benjamin Elder
cf510ac285 fix multiple node cidr masks in providerless build 2019-11-19 09:47:45 -08:00
Yuan Tang
dd308ca576
Fix grammar: have -> has 2019-11-18 11:17:58 -05:00
Kubernetes Prow Robot
c3f8d700ac
Merge pull request #85367 from aramase/node-cidr-followup
[kube controller manager] add comments for compatibility
2019-11-15 19:09:54 -08:00
Kubernetes Prow Robot
9c26a752a9
Merge pull request #85231 from davidz627/flags
Flip CSIMigration and CSIMigrationGCE to Beta
2019-11-15 17:57:41 -08:00
Kubernetes Prow Robot
9859e73433
Merge pull request #85361 from liggitt/endpoint-label
Fix label mutation in endpoints controller
2019-11-15 16:17:49 -08:00
Anish Ramasekar
128f33b26e
add comments for compatibility 2019-11-15 15:38:06 -08:00
Jordan Liggitt
08b5c809d2 Fix label mutation in endpoints controller 2019-11-15 16:24:10 -05:00
Rob Scott
7085d692b7
Reverting managed-by-setup annotation
This ended up causing far more problems than it was worth, especially
given that it just attempted to provide backwards compatibility with
the alpha release.
2019-11-15 11:50:58 -08:00
David Zhu
41c65f4740 Jump out of spec translation early if the spec is not migratable. Unit tests work after all! 2019-11-15 11:23:32 -08:00
David Zhu
6e716af89e Add CSINodes to AttachDetachControllerRecovery test 2019-11-15 11:23:32 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree)
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
2019-11-15 08:29:12 -07:00
Kubernetes Prow Robot
ded6ee953c
Merge pull request #79993 from aramase/controller-manager-multiple-cidr
Allow multiple node cidr masks in kube-controller-manager
2019-11-14 23:23:42 -08:00
Kubernetes Prow Robot
372ebd24f5
Merge pull request #83098 from ddebroy/disable-intree
CSI Migration phase 2: disable probing of in-tree plugins
2019-11-14 20:51:42 -08:00
Anish Ramasekar
796faba4ac
Allow multiple node cidr masks in cm
update tests

add comment

amend var name

update comment

add check for empty slice

fix tests

fix mask size in test

review feedback

add ipv4 and ipv6 flag for mask sizes

add to violation exception list

remove import alias

run update-openapi-spec

review feedback

run update-bazel

review feedback

review feedback
2019-11-14 20:04:31 -08:00
YAMAMOTO Takashi
361cd7212e Fix a comment typo in legacyNodeRoleBehaviorFeature 2019-11-15 11:30:34 +09:00
Deep Debroy
129f15328b Disable in-tree plugins migrated to CSI
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-11-14 17:28:21 -08:00
Kubernetes Prow Robot
ba9f7419f9
Merge pull request #84732 from khenidak/fix-disable-dualstack
Fix a CM panic when ipam tries to lock an out of range pre existing cidr
2019-11-14 11:19:35 -08:00
Kubernetes Prow Robot
5e30d32d2c
Merge pull request #83394 from bertinatto/convert_pv_no_affinity
Convert existing PVs to use volume topology in VolumeBinderPredicate
2019-11-13 21:45:56 -08:00
Kubernetes Prow Robot
565566f4b2
Merge pull request #85153 from codenrhoden/mount-no-exec-int
Retire mount.Exec for k8s.io/utils/exec
2019-11-13 17:28:32 -08:00
Kubernetes Prow Robot
072cf5bd58
Merge pull request #85023 from MrHohn/svc-lb-ga
Promote service load balancer finalizer to GA
2019-11-13 17:28:21 -08:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
Travis Rhoden
367f879131
Retire mount.Exec for k8s.io/utils/exec
This patch removes mount.Exec entirely and instead uses the common
utility from k8s.io/utils/exec.

The fake exec implementation found in k8s.io/utils/exec differs a bit
than mount.Exec, with the ability to pre-script expected calls to
Command.CombinedOutput(), so tests that previously relied on a callback
mechanism to produce specific output have been updated to use that
mechanism.
2019-11-13 14:09:57 -07:00
Fabio Bertinatto
bbfc6ef450 Convert volume binder to use CSINode GA 2019-11-13 14:01:01 +01:00
Fabio Bertinatto
7cba40fb09 Use CSI translation lib in VolumeBinderPredicate 2019-11-13 14:01:01 +01:00
Zihong Zheng
0833e8840e Amend service controller code/test regarding finalizer GA 2019-11-12 15:04:07 -08:00
Rob Scott
0fa9981e01
Splitting IP address type into IPv4 and IPv6 for EndpointSlices 2019-11-12 09:03:53 -08:00
Kubernetes Prow Robot
5dc87d2919
Merge pull request #83965 from robscott/endpointslice-managed-by
Adding new label to indicate what is managing an EndpointSlice
2019-11-12 03:08:07 -08:00
Kubernetes Prow Robot
7d1f9b440e
Merge pull request #83815 from howardjohn/appprotocol
Add appProtocol to EndpointSlice.Port
2019-11-11 17:48:06 -08:00
Kubernetes Prow Robot
01e014c7d6
Merge pull request #85012 from alculquicondor/feat/predicate_factory
Add MetadataProducerFactory for predicates
2019-11-11 14:46:36 -08:00
Kubernetes Prow Robot
709a0c4f7b
Merge pull request #85067 from takanattie/fix_typo
Fix a typo in pkg/controller
2019-11-11 12:56:48 -08:00
Aldo Culquicondor
6a98c93f3c Add MetadataProducerFactory for predicates
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2019-11-11 11:27:44 -05:00
Kubernetes Prow Robot
b2fb0f77ad
Merge pull request #82572 from tnozicka/fix-rs-expectations
Fix RS expectations for recreate case
2019-11-11 05:49:42 -08:00
Tomas Nozicka
ce52643f12 Update Bazel 2019-11-11 09:11:43 +01:00
Tomas Nozicka
6754b93f6b Fix RS informer handlers and handling expectations on delete 2019-11-11 09:11:43 +01:00
Takashi Natsume
e5ad39fbe0 Fix a typo in pkg/controller 2019-11-10 11:24:10 +00:00
shibataka000
b7122770f8 Fix bug about unintentional scale out during updating deployment.
During rolling update with maxSurge=1 and maxUnavailable=0,
len(metrics) is greater than currentReplcas
and it may cause unintentional scale out.
2019-11-09 06:24:31 +00:00
Rob Scott
6b8b2ff975
Adding new label to indicate what is managing an EndpointSlice
This adds a new Label to EndpointSlices that will ensure that multiple
controllers or entities can manage subsets of EndpointSlices. This
label provides a way to indicate the controller or entity responsible
for managing an EndpointSlice.

To provide a seamless upgrade from the alpha release of EndpointSlices
that did not support this label, a temporary annotation has been added
on Services to indicate that this label has been initially set on
EndpointSlices. That annotation will be set automatically by the
EndpointSlice controller with this commit once appropriate Labels have
been added on the corresponding EndpointSlices.
2019-11-08 15:34:44 -08:00
Kubernetes Prow Robot
9cf309ed59
Merge pull request #82049 from andrewsykim/ga-node-instance-type-label
Promote Node Instance Type Label to GA
2019-11-08 13:47:58 -08:00
Khaled Henidak(Kal)
2de6b2e52c unit tests 2019-11-08 18:29:08 +00:00
Khaled Henidak(Kal)
e07402f7dc fix a panic when ipam tries to allocate an out of range pre-existing cidr 2019-11-08 18:29:08 +00:00
John Howard
d00794ca60 Add appProtocol to EndpointSlice.Port 2019-11-08 09:22:50 -08:00
Kubernetes Prow Robot
f0184f0921
Merge pull request #84933 from krzysied/node_controller_v_level
Bumping up log level for not updated node
2019-11-08 09:00:40 -08:00
Kubernetes Prow Robot
ae15368355
Merge pull request #84351 from wojtek-t/promote_node_lease_to_GA
Promote node lease to GA
2019-11-08 09:00:15 -08:00
Andrew Sy Kim
55e40b8dc1 cloud node controller: apply stable instance-type label with backfill to existing nodes
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-11-08 10:50:52 -05:00
Kubernetes Prow Robot
d366d2eaa3
Merge pull request #84896 from RainbowMango/pr_migrate_custom_collector_scheduler
Migrate custom collector for kube-scheduler
2019-11-08 01:04:14 -08:00
Kubernetes Prow Robot
3ee195f0e9
Merge pull request #81431 from andrewsykim/ga-node-topology
Promote Node Zone/Region Topology Labels to GA
2019-11-07 22:00:20 -08:00
Andrew Sy Kim
07229d6c51 pkg/util/node: update GetZoneKey to check both beta and GA labels
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-11-07 21:22:04 -05:00
Andrew Sy Kim
3032c81187 node controller: set both deprecated Beta and GA labels for Zone/Region topology
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-11-07 20:08:11 -05:00
Rob Scott
0c7548f020
Setting Hostname from Pods on EndpointSlice to match Endpoints behavior.
This was an oversight in the initial EndpointSlice release. This update
will ensure that Endpoints and EndpointSlices use the same logic to set
the Hostname attribute.
2019-11-07 13:22:54 -08:00
Kubernetes Prow Robot
f7c3fa8324
Merge pull request #84860 from wojtek-t/remove_conversion_funcs_4
Eliminate couple default conversions
2019-11-07 09:05:30 -08:00
Kubernetes Prow Robot
06a7e9a1f3
Merge pull request #84763 from hwdef/fix-staticcheck6
pkg/controller: fix staticcheck warning
2019-11-07 09:05:17 -08:00
Krzysztof Siedlecki
4e63b9a032 bumping up log level for not updated node 2019-11-07 17:59:26 +01:00
Kubernetes Prow Robot
8841624982
Merge pull request #81167 from krzysied/node_controller_list
Avoid listing pods in NodeLifecycleController
2019-11-07 07:53:10 -08:00
Kubernetes Prow Robot
1183771545
Merge pull request #84748 from hvaara/fix-golint-controller-volume-persistentvolume-options
Fix golint issues in pkg/controller/volume/persistentvolume/options
2019-11-07 04:35:53 -08:00
Kubernetes Prow Robot
ca836256c4
Merge pull request #84573 from robscott/endpointslice-publishnotready
Updating EndpointSlices to use PublishNotReadyAddresses from Services.
2019-11-07 04:35:10 -08:00
Krzysztof Siedlecki
9406e5bf2a adding pods lister 2019-11-07 12:02:21 +01:00
hwdef
38256df718 pkg/controller: fix staticcheck warning 2019-11-07 16:46:47 +08:00
Kubernetes Prow Robot
24fb2c1afd
Merge pull request #84280 from gongguan/service_selector_cache
add service selector cache in endpoint and endpointSlice controller
2019-11-06 18:47:00 -08:00
RainbowMango
09dc221d7b Deal with auto-generated files.
Update bazel by hack/update-bazel.sh
2019-11-07 10:30:12 +08:00
RainbowMango
9efabe8124 Migrate custom collector to stablility framework 2019-11-07 10:26:27 +08:00
Kubernetes Prow Robot
46472773cb
Merge pull request #84836 from yuxiaobo96/k8s-checks
Correct spelling mistakes
2019-11-06 12:21:11 -08:00
Kubernetes Prow Robot
b09b962d96
Merge pull request #84746 from Huang-Wei/move-sched-constrants
Move out const strings in pkg/scheduler/api/well_known_labels.go
2019-11-06 12:20:06 -08:00
Rob Scott
ff3cbdb0ad
Updating EndpointSlices to use PublishNotReadyAddresses from Services.
The Service spec includes a PublishNotReadyAddresses field which has
been used by Endpoints to report all matching resources ready. This may
or may not have been the initial purpose of the field, but given the
desire to provide backwards compatibility with the Endpoints API here,
it seems to make sense to continue to provide the same functionality.
2019-11-06 09:11:31 -08:00
wojtekt
ccded14941 Eliminate some default conversions 2019-11-06 14:08:15 +01:00
yuxiaobo
81e9f21f83 Correct spelling mistakes
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2019-11-06 20:25:19 +08:00
Wei Huang
019d7497a5
bazel files 2019-11-05 20:57:21 -08:00
Wei Huang
dd74205bcf
Move out const strings in pkg/scheduler/api/well_known_labels.go 2019-11-05 20:56:21 -08:00
louisgong
2133f9e9ff add service selector cache in endpoint controller and endpointSlice controller 2019-11-06 10:55:26 +08:00
Kubernetes Prow Robot
0c32aa8910
Merge pull request #83257 from robscott/endpointslice-metrics
Adding initial EndpointSlice metrics.
2019-11-05 15:30:31 -08:00
Kubernetes Prow Robot
268e331c70
Merge pull request #84527 from robscott/endpoint-util-owners
Adding owners file for Endpoint controller utils
2019-11-05 06:28:39 -08:00
wojtekt
ffad401b4e Promote NodeLease feature to GA 2019-11-05 09:01:12 +01:00
Kubernetes Prow Robot
aaa5707896
Merge pull request #84677 from mikedanese/cfssl
remove cfssl dependencies
2019-11-04 15:28:53 -08:00
Kubernetes Prow Robot
1d1385af91
Merge pull request #83474 from msau42/topology-ga
CSI Topology ga
2019-11-04 15:28:27 -08:00
Roy Hvaara
dffcf7c8cd
Fix golint issues in pkg/controller/volume/persistentvolume/options 2019-11-04 21:45:21 +01:00
Mike Danese
6a004d0c18 support URI SANs in local signer 2019-11-04 10:56:06 -08:00
Mike Danese
fe51712288 refactor into seperate authority package 2019-11-04 10:56:06 -08:00
Mike Danese
4bd2c3998f don't use cfssl in signer 2019-11-04 10:56:06 -08:00
Kubernetes Prow Robot
6a19261e96
Merge pull request #84123 from smarterclayton/terminating_cause
Handle namespace deletion more gracefully in built-in controllers
2019-11-04 07:55:41 -08:00
Kubernetes Prow Robot
5e33f3db5f
Merge pull request #84445 from krzysied/node_controller_retry_fix
NodeLifecycleController - MarkPodsNotReady retry fix
2019-11-03 20:15:40 -08:00
Kubernetes Prow Robot
b55440dcf8
Merge pull request #84637 from zhipengzuo/master
fix log and note :cidr mask size must be <= node mask
2019-11-03 18:53:40 -08:00
Kubernetes Prow Robot
d8ab3f26e7
Merge pull request #84323 from draveness/feature/remove-suspended-daemon-pods
feat: remove suspendedDaemonPods from daemon controller
2019-11-02 23:41:40 -07:00
Kubernetes Prow Robot
6e0c915f43
Merge pull request #84060 from yutedz/gc-ref-diff
Traverse OwnerReference maps more efficiently
2019-11-01 18:07:41 -07:00
zhipengzuo
1e0b019062 fix log and annotation :cidr mask size must be <= node mask 2019-11-01 17:26:23 +08:00
Krzysztof Siedlecki
3a82f50b2e adding test for retrying MarkPodsNotReady 2019-10-31 16:56:54 +01:00
Krzysztof Siedlecki
9759a982c5 MarkPodsNotReady retry fix 2019-10-31 16:56:54 +01:00
Ryan Phillips
f87da3fdfa fixes for tests to pass with FIPS compiler
* use P256 ECDSA key since P224 is not supported
* regen test certs to be 2048bits
2019-10-30 10:10:11 -05:00
Rob Scott
40423cf18e
Adding owners file for Endpoint controller utils 2019-10-29 11:01:49 -07:00
Andrew Sy Kim
897b8d7476 improve error handling in cloud node controller
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-10-28 20:23:12 -04:00
Michelle Au
fb6dfeb718 Convert attach-detach controller to use v1.CSINode 2019-10-28 13:41:13 -07:00
wojtekt
ce499ac286 Migrate components to EndpointsLeases leader election lock 2019-10-28 09:09:03 +01:00
Kubernetes Prow Robot
d379ab2697
Merge pull request #84288 from wojtek-t/cleanup_conversions_registrations
Cleanup conversions registrations
2019-10-25 22:53:22 -07:00
draveness
dc437a7890 feat: remove suspendedDaemonPods from daemon controller 2019-10-25 09:16:48 +08:00
wojtekt
7b6bcdf780 Autogenerated code 2019-10-24 20:21:00 +02:00
Kubernetes Prow Robot
2c4cba8aa0
Merge pull request #82365 from jkaniuk/pod-gc
Pod GC controller - use node lister
2019-10-24 03:13:06 -07:00
Rob Scott
724b142f07
Adding initial EndpointSlice metrics. 2019-10-23 17:33:17 -07:00
Kubernetes Prow Robot
ed5a3847a2
Merge pull request #83856 from mrbobbytables/update-autoscaling-owners
Prune inactive owners from autoscaling related OWNERS files.
2019-10-23 15:53:34 -07:00
Kubernetes Prow Robot
4f63f61c36
Merge pull request #84193 from ahg-g/ahg-list
Separate scheduler listers into their own package
2019-10-23 12:51:30 -07:00
Kubernetes Prow Robot
7dc298af42
Merge pull request #82795 from draveness/feature/remove-schedule-daemonset-pods
feat(scheduler): graduate ScheduleDaemonSetPods to GA
2019-10-23 12:49:12 -07:00
Kubernetes Prow Robot
65fa4c979a
Merge pull request #82152 from misterikkit/disruption
Fix retry logic in DisruptionController
2019-10-23 12:48:58 -07:00
Jacek Kaniuk
39883f08bf Pod GC controller - use node lister 2019-10-23 16:54:54 +02:00
draveness
35d772e354 feat: graduate ScheduleDaemonSetPods to GA 2019-10-23 21:34:47 +08:00
Kubernetes Prow Robot
75cd65ae0e
Merge pull request #82145 from shivi28/fix-controller-nodeipam-ipam-cidrset
nodeipam-controller:fix static check failures
2019-10-22 23:18:26 -07:00
Cristian Dima
da759609dc in pkg/controller/service rename service_controller.go to controller.go 2019-10-23 01:52:19 +03:00
Cristian Dima
a18de39166 fix golint errors in pkg/controller/service 2019-10-23 01:52:19 +03:00
Abdullah Gharaibeh
d393804237 separate listers into their own package 2019-10-22 18:11:02 -04:00
Kubernetes Prow Robot
3c0fa84f92
Merge pull request #84075 from yutedz/replica-set-rolling
Extract PodPhase map outside Less func
2019-10-22 10:28:36 -07:00
Kubernetes Prow Robot
4984c6f000
Merge pull request #84049 from jsafrane/block-feature-gate-checks
Add block feature gate checks to PV controller
2019-10-21 21:12:09 -07:00
Ted Yu
7a4b98b896 Extract PodPhase map outside Less func 2019-10-21 14:32:20 -07:00
Clayton Coleman
bd9260711f
deployment: Ignore namespace termination errors when creating replicasets
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. Unlike other controllers, we
drop the replica set create error very late (in the queue handleErr)
in order to avoid changing the structure of the controller
substantially.
2019-10-20 18:39:01 -04:00
Clayton Coleman
c6e34e58c5
job: Ignore namespace termination errors when creating pods or jobs
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. While we could technically
exit the entire processing loop early for very large jobs,
we should wait for more evidence that is an issue before changing
that logic substantially.
2019-10-20 18:39:01 -04:00
Clayton Coleman
8f74c8970b
daemonset: Ignore namespace termination errors when creating pods
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. While we could technically
exit the entire processing loop early for very large daemon sets,
we should wait for more evidence that is an issue before changing
that logic substantially.
2019-10-20 18:39:00 -04:00
Clayton Coleman
2e8ace82eb
replicaset: Ignore namespace termination errors when creating pods
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. While we could technically
exit the entire processing loop early for very large replica sets,
we should wait for more evidence that is an issue before changing
that logic substantially.
2019-10-20 18:39:00 -04:00
Clayton Coleman
dc0c21c7d7
serviceaccount: If namespace is terminating, ignore create errors
In some scenarios the service account and token controllers can
race with namespace deletion, causing a burst of errors as they
attempt to recreate secrets being deleted.

Instead, detect these errors and do not retry.
2019-10-20 18:39:00 -04:00
Clayton Coleman
937ef77257
endpoints: If namespace is terminating, drop item immediately
Avoid sending an event to the namespace that is being terminated,
since it will be rejected.
2019-10-20 18:38:59 -04:00
walter
6991069e31 Push context up to cloud node controller.
This adds context to the cloud node controller. It continues the propogation started in 59287.  Fixes 815.
Fixed test code calls.
2019-10-20 11:20:49 -07:00
Ted Yu
0d704f1ce2 Traverse OwnerReference maps more efficiently 2019-10-19 17:56:11 -07:00
Kubernetes Prow Robot
aab740ffc2
Merge pull request #82703 from draveness/feature/graduate-taint-nodes-by-condition-to-ga
feat: update taint nodes by condition to GA
2019-10-18 20:01:37 -07:00
draveness
1163a1d51e feat: update taint nodes by condition to GA 2019-10-19 09:17:41 +08:00
Kubernetes Prow Robot
de9a7d863d
Merge pull request #83934 from wccsama/wcc-service-dev
Convert error messages to use event recorder
2019-10-18 12:37:46 -07:00
wccsama
18cf49e3df Convert error messages to use event recorder
remove mix protocol validation
remove check nil
2019-10-18 13:30:00 +08:00
Miciah Masters
980b6406b2 Prefer to delete doubled-up pods of a ReplicaSet
When scaling down a ReplicaSet, delete doubled up replicas first, where a
"doubled up replica" is defined as one that is on the same node as an
active replica belonging to a related ReplicaSet.  ReplicaSets are
considered "related" if they have a common controller (typically a
Deployment).

The intention of this change is to make a rolling update of a Deployment
scale down the old ReplicaSet as it scales up the new ReplicaSet by
deleting pods from the old ReplicaSet that are colocated with ready pods of
the new ReplicaSet.  This change in the behavior of rolling updates can be
combined with pod affinity rules to preserve the locality of a Deployment's
pods over rollout.

A specific scenario that benefits from this change is when a Deployment's
pods are exposed by a Service that has type "LoadBalancer" and external
traffic policy "Local".  In this scenario, the load balancer uses health
checks to determine whether it should forward traffic for the Service to a
particular node.  If the node has no local endpoints for the Service, the
health check will fail for that node.  Eventually, the load balancer will
stop forwarding traffic to that node.  In the meantime, the service proxy
drops traffic for that Service.  Thus, in order to reduce risk of dropping
traffic during a rolling update, it is desirable preserve node locality of
endpoints.

* pkg/controller/controller_utils.go (ActivePodsWithRanks): New type to
sort pods using a given ranking.
* pkg/controller/controller_utils_test.go (TestSortingActivePodsWithRanks):
New test for ActivePodsWithRanks.
* pkg/controller/replicaset/replica_set.go
(getReplicaSetsWithSameController): New method.  Given a ReplicaSet, return
all ReplicaSets that have the same owner.
(manageReplicas): Call getIndirectlyRelatedPods, and pass its result to
getPodsToDelete.
(getIndirectlyRelatedPods): New method.  Given a ReplicaSet, return all
pods that are owned by any ReplicaSet with the same owner.
(getPodsToDelete): Add an argument for related pods.  Use related pods and
the new getPodsRankedByRelatedPodsOnSameNode function to take into account
whether a pod is doubled up when sorting pods for deletion.
(getPodsRankedByRelatedPodsOnSameNode): New function.  Return an
ActivePodsWithRanks value that wraps the given slice of pods and computes
ranks where each pod's rank is equal to the number of active related pods
that are colocated on the same node.
* pkg/controller/replicaset/replica_set_test.go (newReplicaSet): Set
OwnerReferences on the ReplicaSet.
(newPod): Set a unique UID on the pod.
(byName): New type to sort pods by name.
(TestGetReplicaSetsWithSameController): New test for
getReplicaSetsWithSameController.
(TestRelatedPodsLookup): New test for getIndirectlyRelatedPods.
(TestGetPodsToDelete): Augment the "various pod phases and conditions, diff
= len(pods)" test case to ensure that scale-down still selects doubled-up
pods if there are not enough other pods to scale down.  Add a "various pod
phases and conditions, diff = len(pods), relatedPods empty" test case to
verify that getPodsToDelete works even if related pods could not be
determined.  Add a "ready and colocated with another ready pod vs not
colocated, diff < len(pods)" test case to verify that a doubled-up pod gets
preferred for deletion.  Augment the "various pod phases and conditions,
diff < len(pods)" test case to ensure that not-ready pods are preferred
over ready but doubled-up pods.
* pkg/controller/replicaset/BUILD: Regenerate.
* test/e2e/apps/deployment.go
(testRollingUpdateDeploymentWithLocalTrafficLoadBalancer): New end-to-end
test.  Create a deployment with a rolling update strategy and affinity
rules and a load balancer with "Local" external traffic policy, and verify
that set of nodes with local endponts for the service remains unchanged
during rollouts.
(setAffinity): New helper, used by
testRollingUpdateDeploymentWithLocalTrafficLoadBalancer.
* test/e2e/framework/service/jig.go (GetEndpointNodes): Factor building the
set of node names out...
(GetEndpointNodeNames): ...into this new method.
2019-10-17 11:52:32 -04:00
Miciah Masters
865c3c5670 TestGetPodsToDelete: Use field names in test cases
* pkg/controller/replicaset/replica_set_test.go (TestGetPodsToDelete): Use
explicit field names in declarations of test cases.
2019-10-17 11:50:09 -04:00
Jan Safranek
a689697519 Do not bind block PV/PVCs when block feature gate is off 2019-10-17 12:40:22 +02:00
Kubernetes Prow Robot
bdc3f96838
Merge pull request #83989 from wojtek-t/remove_coordination_v1beta1
Swtich nodelifecyclecontroller to coordination/v1
2019-10-17 01:47:29 -07:00
Kubernetes Prow Robot
6a5f0e6eda
Merge pull request #81348 from yastij/code-org-service-controller
move service helpers to k8s.io/cloud-provider
2019-10-17 00:20:38 -07:00
Kubernetes Prow Robot
064458de46
Merge pull request #83951 from zouyee/pdbtomeb
add tombstones handle for pdb
2019-10-16 09:36:36 -07:00
Kubernetes Prow Robot
78abdf5375
Merge pull request #83902 from gongguan/remove_duplicate_code
remove duplicate code
2019-10-16 09:34:22 -07:00
Yassine TIJANI
d796baea27 move service helpers to k8s.io/cloud-provider
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-10-16 14:12:11 +02:00
wojtekt
cf9203501e Swtich nodelifecyclecontroller to coordination/v1 2019-10-16 10:59:02 +02:00
Kubernetes Prow Robot
112bdfb7c0
Merge pull request #83862 from mrbobbytables/update-controller-network-owners
Prune inactive owners from pkg/controller/* network related OWNERS files
2019-10-15 23:06:49 -07:00
zouyee
65ddf102ef add tombstoones handle for pdb
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-10-15 22:02:18 +08:00
louisgong
9b7b50c9da remove duplicate function 2019-10-15 09:41:30 +08:00
Krzysztof Siedlecki
b1dfa83be6 using pod pointers in node lifecycle controller 2019-10-14 12:44:43 +02:00
Bob Killen
e37d702208
Prune inactive owners from autoscaling related OWNERS files. 2019-10-13 08:52:14 -04:00
Bob Killen
30053bb00f
Prune inactive owners from pkg/controller/* network related OWNERS files. 2019-10-13 08:50:18 -04:00
zouyee
a864fd2100 fix unsafe JSON construction
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-10-10 09:44:54 +08:00
Kubernetes Prow Robot
a5dc1fffb0
Merge pull request #83543 from yutedz/attach-resync-comment
Remove stale comment about resyncPeriod
2019-10-09 13:17:50 -07:00
Kubernetes Prow Robot
4b002b3baa
Merge pull request #82123 from xiaoanyunfei/cleanup/take-effect-stateofworld-hashmap
replace iteration with hashmap in *state_of_world
2019-10-09 02:17:50 -07:00
Kubernetes Prow Robot
ac9390627e
Merge pull request #83536 from yutedz/del-volume-err
Log the error return from store.Delete
2019-10-08 19:59:50 -07:00
Kubernetes Prow Robot
72d052a444
Merge pull request #81797 from yastij/move-metrics-util
move util/metrics to component-base
2019-10-08 17:08:05 -07:00
Kubernetes Prow Robot
b00f009316
Merge pull request #82996 from tnqn/endpointslice-deletion
Fix EndpointSliceController service deletion processing
2019-10-08 15:42:27 -07:00
Kubernetes Prow Robot
b4489d1709
Merge pull request #82865 from tnqn/endpointslice
Fix wrong comments and inaccurate logs in endpointslice_controller
2019-10-08 15:42:16 -07:00
Yassine TIJANI
c1487840bc move util/metrics to component-base
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-10-08 14:42:31 +02:00
Ted Yu
f0a6aa1e9b Log error from AddIndexers in NewAttachDetachController 2019-10-07 16:15:25 -07:00
Kubernetes Prow Robot
9f875de5d2
Merge pull request #83540 from cofyc/fix83343
Fix volume scheduling error handling
2019-10-07 01:53:09 -07:00
Kubernetes Prow Robot
48b90db9c3
Merge pull request #83495 from tanjunchen/fix-typo
remove the repeat word in documents
2019-10-06 15:05:08 -07:00
tanjunchen
de3cf23414 remove the repeat word in documents 2019-10-06 23:32:01 +08:00
Ted Yu
b81242b62e Remove stale comment about resyncPeriod 2019-10-06 05:02:07 -07:00
Yecheng Fu
b5889ee82c update internal error message 2019-10-06 14:37:31 +08:00
Ted Yu
56717a79ff Log the error return from store.Delete 2019-10-05 19:34:39 -07:00
Kubernetes Prow Robot
e0f651a0be
Merge pull request #83501 from yastij/remove-node-cond-dep
remove Get/Set node condition dependency for the ccm controllers
2019-10-04 16:31:26 -07:00
Kubernetes Prow Robot
74dc287490
Merge pull request #83420 from yutedz/sched-assume-cache
Check the return value from store.Update
2019-10-04 10:22:18 -07:00
Kubernetes Prow Robot
7fab683455
Merge pull request #83343 from yutedz/bind-vol-err
Return proper error message when BindPodVolumes fails
2019-10-04 08:50:30 -07:00
Yassine TIJANI
356e3d0d61 remove Get/Set node condition dependency for the ccm controllers
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-10-04 16:52:36 +02:00
Ted Yu
94d4bf1287 Return proper error message when BindPodVolumes fails 2019-10-04 04:36:48 -07:00
shivi28
a0109f00df nodeipam-controller:fix static check failures 2019-10-04 12:40:09 +05:30
Ted Yu
c264338741 Check the return value from store.Update 2019-10-02 12:02:13 -07:00
Kubernetes Prow Robot
bd89dc462c
Merge pull request #83320 from krzysied/node_controller_delete_pods
Adding pods to DeletePods and MarkPodsReady methods parameters
2019-10-02 09:03:08 -07:00
Krzysztof Siedlecki
a07a3a6878 adding pods to MarkPodsNotReady parameters 2019-10-02 14:22:58 +02:00
Krzysztof Siedlecki
8f48896709 adding pods to DeletePods parameters 2019-10-02 13:11:23 +02:00
mengyang02
b116585b22 remove redundant quota.V1Equals 2019-10-02 01:02:09 +08:00
Kubernetes Prow Robot
c5440829d5
Merge pull request #83248 from krzysied/node_controller_test
Adding fakeGetPodsAssignedToNode to node lifecycle controller tests
2019-09-30 03:19:38 -07:00
Krzysztof Siedlecki
99eeab35a3 adding fakeGetPodsAssignedToNode 2019-09-30 11:03:36 +02:00
Kubernetes Prow Robot
14e5adfc85
Merge pull request #82683 from davidz627/fix/translationStruct
Refactor CSI Translation Library into a struct that is injected into various components to simplify unit testing
2019-09-29 10:11:37 -07:00
Kubernetes Prow Robot
74d2822662
Merge pull request #72535 from tallclair/content-type
Always set content-type & nosniff
2019-09-27 18:43:39 -07:00
David Zhu
92cb06a2e7 Refactor CSI Translation Library into a struct that is injected into various components to simplify unit testing in future 2019-09-27 12:59:53 -07:00
chenyaqi01
66be69bb0e replace bytes.Compare() with bytes.Equal() 2019-09-27 10:08:49 +08:00
Kubernetes Prow Robot
67d750bb28
Merge pull request #81916 from hwdef/fix-typo-pkg
fix typo in pkg
2019-09-26 08:35:24 -07:00
Kubernetes Prow Robot
d8a420c0d8
Merge pull request #82884 from krzysied/node_controller_cleanup3
NodeLifecycleContorller - eviction processing refactor
2019-09-26 04:03:08 -07:00
Kubernetes Prow Robot
37c3a4da97
Merge pull request #82855 from yutedz/alpha-node-role
Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18
2019-09-25 23:59:19 -07:00
Kubernetes Prow Robot
4096a36bfd
Merge pull request #83079 from robscott/endpointslice-owners
Adding owners for EndpointSlice controller
2019-09-25 13:52:13 -07:00
Kubernetes Prow Robot
6555c34743
Merge pull request #83022 from mm4tt/controller_ref
Optimize GetControllerOf method and add a benchmark for it
2019-09-25 13:51:14 -07:00
Matt Matejczyk
01ccd2e19e Optimize GetControllerOf method
In addition create a similar method that doesn't copy objects.

Benchmark for the new no-copy method vs the old one:
```
benchmark                       old ns/op     new ns/op     delta
BenchmarkGetControllerOf-12     214           14.8          -93.08%

benchmark                       old allocs     new allocs     delta
BenchmarkGetControllerOf-12     1              0              -100.00%

benchmark                       old bytes     new bytes     delta
BenchmarkGetControllerOf-12     80            0             -100.00%
```

Benchamrk for the new (copy) method vs the old one:
```
benchmark                       old ns/op     new ns/op     delta
BenchmarkGetControllerOf-12     128           114           -10.94%

benchmark                       old allocs     new allocs     delta
BenchmarkGetControllerOf-12     1              1              +0.00%

benchmark                       old bytes     new bytes     delta
BenchmarkGetControllerOf-12     80            80            +0.00%

```

Overall there is a 10% improvement for the old vs new (copy) method and
huge improvent (x10) for the old vs new (no-copy).

I changed the IsControlledBy and a few other methods to use the new (no-copy) method.
2019-09-25 15:07:37 +02:00
Rob Scott
30d0eca19f
Adding owners for EndpointSlice controller 2019-09-24 11:45:15 -07:00
David Eads
4b44a9f067 make namespace-lifecycle controller more responsive 2019-09-23 13:22:51 -04:00
Quan Tian
db6bbf2375 Fix EndpointSliceController service deletion processing
syncService shouldn't return error if the service doesn't exist which
means it's triggered by service deletion, otherwise the service would be
enqueued repeatedly even its cleanup has been executed successfully.

This patch makes syncService return nil if the error is NotFound when
getting the service, like the other controllers do.
2019-09-22 10:01:29 -07:00
qingsenLi
d3a0c149a3 Remove some unused codes in stateful_set_utils.go 2019-09-21 22:24:48 +08:00
Kubernetes Prow Robot
658e57a157
Merge pull request #82797 from yutedz/rel-cidr-wrong-err
Correct the error variable for releasing CIDR
2019-09-20 14:13:26 -07:00
Kubernetes Prow Robot
259d6bf608
Merge pull request #82189 from deads2k/ns-resources
add conditions for remaining object totals during ns termination
2019-09-20 01:33:00 -07:00
Kubernetes Prow Robot
5f249fecb4
Merge pull request #82363 from yuxiaobo96/k8s-update3
update spelling mistakes
2019-09-20 00:08:59 -07:00
Kubernetes Prow Robot
db1f8da036
Merge pull request #82848 from yutedz/node-ctrl-hostname
Break out of loop when NodeHostName is found
2019-09-19 18:01:13 -07:00
Kubernetes Prow Robot
73505056fb
Merge pull request #82887 from yutedz/token-cleaner-type
[v1.16.1] TokenCleaner#evalSecret should enqueue the key
2019-09-19 14:21:20 -07:00
Kubernetes Prow Robot
94987143c6
Merge pull request #82882 from liggitt/cleanup-finalizer-delete
Clean up redundant post-finalizer deletions
2019-09-19 12:50:33 -07:00
Ted Yu
fd8f2bd91f Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18 2019-09-19 12:06:55 -07:00
Kubernetes Prow Robot
d05183be41
Merge pull request #82858 from hwdef/del-unused-var
delete unused var
2019-09-19 11:05:49 -07:00
Kubernetes Prow Robot
11ce7da888
Merge pull request #82740 from hwdef/del-unuse-var1
del unuse var in pkg/controller
2019-09-19 11:05:15 -07:00
Ted Yu
1269b9e474 TokenCleaner#evalSecret should enqueue the key 2019-09-19 10:34:59 -07:00
Krzysztof Siedlecki
2f3e8463ef eviction processing refactor 2019-09-19 17:15:32 +02:00
Jordan Liggitt
000fffd3c7 Clean up redundant post-finalizer deletions 2019-09-19 10:35:58 -04:00
hwdef
4e7ef9ad36 delete unused var 2019-09-19 18:04:13 +08:00
Quan Tian
c35fd33f42 Fix wrong comments and inaccurate logs in endpointslice_controller 2019-09-19 15:02:02 +08:00
Ted Yu
68d8a5ae15 Break out of loop when NodeHostName is found 2019-09-18 16:57:39 -07:00
Shintaro Murakami
ad333ac421 Return error when failed to get storage class 2019-09-18 15:59:34 +09:00
Ted Yu
669dc0a9fd Correct the error variable for releasing CIDR 2019-09-17 09:58:08 -07:00
Kubernetes Prow Robot
2183a84feb
Merge pull request #82356 from m3ngyang/opt-podgc
optimize gc_controller.gcTerminated
2019-09-16 09:58:38 -07:00
mengyang02
b5f44d5aab optimize gc_controller.gcTerminated 2019-09-16 16:34:08 +08:00
hwdef
851eac6a97 del unuse var in pkg/controller 2019-09-16 15:05:24 +08:00
Kubernetes Prow Robot
7f084f07c3
Merge pull request #82626 from RainbowMango/pr_migrate_prom_bucket_for_volume
Migrate prometheus bucket functionality to kube-metrics for volume
2019-09-13 10:42:44 -07:00
Kubernetes Prow Robot
06609b77e8
Merge pull request #82489 from krzysied/node_controller_lock_map
Adding lock to node data map
2019-09-12 02:46:27 -07:00
Krzysztof Siedlecki
029b72b553 adding lock to node data map 2019-09-12 10:23:24 +02:00
RainbowMango
6bb1229f4b Update bazel by hack/update-bazel.sh 2019-09-12 16:05:21 +08:00
RainbowMango
d6fdac8c56 Migrate prometheus bucket functionality to kube-metrics. 2019-09-12 16:02:53 +08:00
Kubernetes Prow Robot
632e02768a
Merge pull request #82411 from josephburnett/patch-1
Fix reviewer typo.
2019-09-11 15:27:38 -07:00
Kubernetes Prow Robot
61b30b062e
Merge pull request #82329 from m3ngyang/node-ctrl-check
don't start the cloud node controller if cloudprovider.Instances is not supported
2019-09-11 15:26:08 -07:00
Kubernetes Prow Robot
1146e0c4ad
Merge pull request #82279 from deads2k/which-cert
add identification for particular certificate controllers
2019-09-11 15:25:00 -07:00
Tim Allclair
ef6cba0b36 Always set content-type & nosniff 2019-09-11 15:01:43 -07:00
Kubernetes Prow Robot
001f2cd2b5
Merge pull request #82255 from cofyc/avoid-import-cycle
volume scheduling: move metrics to a separate package to avoid import cycle
2019-09-11 10:43:20 -07:00
Tomas Nozicka
55843fc298 Add unit test for RS to correctly handle expectations on recreate 2019-09-11 16:58:29 +02:00
mengyang02
b4638519a9 init check for cloud node controller 2019-09-07 10:47:11 +08:00
David Eads
95ae353f3a squash: reaction to comments 2019-09-06 09:58:41 -04:00
David Eads
0355f4482b add conditions for remaining object totals during ns termination 2019-09-06 09:50:41 -04:00
Joseph Burnett
7bdb66f8d1
Fix reviewer typo. 2019-09-06 12:09:50 +02:00
Kubernetes Prow Robot
208cfaad25
Merge pull request #82288 from deads2k/ns-conditions
fix namespace termination conditions to be consistent and correct
2019-09-05 13:01:11 -07:00
Kubernetes Prow Robot
61ecdba9ca
Merge pull request #82289 from robscott/endpointslice-fixes
Fixing bugs related to Endpoint Slices
2019-09-05 09:03:10 -07:00
yuxiaobo
f6ce8f5789 update spelling mistakes 2019-09-05 17:59:36 +08:00
Rob Scott
8f9483d827
Fixing bugs related to Endpoint Slices
This should fix a bug that could break masters when the EndpointSlice
feature gate was enabled. This was all tied to how the apiserver creates
and manages it's own services and endpoints (or in this case endpoint
slices). Consumers of endpoint slices also need to know about the
corresponding service. Previously we were trying to set an owner
reference here for this purpose, but that came with potential downsides
and increased complexity. This commit changes behavior of the apiserver
endpointslice integration to set the service name label instead of owner
references, and simplifies consumer logic to reference that (both are
set by the EndpointSlice controller).

Additionally, this should fix a bug with the EndpointSlice GenerateName
value that had previously been set with a "." as a suffix.
2019-09-04 09:09:32 -07:00
Jonathan Basseri
c8d937c5f1 Add unit test for DisruptionController retry logic
This tests the PDB status update path in DisruptionController and
asserts that conflicting writes (with eviciton handler) are handled
gracefully.

This adds the client-go fake.Clientset into our tests, because that is
the layer required for injecting update failures.

This also adds a TestMain so that DisruptionController logs can be
enabled during test. e.g.,

    go test ./pkg/controller/disruption -v -args -v=4
2019-09-03 16:52:45 -07:00
Kubernetes Prow Robot
cedffee93e
Merge pull request #82239 from sttts/sttts-persistentvolume-controller-data-race
persistentvolume-controller: fix data race of non-deepcopied objects in fake client
2019-09-03 14:35:12 -07:00
David Eads
076bf949d7 fix namespace termination conditions to be consistent and correct 2019-09-03 15:33:17 -04:00
David Eads
e8b5781499 add identification for particular certificate controllers 2019-09-03 14:05:04 -04:00
Yecheng Fu
8a7607a308 volume scheduling: move metrics code into a separate pkg 2019-09-03 14:38:26 +08:00
Dr. Stefan Schimanski
7816ad7991 persistentvolume-controller: fix data race of non-deepcopied objects in fake client 2019-09-02 15:23:55 +02:00
Jonathan Basseri
8835f6bb00 Fix retry logic in DisruptionController
This changes the retry logic in DisruptionController so that it
reconciles update conflicts. In the old behavior, any pdb status update
failure was retried with the same status, regardless of error.

Now there is no retry logic with the status update. The error is passed
up the stack where the PDB can be requeued for processing.

If the PDB status update error is a conflict error, there are some new
special cases:
- failSafe is not triggered, since this is considered a retryable error
- the PDB is requeued immediately (ignoring the rate limiter) because we
  assume that conflict can be resolved by getting the latest version
2019-08-30 16:02:09 -07:00
Kubernetes Prow Robot
efaacf786a
Merge pull request #73405 from wozniakjan/namespace_status_conditions
Add namespace status conditions
2019-08-29 15:34:58 -07:00
Kubernetes Prow Robot
e6b6e4038c
Merge pull request #81601 from yastij/remove-keyfun
use DeletionHandlingMetaNamespaceKeyFunc from client-go in service_controller
2019-08-29 09:30:09 -07:00
Kubernetes Prow Robot
d6bc4eb853
Merge pull request #81624 from logicalhan/cm-migration
migrate controller-manager metrics to stability framework
2019-08-29 05:30:09 -07:00
Jan Wozniak
b0459feb7d Update generated files
make generated_files UPDATE_API_KNOWN_VIOLATIONS=true
./hack/update-generated-protobuf.sh
./hack/update-openapi-spec.sh
./hack/update-bazel.sh
./hack/update-generated-swagger-docs.sh
./hack/update-generated-api-compatibility-data.sh
2019-08-29 13:26:13 +02:00
sunxiaofei03
45d41ed9e5 replace iteration with hashmap in *state_of_world 2019-08-29 19:22:25 +08:00
Jan Wozniak
035e648fd7 Add tests for namespace status conditions 2019-08-29 13:21:15 +02:00
Jan Wozniak
94a5e8c3dc Add status conditions to namespaces 2019-08-29 13:21:15 +02:00
Yassine TIJANI
3fe7a57000 use directly DeletionHandlingMetaNamespaceKeyFunc from client-go
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-29 11:51:14 +01:00
Rob Scott
75f6c24923
Adding EndpointSlice controller 2019-08-28 21:13:27 -07:00
Kubernetes Prow Robot
550fb1bfc3
Merge pull request #79386 from khenidak/phase2-dualstack
Phase 2 dualstack
2019-08-28 20:39:56 -07:00
Kubernetes Prow Robot
af54eae69a
Merge pull request #81612 from rikatz/issue81060
Remove watching Endpoints of Headless Services
2019-08-28 14:44:25 -07:00
Han Kang
59db3ac27e migrate controller-manager metrics to stability framework 2019-08-28 12:26:57 -07:00
Kubernetes Prow Robot
92a320aeb6
Merge pull request #80238 from smarterclayton/disable_node_role
Clarify use of node-role labels within Kubernetes
2019-08-28 12:01:27 -07:00
Khaled Henidak(Kal)
c27e0b029d phase 2: generated items 2019-08-28 16:11:46 +00:00
Khaled Henidak(Kal)
313a5c5734 phase 2: ipam filter secondary service cidr 2019-08-28 15:59:43 +00:00
Khaled Henidak(Kal)
93c06821e6 Phase 2: service and endpoint processing 2019-08-28 15:59:43 +00:00
Kubernetes Prow Robot
a927ed454c
Merge pull request #81576 from logicalhan/scheduler-migration
migrate scheduler metrics to stability framework
2019-08-28 08:55:12 -07:00
Clayton Coleman
a49a554211
Move the IsMasterNode function to tests and mark it Deprecated
A future change will stop using this signal and instead use a
label selector passed on creation.
2019-08-28 11:17:27 -04:00
Clayton Coleman
2888e6e923
Node lifecycle controller should use a label for excluding nodes
The current mechanism for excluding "master" nodes based on node names
is fragile and should be fixed by using a label exclusion similar to
service load balancers. The legacy code path is preserved behind a
defaulted-on gate and will be removed in the future.
2019-08-28 10:29:08 -04:00
Clayton Coleman
0f49d892d5
Service controller should begin moving away from node-role labels
The service load balancer controller should honor the
LegacyNodeRoleBehavior feature gate for checks that use node-roles,
switch to using a non alpha annotation behind the gate, and prepare
to graduate to beta.
2019-08-28 10:29:08 -04:00
Kubernetes Prow Robot
bdfc8f62b4
Merge pull request #81949 from yastij/remove-ftg-name-dep
remove dependency to pkg/features on service controller package
2019-08-28 05:12:15 -07:00
Han Kang
8da448dbe3 migrate scheduler metrics endpoint to metrics stability framework 2019-08-28 03:40:43 -07:00
Kubernetes Prow Robot
ab13cf1055
Merge pull request #81691 from MrHohn/svc-finalizer-beta
Promote service load balancer finalizer to Beta
2019-08-27 19:37:48 -07:00
Yassine TIJANI
19fa57bca3 remove dependency to pkg/features on service controller package
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-27 18:00:10 +01:00
Kubernetes Prow Robot
4e83be80b1
Merge pull request #81844 from yastij/remove-slice-dep
remove slice dependency from service_controller
2019-08-27 09:25:24 -07:00
Yassine TIJANI
6ad40ba51f remove slice dependency
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-27 11:26:06 +01:00
Kubernetes Prow Robot
927f45191e
Merge pull request #81527 from yastij/move-controller-util
move WaitForCacheSync to the sharedInformer package
2019-08-27 00:52:54 -07:00
hwdef
9b3f577b1d fix typo in pkg 2019-08-26 09:25:39 +08:00
Kubernetes Prow Robot
9ae0963fb7
Merge pull request #81839 from krzysied/node_controller_pod_informer
Moving podInformer to node controller scope
2019-08-23 15:48:53 -07:00
Krzysztof Siedlecki
07b039862b moving podInformer to node controller scope 2019-08-23 15:59:59 +02:00
Kubernetes Prow Robot
9c69a45b52
Merge pull request #81808 from dims/drop-azure-go-autorest-from-pkg/controller
Drop Azure/go-autorest from pkg/controller
2019-08-23 06:54:02 -07:00
Kubernetes Prow Robot
e232921c1f
Merge pull request #80353 from BenTheElder/tags
simulate in-tree cloud provider removal with a build tag
2019-08-23 04:55:31 -07:00
Kubernetes Prow Robot
b8f4f27eda
Merge pull request #81680 from sadlil/sadlil/fix-static-check-volume-controller
volume-controller: fix static check failures
2019-08-22 22:03:44 -07:00
Benjamin Elder
5a3301a59d s/nolegacyproviders/providerless/ 2019-08-22 15:30:56 -07:00
Benjamin Elder
ece112524b hack/update-bazel.sh 2019-08-22 14:53:35 -07:00
Benjamin Elder
678d3f2841 add build tags to legacy provider code and make it possible to build kube-controller-manager without any legacyproviders or without particular legacy providers 2019-08-22 14:53:35 -07:00
Davanum Srinivas
4e4c38bbbe
Drop Azure/go-autorest from pkg/controller 2019-08-22 17:34:50 -04:00
Yassine TIJANI
7e4c3096fe move WaitForCacheSync to the sharedInformer package
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-08-22 16:13:41 +01:00
Zihong Zheng
0a7c085b14 Check service finalizer on upgrade test and fix-up test cases 2019-08-21 15:19:56 -07:00
Ricardo Pchevuzinske Katz
e389237171 Remove watching Endpoints of Headless Services
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@serpro.gov.br>
2019-08-21 16:37:09 -03:00
Krzysztof Siedlecki
6842e11f7e removing redundant code 2019-08-21 17:22:06 +02:00
Sadlil Rhythom
7a8eaf4561 controller:volume fix static check failures 2019-08-21 09:37:42 +02:00
Kubernetes Prow Robot
d987e6353e
Merge pull request #81019 from josephburnett/hparunawaytest-review
Test more replicas than spec.
2019-08-20 00:15:47 -07:00
Kubernetes Prow Robot
60ca3c8a57
Merge pull request #80585 from gongguan/check_svcCIDR_contains_clusterCIDR
check whether serviceCIDR contains clusterCIDR during ipam initialization
2019-08-17 12:08:06 -07:00
louisssgong
3a58cdd1c1 check clusterCIDR after occupy serviceCIDR 2019-08-17 09:47:34 +08:00
Kubernetes Prow Robot
7420bb2214
Merge pull request #80492 from matte21/pvc-protection-controller-fix-issue-75980
Add live list of pods to PVC protection controller to make sure it does not delete a PVC which is being used by a Pod
2019-08-16 05:06:44 -07:00
Kubernetes Prow Robot
22dc60e1a7
Merge pull request #81444 from AllenZMC/patch-3
fix some typos in testing.go and recycle_test.go
2019-08-15 23:08:59 -07:00
Kubernetes Prow Robot
273e9262bb
Merge pull request #80342 from draveness/feature/remove-critical-pod-annotation
feat: cleanup pod critical pod annotations feature
2019-08-15 07:20:34 -07:00
czm
cdcf1c0ea2 fix some typos in recycle_test.go 2019-08-15 11:34:46 +08:00
Kubernetes Prow Robot
e552806753
Merge pull request #81361 from oxddr/kubeproxy-moar-logging
kube-proxy: do not export network programming latency for deleted Endpoints
2019-08-14 16:52:49 -07:00
matte21
1371490bd6 Lowercase first letter of chainable errors in PVC protection controller
Lowercase first letter of error messages that are not printed right
away to ease chaining with other error messages in PVC protection
controller.
2019-08-15 00:46:02 +02:00
matte21
791d1c81f0 Add live list of pods to PVC protection controller
Add live list of pods to PVC protection controller, as opposed to doing
only a cache-based list through the Informer. Both lists are performed
while processing a PVC with deletionTimestamp set to check whether Pods
using the PVC exist and remove the finalizer to enable deletion of the
PVC if that's not the case. Prior to this commit only the cache-based
list was done but that's unreliable because a pod using the PVC might
exist but not be in the cache just yet. On the other hand, the live
list is 100% reliable.

Note that it would be enough to do only the live list. Instead, this
commit adds it after the cache-based list and performs it only if the
latter finds no Pod blocking deletion of the PVC being processed. The
rationale is that live lists are expensive and it's desirable to
minimize them. The drawback is that if at the time of the cache-based
list the cache has not been notified yet of the deletion of a Pod using
the PVC the PVC is kept. Correctness is not compromised because the
finalizer will be removed when the Pod deletion notification is
received, but this means PVC deletion is delayed. Reducing live lists
was valued more than deleting PVCs slightly faster.

Also, add a unit test that fails without the change introduced by this
commit and revamp old unit tests. The latter is needed because expected
behavior is described in terms of API calls the controller makes, and
this commit introduces new API calls (the live lists).
2019-08-15 00:46:02 +02:00
AllenZMC
d266b79a39
fix some typos in testing.go 2019-08-14 20:53:24 +08:00
Janek Łukaszewicz
e52110edcd kube-proxy: do not export network programming latency for deleted enpoints. 2019-08-14 14:00:07 +02:00
Kubernetes Prow Robot
2e72cdd7b1
Merge pull request #81081 from p0lyn0mial/gc_transition_delete
changes the way `gc` detect that an object needs to be deleted
2019-08-13 02:28:33 -07:00
Lukasz Szaszkiewicz
2d81cee900 changes the way gc detect that an object needs to be deleted
before this change, an object would be added to `attemptToDelete` queue only if `gc` detected the transition, simply by check if `deletionTimestamp` was set. After the change, it will check if `foregroundDeletion` finalizer has been set before adding the item to the queue.
2019-08-12 10:52:43 +02:00
Travis Rhoden
4574473753
Rename mount.NewOsExec to mount.NewOSExec 2019-08-09 12:30:56 -06:00
draveness
495faa22db feat: cleanup pod critical pod annotations feature 2019-08-09 08:41:23 +08:00
Kubernetes Prow Robot
ef8869466c
Merge pull request #80978 from wojtek-t/selflink_deprecation
Deprecate SelfLink and introduce feature gate to disable its propagation
2019-08-08 03:47:20 -07:00
wojtekt
399d09ce4a Fix GetReference function 2019-08-07 16:49:29 +02:00
Joseph Burnett
a5354d04bb Test more replicas than spec.
During a Deployment update there may be more Pods in the scale target
ref status than in the spec. This test verifies that we do not scale
to the status value. Instead we should stay at the spec value.

Fails before #79035 and passes after.
2019-08-06 14:46:34 +02:00
Kubernetes Prow Robot
f2cfc160ef
Merge pull request #80273 from tallclair/endpoints
Don't delete service endpoints when a generic error occurs
2019-08-05 18:17:54 -07:00
Kubernetes Prow Robot
decdf8891f
Merge pull request #80460 from mrkm4ntr/pvc-class-name
Use v1helper.GetPersistentVolumeClaimClass for compatibility
2019-08-05 15:08:30 -07:00
Kubernetes Prow Robot
9e735d6b27
Merge pull request #79443 from tedyu/taint-mgr-name
Simplify checking in getMinTolerationTime
2019-08-05 15:08:03 -07:00
Ted Yu
c811b2267f Simplify checking in getMinTolerationTime 2019-08-05 10:45:05 -07:00
Kubernetes Prow Robot
d9a411df6b
Merge pull request #80660 from prameshj/ilb-err
Handle NotImplemented error in service_controller.
2019-08-02 22:39:51 -07:00
Pavithra Ramesh
ecad65a3f8 Added comment after invoking ensureLoadBalancer 2019-08-02 11:24:24 -07:00
Pavithra Ramesh
da887e85e9 Updated comment about ImplementedElsewhere
Removed handling ImplementedElsewhere error in call to EnsureLoadBalancerDeleted.
2019-08-02 10:54:09 -07:00
Pavithra Ramesh
987677c201 Setting log level to 4 since default is 2 or 3.
Depending on how the cluster is created. Test clusters set a default
level of 4.
2019-08-02 10:54:09 -07:00
Pavithra Ramesh
dbfc876e83 Fixed review comments, lint.
Added error check to EnsureLoadBalancerDeleted.
2019-08-02 10:54:09 -07:00
Pavithra Ramesh
d4210b94e2 addressed review comments 2019-08-02 10:54:09 -07:00
Pavithra Ramesh
d79d4e8525 Handle ImplementedElsewhere error in service_controller
This is used when the cloudprovider layer is not implementing loadBalancer service.
Implementation will be in a different controller running on master.
2019-08-02 10:54:09 -07:00
Kubernetes Prow Robot
c981c65c90
Merge pull request #80231 from liggitt/admissionreview-v1
Promote admissionreview to v1
2019-08-01 17:20:05 -07:00
Kubernetes Prow Robot
3287bf7a3a
Merge pull request #80859 from wojtek-t/fix_selflinks_in_tests
Fix selflinks in tests
2019-08-01 15:01:30 -07:00
Jordan Liggitt
44930fc939 AdmissionReview: Install/register 2019-08-01 17:17:42 -04:00
Kubernetes Prow Robot
b658028078
Merge pull request #77713 from zjj2wry/secret_resync_duration
add secret back to the workqueue with delay time, avoid expired bootstrap tokens not being deleted
2019-08-01 09:46:29 -07:00
wojtekt
bc00248e71 Fix selflinks in tests 2019-08-01 15:50:03 +02:00
YueHonghui
d29f194474 add flag concurrent-statefulset-syncs to kube-controller-manager (#79169)
* add flag `concurrent-statefulset-syncs` to set number of concurrent workers for statefulset controller

* change default value of ConcurrentStatefulSetSyncs from 1 to 5

* 1. fix doc comment of statefulset config types.go
2. add missing deps k8s.io/kubernetes/pkg/controller/statefulset/config

* add missing dep k8s.io/kubernetes/pkg/controller/statefulset/config/v1alpha1

* updated bazel BUILD files

* update kube-controller-manager options testcase

* fix codegen

* fix golint error

* fix testcase
2019-07-31 22:36:14 -07:00
zhengjiajin
5c1815abb7 add secret back to the workqueue with delay time, avoid expired bootstrap tokens not being deleted 2019-08-01 10:44:31 +08:00
Tim Allclair
8fc988e7dd Unit test endpoints controller service deletion 2019-07-31 16:10:09 -07:00
Tim Allclair
b2a02140db Don't delete service endpoints when a generic error occurs 2019-07-31 15:10:14 -07:00
Shintaro Murakami
4635f16dc1 Add missing error check 2019-07-29 14:37:48 +09:00
RainbowMango
0e0e1f7dab 1. Fix lint errors for the whole directory staging/src/k8s.io/client-go/tools/cache;
2. Remove staging/src/k8s.io/client-go/tools/cache from .golint_failures;
3. Fix some typo from comments.
2019-07-27 15:49:03 +08:00
Kubernetes Prow Robot
44de947f0f
Merge pull request #80509 from mborsz/endpoints
Add simple pod updates batching to endpoint controller.
2019-07-26 20:16:36 -07:00
Kubernetes Prow Robot
6f8944aa54
Merge pull request #79696 from yittg/fix-pv-controller-affinity
fix pv-controller sync check node affinity for scheduled claim
2019-07-26 20:15:58 -07:00
Kubernetes Prow Robot
368ee4bb8e
Merge pull request #79068 from tedyu/dc-skipped-pods
Remove unnecessary loop for lowering expectations
2019-07-26 14:01:59 -07:00
Kubernetes Prow Robot
d5d6061c8e
Merge pull request #80476 from matte21/fix-pvcs-leaks
PVC protection controller: fix PVC leaks
2019-07-26 05:31:59 -07:00
matte21
b4fed83a4a PVC protection controller: get rid of PVC leaks
Make the PVC protection controller robust to cases where a Pod X is deleted,
then a Pod Y with the same namespaced name is created and the two events are
delivered via a single update notification. Both pods should be processed,
because X might be blocking deletion of a PVC which is not referenced by Y.
Prior to this commit only the newer pod is processed, which means that it
is possible to leak PVCs.

Also, add unit tests to reflect the change.
2019-07-26 11:17:17 +02:00
Yi Tang
8c13f9dea3 fix pv controller not find pv for pvc provisioning 2019-07-26 16:24:30 +08:00
Kubernetes Prow Robot
bf2dd03083
Merge pull request #80318 from davidxia/fix-err-caps
cleanup: fix some log and error capitalizations
2019-07-25 10:41:28 -07:00
AllenZMC
852040c036
fix typos in pv_controller.go
make code kinda more readable
2019-07-25 11:28:19 +08:00
Maciej Borsz
d96f24262d Autogenerated files 2019-07-24 11:36:53 +02:00
Maciej Borsz
2fae3cbcfe Add simple batching to endpoints controller 2019-07-24 11:36:53 +02:00
Kubernetes Prow Robot
bbdd0557b6
Merge pull request #78170 from DaiHao/daemon
ignore failed pods to not block rolling update daemonset
2019-07-23 21:36:14 -07:00
Shintaro Murakami
c94e800008 Use v1helper.GetPersistentVolumeClaimClass for compatibility 2019-07-24 10:35:00 +09:00
David Xia
fabfd950b1
cleanup: fix some log and error capitalizations
Part of https://github.com/kubernetes/kubernetes/issues/15863
2019-07-20 18:26:16 -04:00
Kubernetes Prow Robot
664edf8327
Merge pull request #79408 from seans3/move-kubectl-scheme
Move kubectl scheme
2019-07-19 16:08:55 -07:00
Kubernetes Prow Robot
49f6510d9a
Merge pull request #80277 from draveness/feature/revert-cleanup-critical-pod
Revert "feat: cleanup pod critical pod annotations feature"
2019-07-18 19:31:37 -07:00
Sean Sullivan
67140f13fe Updated dependencies: BUILD/modules.txt 2019-07-18 15:43:26 -07:00
Sean Sullivan
140c62cd4c Update all imports to scheme in staging 2019-07-18 15:32:27 -07:00
Kubernetes Prow Robot
8d4c49faae
Merge pull request #80088 from ZP-AlwaysWin/dev01
Fix golint failure in pkg/controller/volume/expand
2019-07-18 09:52:12 -07:00
draveness
d83526d253 Revert "feat: cleanup pod critical pod annotations feature"
This reverts commit b6d41ee5cc.
2019-07-18 13:31:12 +08:00
Kubernetes Prow Robot
91e17af5ff
Merge pull request #80263 from tedyu/job-ctrl-early
Skip unnecessary operations if diff is <= 0
2019-07-17 21:28:48 -07:00
Kubernetes Prow Robot
c23a031bb4
Merge pull request #79060 from tedyu/dc-check-err
Check error return from MetaNamespaceKeyFunc
2019-07-17 19:34:10 -07:00
Ted Yu
898f099346 Skip unnecessary operations if diff is less than 0 2019-07-17 14:03:08 -07:00
Kubernetes Prow Robot
601b7935ff
Merge pull request #79971 from mrkm4ntr/fix-pv-existence-check
Add check to reduce orphaned volume
2019-07-17 12:20:12 -07:00
Ted Yu
c429b7d3e4 Handle error return from MetaNamespaceKeyFunc 2019-07-17 10:52:23 -07:00
ZP-AlwaysWin
1573be94ae fix pkg/controller/volume/expand/pvc_populator.go 2019-07-17 09:00:24 +08:00
Kubernetes Prow Robot
5ece88c4c8
Merge pull request #74526 from DXist/feature/hpa-scale-to-zero
Support scaling HPA to/from zero pods for object/external metrics
2019-07-16 10:11:24 -07:00
Rinat Shigapov
d55f037b7d HPA scale-to-zero for custom object/external metrics
Add support for scaling to zero pods

minReplicas is allowed to be zero

condition is set once

Based on https://github.com/kubernetes/kubernetes/pull/61423

set original valid condition

add scale to/from zero and invalid metric tests

Scaling up from zero pods ignores tolerance

validate metrics when minReplicas is 0

Document HPA behaviour when minReplicas is 0

Documented minReplicas field in autoscaling APIs
2019-07-16 08:46:21 -05:00
Kubernetes Prow Robot
12f36302f9
Merge pull request #78361 from tedyu/stateful-get-rev
Break out of loop when currentRevision is found in defaultStatefulSetControl#getStatefulSetRevisions
2019-07-15 12:37:23 -07:00
Joseph Burnett
7382fa464d Add josephburnett to podautoscaler OWNERS. 2019-07-12 10:20:16 +02:00
Kubernetes Prow Robot
642a06e552
Merge pull request #79554 from draveness/feature/remove-critical-pod-annotation
feat: cleanup pod critical pod annotations feature
2019-07-11 22:03:04 -07:00
Kubernetes Prow Robot
3dd8add5d2
Merge pull request #79549 from liggitt/admission-webhooks-v1
Promote admission webhook API to v1
2019-07-11 17:01:34 -07:00
Clayton Coleman
d631f9b7e9
Use metadata informers instead of dynamic informers in controller manager
All controllers in controller-manager that deal with objects generically
work with those objects without needing the full object. Update the GC
and quota controller to use PartialObjectMetadata input objects which
is faster and more efficient.
2019-07-11 12:18:52 -04:00
Clayton Coleman
637cc83341
Switch the garbage collector to use metadata client and protobuf 2019-07-11 12:18:51 -04:00
Kubernetes Prow Robot
b500c740ee
Merge pull request #79859 from sukeesh/hpa-error-log-fix
HPA incorrectly reported condition status
2019-07-11 07:28:55 -07:00
Shintaro Murakami
7c0b33e012 Add check to reduce orphaned volume 2019-07-11 16:31:56 +09:00
Kubernetes Prow Robot
ca6cc69bd4
Merge pull request #78744 from smarterclayton/client_ns
Update namespace controller to use the metadata client
2019-07-10 18:48:53 -07:00
draveness
b6d41ee5cc feat: cleanup pod critical pod annotations feature 2019-07-11 08:54:19 +08:00
Kubernetes Prow Robot
57eef32041
Merge pull request #79657 from josephburnett/hpastuck
Ignore unschedulable pods
2019-07-10 11:34:29 -07:00
Clayton Coleman
50fd47258d
Switch the namespace controller to use the metadata client
The metadata client uses protobuf and returns only a subset of object
data (the metadata) which allows operations that act only on objects
generically to work much faster. Use the metadata client in the
namespace controller to reduce the amount of work the namespace controller
has to do in large namespaces.
2019-07-10 14:31:18 -04:00
Joseph Burnett
80e279d353 Ignore pending pods.
This change adds pending pods to the ignored set first before
selecting pods missing metrics. Pending pods are always ignored when
calculating scale.

When the HPA decides which pods and metric values to take into account
when scaling, it divides the pods into three disjoint subsets: 1)
ready 2) missing metrics and 3) ignored. First the HPA selects pods
which are missing metrics. Then it selects pods should be ignored
because they are not ready yet, or are still consuming CPU during
initialization. All the remaining pods go into the ready set. After
the HPA has decided what direction it wants to scale based on the
ready pods, it considers what might have happened if it had the
missing metrics. It makes a conservative guess about what the missing
metrics might have been, 0% if it wants to scale up--100% if it wants
to scale down. This is a good thing when scaling up, because newly
added pods will likely help reduce the usage ratio, even though their
metrics are missing at the moment. The HPA should wait to see the
results of its previous scale decision before it makes another
one. However when scaling down, it means that many missing metrics can
pin the HPA at high scale, even when load is completely removed. In
particular, when there are many unschedulable pods due to insufficient
cluster capacity, the many missing metrics (assumed to be 100%) can
cause the HPA to avoid scaling down indefinitely.
2019-07-10 12:16:33 +02:00
Kubernetes Prow Robot
abe94ce9b3
Merge pull request #79937 from mm4tt/deployment_improve
Deployment Controller - avoid unnecessary copying of pod objects in getPodMapForDeployment
2019-07-10 01:24:25 -07:00
Matt Matejczyk
8140bbc4f5 Deployment Controller - don't copy pods in getPodMapForDeployment
As the benchmark shows it speeds up the method~x4 and reduces memory
consumption ~x20.

```
benchmark                              old ns/op     new ns/op     delta
BenchmarkGetPodMapForDeployment-12     276121        72591         -73.71%

benchmark                              old allocs     new allocs     delta
BenchmarkGetPodMapForDeployment-12     241            238            -1.24%

benchmark                              old bytes     new bytes     delta
BenchmarkGetPodMapForDeployment-12     554025        28956         -94.77%
```
2019-07-10 09:14:15 +02:00
Kubernetes Prow Robot
dc8829df5c
Merge pull request #75922 from humblec/stateful_set
Remove unwanted `else` block from statefulset controller.
2019-07-10 00:12:25 -07:00
Kubernetes Prow Robot
d59a603f1b
Merge pull request #78267 from mucahitkurt/cleanup/operation-generator-migration-scenarios-unit-tests
unit tests for operationGenerator.GenerateUnmapVolumeFunc
2019-07-09 18:20:25 -07:00
Matt Matejczyk
3e363c5c46 Add micro-benchmark for DeploymentController.getPodMapForDeployment method 2019-07-09 15:00:18 +02:00
Kubernetes Prow Robot
2cfd4a5eb9
Merge pull request #79168 from tnozicka/fix-sigapps-owners
Update Sig-Apps OWNERS to aliases in places that were missed in #76669
2019-07-08 17:30:01 -07:00
Jordan Liggitt
e24377f190 Install/register v1 admission registration types 2019-07-08 09:49:29 -04:00
Sukeesh
44c3f0105f fix incorrect hpa status 2019-07-08 17:27:38 +09:00
Kubernetes Prow Robot
a33840e023
Merge pull request #73977 from khenidak/ipv6dualstack
ipv6 dual stack (Phase 1 - ALPHA)
2019-07-02 18:07:12 -07:00
Khaled Henidak(Kal)
2b77667718 vendor updates 2019-07-02 22:26:26 +00:00
Kubernetes Prow Robot
cf7662d3a1
Merge pull request #79035 from josephburnett/hparunaway
Fix HPA feedback from writing status.replicas to spec.replicas.
2019-07-02 09:31:08 -07:00
Khaled Henidak(Kal)
a51b8ce456 route controller + azure v6 routes 2019-07-02 15:39:06 +00:00
Khaled Henidak(Kal)
584d7103e2 node ipam controller for ipv6 dualstack 2019-07-02 15:39:06 +00:00
Joseph Burnett
39c4875321 There are various reasons that the HPA will decide not the change the
current scale. Two important ones are when missing metrics might
change the direction of scaling, and when the recommended scale is
within tolerance of the current scale.

The way that ReplicaCalculator signals it's desire to not change the
current scale is by returning the current scale. However the current
scale is from scale.Status.Replicas and can be larger than
scale.Spec.Replicas (e.g. during Deployment rollout with configured
surge). This causes a positive feedback loop because
scale.Status.Replicas is written back into scale.Spec.Replicas,
further increasing the current scale.

This PR fixes the feedback loop by plumbing the replica count from
spec through horizontal.go and replica_calculator.go so the calculator
can punt with the right value.
2019-07-02 14:21:32 +02:00
Kubernetes Prow Robot
f56b336976
Merge pull request #79592 from tedyu/ctrl-exp-mutex
Move population of expectedUIDs outside lock
2019-07-01 09:43:34 -07:00
Ted Yu
6db618fa42 Move population of expectedUIDs outside lock 2019-07-01 21:26:34 +08:00
Kubernetes Prow Robot
b22e48f240
Merge pull request #79584 from tedyu/pv-ctrl-bind-vol
Drop unnecessary claim parameter from PersistentVolumeController#updateBindVolumeToClaim
2019-07-01 06:09:33 -07:00
Kubernetes Prow Robot
d48f123a40
Merge pull request #79591 from tedyu/ctrl-util-label
Simplify the check of presence of labels in createPods
2019-07-01 01:45:19 -07:00
Ted Yu
69aeabc397 Simplify the check of presence of labels in createPods 2019-07-01 15:32:28 +08:00
Ted Yu
a18633427b Drop unnecessary claim parameter from PersistentVolumeController#updateBindVolumeToClaim 2019-07-01 13:30:11 +08:00
Kubernetes Prow Robot
8865cb3c24
Merge pull request #78853 from tcmichael/bugfix
Fix a bug that StatefulSet applies the revision incorrectly
2019-06-29 20:43:21 -07:00
kanchairen
bf421ae560 Fix a bug that StatefulSet applies the revision incorrectly 2019-06-30 09:49:00 +08:00
wojtekt
cba13eb9ad Autogenerate code 2019-06-29 15:26:09 +02:00
wojtekt
fd819f8fdc Move APIObjectVersioner 2019-06-28 21:16:49 +02:00
Hongcai Ren
9618d1d955 Fix service controller not release loadBalancer issue in corner case. 2019-06-27 09:12:16 +08:00
Kubernetes Prow Robot
eed7af6e41
Merge pull request #79370 from mborsz/node
Use watch in TaintManager
2019-06-26 06:49:17 -07:00
Maciej Borsz
98e9c78c13 Migrate TaintManager to use watch for listing pods instead of expensive
listing pods call.
2019-06-26 13:35:59 +02:00
Kubernetes Prow Robot
41b817b92f
Merge pull request #79038 from yastij/move-jws
move jws to k8s.io/cluster-bootstrap
2019-06-25 17:01:29 -07:00
Kubernetes Prow Robot
a78ae4ba74
Merge pull request #76059 from tedyu/master
Remove unnecessary map in cleanupHistory
2019-06-25 05:24:35 -07:00
Yassine TIJANI
d3620dfa29 move jws to k8s.io/cluster-bootstrap
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
2019-06-25 13:48:13 +02:00
Kubernetes Prow Robot
6f0f62b2c4
Merge pull request #77211 from dixudx/bootstrap_token_refactor
Bootstrap token refactor
2019-06-24 13:36:36 -07:00
Kubernetes Prow Robot
bc70f33e3a
Merge pull request #79294 from tedyu/svc-ctrl-lock
Use RWMutex to improve locking for serviceCache
2019-06-24 11:24:28 -07:00
Ted Yu
e86b0d3cd3 Use RWMutex to improve locking for serviceCache 2019-06-22 06:49:40 -07:00
Kubernetes Prow Robot
4b8a1163aa
Merge pull request #77712 from Sn0rt/check-target-port-check
service controller: if targetPort has changed will process by cloud-p…
2019-06-21 18:52:12 -07:00
guohaowang
d41f7b99ef service controller: if targetPort has changed will process by cloud-provider
Signed-off-by: guohaowang <wangguohao.2009@gmail.com>
2019-06-21 15:26:45 +08:00
Hongcai Ren
fa80c0072a Remove redundant initilization for service controller 2019-06-21 11:38:36 +08:00
Di Xu
5056161d4d auto-generated 2019-06-20 17:06:26 +08:00
Di Xu
af9ae4c11a refactor bootstrap token utils 2019-06-20 15:43:44 +08:00
Kubernetes Prow Robot
8d8c54bd73
Merge pull request #79082 from timoreimann/delete-unused-service-controller-load-balancer-name-method
Remove unused ServiceController.loadBalancerName method
2019-06-19 18:37:13 -07:00
Tomas Nozicka
d4261ba741 Update Sig-Apps OWNERS in places that were missed in #76669 2019-06-19 15:36:16 +02:00
Hongcai Ren
f0fae66001 Minor change: delete unused constant from service controller 2019-06-18 15:45:34 +08:00
Kubernetes Prow Robot
541cc51c7d
Merge pull request #72809 from hanxiaoshuai/fix0111
when SessionAffinityConfig is different, enqueueService in update Service handler
2019-06-17 05:54:09 -07:00
Timo Reimann
77c9950098 Remove unused ServiceController.loadBalancerName method
Its only caller lives in the corresponding test file. Hence, we move the
method called by loadBalancerName over to the test and remove
loadBalancerName.
2019-06-17 00:45:22 +02:00
Ted Yu
9c5f311eff Remove unnecessary loop for lowering expectations 2019-06-15 08:11:46 -07:00
Kubernetes Prow Robot
1782653fe8
Merge pull request #78974 from DaiHao/daemon_controller
fix a bug that pods not be deleted from unmatched nodes by daemon controller
2019-06-15 03:46:11 -07:00
Kubernetes Prow Robot
f20fb80aaa
Merge pull request #78911 from tedyu/list-pv
Do not add non-PersistentVolume to return value for pvAssumeCache#ListPVs
2019-06-14 23:06:47 -07:00
Kubernetes Prow Robot
6e1d8a8fac
Merge pull request #78821 from jhedev/fix/typo_node_lifecycle_controller
Fix typo in node lifecycle controller
2019-06-14 20:46:36 -07:00
Kubernetes Prow Robot
95e3a2576b
Merge pull request #78650 from cwdsuzhou/gc_graph_common
Merge similar funcs
2019-06-14 11:53:02 -07:00
Mario Valderrama
6ac7421535 Update comments 2019-06-14 14:23:13 +02:00
Kubernetes Prow Robot
5777fdfe31
Merge pull request #78105 from cwdsuzhou/narrow_down_lock
Narrow down the lock
2019-06-14 04:08:23 -07:00
daihao
6c0e35d7b2 do not delete pods whose deletiontimestamp != nil 2019-06-13 17:47:52 +08:00
Mario Valderrama
dbbe68601f Fix golint errors in pkg/controller/job 2019-06-12 20:09:57 +02:00
Ted Yu
f3c90b058c Do not add non-PersistentVolume to return value for pvAssumeCache#ListPVs 2019-06-11 10:27:26 -07:00
Mucahit Kurt
db1c07750a unit tests for the volume plugin name that's used inside GeneratedUnmapVolumeFunc for csi migration on/off scenarios
Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
2019-06-11 08:32:25 +03:00
Joel Hermanns
4977aa0ceb Fix typo in node lifecycle controller 2019-06-09 11:57:37 +02:00
Kubernetes Prow Robot
602fc4771a
Merge pull request #78725 from waynepeking348/waynepeking348-master
fix bug of replica_calculator to initialize replicaCount with currentReplicas
2019-06-06 10:48:27 -07:00
waynepeking348
b8b1720f12 Fix bug of ObjectPerPodMetricReplicas to initialize replicaCount with currentReplicas 2019-06-05 11:54:03 +00:00
Kubernetes Prow Robot
88f8c785b4
Merge pull request #78711 from MrHohn/lb-finalizer-patch-err
Don't mask k8s error returned from patch
2019-06-04 22:31:52 -07:00
Zihong Zheng
89a7a35607 Don't mask k8s error returned from patch 2019-06-04 16:40:51 -07:00
Jordan Liggitt
6a7e7fc156 Fix TestStressingCascadingDeletion flake 2019-06-04 17:26:36 -04:00
caiweidong
0989bfee95 merge common funcs 2019-06-04 16:37:42 +08:00
Kubernetes Prow Robot
9f85c5c4b5
Merge pull request #78503 from gjtempleton/Multiple-Metrics-HPA
Multiple metrics hpa
2019-06-03 19:34:59 -07:00
Kubernetes Prow Robot
ac458e9d89
Merge pull request #78581 from andrewsykim/route-rate-limit
route controller: respect rate limit for delete
2019-06-01 12:13:07 -07:00
Kubernetes Prow Robot
bc32307314
Merge pull request #78262 from MrHohn/svc-finalizer-cleanup2
Add Service Load Balancer finalizer support
2019-05-31 22:02:59 -07:00
Kubernetes Prow Robot
b3c1bbb471
Merge pull request #78061 from yuxiangqian/metrics
Enhance to record more accurate e2e provision/deletion latency metric
2019-05-31 20:45:13 -07:00
Kubernetes Prow Robot
6feea43bcc
Merge pull request #77475 from liucimin/fix_cronjob_controller_pageerr
Fix cronjob controller page list err
2019-05-31 12:22:40 -07:00
Andrew Sy Kim
380c6cbd0d route controller: respect rate limit for delete
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
Co-authored-by: Khaled Henidak <khnidk@microsoft.com>
2019-05-31 08:26:36 -04:00
wangqingcan
52f3380ef3 change preempting to PreemptionPolicy 2019-05-31 12:42:05 +08:00
wangqingcan
5c9438c691 non-preempting-priorityclass
Co-authored-by: Vallery Lancey <vallery@zeitgeistlabs.io>
Co-authored-by: Tan shanshan <tan.shanshan@zte.com.cn>
2019-05-31 12:37:07 +08:00
Zihong Zheng
64198a43e7 Auto-generated BUILD files 2019-05-30 21:09:04 -07:00
Zihong Zheng
2ab3681648 Fix-up and add unit test for Load Balancer finalizer 2019-05-30 21:09:04 -07:00
Zihong Zheng
aa3f81d657 Add Load Balancer finalizer support
- Always try to remove finalizer upon load balancer cleanup
- Add finalizer prior to load balancer creation (feature gated)
- Cache logic fix-ups
- Event type/message fix-ups
- Use runtime.HandleError() on eaten errors

Co-authored-by: Josh Horwitz <horwitzja@gmail.com>
2019-05-30 21:09:04 -07:00
xiangqian
38a884aa04 using storage class provisioner instead of annotation of a pv for external provisioner
minor updates
2019-05-30 10:19:36 -07:00
Kubernetes Prow Robot
05df640f33
Merge pull request #77994 from gnufied/csi-resize-migration
Handle CSI volume resize migration.
2019-05-29 21:28:43 -07:00
GuyTempleton
1efbde2815
Handle invalid metrics when scaling on multiple metrics
Handle a case in the Horizontal Pod Autoscaler Controller when scaling
on multiple metrics and one or more is missing or invalid.

If all metrics are missing - return an error and leave the isScalingActive
condition as that for the last invalid metric.

If some metrics are missing/invalid and some are valid and found -
if a scale up would be triggered by the valid metrics ignore the missing
metrics and scale up, if a scale down would be triggered, return an error
and leave the isScalingActive condition as that for the last invalid metric.
2019-05-29 23:20:40 +01:00
GuyTempleton
ee4dbbcbff
Add tests for handling scaling on unavailable metrics
Add three tests for handling invalid metrics when scaling on
multiple metrics - one for scaling up successfully (new behaviour)
and two for ensuring we don't scale down (existing behaviour).
2019-05-29 23:11:32 +01:00
xiangqian
9688511595 record provision and deletion latency metric
instead of using provisioner from storage class directly, uses plugin name firstly
2019-05-29 14:15:30 -07:00
Hemant Kumar
7563b4d01b Address comments about retry in online resizing block 2019-05-29 11:01:45 -04:00
Kubernetes Prow Robot
d8fd232ea1
Merge pull request #78327 from caesarxuchao/pointer-remainingItemCount
Make RemainingItemCount a pointer
2019-05-29 07:59:29 -07:00
Kubernetes Prow Robot
306b6f330d
Merge pull request #78248 from cwdsuzhou/optimize_err_log
Add error info for plugin do not support attachment
2019-05-29 00:53:17 -07:00
Kubernetes Prow Robot
501092c7d0
Merge pull request #78232 from SataQiu/fix-golint-20190523
Fix golint failures of pkg/controller/namespace/deletion pkg/controller/serviceaccount
2019-05-29 00:53:02 -07:00
Hemant Kumar
d119899e22 handle review comments 2019-05-28 15:22:41 -04:00
Ted Yu
7a2edb780a Break out of loop when currentRevision is found in defaultStatefulSetControl#getStatefulSetRevisions 2019-05-26 09:22:58 -07:00
Chao Xu
369314959c generated 2019-05-24 18:14:53 -07:00
Morten Torkildsen
f1883c9e8c Support scale subresource for PDBs (#76294)
* Support scale subresource for PDBs

* Check group in finder functions

* Small fixes and more tests
2019-05-23 22:24:17 -07:00
Kubernetes Prow Robot
cdff17a96b
Merge pull request #78166 from qingsenLi/k8s-190522
duplicated klog.V(5) when had a if klog.V(5)
2019-05-23 20:58:43 -07:00
qingsenLi
5c23e393cf duplicated klog.V(5) when had a if klog.V(5) 2019-05-24 00:49:38 +08:00
caiweidong
e39ec09975 Add error info for plugin do not support attachment 2019-05-23 18:32:49 +08:00
SataQiu
b87d006a50 fix golint failures of pkg/controller/namespace/deletion pkg/controller/serviceaccount 2019-05-23 12:09:01 +08:00
Kubernetes Prow Robot
0cea0675ec
Merge pull request #78159 from byteor/master
[pkg/controller/serviceaccount]: refactor to more idiomatic go
2019-05-22 15:14:37 -07:00
Kubernetes Prow Robot
4f98c6fc7f
Merge pull request #78104 from Pingan2017/update-translate-time
update LastTransitionTime for pod ready condition when node notready
2019-05-22 08:34:14 -07:00
Zhou Peng
2fd4f883d6 [pkg/controller/serviceaccount]: refactor to more idiomatic go
Signed-off-by: Zhou Peng <p@ctriple.cn>
2019-05-21 17:55:30 +08:00
daihao
166147d5c4 ignore failed pods to not stuck rolling update daemonset 2019-05-21 17:38:53 +08:00
Pingan2017
0a8d7aadc0 update LastTransitionTime for pod ready condition when node become notready 2019-05-21 17:20:08 +08:00
Kubernetes Prow Robot
8211cabfb2
Merge pull request #77647 from fisherxu/patch-1
Add pending status for pastBackoffLimitOnFailure
2019-05-20 21:56:39 -07:00
Fei Xu
9feb0df370 Add pending status for pastBackoffLimitOnFailure 2019-05-21 09:45:29 +08:00
Hemant Kumar
33b95ebddb add some tests for expand controller
Update bazel file
2019-05-20 10:55:23 -04:00
caiweidong
5a0e7f19b6 Narrow down the lock 2019-05-20 19:12:27 +08:00
Kubernetes Prow Robot
6ba13bf151
Merge pull request #77773 from DaiHao/daemon
fix daemon set rolling update hang
2019-05-20 03:11:12 -07:00
Yu Liao
05ebe91277 Switched to use dynamic shared informer for Garbage Collector. 2019-05-17 15:41:36 -07:00
Kubernetes Prow Robot
9cbbf59265
Merge pull request #77984 from MrHohn/svc-finalizer-alpha
`patch` service status instead of `update` in service controller
2019-05-17 10:12:06 -07:00
Hemant Kumar
405d33eae4 Add code to handle in-tree to CSI migration for resizing 2019-05-17 10:57:44 -04:00
Kubernetes Prow Robot
27410955e2
Merge pull request #77952 from liggitt/delete-on-update
Handle updates removing remaining finalizers on deleted objects
2019-05-17 02:04:32 -07:00
Kubernetes Prow Robot
da4d6f5829
Merge pull request #77883 from gnufied/mat-expand-workqueue
Use workqueues for volume expansion
2019-05-17 02:04:18 -07:00
Hemant Kumar
4886e8782c name the queue properly and use lower case for error message 2019-05-16 21:34:57 -04:00
Zihong Zheng
cda73ebbb0 Fixes service controller unit test for patching
Co-authored-by: Josh Horwitz <horwitzja@gmail.com>
2019-05-16 17:30:43 -07:00
Zihong Zheng
a1f07049e5 Patch service instead of update in service controller
Co-authored-by: Josh Horwitz <horwitzja@gmail.com>
2019-05-16 17:30:43 -07:00
Hemant Kumar
673773cbde check for pvc objects 2019-05-16 12:23:52 -04:00
Kubernetes Prow Robot
23e54dc634
Merge pull request #77610 from tedyu/rev-limit
Impose length limit when concatenating revision history
2019-05-16 01:10:08 -07:00
daihao
e25ff463ba fix daemon set rolling update hang 2019-05-16 10:52:48 +08:00
Jordan Liggitt
fba885a0d2 Handle updates removing remaining finalizers on deleted objects 2019-05-15 17:17:39 -04:00
Matthew Wong
c16a555654 Use workqueue model in expand controller
Add a test for patch creation
2019-05-14 16:42:06 -04:00
Mike Crute
7d62316f8f Migrate fake cloud provider to staging 2019-05-14 13:32:18 -07:00
Kubernetes Prow Robot
ec88ec272c
Merge pull request #75405 from tghartland/node-init-fix
Recheck for cloud taint before initializing nodes in cloud controller
2019-05-14 11:21:19 -07:00
Ted Yu
9418affa4d add comment on rev history length limit 2019-05-14 03:11:20 +08:00
Thomas Hartland
081ec69386 Abort node initialization if cloud taint was already removed
If node events are received at a faster rate than they
can be processed then initialization for some nodes will
be delayed. Once they are eventually processed their cloud taint
is removed, but there may already be several update events
for those nodes with the cloud taint still on them already
in the event queue. To avoid re-initializing those nodes,
the cloud taint is checked for again after requesting
the current state of the node. If the cloud taint is no
longer on the node then nil is returned from the
RetryOnConflict, as an error does not need to be logged.

The logging for a successful initialization is also
moved inside the RetryOnConflict so that the early nil
return does not cause the aborted initialization to be
logged as a success.
2019-05-10 09:26:16 +02:00
Kubernetes Prow Robot
3ed23a9594
Merge pull request #73350 from hello2mao/remove-unused-const-in-node-controller
Remove unused const
2019-05-09 11:26:51 -07:00
Ted Yu
9546fd540e Impose length limit when concatenating revision history 2019-05-08 10:14:18 -07:00
Andrew Kim
c919139245 update import of generic featuregate code from k8s.io/apiserver/pkg/util/feature -> k8s.io/component-base/featuregate 2019-05-08 10:01:50 -04:00
Walter Fender
796097ae40 Staging the GCE Cloud Provider
**What type of PR is this?**
/kind cleanup

**What this PR does / why we need it**:
Staging the GCE Cloud Provider as part of KEP [20190125-removing-in-tree-providers](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md). Staging repo setup here https://github.com/kubernetes/legacy-cloud-providers
Moves the GCE cloud provider implementation to staging.
This is in preparation for moving the cloud provider code out of tree entirely.
However we need it in staging while the code needs to be consumed both in/out of tree.

**Which issue(s) this PR fixes**:
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```
NONE
```

Updated import dependency tracking.
Factored in the cleanup from #77412
Minor fix to go.mod.
2019-05-07 13:17:52 -07:00
Kubernetes Prow Robot
95eb3a6702
Merge pull request #77452 from cwdsuzhou/fix_error_overrided
fix always print EventTypeWarning due to err override
2019-05-07 09:52:10 -07:00
Kubernetes Prow Robot
43284ecbfc
Merge pull request #77442 from cofyc/fix77084
Fix go lint failures in volume scheduling packages
2019-05-07 00:24:07 -07:00
Kubernetes Prow Robot
86a0a3d883
Merge pull request #77443 from cofyc/fix77085
Remove private copies and update the code to use shared annotations
2019-05-06 22:53:52 -07:00
Kubernetes Prow Robot
a8787dac30
Merge pull request #76927 from mrkm4ntr/unnecessary-goroutine
Do not generate unnecessary goroutines
2019-05-06 21:31:53 -07:00
Yecheng Fu
4abd73048c Do one more level of casting to get the 'assumeCache' 2019-05-07 10:55:58 +08:00
liucimin
f68b12e4ec fix the metainternalversion.List change error 2019-05-07 10:35:04 +08:00
Kubernetes Prow Robot
04d69b20cc
Merge pull request #77438 from cofyc/owners
Create OWNERS in volume scheduling package
2019-05-06 17:08:06 -07:00
caiweidong
722f42caba fix always print EventTypeWarning due to err overrided 2019-05-05 20:19:01 +08:00
Yecheng Fu
3315474f55 Fix go lint failures in a few packages
- pkg/controller/volume/persistentvolume/testing
- pkg/controller/volume/scheduling
2019-05-05 09:45:25 +08:00
Yecheng Fu
2d0d226371 Move all private annotations to shared package and update code 2019-05-05 09:43:43 +08:00
Kubernetes Prow Robot
c516bb51e3
Merge pull request #76723 from LiliC/fix-daemonset-typo
pkg,test: Fix DaemonSet typos
2019-05-04 17:19:37 -07:00
Yecheng Fu
87ca3bd1d6 Create OWNERS in volume scheduling package 2019-05-04 16:46:12 +08:00
Kubernetes Prow Robot
d5245b9563
Merge pull request #74856 from draveness/fix/daemonset-controller-slow-batch-creation
fix(daemon): create more expections when skipping pods
2019-05-03 23:33:37 -07:00
Kubernetes Prow Robot
ef550e6989
Merge pull request #75434 from cofyc/fix56098
Refactor PV scheduling library into a separate package
2019-05-03 22:17:38 -07:00
Kubernetes Prow Robot
e871241268
Merge pull request #77208 from DaiHao/daemon_controller
Fix rolling update daemonset bug in clock-skew scenario
2019-05-03 21:01:52 -07:00
draveness
5f8dfdc698 fix(daemon): create more expections when skipping pods 2019-05-04 08:15:49 +08:00
Kubernetes Prow Robot
b07f311322
Merge pull request #76882 from SataQiu/fix-golint-controller-20190422
Fix golint failures of pkg/controller/certificates/approver, etc
2019-05-02 03:16:18 -07:00
Yecheng Fu
842fed658c Refactor PV scheduling library into separate package 2019-05-02 14:45:52 +08:00
Yecheng Fu
0b6c028c8a Extract testing VolumeReactor into a separate package 2019-05-02 14:45:52 +08:00
Kubernetes Prow Robot
b03e4bbc22
Merge pull request #76868 from tedyu/res-quota-mon-read
Use read lock for QuotaMonitor#IsSynced
2019-05-01 20:42:31 -07:00
SataQiu
3c35e4e2d6 fix golint failures of pkg/controller/certificates/approver 2019-05-02 10:37:38 +08:00
Humble Chirammal
4d56ab19e4 Remove unwanted conditions from controllers.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-05-01 14:13:19 +05:30
Kubernetes Prow Robot
4ebe11a6cb
Merge pull request #76110 from DirectXMan12/infra/prune-owners
Prune directxman12 from metrics/autoscaling OWNERS
2019-04-29 14:35:36 -07:00
daihao
18ed2f6c54 Enqueue controllers after minreadyseconds when all pods are ready 2019-04-29 19:51:03 +08:00
Kubernetes Prow Robot
99d331e37c
Merge pull request #76817 from soltysh/apps_approvers
Updates OWNERS files in job controller
2019-04-25 12:03:57 -07:00
Maciej Szulik
edb3357a29
Rename CronJob controller file 2019-04-25 12:19:29 +02:00
Shintaro Murakami
f8e81337da Do not generate unnecessary goroutine 2019-04-23 16:22:14 +09:00
Kubernetes Prow Robot
0ca27bfee2
Merge pull request #76139 from SataQiu/fix-golint-kubectl-20190404
Fix golint failures of pkg/kubectl/apps
2019-04-22 10:43:44 -07:00
Ted Yu
0129dede89 Use read lock for QuotaMonitor#IsSynced 2019-04-20 11:05:57 -07:00
Kubernetes Prow Robot
22c67bb113
Merge pull request #76333 from cwdsuzhou/clean_up_scheduler_binder
Rename some varibles and clean up codes in scheduler_binder.go
2019-04-19 17:18:03 -07:00
Davanum Srinivas
7b8c9acc09
remove unused code
Change-Id: If821920ec8872e326b7d85437ad8d2620807799d
2019-04-19 08:36:31 -04:00
Maciej Szulik
3cc85a1c09
Updates OWNERS files in job controller 2019-04-19 10:35:16 +02:00
caiweidong
1c5efe7eae Rename some varible and clean up codes in scheduler_binder.go 2019-04-19 11:06:17 +08:00
Lili Cosic
c9cbabc8f9 pkg,test: Fix DaemonSet typos 2019-04-17 18:47:00 +02:00
Joel Smith
f50696adda Fix potential test flakes in HPA tests TestEventNotCreated and TestAvoidUncessaryUpdates
Also, re-work the code so that the lock is never held while writing to the chan
2019-04-17 08:10:33 -06:00
Kubernetes Prow Robot
0889c3e4e9
Merge pull request #75761 from fenggw-fnst/mybranch
Fix comments about node health monitor
2019-04-17 05:26:12 -07:00
SataQiu
4c713e94d9 fix golint failures of pkg/kubectl/apps 2019-04-17 19:37:35 +08:00
Kubernetes Prow Robot
0148014048
Merge pull request #76669 from kow3ns/apps-owners-update
Updates OWNERS files and OWNERS_ALIASES for SIG Apps
2019-04-16 17:49:05 -07:00
Kubernetes Prow Robot
90b9ccf7f4
Merge pull request #74447 from WanLinghao/builder_ptr_replace
Remove and replace ptr functions
2019-04-16 16:19:38 -07:00
Kenneth Owens
f81fc8ae1b Updates OWNERS files and OWNERS_ALIASES for SIG Apps to make reviewers
and approvers more clear
2019-04-16 11:35:21 -07:00
Kubernetes Prow Robot
440d086268
Merge pull request #76257 from johscheuer/remove-unused-nodeipam-code
Remove empty metrics.go file and method call
2019-04-16 08:57:09 -07:00
Kubernetes Prow Robot
a93f803f8e
Merge pull request #75501 from Huang-Wei/scheduler-metrics
scheduler: add metrics to record number of pending pods in different queues
2019-04-09 01:09:05 -07:00
Kubernetes Prow Robot
1cca3f9d45
Merge pull request #76215 from liggitt/update-vendored-dependencies
Update vendored dependencies
2019-04-08 23:51:03 -07:00
Kubernetes Prow Robot
fa9b36de77
Merge pull request #76151 from vladimirvivien/plugin-CanAttach-return-error
Ability for volume AttachablePlugin.CanAttach() to return both bool and error
2019-04-08 20:29:05 -07:00
WanLinghao
d0138ca3fe This commit does two things in pkg package:
1. Remove unused ptr functions.
2. Replace ptr functions with k8s.io/utils/pointer
2019-04-09 10:56:35 +08:00
Kubernetes Prow Robot
65dc445aa2
Merge pull request #74241 from snowplayfire/fix-pdb-update
fix too many pdb update operations when nothing change
2019-04-08 18:53:03 -07:00
Wei Huang
63c3a617cd
auto-generated files 2019-04-08 17:51:08 -07:00
Vladimir Vivien
cfafde983b Volume AttachablePlugin.CanAttach() now returns both bool and error 2019-04-08 16:53:22 -04:00
Jordan Liggitt
bba9f5e673 Fixup gonum.org/v1/gonum/graph API calls 2019-04-08 15:20:46 -04:00
Kubernetes Prow Robot
8f8d9e2c72
Merge pull request #76060 from krzysztof-jastrzebski/master
Delete only unscheduled pods in DaemonSetController if node doesn't exist anymore
2019-04-08 08:58:27 -07:00
Johannes M. Scheuermann
80d6b0465e Remove empty metrics.go file and method call
Update bazel code file
2019-04-08 14:49:27 +02:00
jingxueli
dfa3353390 fix pdb update too many when nothing change 2019-04-08 11:27:42 +08:00
Kubernetes Prow Robot
2c013fa1a8
Merge pull request #75129 from xing-yang/informer
Move CSIDriver Lister to the controller
2019-04-05 18:06:27 -07:00
Kubernetes Prow Robot
f3de278f18
Merge pull request #75964 from humblec/more-lnt
Remove some unwanted code blocks in controller_utils.go
2019-04-05 16:46:40 -07:00
Kubernetes Prow Robot
deb48e331a
Merge pull request #76189 from soltysh/fix_legacy_podautoscaler
Fix flaky legacy pod autoscaler test
2019-04-05 14:34:05 -07:00
Kubernetes Prow Robot
1cdb4c965a
Merge pull request #74946 from ialidzhikov/clean-ineffectual-assignments
Clean ineffectual assignments
2019-04-05 14:33:53 -07:00
Xing Yang
000ab86788 Move CSIDriver Lister to the controller 2019-04-05 12:20:11 -07:00
Maciej Szulik
bcfd48c29e
Fix flaky legacy pod autoscaler test
The reactor in runTest is set to catch all actions, but eventually it
only handles CreateAction without checking action type which might fail
sometimes when Patch arrives. This fix ensures we handle only the
CreateAction.
2019-04-05 13:20:30 +02:00
Kubernetes Prow Robot
529cd2c674
Merge pull request #74649 from draveness/patch-1
fix: typo in stateful_set_control
2019-04-04 17:47:31 -07:00
Kubernetes Prow Robot
79a8827c37
Merge pull request #76108 from MrHohn/svc-controller-sync-name
Rename createLoadBalancerIfNeeded() to syncLoadBalancerIfNeeded()
2019-04-04 00:41:27 -07:00
Kubernetes Prow Robot
eee8af93ba
Merge pull request #75622 from jonsabo/ssetresync
Remove resync period for sset controller
2019-04-04 00:41:02 -07:00
Solly Ross
837976cb59 Prune directxman12 from metrics/autoscaling OWNERS
Since I'm not really working on metrics or autoscaling stuff any more, I
figured it was time to remove myself from the approvers list.
2019-04-03 16:24:51 -07:00
Zihong Zheng
3e52ea8081 Rename createLoadBalancerIfNeeded() to syncLoadBalancerIfNeeded() to reduce confusion 2019-04-03 14:27:04 -07:00
Kubernetes Prow Robot
be374388f6
Merge pull request #74941 from cwdsuzhou/fix_pvc_label
Do not replace labels of pvc with those of StastefulSet
2019-04-03 02:05:44 -07:00
Ted Yu
eebd8d2690 Remove unnecessary map in cleanupHistory 2019-04-02 15:45:49 -07:00
Krzysztof Jastrzebski
9c142cf47b Delete only unscheduled pods if node doesn't exist anymore. 2019-04-03 00:24:26 +02:00
Michelle Au
d2aa8178f2 Remove alpha CRD install 2019-04-02 10:59:11 -07:00
Kubernetes Prow Robot
b1186435eb
Merge pull request #75080 from draveness/feature/get-nodelists-sync-daemonset
fix: list nodes in sync daemonset
2019-04-02 08:22:35 -07:00
Kubernetes Prow Robot
f83fcbefb6
Merge pull request #76004 from yue9944882/chore/trival-reserving-error-msg
Fixes reversed owner relation in error msg from garbage collector
2019-04-02 03:04:58 -07:00
draveness
36c535cf42 fix: list nodes in sync daemonset 2019-04-02 13:54:28 +08:00
Kubernetes Prow Robot
42ff0d8517
Merge pull request #75972 from smarterclayton/use_patch
Garbage collector should use a merge patch instead of Update
2019-04-01 22:44:57 -07:00
yue9944882
0a60d19ebd fixes reversed owner relation in error msg 2019-04-02 12:08:53 +08:00
Clayton Coleman
a63fef26ca
Garbage collector should use a merge patch instead of Update
Fix a TODO in GC controller that blocks using the new
PartialObjectMetadata flow (because we don't support PUT of
PartialObjectMetadata). This patch is equivalent to the previous
mutation.
2019-04-01 11:02:03 -04:00
Humble Chirammal
e9d8d0f5a5 Remove some unwanted code blocks in controller_utils.go
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-04-01 19:20:12 +05:30
Humble Chirammal
48e1838f6c Remove unwanted else block from statefulset controller.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-04-01 16:24:55 +05:30
Tom Wanielista
d0cfc49704 Avoid panic in cronjob sorting
This change handles the case where the ith cronjob may have its start
time set to nil.

Previously, the Less method could cause a panic in case the ith
cronjob had its start time set to nil, but the jth cronjob did not. It
would panic when calling Before on a nil StartTime.
2019-03-30 12:43:14 -04:00
Kubernetes Prow Robot
7a478a4609
Merge pull request #75844 from vladimirvivien/volume-skip-device-mount
Volume DeviceMountablePlugin.CanDeviceMount check when retrieving plugins
2019-03-29 13:02:13 -07:00
Kubernetes Prow Robot
16a0351881
Merge pull request #75712 from danielqsj/cj
Add completed job status in cronjob event
2019-03-29 11:48:37 -07:00
Vladimir Vivien
3777514f83 Adds DeviceMountablePlugin.CanDeviceMount check when retrieving plugins 2019-03-28 10:39:32 -04:00
zhouhaibing089
f58c2ae62d resourcequota: use dynamic informer
The resource quota controller should use a dynamic informer so it
can create informer for custom resources.
2019-03-27 11:08:24 -07:00
Guangwen Feng
5714041f54 Fix comments about node health monitor
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2019-03-27 12:18:23 +08:00
Jordan Liggitt
27cd2be49f Update quota status with limits even when calculating errors 2019-03-26 23:15:40 -04:00
Jordan Liggitt
739df5452a Avoid deadlock in resource quota resync 2019-03-26 23:15:40 -04:00
Jordan Liggitt
e5f7af7058 Improve quota sync log messages 2019-03-26 23:15:40 -04:00
Jordan Liggitt
8146fe47d8 Clean up test output 2019-03-26 23:15:39 -04:00
Jordan Liggitt
713a10d276 Fix race in quota sync test 2019-03-26 23:15:39 -04:00
danielqsj
6b2e9e8af3 add completed job status in cronjob event 2019-03-27 09:48:55 +08:00
Kubernetes Prow Robot
2086f81546
Merge pull request #74678 from pmcalpine/lint-bs_cj
Fix some golint failures for pkg/controller
2019-03-26 15:10:16 -07:00
Kubernetes Prow Robot
531dbd409f
Merge pull request #75445 from shinytang6/enhance/fmt
Replace all time.Now().Sub with time.Since
2019-03-26 13:55:17 -07:00
Kubernetes Prow Robot
11d472ea01
Merge pull request #72179 from WanLinghao/sa_controller
Migrate the controller to use TokenRequest and rotate token periodically
2019-03-26 12:33:19 -07:00
Kubernetes Prow Robot
68f839662d
Merge pull request #74042 from tedyu/master
Reduce unnecessary Map in node_controller#nodeAddressesChangeDetected
2019-03-25 13:24:24 -07:00
WanLinghao
244b244f9d Migrate the controller to use TokenRequest and rotate token periodically 2019-03-25 14:54:22 +08:00
Kubernetes Prow Robot
29e74dc58c
Merge pull request #75021 from cwdsuzhou/protectionutil
Move protection common funcs to protectionutil
2019-03-22 22:15:07 -07:00
ialidzhikov
c3b2fb0d11 Clean ineffectual assignments
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2019-03-23 00:27:07 +02:00
Jon Sabo
445d711611 Remove resync period 2019-03-22 16:40:40 -05:00
Kubernetes Prow Robot
8ef336c05a
Merge pull request #74568 from hex108/pv
Remove redundant checker whether pod has claims in func FindPodVolumes
2019-03-21 22:50:31 -07:00
Kubernetes Prow Robot
4499275cb9
Merge pull request #72800 from stewart-yu/stewart-component-base
Move config local to every controller in KCM
2019-03-21 19:26:19 -07:00
shinytang6
5c9f4d9dc6 replace time.Now().Sub with time.Since 2019-03-21 18:02:55 +08:00
Kubernetes Prow Robot
bdc013ad57
Merge pull request #75276 from WanLinghao/node_lifecycle_clean
unused function clean
2019-03-20 05:25:35 -07:00
Kubernetes Prow Robot
fcf21a2168
Merge pull request #74885 from cwdsuzhou/fix_log_style
Change log: avoid to print raw json response too frequently
2019-03-19 21:26:36 -07:00
Kubernetes Prow Robot
046dcbd1ed
Merge pull request #73917 from droslean/cleanup
replace loops with go idiomatic.
2019-03-19 19:01:04 -07:00
Peter McAlpine
ac88e13821 Fix lint warnings in pkg/controller/cronjob. 2019-03-19 14:36:26 -04:00
Peter McAlpine
6518c0b696 Rename: cronjob_controller[_test].go -> controller[_test].go
This change renames these source files to reduce stuttering when reading
the path.
2019-03-19 14:36:26 -04:00
Peter McAlpine
4cfcf0519d Fix lint warnings in pkg/controller/bootstrap 2019-03-19 14:36:26 -04:00
caiweidong
eb8dd093fe add UT 2019-03-19 20:36:38 +08:00
caiweidong
e9c13409a8 Move protection common func to protectionutil 2019-03-17 22:24:42 +08:00
caiweidong
5fa000e5ed Change log: avoid to print raw json response too frequently 2019-03-13 13:07:01 +08:00
caiweidong
751007c17d Do not replace labels of pvc with those of StastefulSet 2019-03-12 11:13:57 +08:00
WanLinghao
686b526de4 remove unused functions in pkg/controller/nodelifecycle/node_lifecycle_controller.go 2019-03-12 11:01:47 +08:00
Kubernetes Prow Robot
9103186489
Merge pull request #74442 from yujuhong/reconcile-node-labels
nodelifecycle controller: reconcile node OS/arch labels
2019-03-07 21:19:57 -08:00
David Zhu
41b3579345 Address review comments 2019-03-07 17:17:09 -08:00
David Zhu
7d2f4e97b8 Add ADC Fallback if Node doesn't have driver installed 2019-03-07 14:47:38 -08:00
Yu-Ju Hong
bd2301a628 nodelifecycle controller: reconcile node OS/arch labels 2019-03-06 17:26:23 -08:00
Kubernetes Prow Robot
bcbbb98f78
Merge pull request #70265 from jingyih/use_chunking_when_list_in_cronjob_controller
Retrieve list in chunks in cronjob controller
2019-03-06 04:45:59 -08:00
Kubernetes Prow Robot
d31427637b
Merge pull request #74926 from ddebroy/csiprov2
Add new CSI translation APIs required by CSI sidecars and unit tests
2019-03-05 14:54:21 -08:00
Kubernetes Prow Robot
dccb8ab5b0
Merge pull request #74615 from andrewsykim/delete-pvl-controller
Delete the out-of-tree PV labeler controller
2019-03-05 08:16:03 -08:00
Xing Yang
6265f4f78c CSINodeInfo/CSIDriver controller changes
This is the 2nd PR to move CSINodeInfo/CSIDriver APIs to
v1beta1 core storage APIs. It includes controller side changes.
It depends on the PR with API changes:
https://github.com/kubernetes/kubernetes/pull/73883
2019-03-04 16:41:58 -08:00
Deep Debroy
1da91ad39a Add GetIntreeNameFromCSIName and SupersedesInTreePlugin APIs and unit tests
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-03-04 16:36:45 -08:00
stewart-yu
ecbd5427e7 auto-generated file 2019-03-02 12:55:26 +08:00
stewart-yu
fc54de589f fix all the reference about the API packages change 2019-03-02 12:54:33 +08:00
stewart-yu
e01ff1641c move config local to every controllers in kube-controller-manager 2019-03-02 12:54:33 +08:00
Lubomir I. Ivanov
e29c6e1b38 go-1.12: fix 'go vet' failures 2019-03-01 18:48:17 +02:00
Kubernetes Prow Robot
36787041cb
Merge pull request #73653 from ddebroy/migprov1
Support dynamic provisioning for CSI migration scenarios
2019-02-28 01:52:55 -08:00
Kubernetes Prow Robot
84dce4d119
Merge pull request #74393 from codenrhoden/refactor-subpath
Refactor subpath out of pkg/util/mount
2019-02-27 15:54:36 -08:00
Kubernetes Prow Robot
bf2c9ccec7
Merge pull request #74122 from draveness/feature/refactor-filter-active-pods
refactor: use FilterActivePods instead in replicaset controller
2019-02-27 15:54:25 -08:00
Draven
df190a0197
fix: typo in stateful_set_control 2019-02-27 18:16:50 +08:00
Travis Rhoden
2c4d748bed Refactor subpath out of pkg/util/mount
This patch moves subpath functionality out of pkg/util/mount and into a
new package pkg/volume/util/subpath. NSEnter funtionality is maintained.
2019-02-26 19:59:53 -07:00
Kubernetes Prow Robot
be8a9b9637
Merge pull request #74422 from liggitt/client-version-methods
Remove deprecated versionless client interface methods
2019-02-26 12:44:24 -08:00
Andrew Kim
2901def8c3 delete the persistentvolume labeler controller 2019-02-26 14:23:20 -05:00
Daniel (Shijun) Qian
d648ba856b Move pkg/api/v1/node to pkg/util/node (#73656)
* merge pkg/api/v1/node with pkg/util/node

* update test case for utilnode

* remove package pkg/api/v1/node

* move isNodeReady to internal func

* Split GetNodeCondition into e2e and controller pkg

* fix import errors
2019-02-26 11:05:32 -08:00
Deep Debroy
23478f104f PV Controller changes to support provisioning in CSI Migration scenarios
Signed-off-by: Deep Debroy <ddebroy@docker.com>
2019-02-26 08:39:54 -08:00
Jordan Liggitt
d1e865ee34 Update client callers to use explicit versions 2019-02-26 08:36:30 -05:00
Jun Gong
a916f1b28c Remove redundant checker whether pod has claims in func FindPodVolumes 2019-02-26 13:06:52 +08:00
Kubernetes Prow Robot
d6de0454e9
Merge pull request #73968 from freehan/big-endpoint-event
record event on endpoint update failure
2019-02-22 16:15:20 -08:00
Kubernetes Prow Robot
9fcbf02dca
Merge pull request #74044 from danielqsj/dr
fix the disruption-recheck metrics register error
2019-02-21 20:51:01 -08:00
danielqsj
687d759e36 fix more metrics rergister errors 2019-02-22 10:20:09 +08:00
Kubernetes Prow Robot
9b87046cb2
Merge pull request #74126 from danielqsj/cu
correct error string according to golang best practice
2019-02-21 09:21:50 -08:00
Kubernetes Prow Robot
3baab4dc35
Merge pull request #73284 from leakingtapan/kubelet-migration-aws-2
Add In-tree to CSI migration logic for Mount and Unmount
2019-02-20 16:40:02 -08:00
Kubernetes Prow Robot
dc634b3fd3
Merge pull request #70934 from mikeweiwei/my_fix3
Fix typos
2019-02-20 12:53:52 -08:00
Matt Matejczyk
bf25f7160b Clear EndpointsLastChangeTriggerTime on no-change.
We should clean the EndpointsLastChangeTriggerTime annotation when there
is no new trigger time to be exported. Not clearing it may result in
kube-proxy exporting the wrong Network Programming Latency SLI.
2019-02-20 11:53:40 +01:00
Kubernetes Prow Robot
cbcc2b26fe
Merge pull request #72904 from ping035627/k8s-190115
Correct the count of evictionsNumber
2019-02-18 18:40:09 -08:00
Cheng Pan
6355186c3e Add In-tree to CSI migration logic for Mount and Unmount 2019-02-18 04:55:31 +00:00
danielqsj
6edde10fcd correct error string according to golang best practice 2019-02-15 18:12:00 +08:00
draveness
590bf5530d
refactor: use FilterActivePods instead in replicaset controller 2019-02-15 17:44:56 +08:00
Kubernetes Prow Robot
808f2cf0ef
Merge pull request #72525 from justinsb/owners_should_not_be_executable
Remove executable file permission from OWNERS files
2019-02-14 23:55:45 -08:00
Kubernetes Prow Robot
60943a7a08
Merge pull request #69830 from davidz627/feature/csiTranslationMigration
In-Tree to CSI Migration logic for PersistentVolume Attach/Detach
2019-02-14 22:43:05 -08:00
David Zhu
5dde1df1cd Migration shim logic for Persistent Volumes for Attach/Detach 2019-02-14 17:04:23 -08:00
Ted Yu
4031900c0c fix variable name 2019-02-13 19:46:18 -08:00
Kubernetes Prow Robot
d457fb7771
Merge pull request #73869 from grayluck/no-cluster-cidr-validation
Skip validation for clusterCIDR in node ipam controller.
2019-02-13 17:31:44 -08:00
danielqsj
23be9587a0 fix the disruption-recheck metrics register error 2019-02-14 09:15:44 +08:00
Ted Yu
a346460c08 Reduce unnecessary Map in node_controller#nodeAddressesChangeDetected 2019-02-13 16:16:15 -08:00
yankaiz
7379ad5ae2 Skip validation for clusterCIDR in node ipam controller.
clusterCIDR is passed down from kube_env CLUSTER_IP_RANGE to the flag --cluster-cidr.
We plan not to let GKE to pass down CLUSTER_IP_RANGE to kube-env for the master node.
2019-02-13 12:13:33 -08:00
Kubernetes Prow Robot
2aedcbc7ca
Merge pull request #73761 from andrewsykim/remove-cloud-provider-volume-deps
remove cloud provider dependencies to pkg/volume
2019-02-12 18:45:24 -08:00
Minhan Xia
299fa607c0 record event on endpoint update failure 2019-02-12 13:56:20 -08:00
Dr. Stefan Schimanski
618050e35d client-go: extend discovery intf with ServerGroupsAndResources 2019-02-12 14:28:19 +01:00
Kubernetes Prow Robot
ee734d0543
Merge pull request #73932 from dims/cleanup-unnecessary-packages-from-import-restrictions
Remove unnecessary prefixes from various .import-restrictions files
2019-02-11 16:24:17 -08:00
Davanum Srinivas
1d430a4a73
Remove unnecessary prefixes from various .import-restrictions files
Found using script:
https://gist.github.com/dims/384dea60754042f61d79233603034038

Just run using:
`find . -name .import-restrictions | xargs python ~/junk/sanitize-import-boss.py`

The removed entries are either packages that got moved/renamed/deleted
but are still not cleaned up from .import-restrictions files.

Change-Id: I92c400f74e6f012cc75539311ed4de280e25e918
2019-02-11 16:47:28 -05:00
Nikolaos Moraitis
6e820cdcaf replace loops with go idiomatic. 2019-02-11 11:21:52 +01:00
houjun
a5cde1a463 Check for pvcVolume with IsOperationPending() before markPVCResizeInProgress() 2019-02-11 15:23:17 +08:00
PingWang
1ff8fac138 Correct the count of evictionsNumber
Signed-off-by: PingWang <wang.ping5@zte.com.cn>

check nodeutil.SwapNodeControllerTaint's return

Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2019-02-11 10:15:10 +08:00
Andrew Kim
ca6a051b00 remove cloud provider dependencies to pkg/volume
Co-authored-by: Weibin Lin <linweibin1@huawei.com>
2019-02-09 01:16:55 -05:00
Kubernetes Prow Robot
52b3956df4
Merge pull request #67638 from houjun41544/20180821
Fix fmt.Errorf messages
2019-02-08 13:13:49 -08:00
Kubernetes Prow Robot
5b7a790d35
Merge pull request #72185 from dcbw/owners-label-sig-network
OWNERS: add label:sig/network to a bunch of places
2019-02-08 10:36:16 -08:00
Kubernetes Prow Robot
f0b72df47e
Merge pull request #73789 from vladimirvivien/volume-plugin-can-attach
AttachableVolumePlugin CanAttach() method for attachable check
2019-02-08 09:06:17 -08:00
Kubernetes Prow Robot
b50c643be0
Merge pull request #73540 from rlenferink/patch-5
Updated OWNERS files to include link to docs
2019-02-08 09:05:56 -08:00
Vladimir Vivien
0a653b3b80 Adds method CanAttach() to check plugin attachability 2019-02-08 08:04:15 -05:00
Kubernetes Prow Robot
eac19a3ab9
Merge pull request #73616 from dims/move-part-of-kubelet-apis-well-known-lables
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
2019-02-07 19:44:34 -08:00
Adrián
ca809b1d33
gofmt 2019-02-07 20:26:21 +01:00
Adrián
34099a9274
ControllerRef creation through factory function 2019-02-07 10:44:49 +01:00
Adrián
290101330e
ControllerRef creation through factory function 2019-02-07 09:36:39 +01:00
Kubernetes Prow Robot
bf8dd697b2
Merge pull request #73314 from mm4tt/trigger_time_tracker
Introduce the TriggerTimeTracker util in the Endpoints Controller.
2019-02-06 03:12:54 -08:00
Kubernetes Prow Robot
a1539d8e52
Merge pull request #73159 from cofyc/fix72329
Better way to share common utilities between PV controller and Volume Binder
2019-02-05 22:36:13 -08:00
Yecheng Fu
8b79fe3ebe Do not call methods on PersistentVolumeController 2019-02-06 12:04:05 +08:00
Davanum Srinivas
b975573385
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
Co-Authored-By: Weibin Lin <linweibin1@huawei.com>

Change-Id: I163b2f2833e6b8767f72e2c815dcacd0f4e504ea
2019-02-05 13:39:07 -05:00
Matt Matejczyk
9e7f7df94e Introduce the TriggerTimeTracker util.
It will be used by the Endpoints Controller to compute and export the EndpointsLastChangeTriggerTime annotation, which in turn will be used to compute the In-Cluster Network Programming Latency SLI.
See https://github.com/kubernetes/community/blob/master/sig-scalability/slos/network_programming_latency.md for more details.
2019-02-05 09:37:31 +01:00
Kubernetes Prow Robot
7447b8709d
Merge pull request #73706 from deads2k/csr-01-expiry-min
csr signer has no need to sign certificates for a duration longer than the signer itself
2019-02-04 18:28:24 -08:00
Antoine Pelisse
0e1d50e70f API Machinery, Kubectl and tests 2019-02-04 13:51:48 -08:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Kubernetes Prow Robot
9d6ebf6c78
Merge pull request #73467 from ashishranjan738/newpackage
Refactor to use k8s.io/utils/net/ package instead of kubernetes/pkg/util/net/sets
2019-02-04 11:43:14 -08:00
David Eads
179dc4ca43 csr signer has no need to sign certificates for a duration longer than the signer itself 2019-02-04 13:22:17 -05:00
Kubernetes Prow Robot
a4e3a5cb52
Merge pull request #71561 from anjensan/hpa-fix-current-metrics
Fix 'currentMetrics' field for HPA with 'AverageValue' target type
2019-02-04 03:34:52 -08:00
Ashish Ranjan
7be223e798 Refactor to use k8s.io/utils/net/ package instead of kubernetes/pkg/util/net/sets
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>
2019-02-04 10:34:53 +05:30
Kubernetes Prow Robot
15ae6ec140
Merge pull request #68114 from houjun41544/20180831-disruption
Add unit test case for controller/disruption
2019-02-02 00:37:25 -08:00
Kubernetes Prow Robot
aee11a844c
Merge pull request #73596 from liggitt/deprecated-tests
Stop using beta apps versions
2019-02-01 16:02:08 -08:00
Jingyi Hu
1bdbc35994 controller: use pagination in cronjob controller
Use pagination (chunking) when listing Jobs and CronJobs in cronjob
controller.
2019-02-01 14:02:14 -08:00
Kubernetes Prow Robot
a3f74bd583
Merge pull request #72872 from arjunrn/object-average-value
Added functionality for specifying target average value for object me…
2019-02-01 06:31:50 -08:00
Kubernetes Prow Robot
a3c14ecfa5
Merge pull request #73606 from krzysztof-jastrzebski/daemonsets
Deleting pods assigned to not existing nodes only if
2019-01-31 23:30:13 -08:00
Kubernetes Prow Robot
aa7220876a
Merge pull request #73550 from andrewsykim/cloud-provider-version
use k8s.io/client-go/pkg/version for cloud providers
2019-01-31 11:44:46 -08:00
Krzysztof Jastrzebski
0087af78e2 Deleting pods assigned to not existing nodes only if
ScheduleDaemonSetPods is enabled.
2019-01-31 20:34:51 +01:00
Jordan Liggitt
f100a762bc Stop using apps/v1beta1 in tests 2019-01-31 10:12:38 -05:00
Daniel (Shijun) Qian
e72b32558c
Merge branch 'master' into keymutex 2019-01-31 20:50:57 +08:00
Kubernetes Prow Robot
1f7e9fd9a2
Merge pull request #73488 from andrewsykim/replace-utils-file
Replace pkg/util/file with k8s.io/utils/path
2019-01-30 17:50:16 -08:00
Andrew Kim
c01caa6796 use k8s.io/client-go/pkg/version for cloud providers 2019-01-30 18:11:11 -05:00
Kubernetes Prow Robot
f78770565c
Merge pull request #73401 from krzysztof-jastrzebski/daemonsets
Delete pods assigned to not existing nodes.
2019-01-30 07:30:05 -08:00
danielqsj
657a1a1a34 change import alias of utils/strings 2019-01-30 10:44:09 +08:00
danielqsj
093328e57f migrate to k8s.io/utils/strings 2019-01-30 10:24:00 +08:00
Andrew Kim
84191eb99b replace pkg/util/file with k8s.io/utils/path 2019-01-29 15:20:13 -05:00
Kubernetes Prow Robot
2e90d92db9
Merge pull request #73357 from tedyu/master
Use read lock for scheduler_binder_cache GetDecisions
2019-01-29 01:21:24 -08:00
Kubernetes Prow Robot
bbfc3be51b
Merge pull request #73096 from yuwenma/golint1
fix golint failure for pkg/controller/deployment/util
2019-01-28 21:52:15 -08:00
Kubernetes Prow Robot
3c34d28fe0
Merge pull request #72818 from humblec/md-2
Remove explicit nil initialization and correct error string.
2019-01-28 21:52:03 -08:00
Yuwen Ma
14a1e27ddd fix golint failure for pkg/controller/deployment/util 2019-01-28 11:00:40 -08:00
Krzysztof Jastrzebski
7186d3ba8b Delete pods assigned to not existing nodes. 2019-01-28 14:38:09 +01:00
Ted Yu
c8f1826185 Use read lock for scheduler_binder_cache GetDecisions 2019-01-26 13:06:23 -08:00
maohongbin01
cbfe654a30 remove unused const in node-controller.go 2019-01-26 23:05:47 +08:00
Joshua Horwitz
9b3ab29cc9 Only attempt to register cloud nodes on update with the cloud taint 2019-01-25 14:48:29 -05:00
Kubernetes Prow Robot
2cbb16bc8d
Merge pull request #73243 from andrewsykim/update-utils-vendor
Update vendor k8s.io/utils and remove internal utils
2019-01-24 16:30:14 -08:00
Kubernetes Prow Robot
7da6b42122
Merge pull request #72786 from caesarxuchao/72364-minor-followup
followup of #72364, slightly improve the comment
2019-01-24 16:29:40 -08:00
Kubernetes Prow Robot
e28c757e87
Merge pull request #72972 from liggitt/remove-alpha-initializers
Remove use of alpha initializers
2019-01-24 14:54:52 -08:00
Andrew Kim
0bc5508aca replace client-go/util/integer with k8s.io/utils/integer 2019-01-24 15:34:21 -05:00
Andrew Kim
2ea82cea20 replace pkg/util/nsenter with k8s.io/utils/nsenter 2019-01-24 13:49:04 -05:00
Andrew Kim
123590d911 replace pkg/util/io with k8s.io/utils/io 2019-01-24 13:49:04 -05:00
Chao Xu
e2812ce312 Slightly modify the comment in the test 2019-01-24 10:42:30 -08:00
Kubernetes Prow Robot
4cd759dbe0
Merge pull request #73001 from shivnagarajan/remove_deprecated_taints
remove remaining deprecated taints from 1.9
2019-01-24 05:18:57 -08:00
Jordan Liggitt
7d398058f1 remove Initializer use from pv label controller 2019-01-23 16:34:44 -05:00
Jordan Liggitt
17aa60686e Deprecate and remove use of alpha metadata.initializers field, remove IncludeUninitialized options 2019-01-23 16:34:43 -05:00
Arjun Naik
c99d505001 Added functionality to use target average value for object metrics
Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
2019-01-23 21:00:05 +01:00
Jordan Liggitt
dc1fa870bf Remove alpha InitializerConfiguration types, Initializers admission plugin 2019-01-23 11:37:39 -05:00
Humble Devassy Chirammal
2651c72166 This patch consists of various corrections. (#73060)
* This patch consists of various corrections.

*) Remove unwanted `else` code block
*) Adjust variable intialization.
*) Correct error strings.
*) Use recommended variable increment method.

Signed-off-by: hchiramm <hchiramm@redhat.com>

* Remove cluster/images/cluster-version-monitor from hack/.golint_failures.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-01-22 12:28:59 -08:00
Kubernetes Prow Robot
0b62ad23c2
Merge pull request #72959 from cofyc/fix72954
Fix flaky test TestBindAPIUpdate
2019-01-22 11:12:59 -08:00
Kubernetes Prow Robot
54c4428eb4
Merge pull request #71276 from jingxu97/Oct/uncertain
Handle failed attach operation leave uncertain volume attach state
2019-01-17 22:52:57 -08:00
Humble Chirammal
9e638676e9 Remove explicit nil initialization and correct error string.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2019-01-18 09:29:25 +05:30
David Zhu
d8c9dc5bb5 Add IsMigratableToCSI to volume plugin interface 2019-01-17 14:43:52 -08:00
Kubernetes Prow Robot
c13f9f7272
Merge pull request #72816 from humblec/md-1
Remove unwanted else block from code.
2019-01-17 11:20:55 -08:00
Yecheng Fu
f406c6bde7 Fix flaky test TestBindAPIUpdate 2019-01-17 11:25:18 +08:00
Shiv Nagarajan
36ee154243 remove deprecated taints from 1.9 2019-01-16 21:20:57 -05:00
Kubernetes Prow Robot
bec0c72f5a
Merge pull request #72953 from cofyc/fix72045-performance
Improve FindPodVolumes performance
2019-01-16 10:16:09 -08:00
Kubernetes Prow Robot
64071e03cc
Merge pull request #72648 from tnozicka/fix-clientbuilder-watch
SAControllerClientBuilder: Replace ListWatchUntil with UntilWithSync to avoid watch timeouts
2019-01-16 07:54:33 -08:00
Yecheng Fu
dbd80460de Clear cache instead of saving nils if no claims to bind or provision 2019-01-16 21:21:36 +08:00
Yecheng Fu
c2d25e08d7 Skip if pod does not have claims. 2019-01-16 21:02:08 +08:00
Yecheng Fu
7fe97886a8 Merge UpdateProvisionedPVCs with UpdateBindings.
This simplifies code and saves a lock.
2019-01-16 21:02:08 +08:00
Kubernetes Prow Robot
922cf406c4
Merge pull request #72629 from krzysztof-jastrzebski/hpa_fix
Update comments in Horizontal Pod Autoscaler Controller.
2019-01-15 23:26:19 -08:00
Kubernetes Prow Robot
8feab37d41
Merge pull request #72815 from humblec/md
Remove explicit `nil` initialization and correct error strings.
2019-01-12 01:32:17 -08:00
Kubernetes Prow Robot
ccb1e1f26d
Merge pull request #72045 from cofyc/fix71928
Make volume binder resilient to races
2019-01-11 17:42:32 -08:00
Justin SB
dd19b923b7
Remove executable file permission from OWNERS files 2019-01-11 16:42:59 -08:00
Kubernetes Prow Robot
dd99c2ba79
Merge pull request #72364 from kdada/master
WaitFor returns immediately when done is closed
2019-01-11 11:51:21 -08:00
Jing Xu
7bac6ca73a Address comments
This commit addressed the comment and also add a unit test.
2019-01-11 10:57:37 -08:00
hchiramm
e3fd0b6936 Remove unwanted else block from code.
Signed-off-by: hchiramm <hchiramm@redhat.com>
2019-01-11 16:46:39 +05:30
hchiramm
11045ca28e Correct linter errors on error strings.
Signed-off-by: hchiramm <hchiramm@redhat.com>
2019-01-11 16:27:14 +05:30
hchiramm
68416bdf29 Remove explicit nil declaration of some variables in endpoint ctrl.
Signed-off-by: hchiramm <hchiramm@redhat.com>
2019-01-11 16:25:50 +05:30
hangaoshuai
2adcddc4d5 when SessionAffinityConfig is different, enqueueService in update Service handler 2019-01-11 15:55:41 +08:00
Wei Guo
44b2e8464b change the period of GarbageCollector.Sync to 200ms for TestGarbageCollectorSync 2019-01-10 17:51:53 +08:00
David Eads
47ca64c8f2 delete as much content from a namespace as possible 2019-01-09 14:16:07 -05:00
Yecheng Fu
1a62f53d3f If provisioning PVC's PV is not found, check next time. 2019-01-09 10:50:07 +08:00
Yecheng Fu
8b94b9625b Make volume binder resilient to races: unit tests 2019-01-09 10:50:07 +08:00
Kubernetes Prow Robot
8cb5bc49b6
Merge pull request #72636 from mesaugat/patch-1
Aesthetic changes and fix typo
2019-01-08 16:43:36 -08:00
Kubernetes Prow Robot
cc67ccfd7f
Merge pull request #71731 from cheftako/leaseMetric
Add gauge metric for master of leader election.
2019-01-08 08:57:53 -08:00
Kubernetes Prow Robot
1b28775db1
Merge pull request #72569 from luxas/component_base_init
Create the k8s.io/component-base staging repo
2019-01-08 03:18:35 -08:00
Kubernetes Prow Robot
c5616157a0
Merge pull request #71668 from mtaufen/node-lifecycle-metrics
export metrics from node lifecycle controller workqueues
2019-01-07 20:24:12 -08:00
Michael Taufen
0ab928c9d6 export metrics from node lifecycle controller workqueues 2019-01-07 15:27:35 -08:00
Yecheng Fu
13d87fbff8 Make volume binder resilient to races
- FindPodVolumes do not error if PVC is assumed with selected node
- BindPodVolumes check against API objects
2019-01-08 02:14:13 +08:00
Kubernetes Prow Robot
3caa7ada69
Merge pull request #65469 from k82cn/k8s_64857
Set .spec.schedulerName to ds-controller.
2019-01-07 08:35:42 -08:00
Tomas Nozicka
9747c9a221 SAControllerClientBuilder: Replace ListWatchUntil with UntilWithSync to
avoid watch timeouts
2019-01-07 15:58:12 +01:00
Kubernetes Prow Robot
80afde7ca7
Merge pull request #70026 from bertinatto/only_schedule_pod_if_pv_requirements_are_met
Check PV requirements before scheduling
2019-01-07 03:46:21 -08:00
Saugat Acharya
926cabfc3a
Remove multiple spaces after a full stop 2019-01-07 17:04:46 +05:45
Saugat Acharya
956a21cd31
Aesthetic changes
* Remove multiple spaces after full stop
* Include a single space after a comment
* Fixed a typo
```diff
- eixst
+ exist
```
* Make comment and function name the same
2019-01-07 16:49:12 +05:45
Krzysztof Jastrzebski
7498c14218 Update comments in Horizontal Pod Autoscaler Controller. 2019-01-07 10:06:21 +01:00
Lucas Käldström
1edd2723f8
autogenerated files 2019-01-06 15:48:53 +02:00
Lucas Käldström
15e22ff4c4
Update various policy files wrt the new staging repo 2019-01-06 15:48:21 +02:00
Lucas Käldström
0140c82c16
Updated references from k8s.io/{apiserver,apimachinery} to the new k8s.io/component-base repo. Co-authored-by @Klaven 2019-01-06 14:01:26 +02:00
Kubernetes Prow Robot
d3aa7b2cee
Merge pull request #72559 from andrewsykim/72499
Delete non-existent cloud provider nodes with Ready condition Unknown
2019-01-04 14:09:52 -08:00
Kubernetes Prow Robot
86691cad55
Merge pull request #72373 from krzysztof-jastrzebski/hpa_fix
Add request processing HPA into the queue after processing is finished.
2019-01-04 11:09:00 -08:00
Fabio Bertinatto
bb4fcddd1b Check PV requirements before scheduling pod 2019-01-04 12:33:18 +01:00
Krzysztof Jastrzebski
c6ebd126a7 Add request processing HPA into the queue after processing is finished.
This fixes a bug with skipping request inserted by resync because previous one hasn't processed yet.
2019-01-04 11:59:57 +01:00
andrewsykim
20c30d5cd1 delete non-existent nodes with Ready condition Unknown 2019-01-04 01:33:39 -05:00
Kubernetes Prow Robot
bfa5876311
Merge pull request #72383 from cheftako/owners
Adding cheftako to reviewers
2019-01-03 09:18:32 -08:00
Kubernetes Prow Robot
6e182ed5ea
Merge pull request #71816 from liggitt/service-account-lookup
Look up service accounts from informer before trying live lookup
2018-12-31 21:18:55 -08:00
Walter Fender
97426ce7a5 Adding cheftako to reviewers
Also adding as an owners to pkg/cloudprovider.
2018-12-27 15:25:20 -08:00
Jordan Liggitt
73dcfe12da Stop checking VolumeScheduling feature gate 2018-12-27 17:45:45 -05:00
Walter Fender
f192657380 Add gauge metric for master of leader election.
Fixes #71730
0 indicates standby, 1 indicates master, label indicates which lease.
Tweaked name and documentation
Factored in Mike Danese feedback.
Removed dependency on prometheus from client-go using adapter.
Centralized adapter import.
Fixed godeps
Fixed boilerplate.
Put in fixes for caesarxuchao
2018-12-27 09:40:33 -08:00
Kubernetes Prow Robot
eb79f8f279
Merge pull request #69615 from k82cn/update_node_ns
Fixed node namespace to none.
2018-12-23 23:39:09 -08:00
wangqingcan
b82a1d4600 Move predicate types from algorithm to predicates 2018-12-21 22:26:47 +08:00
Kubernetes Prow Robot
0d63cf9caa
Merge pull request #67037 from Huang-Wei/cleanup-ood
cleanup logic related with OutOfDisk
2018-12-20 17:30:27 -08:00
Kubernetes Prow Robot
fbc7114734
Merge pull request #72093 from WanLinghao/client_builder_log_fix
fix log information error
2018-12-20 00:02:30 -08:00
Kubernetes Prow Robot
00ca6939cb
Merge pull request #72038 from bowei/change-gce-cloud-provider
Change gce cloud provider
2018-12-19 14:13:55 -08:00
Jordan Liggitt
0ff455e340 generated files 2018-12-19 11:19:12 -05:00
Jordan Liggitt
fd9e9b01b1 Remove uses of extensions/v1beta1 clients 2018-12-19 11:18:53 -05:00
Weibin Lin
842bd1e1ec update deployment, daemonset, replicaset, statefulset to apps/v1 2018-12-19 10:46:45 -05:00
Kubernetes Prow Robot
ec4105a6d3
Merge pull request #66882 from ryanmcnamara/rm/stable-controllerrevisions-sort
Stably sort controllerrevisions
2018-12-19 00:51:29 -08:00
Dan Williams
2e339188ed OWNERS: add label:sig/network to a bunch of places 2018-12-19 00:00:02 -06:00
Kubernetes Prow Robot
33404d973a
Merge pull request #72174 from msau42/owners
Update sig-storage owners
2018-12-18 21:28:10 -08:00
Michelle Au
0b6fa24f65 Add msau42 to top-level volume approvers 2018-12-18 15:11:42 -08:00
Wei Huang
8f87e71e0c
cleanup logic related with OutOfDisk
- cleanup OOD logic in scheduling and node controller
- update comments and testcases
2018-12-18 11:28:02 -08:00
Bowei Du
4ffaf707c1 Add google k8s-cloud-provider to the import boss whitelist 2018-12-18 10:28:06 -08:00
Kubernetes Prow Robot
e2be7c91d9
Merge pull request #70344 from andrewsykim/consolidate-node-delete
consolidate node deletion logic between kube-controller-manager and cloud-controller-manager
2018-12-17 15:49:16 -08:00
WanLinghao
da3c019873 fix log information error 2018-12-17 12:03:39 +08:00
yuexiao-wang
7b6f60f085 modify BUILD
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
2018-12-11 11:22:06 +08:00
yuexiao-wang
f3353c358d [scheduler cleanup phase 2]: Rename to
Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>
2018-12-11 11:21:12 +08:00
Kubernetes Prow Robot
1a82272782
Merge pull request #71684 from danielqsj/typo-fix
Fix typos like limitting
2018-12-07 07:58:09 -08:00
Jordan Liggitt
a9dc919f82 Look up service accounts from informer before trying live lookup 2018-12-06 16:48:39 -05:00
Maciej Szulik
65e074fd1a Set delete propagation policy to background when removing jobs and its dependents 2018-12-06 17:20:23 +01:00
danielqsj
3c055aa4b4 Fix typos like limitting 2018-12-04 11:01:40 +08:00
andrewsykim
5329f09663 consolidate node deletion logic between node lifecycle and cloud node controller 2018-12-03 13:33:53 -05:00
k8s-ci-robot
79e5cb2cb7
Merge pull request #71302 from liggitt/verify-unit-test-feature-gates
Split mutable and read-only access to feature gates, limit tests to readonly access
2018-11-29 21:45:12 -08:00
k8s-ci-robot
550f6200c5
Merge pull request #67036 from Huang-Wei/update-ds-pod-tolerations
update logic of adding default DS pod tolerations
2018-11-29 19:04:17 -08:00
k8s-ci-robot
6d189fd316
Merge pull request #70838 from ping035627/k8s-181107
Fix the service_controller test cases and some syntax errors
2018-11-29 07:36:18 -08:00
Andrei Zhlobich
a8c58bcd24 Fix updating 'currentMetrics' field for HPA with 'AverageValue' target 2018-11-29 11:50:33 +01:00
Wei Huang
ad6e3617d3
update logic of adding default DS pod tolerations
- update DS pod default tolerations: add PIDPressure, remove OutOfDisk
- remove useless tolerations testcases
2018-11-29 01:18:32 -08:00
k8s-ci-robot
06a0ed7f3f
Merge pull request #70596 from neolit123/owners-controller
pkg/controller: add SIG label to OWNERS
2018-11-29 00:48:25 -08:00
k8s-ci-robot
3faeb7ba6f
Merge pull request #70360 from houjun41544/20181029-1
Fix an error in comment
2018-11-28 23:31:40 -08:00
k8s-ci-robot
0b78c0b45a
Merge pull request #67927 from k82cn/ds_approver
Volunteer to be DaemonSet controller maintainer.
2018-11-28 21:44:18 -08:00
Jordan Liggitt
2498ca7606 drop VerifyFeatureGatesUnchanged 2018-11-21 11:51:33 -05:00
Jordan Liggitt
70ad4dff48 Fix unit tests calling SetFeatureGateDuringTest incorrectly 2018-11-21 11:51:33 -05:00
Jordan Liggitt
4dca07ef7e Fixup incorrect use of DefaultFeatureGate.Set in tests 2018-11-21 11:51:33 -05:00
Jing Xu
562d0fea53 Handle failed attach operation leave uncertain volume attach state
This commit adds the unit tests for the PR. It also includes some files
that are affected by the function name changes.
2018-11-19 17:21:49 -08:00
Jing Xu
47331cf0a2 WIP: Handle failed attach operation leave uncertain volume attach state
This PR fixes issue #32727.

When an attach operation fails, it is still possible that the volume
will be attached to the node later. This PR adds the logic to record the
volume to node with attached state no matter whether the operation
succedded or not. If the operation fails, mark the attached state to
false. If the operation succeeded, mark the attached state to true. The
reconciler will still issue attach operation until it returns
successfully. If the pod is removed in the mean time, the reconciler
will issue detach operations for all the volumes no matter what is the
attached state.
2018-11-19 17:19:10 -08:00
Michelle Au
18453b01e6 Tolerate apiserver being older than controller-manager 2018-11-16 16:31:27 -08:00
Matthew Wong
dd517c9ff2 Update all tests to account for BlockVolume enabled by default 2018-11-16 13:38:59 -05:00
Jordan Liggitt
733dd9dfd7 Add tests to ensure feature gate changes don't escape kubelet/scheduler packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt
de8bf9b63d fix scheduler and kubelet unit tests leaking feature flag changes 2018-11-16 10:52:53 -05:00
Jordan Liggitt
248d661327 Add tests to ensure storage feature gate changes don't escape packages 2018-11-16 10:52:53 -05:00
Jordan Liggitt
358c092abe fix storage unit tests leaking feature flag changes 2018-11-16 10:52:52 -05:00
Michelle Au
fd64c08240 Fix storage feature gate test setting 2018-11-16 10:49:40 -05:00
Tomas Smetana
f9c9ef6ec0 PV Controller: fix recycling
In the situation when a PVC is deleted and a new one with the same name
bound to a different PV the "old" PV may fail to recycle since it's
associaded with a PVC that is detected as being in use. This may cause
the recycler processes to hang.
2018-11-15 16:38:25 +01:00
k8s-ci-robot
1a9fd268a9
Merge pull request #71005 from mikedanese/certpubfix
rootcacertpublisher: trigger resync on namespace add and update
2018-11-14 11:38:07 -08:00
k8s-ci-robot
a44c2b9eeb
Merge pull request #70035 from liggitt/retain-quota-metadata
Avoid dropping resourcequota metadata in controller
2018-11-14 01:29:53 -08:00
k8s-ci-robot
d3a21cf5a2
Merge pull request #70848 from cofyc/fix64590
Improve usability of CSI plugin metrics
2018-11-13 19:45:43 -08:00
PingWang
c32530ddf2 Fix the service_controller test cases and some syntax errors
Signed-off-by: PingWang <wang.ping5@zte.com.cn>

add test condition and remove TODO

Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update test

Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2018-11-14 08:29:58 +08:00
WanLinghao
fb3d1caf9b fix a typo error imported by https://github.com/kubernetes/kubernetes/pull/68812 2018-11-13 13:23:10 -08:00
Mike Danese
bf02f55147 rootcacertpublisher: trigger resync on namespace add and update
Last cleanup was a bit overzealous.
2018-11-13 11:38:45 -08:00
k8s-ci-robot
08784ad9af
Merge pull request #70842 from mikedanese/simplify
combine syncs in rootcacertpublisher
2018-11-12 12:01:45 -08:00
juanvallejo
18e969e8b6
update bazel 2018-11-12 10:13:48 -05:00
juanvallejo
9f1cc8571e
defer finalizing pods for cronjobs to server delete 2018-11-12 10:13:48 -05:00
mikeweiwei
31bbc17b2a Fix typos 2018-11-12 09:43:53 +08:00
Yecheng Fu
dfe0a08f05 Improve usability of CSI plugin metrics
Use full qualified plugin name if volume spec is present.
2018-11-12 09:21:49 +08:00
Mike Danese
206f5892a7 combine syncs in rootcacertpublisher
and some misc simplifications.
2018-11-11 11:29:32 -08:00
Davanum Srinivas
954996e231
Move from glog to klog
- Move from the old github.com/golang/glog to k8s.io/klog
- klog as explicit InitFlags() so we add them as necessary
- we update the other repositories that we vendor that made a similar
change from glog to klog
  * github.com/kubernetes/repo-infra
  * k8s.io/gengo/
  * k8s.io/kube-openapi/
  * github.com/google/cadvisor
- Entirely remove all references to glog
- Fix some tests by explicit InitFlags in their init() methods

Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
2018-11-10 07:50:31 -05:00
Mike Danese
1469bb413e finish controller name change and don't double check feature flag 2018-11-08 15:51:49 -08:00
k8s-ci-robot
3f5db92840
Merge pull request #68812 from WanLinghao/token_projection_ca_secret_create
Create Ca-certificate configmap  used by token projected volume
2018-11-08 10:57:25 -08:00
k8s-ci-robot
3c10143967
Merge pull request #60195 from humblec/glusterfs-pvspec-3
Refactor GlusterFS PV spec.
2018-11-08 00:24:39 -08:00
WanLinghao
efac533f92 To inject ca.crt into container when projected volume was specified, configmap should be created in each namespace.
This patch add a controller called "root-ca-cert-publisher" to complete above job as well as some bootstrap rbac policies.
2018-11-08 11:33:47 +08:00
Humble Chirammal
bdb051c72d Refactor GlusterFS PV spec.
This patch introduces glusterfsPersistentVolumeSource addition
to glusterfsVolumeSource. All fields remains same as glusterfsVolumeSource
with an addition of a new field
called `EndpointsNamespace` to define namespace of endpoint in the
spec.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2018-11-06 15:51:01 +05:30
Jordan Liggitt
360a890c58 serviceaccount subproject approvers/reviewers 2018-11-06 00:57:39 -05:00
Jordan Liggitt
4ebe084376 certificates subproject approvers/reviewers 2018-11-06 00:57:38 -05:00
Ryan McNamara
0aae852a3c Stably sort controllerrevisions
Fixes https://github.com/kubernetes/kubernetes/issues/61998

There are times when multiple "equal" controllerrevisions are created with
the same revision number. When this happens and this is the case for the
largest revision number, the statefulset controller will periodically
select one of the maximal controllerrevisions to be the target of the
underlying statefulset. The selection happens here: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/statefulset/stateful_set_control.go#L212.
Prior to this change this selection was random as the sort was not
stable, which caused the pods of a stable set to continually roll.
2018-11-05 16:01:05 -08:00
k8s-ci-robot
faabfd9455
Merge pull request #70575 from houjun41544/20181102
Replace getPVCName() with a variable
2018-11-02 21:28:41 -07:00
k8s-ci-robot
69f5f5eff2
Merge pull request #67978 from WanLinghao/token_controller_improve
remove idle tokens in kubelet token manager
2018-11-02 12:28:47 -07:00
Lubomir I. Ivanov
9d02982372 pkg/controller: add SIG label to OWNERS 2018-11-02 21:25:59 +02:00
k8s-ci-robot
6813ebb568
Merge pull request #67851 from aniket-s-kulkarni/flexvolume-resize-implementation
Flexvolume resize implementation
2018-11-02 10:47:01 -07:00
houjun
fc5dc1ffd8 Replace getPVCName() with a variable 2018-11-02 17:23:18 +08:00
k8s-ci-robot
4351cea80c
Merge pull request #70046 from cheftako/lintCleanGce
Fixed lint errors for pkg/cloudprovider/providers/gce.
2018-11-01 13:44:06 -07:00
k8s-ci-robot
e663a2cc6f
Merge pull request #68411 from saravanan30erd/68201-pkg-controller-apis
Update import-boss restrictions - pkg/controller
2018-10-31 13:07:28 -07:00
saravanan30erd
25d83664c6 Update import-boss restrictions - pkg/controller 2018-10-31 19:04:56 +04:00