Kubernetes Prow Robot
f9d987c7c8
Merge pull request #121106 from aojea/ipaddress_uid
...
Remove Ipaddress uid
2023-10-12 03:26:45 +02:00
Dejan Zele Pejchev
921c0d0180
cleanup: add defaulting for job manual selector ( #120206 )
...
* cleanup: add defaulting for job manual selector
* cleanup: add assert in job defaults test for manual selector
* cleanup: fix failing job storage test
* cleanup: fix batch fuzzer to handle manual selector default
* cleanup: fix lint issue on checking bool condition in job strategy
* cleanup: remove TODO in generateSelectors in job strategy Validate; inline job manual selector assignment in fuzzer
2023-10-11 22:51:40 +02:00
Antonio Ojea
b7ee8e8422
drop UID from the IPAddress.Spec.ParentRef
...
This field is not needed, IPAddresses are unique and
the name is canonicalized to avoid duplicates.
Change-Id: Iccaaf5d55e2af61fea7af9abd39584a80ed4054e
2023-10-10 11:03:19 +00:00
Antonio Ojea
566fad5eda
add metrics to the ipallocator repair loop
...
The repair loop are great for saving us of leaks, but the side effect
is that bugs can go unnoticed for a long time, so we need some
signal to be able to identify those errors proactivily.
Add two new metrics to identify:
- errors on the reconcile loop
- errors per clusterip
2023-09-30 15:46:06 +00:00
Antonio Ojea
4eff70dcf9
add metrics to the nodeport allocator repair loop
...
The repair loop are great for saving us of leaks, but the side effect
is that bugs can go unnoticed for a long time, so we need some
signal to be able to identify those errors proactivily.
Add two new metrics to identify:
- errors on the reconcile loop
- errors per nodeport
2023-09-30 15:46:06 +00:00
Antonio Ojea
21e26486ac
sync Service API status rest storage
...
The Service API Rest implementation is complex and has to use different
hooks on the REST storage. The status store was making a shallow copy of
the storage before adding the hooks, so it was not inheriting the hooks.
The status store must have the same hooks as the rest store to be able
to handle correctly the allocation and deallocation of ClusterIPs and
nodePorts.
Change-Id: I44be21468d36017f0ec41a8f912b8490f8f13f55
Signed-off-by: Antonio Ojea <aojea@google.com>
2023-09-13 11:35:42 +00:00
tao.yang
b35357b6c0
cleanup: omit comparison with bool constants
...
Signed-off-by: tao.yang <tao.yang@daocloud.io>
2023-09-05 10:24:38 +08:00
Kubernetes Prow Robot
5d94b2a8e8
Merge pull request #118709 from ty-dc/pr/ut
...
[UT] add ut for pkg/registry/networking/ipaddress
2023-09-04 02:49:48 -07:00
Kubernetes Prow Robot
efadb94a74
Merge pull request #120259 from SataQiu/clean-apf-20230830
...
apf: remove v1alpha1 API
2023-08-31 19:44:42 -07:00
Quan Tian
2b69daa960
Allow specifying ExternalTrafficPolicy for ClusterIP Services with ExternalIPs
...
When defining a ClusterIP Service, we can specify externalIP, and the
traffic policy of externalIP is subject to externalTrafficPolicy.
However, the policy can't be set when type is not NodePort or
LoadBalancer, and will default to Cluster when kube-proxy processes the
Service.
This commit updates the defaulting and validation of Service to allow
specifying ExternalTrafficPolicy for ClusterIP Services with
ExternalIPs.
Signed-off-by: Quan Tian <qtian@vmware.com>
2023-08-30 23:56:47 +08:00
SataQiu
2825519da2
apf: remove v1alpha1 API
2023-08-30 20:48:42 +08:00
Kubernetes Prow Robot
370c85f5ab
Merge pull request #118493 from kerthcet/cleanup/pod-status-reason
...
Remove reasons from PodConditionType
2023-08-30 01:40:47 -07:00
Kubernetes Prow Robot
df8bfdf55e
Merge pull request #120102 from p0lyn0mial/upstream-storage-etcd-new-params
...
storage/factory: extend the Create method by newList and resourcePrefix params
2023-08-24 05:22:32 -07:00
Lukasz Szaszkiewicz
ccabc01093
storage/factory: extend the Create method by newList and resourcePrefix params
2023-08-24 11:23:05 +02:00
Kubernetes Prow Robot
c034f321f9
Merge pull request #119879 from togettoyou/cleanup
...
Fix receiver names in legacyProvider
2023-08-23 08:07:29 -07:00
Kubernetes Prow Robot
c0691f3784
Merge pull request #119789 from thockin/deprecate_svc_lb_ingress_with_clusterip
...
Gate: disallow .status.loadBalancer on non-LB svc
2023-08-22 10:02:55 -07:00
Patrick Ohly
2472291790
api: introduce separate VolumeResourceRequirements struct
...
PVC and containers shared the same ResourceRequirements struct to define their
API. When resource claims were added, that struct got extended, which
accidentally also changed the PVC API. To avoid such a mistake from happening
again, PVC now uses its own VolumeResourceRequirements struct.
The `Claims` field gets removed because risk of breaking someone is low:
theoretically, YAML files which have a claims field for volumes now
get rejected when validating against the OpenAPI. Such files
have never made sense and should be fixed.
Code that uses the struct definitions needs to be updated.
2023-08-21 15:31:28 +02:00
Tim Hockin
a930892769
Gate: disallow .status.loadBalancer on non-LB svc
...
The fact that the .status.loadBalancer field can be set while .spec.type
is not "LoadBalancer" is a flub. Any spec update will already clear
.status.ingress, so it's hard to really rely on this. After this
change, updates which try to set this combination will fail validation.
Existing cases of this will not be broken. Any spec/metadata update
will clear it (no error) and this is the only stanza of status.
New gate "AllowServiceLBStatusOnNonLB" is off by default, but can be
enabled if this change actually breaks someone, which seems exceeedingly
unlikely.
2023-08-20 16:40:41 -07:00
Kubernetes Prow Robot
ee265c92fe
Merge pull request #119937 from RyanAoh/kep-1860-dev
...
Make Kubernetes aware of the LoadBalancer behaviour
2023-08-17 14:00:28 -07:00
git-jxj
a5b3a4b738
cleanup: Update deprecated FromInt to FromInt32 ( #119858 )
...
* redo commit
* apply suggestions from liggitt
* update Parse function based on suggestions
2023-08-16 09:33:01 -07:00
Kubernetes Prow Robot
fd4109d5f6
Merge pull request #119732 from sairameshv/pdb-fix
...
Fix to honor PDB with an empty selector `{}`
2023-08-15 19:44:00 -07:00
Aohan Yang
3ac2899d2b
Add IP mode field
2023-08-14 11:24:49 +08:00
Junhao Zou
509ffe2938
Fix receiver names in legacyProvider
2023-08-10 14:59:46 +08:00
Mark Rossetti
0d90d1ffa5
Revert "Merge pull request #118895 from RyanAoh/kep-1860"
...
This reverts commit 890a6c8f704f60a8d493
2023-08-09 15:51:20 -07:00
Sai Ramesh Vanka
a6329ac453
Fix to honor PDB with an empty selector {}
...
PDB with an empty selector `{}` is selecting all the pods in a namespace.
But, during the `drain`, all the pods are getting evicted which is not expected.
This change should fix the issue and honor the pdb before evicting the pods.
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
2023-08-08 17:28:48 +05:30
Kubernetes Prow Robot
18f8cb8398
Merge pull request #118644 from alexzielenski/apiserver/policy/namespaceParamRef
...
KEP-3488: Promote ValidatingAdmissionPolicy to Beta
2023-07-21 17:44:08 -07:00
Kubernetes Prow Robot
f3a070f9c6
Merge pull request #116469 from RomanBednar/pv-phase-transition-time
...
PersistentVolume last phase transition time
2023-07-21 16:10:07 -07:00
Roman Bednar
a9c3444a47
test: add coverage for pv status update and create strategy
2023-07-21 21:39:16 +02:00
Roman Bednar
aa65bab426
implement pv last phase transition time
2023-07-21 20:42:25 +02:00
Roman Bednar
a31fee98f0
rename function for dropping disabled fields
...
The function should indicate it is specific for dropping spec fields.
2023-07-21 17:19:11 +02:00
Alexander Zielenski
88becfc0ba
api: add v1beta1 ValidatingAdmissionPolicy/Binding types and storage
2023-07-20 13:24:09 -07:00
Kubernetes Prow Robot
5766947ab8
Merge pull request #119437 from serathius/etcd-semantics
...
Fix the semantic meaning of etcd server within component statuses and metrics.
2023-07-20 13:18:22 -07:00
Kubernetes Prow Robot
8a053c700a
Merge pull request #119215 from alexzielenski/apiserver/policy/namespaceParamRef-alpha
...
KEP-3488: Per namespace policy params
2023-07-20 13:18:10 -07:00
Alexander Zielenski
c8dbf4712c
add namespaceParamRef to v1alpha1 and internal
...
add required field to validation test
test multiple combinartions of paramRefs in binding tests
add validation test cases for new ParamRef fields
2023-07-20 09:30:09 -07:00
Marek Siarkowicz
03aad1f823
Fix the semantic meaning of etcd server within component statuses and metrics.
...
Instead of numerating all the etcd endpoints known by apiserver, we will
group them by purpose. `etcd-0` will be the default etcd, `etcd-1` will
be the first resource override, `etcd-2` will be the second override and
so on.
2023-07-20 15:08:41 +02:00
kannon92
ce92952037
add podReplacementPolicy and terminating field to job api
2023-07-19 16:34:38 +00:00
Kubernetes Prow Robot
f3f5dd99ac
Merge pull request #119294 from mimowo/backoff-limit-per-index-api
...
Extend the Job API for BackoffLimitPerIndex
2023-07-18 10:05:21 -07:00
Kubernetes Prow Robot
56b59c89f5
Merge pull request #117666 from carlory/fix-008
...
Remove ability to re-enable serving deprecated policyv1beta1 APIs
2023-07-18 08:41:12 -07:00
Michal Wozniak
fcbfdc1710
Extend the Job API for BackoffLimitPerIndex
2023-07-18 11:28:15 +02:00
carlory
850dc6123a
Remove ability to re-enable serving deprecated policyv1beta1 APIs
2023-07-18 10:24:26 +08:00
Aohan Yang
e6863757f4
Add IP mode field
2023-07-17 15:51:40 +08:00
Mike Spreitzer
2069835094
Tolerate only the two allowed field changes
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-07-14 01:01:43 +00:00
Abu Kashem
3754d2da20
apf: allow admin to change the Exempt field only of the exempt pl
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-07-14 01:01:29 +00:00
Dr. Stefan Schimanski
f1f2fa9da8
kube-apiserver/corerest: split apart generic code
2023-07-12 14:13:10 +02:00
Dr. Stefan Schimanski
a34e06e74c
kube-apiserver/corerest: structure Config
2023-07-11 17:27:20 +02:00
Dr. Stefan Schimanski
75e3576523
kube-apiserver: rewire service controllers: kubernetesservice + IP repair
2023-07-11 17:27:20 +02:00
Dr. Stefan Schimanski
c733c57962
pkg/controlplane: wire core storage as RESTStorageProvider
2023-07-05 16:46:40 +02:00
Dr. Stefan Schimanski
68aee61d4f
SPLIT: kube-apiserver/corerest: split out service IP setup logic
2023-07-05 11:00:37 +02:00
Dr. Stefan Schimanski
dad3e4d211
SPLIT: kube-apiserver/corerest: split constructor
2023-07-05 09:45:20 +02:00
Dr. Stefan Schimanski
616c959988
FIXUP: pkg/controlplane: move bootstrap controller to controllers/kubernetesservice
2023-07-04 16:38:14 +02:00
Dr. Stefan Schimanski
19cb6d036a
kube-apiserver/corerest: remove redundant interface
2023-07-03 15:27:09 +02:00
Kubernetes Prow Robot
a8cc22f416
Merge pull request #118680 from danwinship/not-that-kind-of-proxying
...
move an apiserver helper function out of pkg/proxy
2023-07-03 02:28:51 -07:00
Dan Winship
bb0c3a0818
Remove proxyutil.IsProxyableIP / IsProxyableHostname
...
These don't belong in pkg/proxy/util; they involve a completely
unrelated definition of proxying.
Since each is only used from one place, just inline them at the
callers.
2023-07-01 08:49:38 -04:00
Patrick Ohly
a5df442be7
flowcontrol: copy object before passing it to client-go Create to avoid data race
...
This is similar to 5e1c6cd0d4
2023-06-30 09:55:25 +02:00
Kubernetes Prow Robot
ba6d2674ca
Merge pull request #118722 from aojea/ip_leading_zeros
...
ipallocator bug if ips has leading zeros
2023-06-25 07:11:07 -07:00
Antonio Ojea
e4f93d8a82
ipallocator bug if ips has leading zeros
...
The ipallocator for the new IPAddress object use the golang big.Int
library for some math operations, like adding an offset to an IP
address.
We use the bytes array to convert between big.Int and IP addresses,
however, IP addresses are always represented as 4 or 16 bytes arrays.
Big int bytes representations just return the byte array until the
most representative number, this requires that we need to prepend
these extra bytes for IPs with leading zeros.
Change-Id: I9d539f582cae1f9f4e373b28c5b94d7a342f09c7
Signed-off-by: Antonio Ojea <aojea@google.com>
2023-06-25 13:14:46 +00:00
Mike Spreitzer
92a35f5bca
Usse generics to simplify pkg/registry/flowcontrol/ensurer
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-06-22 00:56:54 -04:00
tao.yang
f2879eed00
[UT] add ut for pkg/registry/networking/ipaddress
...
Signed-off-by: tao.yang <tao.yang@daocloud.io>
2023-06-19 10:12:34 +08:00
Aldo Culquicondor
c27f9fdeb7
Add warnings for big number of completions and parallelism
...
Change-Id: I63e192b1ce9da7d8bb04f8be1a6e19ec6fbbfa5a
2023-06-14 10:38:42 -04:00
Kubernetes Prow Robot
e80e6b8e5a
Merge pull request #118597 from tkashem/apf-refactor
...
apf: refactor bootstrap ensure strategy
2023-06-13 04:59:58 -07:00
Kubernetes Prow Robot
3b44969134
Merge pull request #118460 from serathius/componentstatuses
...
Make etcd component status consistent with health probes
2023-06-13 02:17:58 -07:00
Marek Siarkowicz
a60314c47e
Make etcd component status consistent with health probes
...
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
2023-06-13 10:10:29 +02:00
Abu Kashem
672614b57e
apf: refactor bootstrap ensure strategy
2023-06-09 13:31:23 -04:00
Tim Hockin
151509fb74
Remove unreachable warning on volume name dup
...
Volume names are validated to be unique and always have been. The cited
issues are all about apply getting messed up, not the aspiserver
allowing dups.
```
$ k create -f /tmp/bad.yaml
The Deployment "bad-volumes-test" is invalid: spec.template.spec.volumes[1].name: Duplicate value: "config"
$ k apply --server-side -f /tmp/bad.yaml
Error from server: failed to create typed patch object (default/bad-volumes-test; apps/v1, Kind=Deployment): .spec.template.spec.volumes: duplicate entries for key [name="config"]
$ k apply -f /tmp/bad.yaml -o json | jq '.spec.template.spec.volumes'
The Deployment "bad-volumes-test" is invalid: spec.template.spec.volumes[1].name: Duplicate value: "config"
```
2023-06-07 17:14:49 -07:00
kerthcet
96ab232f5f
Remove reasons from PodConditionType
...
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-06-07 11:47:47 +08:00
Tobias Klauser
0f5535ea25
registry/core/service: remove incorrect comments
...
These interface methods are not only used for testing. Remove the
incorrect comments.
2023-05-22 12:35:43 +02:00
Kubernetes Prow Robot
1d6158e11b
Merge pull request #117993 from liggitt/shortnames
...
Undo 1.28 shortname additions for now
2023-05-15 11:05:27 -07:00
Kubernetes Prow Robot
1487fc762f
Merge pull request #117982 from jpbetz/sig-roles-jpbetz
...
Add api-machinery TL owners permissions for jpbetz
2023-05-15 09:07:29 -07:00
Joe Betz
f0f92853ad
Add api-machinery TL owners permissions for jpbetz
2023-05-15 11:09:54 -04:00
Kubernetes Prow Robot
11218f10aa
Merge pull request #117061 from AxeZhan/duplicate_validation
...
remove duplicate validation for csi
2023-05-14 12:51:26 -07:00
Jordan Liggitt
815578295a
Revert "support short name for flowschema and prioritylevelconfiguration"
...
This reverts commit 3dd0c41663
2023-05-13 11:11:04 -04:00
Jordan Liggitt
72202f9a00
Revert "add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations"
...
This reverts commit 7514d8b333
2023-05-13 11:10:55 -04:00
Daniel Smith
1ffe3f467e
lavalamp is taking a long break
2023-05-11 16:43:38 +00:00
Tim Hockin
4bbf611773
Retool validation for pod HostNetwork ports
...
This will ensure that HostPort == ContainerPort for pods and that
HostPort == 0 || HostPort == ContainerPort for embedded PodSpecs.
2023-05-09 18:10:44 -07:00
Kubernetes Prow Robot
a9b08f4cc2
Merge pull request #117642 from carlory/fix-001
...
remove ability to re-enable serving deprecated node.k8s.io/v1beta1 types
2023-05-09 09:35:56 -07:00
Kubernetes Prow Robot
51ffca216c
Merge pull request #117535 from hysyeah/feature/webhookconfiguration-shortnames
...
add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations
2023-05-05 09:17:32 -07:00
Mike Spreitzer
008576da07
Improve and simplify maintenance of APF bootstrap objects
...
Prepare to make deletion of unwanted object conditional on ResourceVersion.
Remove unnecessary split between finding unwanted objects and removing
them.
Remove unnecessary layers of indirection to reach constant logic.
Use interfaces to remove need for type assertions.
Threaded context into APF object maintenance
Note and respect immutability of desired bootstrap objects
2023-05-05 09:36:48 -04:00
Kubernetes Prow Robot
f5e361e4e6
Merge pull request #117107 from pohly/test-integration-race-detection-flowcontrol
...
pkg/registry/flowcontrol: avoid race condition during Create
2023-05-05 00:09:24 -07:00
Kubernetes Prow Robot
3cd81876bd
Merge pull request #116208 from kkkkun/support-short-name-for-flowschema-and-prioritylevelconfigurations
...
support short name for flowschema and prioritylevelconfiguration
2023-05-05 00:09:12 -07:00
Jordan Liggitt
e807a6aec5
Disable NewVolumeManagerReconstruction feature gate
2023-05-04 16:41:20 -04:00
Kubernetes Prow Robot
7add692580
Merge pull request #117633 from kannon92/remove-job-tracking-finalizers
...
remove tracking annotation from validation and webhooks
2023-05-04 10:34:43 -07:00
Kubernetes Prow Robot
78833e1b33
Merge pull request #117713 from flant/ssr-ga
...
KEP-3325: Promote SelfSubjectReview to GA
2023-05-03 08:54:24 -07:00
carlory
e7396e3551
remove ability to re-enable serving deprecated versions of the runtimeclasses kind
2023-05-02 22:40:26 +08:00
m.nabokikh
40de26dcff
KEP-3325: Promote SelfSubjectReview to GA
...
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
2023-05-02 14:50:40 +02:00
Ricardo Katz
bff8a6cd9f
Remove withdrawn feature NetworkPolicyStatus
2023-05-01 15:19:25 -03:00
Stephen Kitt
026e7c7cb3
registry: replace intstr.FromInt with intstr.FromInt32
...
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2023-05-01 09:17:45 +02:00
carlory
da922f0af6
Remove ability to re-enable serving deprecated discoveryv1beta1 APIs
2023-04-30 19:21:46 +08:00
carlory
944a4cd311
Remove ability to re-enable serving deprecated autoscalingapiv2beta APIs
2023-04-29 16:51:48 +08:00
Kubernetes Prow Robot
4ca7bcec24
Merge pull request #117665 from carlory/fix-007
...
Remove ability to re-enable serving deprecated eventv1beta1 APIs
2023-04-28 11:08:27 -07:00
carlory
f81b49d873
Remove ability to re-enable serving deprecated eventv1beta1 APIs
2023-04-28 14:58:59 +08:00
carlory
48d01d6d9b
Remove ability to re-enable serving deprecated batchapiv1beta1 APIs
2023-04-28 14:08:31 +08:00
kannon92
6a4cf352b8
remove tracking annotation from validation and webhooks
2023-04-26 17:16:05 +00:00
Sheng Zhan
892ebf2d25
Ensure version "*" is passed instead of "" for all authz checks ( #116937 )
...
* ensure version * is passed instead of for all authz checks
* unexport match function
* remove allversion constant
2023-04-25 09:06:18 -07:00
hysyeah
7514d8b333
add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations
2023-04-23 18:32:49 +08:00
Kubernetes Prow Robot
25a25e27a9
Merge pull request #110477 from halfcrazy/feat/hostnetwork-fieldsel
...
support fieldSelector spec.hostNetwork
2023-04-21 18:13:11 -07:00
Yan Zhu
7fb88eec73
support fieldSelector spec.hostNetwork
...
Signed-off-by: Yan Zhu <hackzhuyan@gmail.com>
2023-04-17 13:19:35 +08:00
Tim Hockin
bc302fa414
Replace uses of ObjectReflectDiff with cmp.Diff
...
ObjectReflectDiff is already a shim over cmp.Diff, so no actual output
or behavior changes
2023-04-12 08:48:03 -07:00
Tim Hockin
29c0b73d64
Replace uses of diff.ObjectDiff with cmp.Diff
...
ObjectDiff is already a shim over cmp.Diff, so no actual output or
behavior changes
2023-04-12 08:46:12 -07:00
Patrick Ohly
5e1c6cd0d4
pkg/registry/flowcontrol: avoid race condition during Create
...
k8s.io/kubernetes/test/integration/controlplane.TestReconcilerAPIServerLeaseMultiCombined
suffered from race conditions. The underlying reason is that
330b5a2b8d/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go (L221-L243)
2023-04-05 15:59:22 +02:00
kidddddddddddddddddddddd
cc8cd88a94
remove duplicate validation for csi
2023-04-03 16:41:09 +08:00
