Dr. Stefan Schimanski
19cb6d036a
kube-apiserver/corerest: remove redundant interface
2023-07-03 15:27:09 +02:00
Kubernetes Prow Robot
a8cc22f416
Merge pull request #118680 from danwinship/not-that-kind-of-proxying
...
move an apiserver helper function out of pkg/proxy
2023-07-03 02:28:51 -07:00
Dan Winship
bb0c3a0818
Remove proxyutil.IsProxyableIP / IsProxyableHostname
...
These don't belong in pkg/proxy/util; they involve a completely
unrelated definition of proxying.
Since each is only used from one place, just inline them at the
callers.
2023-07-01 08:49:38 -04:00
Patrick Ohly
a5df442be7
flowcontrol: copy object before passing it to client-go Create to avoid data race
...
This is similar to 5e1c6cd0d4
2023-06-30 09:55:25 +02:00
Kubernetes Prow Robot
ba6d2674ca
Merge pull request #118722 from aojea/ip_leading_zeros
...
ipallocator bug if ips has leading zeros
2023-06-25 07:11:07 -07:00
Antonio Ojea
e4f93d8a82
ipallocator bug if ips has leading zeros
...
The ipallocator for the new IPAddress object use the golang big.Int
library for some math operations, like adding an offset to an IP
address.
We use the bytes array to convert between big.Int and IP addresses,
however, IP addresses are always represented as 4 or 16 bytes arrays.
Big int bytes representations just return the byte array until the
most representative number, this requires that we need to prepend
these extra bytes for IPs with leading zeros.
Change-Id: I9d539f582cae1f9f4e373b28c5b94d7a342f09c7
Signed-off-by: Antonio Ojea <aojea@google.com>
2023-06-25 13:14:46 +00:00
Mike Spreitzer
92a35f5bca
Usse generics to simplify pkg/registry/flowcontrol/ensurer
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-06-22 00:56:54 -04:00
tao.yang
f2879eed00
[UT] add ut for pkg/registry/networking/ipaddress
...
Signed-off-by: tao.yang <tao.yang@daocloud.io>
2023-06-19 10:12:34 +08:00
Aldo Culquicondor
c27f9fdeb7
Add warnings for big number of completions and parallelism
...
Change-Id: I63e192b1ce9da7d8bb04f8be1a6e19ec6fbbfa5a
2023-06-14 10:38:42 -04:00
Kubernetes Prow Robot
e80e6b8e5a
Merge pull request #118597 from tkashem/apf-refactor
...
apf: refactor bootstrap ensure strategy
2023-06-13 04:59:58 -07:00
Kubernetes Prow Robot
3b44969134
Merge pull request #118460 from serathius/componentstatuses
...
Make etcd component status consistent with health probes
2023-06-13 02:17:58 -07:00
Marek Siarkowicz
a60314c47e
Make etcd component status consistent with health probes
...
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
2023-06-13 10:10:29 +02:00
Abu Kashem
672614b57e
apf: refactor bootstrap ensure strategy
2023-06-09 13:31:23 -04:00
Tim Hockin
151509fb74
Remove unreachable warning on volume name dup
...
Volume names are validated to be unique and always have been. The cited
issues are all about apply getting messed up, not the aspiserver
allowing dups.
```
$ k create -f /tmp/bad.yaml
The Deployment "bad-volumes-test" is invalid: spec.template.spec.volumes[1].name: Duplicate value: "config"
$ k apply --server-side -f /tmp/bad.yaml
Error from server: failed to create typed patch object (default/bad-volumes-test; apps/v1, Kind=Deployment): .spec.template.spec.volumes: duplicate entries for key [name="config"]
$ k apply -f /tmp/bad.yaml -o json | jq '.spec.template.spec.volumes'
The Deployment "bad-volumes-test" is invalid: spec.template.spec.volumes[1].name: Duplicate value: "config"
```
2023-06-07 17:14:49 -07:00
kerthcet
96ab232f5f
Remove reasons from PodConditionType
...
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-06-07 11:47:47 +08:00
Tobias Klauser
0f5535ea25
registry/core/service: remove incorrect comments
...
These interface methods are not only used for testing. Remove the
incorrect comments.
2023-05-22 12:35:43 +02:00
Kubernetes Prow Robot
1d6158e11b
Merge pull request #117993 from liggitt/shortnames
...
Undo 1.28 shortname additions for now
2023-05-15 11:05:27 -07:00
Kubernetes Prow Robot
1487fc762f
Merge pull request #117982 from jpbetz/sig-roles-jpbetz
...
Add api-machinery TL owners permissions for jpbetz
2023-05-15 09:07:29 -07:00
Joe Betz
f0f92853ad
Add api-machinery TL owners permissions for jpbetz
2023-05-15 11:09:54 -04:00
Kubernetes Prow Robot
11218f10aa
Merge pull request #117061 from AxeZhan/duplicate_validation
...
remove duplicate validation for csi
2023-05-14 12:51:26 -07:00
Jordan Liggitt
815578295a
Revert "support short name for flowschema and prioritylevelconfiguration"
...
This reverts commit 3dd0c41663
2023-05-13 11:11:04 -04:00
Jordan Liggitt
72202f9a00
Revert "add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations"
...
This reverts commit 7514d8b333
2023-05-13 11:10:55 -04:00
Daniel Smith
1ffe3f467e
lavalamp is taking a long break
2023-05-11 16:43:38 +00:00
Tim Hockin
4bbf611773
Retool validation for pod HostNetwork ports
...
This will ensure that HostPort == ContainerPort for pods and that
HostPort == 0 || HostPort == ContainerPort for embedded PodSpecs.
2023-05-09 18:10:44 -07:00
Kubernetes Prow Robot
a9b08f4cc2
Merge pull request #117642 from carlory/fix-001
...
remove ability to re-enable serving deprecated node.k8s.io/v1beta1 types
2023-05-09 09:35:56 -07:00
Kubernetes Prow Robot
51ffca216c
Merge pull request #117535 from hysyeah/feature/webhookconfiguration-shortnames
...
add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations
2023-05-05 09:17:32 -07:00
Mike Spreitzer
008576da07
Improve and simplify maintenance of APF bootstrap objects
...
Prepare to make deletion of unwanted object conditional on ResourceVersion.
Remove unnecessary split between finding unwanted objects and removing
them.
Remove unnecessary layers of indirection to reach constant logic.
Use interfaces to remove need for type assertions.
Threaded context into APF object maintenance
Note and respect immutability of desired bootstrap objects
2023-05-05 09:36:48 -04:00
Kubernetes Prow Robot
f5e361e4e6
Merge pull request #117107 from pohly/test-integration-race-detection-flowcontrol
...
pkg/registry/flowcontrol: avoid race condition during Create
2023-05-05 00:09:24 -07:00
Kubernetes Prow Robot
3cd81876bd
Merge pull request #116208 from kkkkun/support-short-name-for-flowschema-and-prioritylevelconfigurations
...
support short name for flowschema and prioritylevelconfiguration
2023-05-05 00:09:12 -07:00
Jordan Liggitt
e807a6aec5
Disable NewVolumeManagerReconstruction feature gate
2023-05-04 16:41:20 -04:00
Kubernetes Prow Robot
7add692580
Merge pull request #117633 from kannon92/remove-job-tracking-finalizers
...
remove tracking annotation from validation and webhooks
2023-05-04 10:34:43 -07:00
Kubernetes Prow Robot
78833e1b33
Merge pull request #117713 from flant/ssr-ga
...
KEP-3325: Promote SelfSubjectReview to GA
2023-05-03 08:54:24 -07:00
carlory
e7396e3551
remove ability to re-enable serving deprecated versions of the runtimeclasses kind
2023-05-02 22:40:26 +08:00
m.nabokikh
40de26dcff
KEP-3325: Promote SelfSubjectReview to GA
...
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
2023-05-02 14:50:40 +02:00
Ricardo Katz
bff8a6cd9f
Remove withdrawn feature NetworkPolicyStatus
2023-05-01 15:19:25 -03:00
Stephen Kitt
026e7c7cb3
registry: replace intstr.FromInt with intstr.FromInt32
...
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2023-05-01 09:17:45 +02:00
carlory
da922f0af6
Remove ability to re-enable serving deprecated discoveryv1beta1 APIs
2023-04-30 19:21:46 +08:00
carlory
944a4cd311
Remove ability to re-enable serving deprecated autoscalingapiv2beta APIs
2023-04-29 16:51:48 +08:00
Kubernetes Prow Robot
4ca7bcec24
Merge pull request #117665 from carlory/fix-007
...
Remove ability to re-enable serving deprecated eventv1beta1 APIs
2023-04-28 11:08:27 -07:00
carlory
f81b49d873
Remove ability to re-enable serving deprecated eventv1beta1 APIs
2023-04-28 14:58:59 +08:00
carlory
48d01d6d9b
Remove ability to re-enable serving deprecated batchapiv1beta1 APIs
2023-04-28 14:08:31 +08:00
kannon92
6a4cf352b8
remove tracking annotation from validation and webhooks
2023-04-26 17:16:05 +00:00
Sheng Zhan
892ebf2d25
Ensure version "*" is passed instead of "" for all authz checks ( #116937 )
...
* ensure version * is passed instead of for all authz checks
* unexport match function
* remove allversion constant
2023-04-25 09:06:18 -07:00
hysyeah
7514d8b333
add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations
2023-04-23 18:32:49 +08:00
Kubernetes Prow Robot
25a25e27a9
Merge pull request #110477 from halfcrazy/feat/hostnetwork-fieldsel
...
support fieldSelector spec.hostNetwork
2023-04-21 18:13:11 -07:00
Yan Zhu
7fb88eec73
support fieldSelector spec.hostNetwork
...
Signed-off-by: Yan Zhu <hackzhuyan@gmail.com>
2023-04-17 13:19:35 +08:00
Tim Hockin
bc302fa414
Replace uses of ObjectReflectDiff with cmp.Diff
...
ObjectReflectDiff is already a shim over cmp.Diff, so no actual output
or behavior changes
2023-04-12 08:48:03 -07:00
Tim Hockin
29c0b73d64
Replace uses of diff.ObjectDiff with cmp.Diff
...
ObjectDiff is already a shim over cmp.Diff, so no actual output or
behavior changes
2023-04-12 08:46:12 -07:00
Patrick Ohly
5e1c6cd0d4
pkg/registry/flowcontrol: avoid race condition during Create
...
k8s.io/kubernetes/test/integration/controlplane.TestReconcilerAPIServerLeaseMultiCombined
suffered from race conditions. The underlying reason is that
330b5a2b8d/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go (L221-L243)
2023-04-05 15:59:22 +02:00
kidddddddddddddddddddddd
cc8cd88a94
remove duplicate validation for csi
2023-04-03 16:41:09 +08:00
Paco Xu
b83600de01
fix nil pointer dereference panic for deprecated metrics
2023-03-24 18:50:43 +08:00
Kubernetes Prow Robot
15894cfc85
Merge pull request #116550 from alculquicondor/fix-bind-uid
...
Preserve UID and ResourceVersion in BindingREST
2023-03-20 08:49:20 -07:00
Aldo Culquicondor
62889f416c
Preserve UID/ResourceVersion in the BindingREST endpoint
...
Change-Id: If4023da10c455963a320fdb9fc2a73c099bea3db
2023-03-20 10:29:25 -04:00
Kubernetes Prow Robot
fe91bc257b
Merge pull request #116554 from atiratree/eviction-resource-version-fix
...
API-initiated eviction: handle deleteOptions correctly
2023-03-17 16:59:15 -07:00
Filip Křepinský
51c0e2374f
API-initiated eviction: handle deleteOptions correctly
...
when adding a DisruptionTarget condition into a pod that will be deleted
- handle ResourceVersion and Preconditions correctly
- handle DryRun option correctly
Co-authored-by: Jordan Liggitt jordan@liggitt.net
2023-03-17 22:18:07 +01:00
Taahir Ahmed
6a75e7c40c
ClusterTrustBundles: Define types
...
This commit is the main API piece of KEP-3257 (ClusterTrustBundles).
This commit:
* Adds the certificates.k8s.io/v1alpha1 API group
* Adds the ClusterTrustBundle type.
* Registers the new type in kube-apiserver.
* Implements the type-specfic validation specified for
ClusterTrustBundles:
- spec.pemTrustAnchors must always be non-empty.
- spec.signerName must be either empty or a valid signer name.
- Changing spec.signerName is disallowed.
* Implements the "attest" admission check to restrict actions on
ClusterTrustBundles that include a signer name.
Because it wasn't specified in the KEP, I chose to make attempts to
update the signer name be validation errors, rather than silently
ignored.
I have tested this out by launching these changes in kind and
manipulating ClusterTrustBundle objects in the resulting cluster using
kubectl.
2023-03-15 20:10:18 -07:00
Kubernetes Prow Robot
8decaf3ae7
Merge pull request #115447 from kidddddddddddddddddddddd/ingress
...
[ingress] Create with ingressClass annotation and IngressClassName both set
2023-03-15 02:02:16 -07:00
Igor Velichkovich
5e5b3029f3
Matchconditions admission webhooks alpha implementation for kep-3716 ( #116261 )
...
* api changes adding match conditions
* feature gate and registry strategy to drop fields
* matchConditions logic for admission webhooks
* feedback
* update test
* import order
* bears.com
* update fail policy ignore behavior
* update docs and matcher to hold fail policy as non-pointer
* update matcher error aggregation, fix early fail failpolicy ignore, update docs
* final cleanup
* openapi gen
2023-03-14 20:28:26 -07:00
Kubernetes Prow Robot
f44d561c1f
Merge pull request #115075 from aojea/ipaddress
...
IPAddress allocator
2023-03-14 19:26:13 -07:00
kidddddddddddddddddddddd
ac626f8abc
remove test in strategy_test
2023-03-15 09:47:10 +08:00
Kubernetes Prow Robot
f3aebc85b9
Merge pull request #114930 from kannon92/add-new-labels
...
Add batch.kubernetes.io to labels created in the Job controller.
2023-03-14 17:44:13 -07:00
Kubernetes Prow Robot
f7bcff44cd
Merge pull request #116425 from jsafrane/flip-selinux
...
Flip SELinuxMountReadWriteOncePod to Beta
2023-03-14 16:34:41 -07:00
Antonio Ojea
756f1bfe99
add repair loop
...
Change-Id: I63464bdd5db706ddf7dc5d828b8d03ad532d7981
2023-03-14 22:58:11 +00:00
Antonio Ojea
b2c8190ee7
allow to set the service reference on the allocator
2023-03-14 22:58:11 +00:00
Antonio Ojea
e6f197a991
plumb new ipallocators in the apiserver
...
plumb the new allocators from the control-plane instance to the
registry_core
Change-Id: I240cc91942260f725492597f1b599f7480560b1e
2023-03-14 22:58:11 +00:00
Antonio Ojea
b022475448
clusterip allocator based on IPAddress API
...
add a new ClusterIP allocator that uses the new IPAddress API resource
and an informer as the backend, instead a bitmap snapshotted on etcd.
Change-Id: Ia891a2900acd2682d4d169abab65cdd9270a8445
2023-03-14 22:58:11 +00:00
Antonio Ojea
aa18a0cd3f
enable IPAddress on storage
...
Change-Id: Iaeac050223bb7db6acba601aa9b7254c74f2b5d2
2023-03-14 22:58:11 +00:00
Antonio Ojea
a2dfbd6117
Add IPAddress API to the REST registry
...
ipaddress registry storage
don't generate names for ipaddress
2023-03-14 22:58:11 +00:00
Jan Safranek
a53c6f1dc8
Add validation of CSIDriver.SELinuxMount
2023-03-14 16:49:55 +01:00
Patrick Ohly
fec5233668
api: resource.k8s.io PodScheduling -> PodSchedulingContext
...
The name "PodScheduling" was unusual because in contrast to most other names,
it was impossible to put an article in front of it. Now PodSchedulingContext is
used instead.
2023-03-14 10:18:08 +01:00
Patrick Ohly
29941b8d3e
api: resource.k8s.io v1alpha1 -> v1alpha2
...
For Kubernetes 1.27, we intend to make some breaking API changes:
- rename PodScheduling -> PodSchedulingHints (https://github.com/kubernetes/kubernetes/issues/114283 )
- extend ResourceClaimStatus (https://github.com/kubernetes/enhancements/pull/3802 )
We need to switch from v1alpha1 to v1alpha2 for that.
2023-03-14 07:52:03 +01:00
kidddddddddddddddddddddd
488d7650f4
update description
2023-03-14 09:42:41 +08:00
kannon92
aef8cbab89
Add batch.kubernetes.io to labels created in the Job controller.
2023-03-11 12:27:38 +00:00
Kubernetes Prow Robot
94e30facdb
Merge pull request #114497 from dgrisonnet/pod-logs-metrics
...
Remove redundant subsystem in kube-apiserver pod logs metrics name
2023-03-10 12:40:41 -08:00
Damien Grisonnet
1efa1a65ee
pkg/registry: rename pod logs metrics
...
The pod_logs subsystem was inadvertently made redundant in the following
kube-apiserver metrics:
- kube_apiserver_pod_logs_pods_logs_backend_tls_failure_total
- kube_apiserver_pod_logs_pods_logs_insecure_backend_total
To safely rename them, it is required to deprecate them in 1.27 whilst
introducing the new metrics replacing them.
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
2023-03-10 17:43:09 +01:00
Kubernetes Prow Robot
e8ae6658ed
Merge pull request #115065 from apelisse/apimachinery-managed-fields
...
managedfields: Move most of fieldmanager package to managefields
2023-03-09 21:34:22 -08:00
Maksim Nabokikh
c1431af4f8
KEP-3325: Promote SelfSubjectReview to Beta ( #116274 )
...
* Promote SelfSubjectReview to Beta
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
* Fix whoami API
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
* Fixes according to code review
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
---------
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
2023-03-08 15:42:33 -08:00
Antoine Pelisse
4f3859ce91
managedfields: Move most of fieldmanager package to managefields
2023-03-08 13:44:00 -08:00
Jiahui Feng
68ac7acbce
[API REVIEW] ValidatingAdmissionPolicyStatus
2023-03-07 15:43:34 -08:00
Kubernetes Prow Robot
2225ee5dd3
Merge pull request #115904 from soltysh/cronjob_tz_ga
...
Promote CronJob TZ to GA
2023-03-07 07:20:47 -08:00
Kubernetes Prow Robot
51ef4b10ba
Merge pull request #115504 from pacoxu/cronjob-timezone
...
add some ut for cronjob strategy and timezone in schedule
2023-03-07 07:20:34 -08:00
Maciej Szulik
1b825c179b
Promote CronJob TZ to GA
2023-03-07 12:58:57 +01:00
Joe Betz
d221ddb89a
Implement validationActions and auditAnnotations
2023-03-06 21:51:27 -05:00
kannon92
cd71486cfb
update documentation on generateSelector for manual selector case
2023-03-02 19:47:58 +00:00
kkkkun
3dd0c41663
support short name for flowschema and prioritylevelconfiguration
2023-03-02 09:04:28 +00:00
ahg-g
2ecd24011a
Graduate JobMutableNodeSchedulingDirectives feature to GA
2023-02-28 15:47:13 +00:00
Kubernetes Prow Robot
f2fdda8667
Merge pull request #115918 from yt2985/genericWatch
...
Partition watchers by namespace/name scope
2023-02-28 01:47:17 -08:00
Kubernetes Prow Robot
b9fd1802ba
Merge pull request #102884 from vinaykul/restart-free-pod-vertical-scaling
...
In-place Pod Vertical Scaling feature
2023-02-27 22:53:15 -08:00
Jordan Liggitt
1c2fa0c7f7
Partition watchers by namespace/name scope
2023-02-27 20:38:11 +00:00
Daniel Vega-Myhre
93a74afccb
move AllowElasticIndexedJobs into JobValidationOptions declaration
2023-02-27 18:45:58 +00:00
Vinay Kulkarni
76962b0fa7
In-place Pod Vertical Scaling - API changes
...
1. Define ContainerResizePolicy and add it to Container struct.
2. Add ResourcesAllocated and Resources fields to ContainerStatus struct.
3. Define ResourcesResizeStatus and add it to PodStatus struct.
4. Add InPlacePodVerticalScaling feature gate and drop disabled fields.
5. ResizePolicy validation & defaulting and Resources mutability for CPU/Memory.
6. Various fixes from code review feedback (originally committed on Apr 12, 2022)
KEP: /enhancements/keps/sig-node/1287-in-place-update-pod-resources
2023-02-24 17:18:04 +00:00
Kubernetes Prow Robot
0753f02851
Merge pull request #115944 from SataQiu/warning-for-externalid
...
Add field-level warning for deprecated spec.externalID of node
2023-02-24 06:15:47 -08:00
Daniel Vega-Myhre
8d31da4599
add validation test case for immutable completions on indexed jobs when AllowElasticIndexedJobs is false
2023-02-23 21:05:03 +00:00
Daniel Vega-Myhre
15077a0f28
plumb feature gate value through job validation opts and modify validateCompletions function to only check completions == parallelism after the update, not before
2023-02-23 18:09:47 +00:00
SataQiu
ba6fcf4169
add field-level warning for deprecated spec.externalID of node
2023-02-23 09:35:56 +08:00
Paco Xu
dfea1ae53e
add some ut for cronjob strategy and timezone in schedule
...
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
2023-02-22 16:29:26 +08:00
Wei Huang
feed8c683d
Enforce nodeName cannot be set along with non empty schedulingGates
2023-02-07 13:53:28 -08:00
Kubernetes Prow Robot
4b0d433dd9
Merge pull request #115536 from pwschuurman/kep-3335-enable-disable-unit-test
...
Add enablement/disablement unit test for StatefulSetStartOrdinal feature
2023-02-07 05:53:00 -08:00
Peter Schuurman
773b45abc5
Add enablement/disablement unit test for StatefulSetStartOrdinal feature
2023-02-05 20:28:54 -08:00
Kubernetes Prow Robot
ae23b0c11b
Merge pull request #115111 from kannon92/strategy-coverage-increase
...
increasing coverage from 78% to 94% for strategy.go for batch/job
2023-02-02 07:58:41 -08:00
kidddddddddddddddddddddd
113355a5a2
loosen check rules for ingress creation
2023-02-01 15:21:45 +08:00
Kubernetes Prow Robot
7f0d1722f5
Merge pull request #115378 from aojea/aojea_allocator
...
add aojea as approver for networking APIs: services/allocators, netwo…
2023-01-29 16:14:49 -08:00
Kubernetes Prow Robot
5bb7326c36
Merge pull request #114418 from xuzhenglun/master
...
Reserve Nodeport Ranges For Dynamic And Static Port Allocation
2023-01-29 14:02:35 -08:00
Antonio Ojea
0461c48078
add aojea as approver for networking APIs: services/allocators, networking group, ...
...
Change-Id: Ia6542b21339f4a92a9c13c2b628038abe737d0f9
2023-01-29 00:10:06 +00:00
Kubernetes Prow Robot
12240c2a5c
Merge pull request #115247 from Volatus/refactor-node-storage-tests
...
Refactor: cleanup node/storage tests
2023-01-26 17:42:32 -08:00
Ismayil Mirzali
6d484dc037
Refactor: cleanup node/storage tests
...
Removes some repetitive patterns and simplifies the existing test code.
2023-01-26 23:03:02 +02:00
xuzhenglun
d48dd100bf
add kube_apiserver_nodeport_allocator_* to improve observability of ServiceNodePortStaticSubrange
2023-01-26 14:44:16 +08:00
xuzhenglun
c18c6e1b87
allocate nodeport with offset
2023-01-26 14:44:04 +08:00
Antonio Ojea
ea99593fa1
Fix panic on ClusterIP allocation for /28 subnets
...
The ClusterIP allocator tries to reserve on part of the ServiceCIDR
to allocate static IPs to the Services.
The heuristic of the allocator to obtain the offset was taking into
account the whole range size, not the IPs available in the range, the
subnet address and the broadcast address for IPv4 are not available.
This caused that for CIDRs with 16 hosts, /28 for IPv4 and /124 for
IPv6, the offset calculated was higher than the max number of available
addresses on the allocator, causing this to panic.
Change-Id: I6c6f527b0a600b3612be37769e405b8fb3dd33a8
2023-01-25 20:32:40 +00:00
kannon92
96541d3e51
increasing coverage from 75% to 95% for strategy.go for batch/job
2023-01-23 18:53:46 +00:00
HirazawaUi
3b18e80fb4
delete unused functions in pkg directory
2023-01-16 21:43:36 +08:00
Kubernetes Prow Robot
696701b9fd
Merge pull request #114086 from xmcqueen/113935
...
block ephemeral container addition to static pods
2023-01-13 07:36:28 -08:00
Kubernetes Prow Robot
6ce055d62d
Merge pull request #114947 from saschagrunert/seccomp-ga-cleanup
...
Make seccomp annotations non-functional
2023-01-12 13:48:54 -08:00
Sascha Grunert
af1f6a230b
Make seccomp annotations non-functional
...
This cleanup has been planned to finish the corresponding KEP:
https://github.com/kubernetes/kubernetes/issues/91286
As follow-up on the partly removal of the seccomp annotations in
https://github.com/kubernetes/kubernetes/pull/109819 , we now drop
the version skew handling completely, but still warn as well as keep
the validation in place if both (annotation and field) are set.
The Pod Security Admission code has been already changed in
https://github.com/kubernetes/kubernetes/pull/114846 .
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2023-01-12 17:11:52 +01:00
Kubernetes Prow Robot
08d9a0ef5b
Merge pull request #113467 from pacoxu/psp-cleanup
...
Remove PodSecurityPolicy related code except client-go & API type
2023-01-11 14:28:07 -08:00
Kubernetes Prow Robot
564f438892
Merge pull request #114691 from thockin/fix-pod-warning-string
...
Make the warning about pod name clearer
2023-01-10 13:47:38 -08:00
Kubernetes Prow Robot
5a896bf379
Merge pull request #114677 from kl52752/epd-warning-address-type
...
Generate warning for EndpointSlice AddressType FQDN
2023-01-10 13:47:27 -08:00
Paco Xu
e0bc0693e9
registry/storage: remove psp support
2023-01-06 17:07:02 +08:00
Kubernetes Prow Robot
ac889a0251
Merge pull request #113581 from aimuz/verify-tls-secret
...
Verify that the key matches the cert
2023-01-04 14:29:58 -08:00
TommyStarK
e2d8fc3f62
pkg/registry: Replace deprecated pointer function
...
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-01-04 10:38:09 +01:00
Kubernetes Prow Robot
12c71fdf1c
Merge pull request #113542 from ardaguclu/fix-shortname-disperancy
...
Set singular names for core types to pass to discovery
2023-01-03 09:29:43 -08:00
Katarzyna Lach
249f763c7e
Generate warning for EndpointSlice AddressType FQDN
...
Change-Id: Ibc213acdffa741e630821f371ea25e2b5187a011
2023-01-02 10:00:01 +00:00
Antonio Ojea
29ea5076ea
refactor current ipallocator
...
- rename files to match the allocator backend
- use t.Run for tests and cover large ranges
- add benchmarks
- check that thebitmap ip allocator satisfies the interface
goos: linux
goarch: amd64
pkg: k8s.io/kubernetes/pkg/registry/core/service/ipallocator
cpu: Intel(R) Xeon(R) CPU E5-2678 v3 @ 2.50GHz
BenchmarkAllocateNextIPv4Size1048574
BenchmarkAllocateNextIPv4Size1048574-24 1517683
7373 ns/op 135 B/op 8 allocs/op
BenchmarkAllocateNextIPv6Size65535
BenchmarkAllocateNextIPv6Size65535-24 5607438
193.9 ns/op 18 B/op 2 allocs/op
PASS
2022-12-31 12:48:50 +00:00
Tim Hockin
7c7d79b058
Make the warning about pod name clearer
...
Previously this was cut-paste from deployment. It didn't make much
sense for pod.
2022-12-25 14:20:55 -08:00
Tim Hockin
ed3ebbaaa7
Remove TODO about API proxy checking for svc
2022-12-23 12:32:17 -08:00
Kubernetes Prow Robot
038d983769
Merge pull request #114505 from aojea/service_warnings
...
Services API: warnings on IP addresses
2022-12-16 18:07:52 -08:00
Tim Hockin
8f62b94991
cronjob: API warn when name is not DNS label
2022-12-16 13:08:08 -08:00
Tim Hockin
fec8e721b2
job: API warn when name is not DNS label
2022-12-16 13:07:42 -08:00
Tim Hockin
b65cec86eb
deployment: API warn when name is not DNS label
2022-12-16 13:07:13 -08:00
Tim Hockin
820e2fff0d
rs: API warn when name is not DNS label
2022-12-16 13:06:43 -08:00
Tim Hockin
e27cf75094
rc: API warn when name is not DNS label
2022-12-16 13:06:10 -08:00
Tim Hockin
c555d290c1
pod: API warn when name is not DNS label
2022-12-16 13:05:17 -08:00
Antonio Ojea
1b804fc87c
Services API: warnings
...
The Services API should warn users about some IP addresses
representations, mainly because some of them are not allowed
by the golang std parsers since go 1.17
Specifically:
- IPv4 addresses with leading zeros, that may cause security risks
- IPv6 addresses in non canonical format, that may cause problems
with controllers hotlooping or cause security issues
Change-Id: Ife50a651d1b22dc4c318e42bd3e5f2e5f88ecbcd
2022-12-16 11:54:05 +00:00
Kubernetes Prow Robot
4b27077eb2
Merge pull request #114428 from SataQiu/clean-rest-20221212
...
apiserver: cleanup unused StrategyExceptions
2022-12-14 06:47:34 -08:00
aimuz
4a7ab7fd75
Verify that the key matches the cert
...
Signed-off-by: aimuz <mr.imuz@gmail.com>
2022-12-13 10:43:58 +08:00
SataQiu
090c36027f
apiserver: cleanup unused StrategyExceptions
2022-12-12 23:56:24 +08:00
Tim Hockin
dd0a50336e
ServiceInternalTrafficPolicyType: s/Type//
...
Rename ServiceInternalTrafficPolicyType => ServiceInternalTrafficPolicy
2022-12-11 13:48:31 -08:00
Tim Hockin
d0e2b06850
ServiceExternalTrafficPolicyType: s/Type//
...
Rename ServiceExternalTrafficPolicyType => ServiceExternalTrafficPolicy
2022-12-11 13:48:27 -08:00
Kubernetes Prow Robot
4106b10d9c
Merge pull request #112799 from kerthcet/cleanup/strategy-test
...
optimize testcases arrangement
2022-12-09 15:43:29 -08:00
Kubernetes Prow Robot
6f6bf42ee5
Merge pull request #113768 from lojies/codecleanupforkubeleteviction
...
cleanup:Omit comparison with boolean constant
2022-12-09 14:34:26 -08:00
Brian McQueen
25e990f738
added validation check to block adding an ephemeral container to a static pod and test cases
2022-12-02 15:39:11 -08:00
Arda Güçlü
43a889fc65
Add integration test to test singularnames for all resources
2022-11-21 09:59:37 +03:00
Arda Güçlü
1f54f610e4
minor integration test fixes and more singular resource
2022-11-18 13:11:16 +03:00
Arda Güçlü
23e2899556
Implement GetSingularName for LegacyBindingREST
...
LegacyBindingREST is only used for `bindings` resource. It is not
a subresource and that's why it is required to implement
`GetSingularName` function. However, there is no need to implement
this function for BindingREST because it is only used for binding
subresource.
That's why, this function statically adds GetSingularName for
LegacyBindingREST.
2022-11-18 12:21:19 +03:00
Arda Güçlü
d14b7781e2
Use casted SingularName for rbac types
2022-11-18 12:21:19 +03:00
Arda Güçlü
1abf94bec3
Remove GetSingularName for subresources
2022-11-18 12:21:19 +03:00
Arda Güçlü
672e0b1e01
Use correct singular name format for subresources
2022-11-18 12:21:19 +03:00
Arda Güçlü
578ddde80e
Add singular name for the rest of types
2022-11-18 12:21:13 +03:00
Arda Güçlü
0990ba1cc9
Introduce singularNameProvider for core types
...
This introduces `singularNameProvider`. This provider will be used
by core types to have their singular names are defined in discovery
endpoint. Thanks to that, core resources singular name always have
higher precedence than CRDs shortcuts or singular names.
2022-11-18 12:21:07 +03:00
Kubernetes Prow Robot
d1c0171aed
Merge pull request #111023 from pohly/dynamic-resource-allocation
...
dynamic resource allocation
2022-11-11 16:21:56 -08:00
