5490273951
Automatic merge from submit-queue Fix a bug that --flag=val causes completion error in zsh **What this PR does / why we need it**: This PR fixes a bug that flag of syntax like --flag=val causes completion error in zsh. ``` kubectl --namespace=foo g__handle_flag:25: bad math expression: operand expected at end of string ``` This problem is due to [dynamic scope](https://en.wikipedia.org/wiki/Scope_(computer_science)#Dynamic_scoping) of shell variables. If a variable is declared as local to a function, that scope remains until the function returns. In kubectl completion zsh, `declare -A flaghash` in __start_kubectl() is replaced with `__kubectl_declare -A flaghash` by __kubectl_convert_bash_to_zsh(). As a result of it, flaghash is declared in __kubectl_declare(), and it can not access to flaghash declared in __kubectl_declare() from __handle_flag(). Therefore an error occurs in __handle_flag(). The following is the minimum reproduction code. ```sh #!/usr/bin/env zsh set -e __kubectl_declare() { builtin declare "$@" } __handle_flag() { local flagname="--namespace=" local flagval="kube-system" flaghash[${flagname}]=${flagval} echo "flaghash[${flagname}]=${flaghash[${flagname}]}" } __handle_word() { __handle_flag } __start_kubectl() { __kubectl_declare -A flaghash __handle_word } __start_kubectl # # $ zsh reproduction.zsh # __handle_flag:4: bad math expression: operand expected at end of string # # __start_kubectl { # # __kubectl_declare { # # builtin declare -A flaghash # # } # # __handle_word { # # __handle_flag { # # # It is unable to access flaghash declared in __kubectl_declare from here # flaghash[${flagname}]=${flagval} # # } # # } # } ``` The following is the fixed code. ```sh #!/usr/bin/env zsh set -e __handle_flag() { local flagname="--namespace=" local flagval="kube-system" flaghash[${flagname}]=${flagval} echo "flaghash[${flagname}]=${flaghash[${flagname}]}" } __handle_word() { __handle_flag } __start_kubectl() { builtin declare -A flaghash __handle_word } __start_kubectl # # $ zsh fixed.zsh # flaghash[--namespace=]=kube-system # # __start_kubectl { # # builtin declare -A flaghash # # __handle_word { # # __handle_flag { # # # It is able to access flaghash declared in __start_kubectl from here :) # flaghash[${flagname}]=${flagval} # # } # # } # } ``` https://gist.github.com/superbrothers/0ede4292f6d973f93e54368e227a4902 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes kubernetes/kubectl#42 **Special notes for your reviewer**: @mengqiy **Release note**: ```release-note NONE ```
Kubernetes
Kubernetes is an open source system for managing containerized applications across multiple hosts, providing basic mechanisms for deployment, maintenance, and scaling of applications.
Kubernetes builds upon a decade and a half of experience at Google running production workloads at scale using a system called Borg, combined with best-of-breed ideas and practices from the community.
Kubernetes is hosted by the Cloud Native Computing Foundation (CNCF). If you are a company that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF. For details about who's involved and how Kubernetes plays a role, read the CNCF announcement.
To start using Kubernetes
See our documentation on kubernetes.io.
Try our interactive tutorial.
Take a free course on Scalable Microservices with Kubernetes.
To start developing Kubernetes
The community repository hosts all information about building Kubernetes from source, how to contribute code and documentation, who to contact about what, etc.
If you want to build Kubernetes right away there are two options:
You have a working Go environment.
$ go get -d k8s.io/kubernetes
$ cd $GOPATH/src/k8s.io/kubernetes
$ make
You have a working Docker environment.
$ git clone https://github.com/kubernetes/kubernetes
$ cd kubernetes
$ make quick-release
If you are less impatient, head over to the developer's documentation.
Support
If you need support, start with the troubleshooting guide and work your way through the process that we've outlined.
That said, if you have questions, reach out to us one way or another.