After a couple years of seeing changes spawned from this issue, I don't think this is a good use of contributors' or reviewers' time. golint is very opinionated about:
exported type and function names, leading to PRs attempting to change exported things people use downstream
missing documentation on interface implementation functions, which leads to not-very-useful copy/paste of interface godoc
the govet and staticcheck verify jobs are much more useful since they catch correctness issues
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
This document describes how you can use the scripts from hack directory
and gives a brief introduction and explanation of these scripts.
Overview
The hack directory contains many scripts that ensure continuous development of kubernetes,
enhance the robustness of the code, improve development efficiency, etc.
The explanations and descriptions of these scripts are helpful for contributors.
For details, refer to the following guidelines.
Key scripts
verify-all.sh: This script is a vestigial redirection, Please do not add "real" logic. It is equivalent to make verify.
update-all.sh: This script is a vestigial redirection, Please do not add "real" logic.
The true target of this makerule is hack/make-rules/update.sh.It is equivalent to make update.
Attention
Note that all scripts must be run from the Kubernetes root directory.
We should run hack/verify-all.sh before submitting a PR and if anything fails run hack/update-all.sh.
8cec5fbd28