
We had another bug where we confused the hostname with the NodeName. To avoid this happening again, and to make the code more self-documenting, we use types.NodeName (a typedef alias for string) whenever we are referring to the Node.Name. A tedious but mechanical commit therefore, to change all uses of the node name to use types.NodeName Also clean up some of the (many) places where the NodeName is referred to as a hostname (not true on AWS), or an instanceID (not true on GCE), etc.
189 lines
5.4 KiB
Go
189 lines
5.4 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package aws
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/aws/aws-sdk-go/aws"
|
|
"github.com/aws/aws-sdk-go/service/ec2"
|
|
"github.com/golang/glog"
|
|
"k8s.io/kubernetes/pkg/cloudprovider"
|
|
)
|
|
|
|
func (c *Cloud) findRouteTable(clusterName string) (*ec2.RouteTable, error) {
|
|
// This should be unnecessary (we already filter on TagNameKubernetesCluster,
|
|
// and something is broken if cluster name doesn't match, but anyway...
|
|
// TODO: All clouds should be cluster-aware by default
|
|
filters := []*ec2.Filter{newEc2Filter("tag:"+TagNameKubernetesCluster, clusterName)}
|
|
request := &ec2.DescribeRouteTablesInput{Filters: c.addFilters(filters)}
|
|
|
|
tables, err := c.ec2.DescribeRouteTables(request)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if len(tables) == 0 {
|
|
return nil, fmt.Errorf("unable to find route table for AWS cluster: %s", clusterName)
|
|
}
|
|
|
|
if len(tables) != 1 {
|
|
return nil, fmt.Errorf("found multiple matching AWS route tables for AWS cluster: %s", clusterName)
|
|
}
|
|
return tables[0], nil
|
|
}
|
|
|
|
// ListRoutes implements Routes.ListRoutes
|
|
// List all routes that match the filter
|
|
func (c *Cloud) ListRoutes(clusterName string) ([]*cloudprovider.Route, error) {
|
|
table, err := c.findRouteTable(clusterName)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var routes []*cloudprovider.Route
|
|
var instanceIDs []*string
|
|
|
|
for _, r := range table.Routes {
|
|
instanceID := orEmpty(r.InstanceId)
|
|
|
|
if instanceID == "" {
|
|
continue
|
|
}
|
|
|
|
instanceIDs = append(instanceIDs, &instanceID)
|
|
}
|
|
|
|
instances, err := c.getInstancesByIDs(instanceIDs)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, r := range table.Routes {
|
|
instanceID := orEmpty(r.InstanceId)
|
|
destinationCIDR := orEmpty(r.DestinationCidrBlock)
|
|
|
|
if instanceID == "" || destinationCIDR == "" {
|
|
continue
|
|
}
|
|
|
|
instance, found := instances[instanceID]
|
|
if !found {
|
|
glog.Warningf("unable to find instance ID %s in the list of instances being routed to", instanceID)
|
|
continue
|
|
}
|
|
nodeName := mapInstanceToNodeName(instance)
|
|
routeName := clusterName + "-" + destinationCIDR
|
|
routes = append(routes, &cloudprovider.Route{Name: routeName, TargetNode: nodeName, DestinationCIDR: destinationCIDR})
|
|
}
|
|
|
|
return routes, nil
|
|
}
|
|
|
|
// Sets the instance attribute "source-dest-check" to the specified value
|
|
func (c *Cloud) configureInstanceSourceDestCheck(instanceID string, sourceDestCheck bool) error {
|
|
request := &ec2.ModifyInstanceAttributeInput{}
|
|
request.InstanceId = aws.String(instanceID)
|
|
request.SourceDestCheck = &ec2.AttributeBooleanValue{Value: aws.Bool(sourceDestCheck)}
|
|
|
|
_, err := c.ec2.ModifyInstanceAttribute(request)
|
|
if err != nil {
|
|
return fmt.Errorf("error configuring source-dest-check on instance %s: %v", instanceID, err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// CreateRoute implements Routes.CreateRoute
|
|
// Create the described route
|
|
func (c *Cloud) CreateRoute(clusterName string, nameHint string, route *cloudprovider.Route) error {
|
|
instance, err := c.getInstanceByNodeName(route.TargetNode)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// In addition to configuring the route itself, we also need to configure the instance to accept that traffic
|
|
// On AWS, this requires turning source-dest checks off
|
|
err = c.configureInstanceSourceDestCheck(orEmpty(instance.InstanceId), false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
table, err := c.findRouteTable(clusterName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var deleteRoute *ec2.Route
|
|
for _, r := range table.Routes {
|
|
destinationCIDR := aws.StringValue(r.DestinationCidrBlock)
|
|
|
|
if destinationCIDR != route.DestinationCIDR {
|
|
continue
|
|
}
|
|
|
|
if aws.StringValue(r.State) == ec2.RouteStateBlackhole {
|
|
deleteRoute = r
|
|
}
|
|
}
|
|
|
|
if deleteRoute != nil {
|
|
glog.Infof("deleting blackholed route: %s", aws.StringValue(deleteRoute.DestinationCidrBlock))
|
|
|
|
request := &ec2.DeleteRouteInput{}
|
|
request.DestinationCidrBlock = deleteRoute.DestinationCidrBlock
|
|
request.RouteTableId = table.RouteTableId
|
|
|
|
_, err = c.ec2.DeleteRoute(request)
|
|
if err != nil {
|
|
return fmt.Errorf("error deleting blackholed AWS route (%s): %v", aws.StringValue(deleteRoute.DestinationCidrBlock), err)
|
|
}
|
|
}
|
|
|
|
request := &ec2.CreateRouteInput{}
|
|
// TODO: use ClientToken for idempotency?
|
|
request.DestinationCidrBlock = aws.String(route.DestinationCIDR)
|
|
request.InstanceId = instance.InstanceId
|
|
request.RouteTableId = table.RouteTableId
|
|
|
|
_, err = c.ec2.CreateRoute(request)
|
|
if err != nil {
|
|
return fmt.Errorf("error creating AWS route (%s): %v", route.DestinationCIDR, err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// DeleteRoute implements Routes.DeleteRoute
|
|
// Delete the specified route
|
|
func (c *Cloud) DeleteRoute(clusterName string, route *cloudprovider.Route) error {
|
|
table, err := c.findRouteTable(clusterName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
request := &ec2.DeleteRouteInput{}
|
|
request.DestinationCidrBlock = aws.String(route.DestinationCIDR)
|
|
request.RouteTableId = table.RouteTableId
|
|
|
|
_, err = c.ec2.DeleteRoute(request)
|
|
if err != nil {
|
|
return fmt.Errorf("error deleting AWS route (%s): %v", route.DestinationCIDR, err)
|
|
}
|
|
|
|
return nil
|
|
}
|