7b14e0e382
Importing the `k8s.io/kubernetes/pkg/features` package in the remote runtime implementation makes it harder to separate the functionalities at some later point in time. We now decouple them by checking if the feature is enabled directly in the kubelet service creation path. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
99 lines
3.0 KiB
Go
99 lines
3.0 KiB
Go
/*
|
|
Copyright 2022 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package remote
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
sdktrace "go.opentelemetry.io/otel/sdk/trace"
|
|
"go.opentelemetry.io/otel/sdk/trace/tracetest"
|
|
oteltrace "go.opentelemetry.io/otel/trace"
|
|
internalapi "k8s.io/cri-api/pkg/apis"
|
|
runtimeapi "k8s.io/cri-api/pkg/apis/runtime/v1"
|
|
"k8s.io/kubernetes/pkg/kubelet/util"
|
|
)
|
|
|
|
func createRemoteImageServiceWithTracerProvider(endpoint string, tp oteltrace.TracerProvider, t *testing.T) internalapi.ImageManagerService {
|
|
runtimeService, err := NewRemoteImageService(endpoint, defaultConnectionTimeout, tp)
|
|
require.NoError(t, err)
|
|
|
|
return runtimeService
|
|
}
|
|
|
|
func createRemoteImageServiceWithoutTracerProvider(endpoint string, t *testing.T) internalapi.ImageManagerService {
|
|
runtimeService, err := NewRemoteImageService(endpoint, defaultConnectionTimeout, oteltrace.NewNoopTracerProvider())
|
|
require.NoError(t, err)
|
|
|
|
return runtimeService
|
|
}
|
|
|
|
func TestImageServiceSpansWithTP(t *testing.T) {
|
|
fakeRuntime, endpoint := createAndStartFakeRemoteRuntime(t)
|
|
defer func() {
|
|
fakeRuntime.Stop()
|
|
// clear endpoint file
|
|
if addr, _, err := util.GetAddressAndDialer(endpoint); err == nil {
|
|
if _, err := os.Stat(addr); err == nil {
|
|
os.Remove(addr)
|
|
}
|
|
}
|
|
}()
|
|
exp := tracetest.NewInMemoryExporter()
|
|
tp := sdktrace.NewTracerProvider(
|
|
sdktrace.WithBatcher(exp),
|
|
)
|
|
ctx := context.Background()
|
|
imgSvc := createRemoteImageServiceWithTracerProvider(endpoint, tp, t)
|
|
imgRef, err := imgSvc.PullImage(ctx, &runtimeapi.ImageSpec{Image: "busybox"}, nil, nil)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "busybox", imgRef)
|
|
require.NoError(t, err)
|
|
err = tp.ForceFlush(ctx)
|
|
require.NoError(t, err)
|
|
assert.NotEmpty(t, exp.GetSpans())
|
|
}
|
|
|
|
func TestImageServiceSpansWithoutTP(t *testing.T) {
|
|
fakeRuntime, endpoint := createAndStartFakeRemoteRuntime(t)
|
|
defer func() {
|
|
fakeRuntime.Stop()
|
|
// clear endpoint file
|
|
if addr, _, err := util.GetAddressAndDialer(endpoint); err == nil {
|
|
if _, err := os.Stat(addr); err == nil {
|
|
os.Remove(addr)
|
|
}
|
|
}
|
|
}()
|
|
exp := tracetest.NewInMemoryExporter()
|
|
tp := sdktrace.NewTracerProvider(
|
|
sdktrace.WithBatcher(exp),
|
|
)
|
|
ctx := context.Background()
|
|
imgSvc := createRemoteImageServiceWithoutTracerProvider(endpoint, t)
|
|
imgRef, err := imgSvc.PullImage(ctx, &runtimeapi.ImageSpec{Image: "busybox"}, nil, nil)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "busybox", imgRef)
|
|
require.NoError(t, err)
|
|
err = tp.ForceFlush(ctx)
|
|
require.NoError(t, err)
|
|
assert.Empty(t, exp.GetSpans())
|
|
}
|