github/ocf
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

more precise req->alock_status size calculations

Browse Source 
1. On 1 bit per cacheline is required for the status
2. ... however the size must be 8B aligned

Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
This commit is contained in:
Adam Rutkowski 2022-08-26 06:45:52 +02:00
parent 93b6ddb8a7
commit 2f3e0b0fd0
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/ocf_request.c
View File

@ -1,5 +1,5 @@
/*
* Copyright(c) 2012-2021 Intel Corporation
* Copyright(c) 2012-2022 Intel Corporation
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -43,13 +43,18 @@ static inline size_t ocf_req_sizeof_map(struct ocf_request *req)
return size;
}
static inline size_t ocf_req_sizeof_alock_status(struct ocf_request *req)
static inline size_t ocf_req_sizeof_alock_status(uint32_t lines)
{
uint32_t lines = req->core_line_count;
size_t size = (lines * sizeof(uint8_t));
uint32_t size;
ENV_BUG_ON(lines == 0);
return size;
/* 1 bit per cacheline */
size = OCF_DIV_ROUND_UP(lines, 8);
/* round up to 8B to avoid out of boundary access in bit operations
* on alock status */
return OCF_DIV_ROUND_UP(size, sizeof(long)) * sizeof(long);
}
int ocf_req_allocator_init(struct ocf_ctx *ocf_ctx)
@ -142,7 +147,8 @@ int ocf_req_alloc_map(struct ocf_request *req)
return 0;
req->map = env_zalloc(ocf_req_sizeof_map(req) +
ocf_req_sizeof_alock_status(req), ENV_MEM_NOIO);
ocf_req_sizeof_alock_status(req->core_line_count),
ENV_MEM_NOIO);
if (!req->map) {
req->error = -OCF_ERR_NO_MEM;
return -OCF_ERR_NO_MEM;