github/ocf
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
1,925 Commits 1 Branch 1 Tag
96e527049a52ccbfbaa16f561797120a910c93ee
Commit Graph

1925 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michal Mielewczyk
96e527049a Refactor __set_cache_line_invalid() pt.2 
Get rid of nested ifs

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-24 12:02:34 +01:00
Michal Mielewczyk
4a01ff957d Refactor __set_cache_line_invalid() pt.1 
Better naming

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-24 12:02:34 +01:00
Michal Mielewczyk
67eb940589 Refactor metadata collision API 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-24 12:02:32 +01:00
Michal Mielewczyk
e1d2ff12d8 FIX metadata collision API 
If `is_valid` was NULL, OCF would crash

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-24 11:38:32 +01:00
Robert Baldyga
f43d53be19 Merge pull request #867 from mmichal10/detach_vs_acp 
Detach vs acp
 2025-03-17 16:20:21 +01:00
Michal Mielewczyk
98a3aaea89 pyocf: Test detaching cache with cleaning policy 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:28:09 +01:00
Michal Mielewczyk
69987bd20c detach: Don't deinitialize cleaning policy twice 
The cleaning metadata has been deinitialized in the previous pipeline step
together with other services

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:28:09 +01:00
Michal Mielewczyk
1e75a9826d stop&detach: Deinit services before removing cores 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:28:09 +01:00
Michal Mielewczyk
9c2da08ffe stop pipeline: flush_metadata as a separate step 
Flushing metadata has nothing to do with dinitializing services so it
should be a separate step in the stop pipeline

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:28:07 +01:00
Michal Mielewczyk
75c4c9b473 Move _ocf_mngt_cache_deinit_services() definition 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:27:17 +01:00
Michal Mielewczyk
942825146a Simplify _ocf_mngt_cache_deinit_services() 
Move flushing metadata outside cache_detinit_services(), so the function
can be shared between stop() and detach() without redundant ifs.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:27:16 +01:00
Michal Mielewczyk
eca7872299 detach: Rename update_metadata() to remove_cores() 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:19:55 +01:00
Michal Mielewczyk
03338d798c detach pipeline: remove unused completion 
The completion callback is called only in the cache stop scenario, after
flushing the metadata

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:19:55 +01:00
Michal Mielewczyk
5e55bf78b4 Rename cache_unplug() to deinit_services() 
The function doesn't unplug anything, it just deinitializes cleaning and
promotion.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-17 15:19:53 +01:00
Robert Baldyga
fba384d23f Merge pull request #815 from Kamoppl/kamilg/add_checkpatch 
github-actions: add checkpatch
 2025-03-17 08:16:48 +01:00
Robert Baldyga
bddc18f891 Merge pull request #862 from mmichal10/sanitizers 
Enable compiling pyocf with sanitizers
 2025-03-17 08:16:06 +01:00
Krzysztof Majzerowicz-Jaszcz
23abad76a8 Add script for running PyOCF with sanitization 
GCC/Clang sanitizer can be used together with PyOCF to catch some errors during
testing.

CC was purposely removed from the Makefile. It always points to GCC on Linux
by default. This allows to change the compiler and its options during the run
of the script

Signed-off-by: Krzysztof Majzerowicz-Jaszcz <krzysztof.majzerowicz-jaszcz@intel.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-14 16:54:30 +01:00
Michal Mielewczyk
8dc462e08e Fix using request after free 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-14 13:36:55 +01:00
Michal Mielewczyk
495c67e74e posix env: Implement missing atomic operations 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-03-14 13:36:55 +01:00
Robert Baldyga
a2272266f6 Merge pull request #864 from Open-CAS/fix_detached_check 
Check if cache is attached before setting promotion and seqcutoff params
 2025-03-12 11:05:40 +01:00
Rafal Stefanowski
794fa125e8 Check if cache is attached before setting promotion and seqcutoff params 
Fixes null pointer dereference if setting those params is attempted
on detached cache.

Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
 2025-03-11 16:47:53 +01:00
Robert Baldyga
a12496320c Merge pull request #849 from mmichal10/refcnt-per-cpu 
Refcnt per cpu
 2025-02-06 17:28:07 +01:00
Robert Baldyga
bb4d67397c Merge pull request #861 from Deixx/deinit-variable-metadata 
Split count_pages and update on metadata deinit
 2025-02-06 16:06:33 +01:00
Roel Apfelbaum
b02481cf74 A utility to continue pipeline on zero refcnt 
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-02-06 12:04:40 +01:00
Robert Baldyga
7685b70810 Protect cache lock against locking during lock deinitialization 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2025-02-06 12:04:37 +01:00
Adam Rutkowski
53ee7c1d3a Per-cpu refcounters 
Signed-off-by: Adam Rutkowski <adam.j.rutkowski@intel.com>
Signed-off-by: Jan Musial <jan.musial@huawei.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
Signed-off-by: Rafal Stefanowski <rafal.stefanowski@huawei.com>
 2025-02-06 12:04:34 +01:00
Daniel Madej
d8feef301d Change type of pages count variables to uint32_t 
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
 2025-02-06 11:54:53 +01:00
Daniel Madej
a15003d43e Split count_pages and update on metadata deinit 
This resets count_pages_variable on cache-detach, so during the following
cache-attach metadata size is calculated properly.

Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
 2025-02-06 11:54:53 +01:00
Robert Baldyga
ba4b81a94c Merge pull request #863 from Deixx/detach-zero-superblock 
Zero metadata superblock on detach
 2025-02-06 11:22:55 +01:00
Daniel Madej
3263503de1 pyocf: Add test for re-attaching device w/o force 
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
 2025-02-06 09:24:40 +01:00
Daniel Madej
95c9c8987e Zero metadata superblock on detach 
Metadata from a detached cache device is not meant to be loaded.

Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
 2025-02-06 09:24:40 +01:00
Robert Baldyga
c200c24344 Merge pull request #851 from robertbaldyga/core-stat-fix-inv-waiter 
Decrement core stats only if the cache line mapping is cleaned
 2025-02-06 06:15:33 +01:00
Robert Baldyga
be068df400 Merge pull request #853 from mmichal10/repart 
Repart
 2025-02-04 16:39:49 +01:00
Robert Baldyga
08eb00665c Merge pull request #854 from robertbaldyga/request-cleanup 
A little cleanup between ocf_request and ocf_io
 2025-02-04 15:20:44 +01:00
Robert Baldyga
c029f78e95 Make alock_rw a bit field 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2025-02-04 12:05:26 +01:00
Robert Baldyga
0e294fc75d Merge pull request #859 from Deixx/detach-unfreeze-fix 
ocf_cleaner_refcnt_unfreeze bug fix
 2025-02-04 11:40:14 +01:00
Daniel Madej
8ce129de06 ocf_cleaner_refcnt_unfreeze bug fix 
During core remove/detach ocf_cleaner_refcnt_freeze was called only
when cache was attached, but ocf_cleaner_refcnt_unfreeze was called
regardless of cache state.

Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
 2025-01-15 18:51:42 +01:00
Robert Baldyga
e630b811ff Merge pull request #858 from robertbaldyga/attach-fix-race-condition 
Fix race condition during cache attach
 2024-11-25 19:37:03 +01:00
Robert Baldyga
b850727d17 tests: Fix d2c test 
Cache attach operation is not supposed to complete unless all the d2c
requests are completed, thus need to handle it asynchronously.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2024-11-21 21:29:23 +01:00
Robert Baldyga
0d06b3a597 Fix race condition during cache attach 
After attaching new cache device handle all the IOs in Pass-Through mode
until all the d2c requests are completed.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2024-11-21 21:26:00 +01:00
Kamil Gierszewski
42004058cc github-actions: add checkpatch 
Signed-off-by: Kamil Gierszewski <kamil.gierszewski@huawei.com>
 2024-11-05 12:55:49 +01:00
Robert Baldyga
2c28f33e37 Merge pull request #857 from robertbaldyga/fix-ubasn-false-positive-2 
Avoid UBSAN false positive - continuation
 2024-10-30 15:22:55 +01:00
Robert Baldyga
2da05343e2 Avoid UBSAN false positive - continuation 
Address issue in two more instances.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2024-10-30 11:33:17 +01:00
Michal Mielewczyk
91ad6476e2 pyocf: Cache lines reclassification test 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2024-10-21 19:32:51 +02:00
Michal Mielewczyk
a18bee3d23 pyocf: ioclass statas api 
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2024-10-21 19:32:51 +02:00
Michal Mielewczyk
6bfd2122d2 Repart all misclassified cache lines 
Remapped cache lines my require repartitioning as well

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2024-10-16 18:37:42 +02:00
Michal Mielewczyk
b3fa1fc96a Reset repart flag during refreshing request status 
The flag isn't reset before retraversation so it might be true even if cache
line was reparted in the meantime

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
 2024-10-16 18:37:42 +02:00
Robert Baldyga
b3332793bb Remove unused request field 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2024-10-15 16:15:02 +02:00
Robert Baldyga
0cf4e8124b Remove io.ref_count 
There is already refcounting on the request. No need for additional one.

Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2024-10-15 09:55:56 +02:00
Robert Baldyga
85513332d7 Remove ocf_io_get() 
Signed-off-by: Robert Baldyga <robert.baldyga@huawei.com>
 2024-10-15 09:55:56 +02:00