github/open-cas-linux
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change CAS_BIO_MAX_VECS value

Browse Source 
Previously when user tried to allocate to big bio he recieved NULL. As the
behavior was changed to `BUG()` passing out of range value is no longer legal.

Limiting the requested bio size to BIO_MAX_PAGES (on the older kernels) or to
BIO_MAX_VECS (on the newer ones) eliminates the problem as the macros represent
the max possible value.

Signed-off-by: Michal Mielewczyk <michal.mielewczyk@intel.com>
This commit is contained in:
Michal Mielewczyk 2022-12-28 13:45:18 +01:00
parent bc0c8c1bf5
commit 4753374b1b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
configure.d/1_bio_max_vecs.conf
View File

@ -20,9 +20,9 @@ check() {
apply() {
case "$1" in
"1")
;;
add_define "CAS_BIO_MAX_VECS ((uint32_t)BIO_MAX_VECS)" ;;
"2")
add_define "BIO_MAX_VECS ((uint32_t)(-1))" ;;
add_define "CAS_BIO_MAX_VECS ((uint32_t)BIO_MAX_PAGES)" ;;
*)
exit 1
esac

4
modules/cas_cache/volume/vol_blk_utils.h
View File

@ -1,5 +1,5 @@
/*
* Copyright(c) 2012-2021 Intel Corporation
* Copyright(c) 2012-2022 Intel Corporation
* SPDX-License-Identifier: BSD-3-Clause
*/
@ -90,7 +90,7 @@ static inline uint32_t cas_io_iter_size_done(struct bio_vec_iter *iter)
static inline uint32_t cas_io_iter_size_left(struct bio_vec_iter *iter)
{
if (iter->idx < iter->vec_size)
return min(iter->vec_size - iter->idx, BIO_MAX_VECS);
return min(iter->vec_size - iter->idx, CAS_BIO_MAX_VECS);
return 0;
/* TODO UNITTEST */
}