Merge pull request #479 from Ostrokrzew/core_rem

Add tests for a core removal when the other one is mounted

test/functional/api/cas/casadm.py

@@ -46,7 +46,7 @@ def stop_cache(cache_id: int, no_data_flush: bool = False, shortcut: bool = Fals
 
 
 def add_core(cache: Cache, core_dev: Device, core_id: int = None, shortcut: bool = False):
-    _core_id = None if core_id is None else str(id)
+    _core_id = None if core_id is None else str(core_id)
     output = TestRun.executor.run(
         add_core_cmd(cache_id=str(cache.cache_id), core_dev=core_dev.system_path,
                      core_id=_core_id, shortcut=shortcut))

test/functional/tests/cache_ops/test_core_remove.py

@@ -0,0 +1,98 @@
+#
+# Copyright(c) 2020 Intel Corporation
+# SPDX-License-Identifier: BSD-3-Clause-Clear
+#
+import random
+
+import pytest
+
+from api.cas import casadm
+from core.test_run import TestRun
+from storage_devices.disk import DiskType, DiskTypeLowerThan, DiskTypeSet
+from test_tools.disk_utils import Filesystem
+from test_utils.output import CmdException
+from test_utils.size import Size, Unit
+
+mount_point = "/mnt/cas"
+cores_amount = 3
+
+
+@pytest.mark.require_disk("cache", DiskTypeSet([DiskType.optane, DiskType.nand]))
+@pytest.mark.require_disk("core", DiskTypeLowerThan("cache"))
+def test_remove_core_when_other_mounted_auto_numeration():
+    """
+        title: |
+          Test for removing one core from the cache when the other core is mounted.
+          Cores are numerated automatically.
+        description: |
+          Test of the ability to remove the unmounted core from the cache when the other core
+          is mounted and its ID starts with a different digit.
+        pass_criteria:
+          - No system crash.
+          - Removing unmounted core finished with success.
+    """
+    with TestRun.step("Prepare devices."):
+        cache_device = TestRun.disks['cache']
+        cache_device.create_partitions([Size(50, Unit.MebiByte)])
+        cache_part = cache_device.partitions[0]
+        core_device = TestRun.disks['core']
+        core_device.create_partitions([Size(200, Unit.MebiByte)] * cores_amount)
+
+    with TestRun.step("Start cache."):
+        cache = casadm.start_cache(cache_part, force=True)
+
+    with TestRun.step("Add cores to cache and mount them except the first one."):
+        free_core = cache.add_core(core_device.partitions[0])
+        mounted_cores = []
+        for i, part in enumerate(core_device.partitions[1:]):
+            part.create_filesystem(Filesystem.xfs)
+            mounted_cores.append(cache.add_core(part))
+            mounted_cores[i].mount(f"{mount_point}{cache.cache_id}-{mounted_cores[i].core_id}")
+
+    with TestRun.step("Remove the unmounted core."):
+        try:
+            cache.remove_core(free_core.core_id)
+        except CmdException as exc:
+            TestRun.fail(f"Cannot remove the unmounted core.\n{exc}")
+
+
+@pytest.mark.require_disk("cache", DiskTypeSet([DiskType.optane, DiskType.nand]))
+@pytest.mark.require_disk("core", DiskTypeLowerThan("cache"))
+def test_remove_core_when_other_mounted_custom_numeration():
+    """
+        title: |
+          Test for removing one core from the cache when the other core is mounted.
+          Cores have custom numeration, starting with the same digit.
+        description: |
+          Test of the ability to remove the unmounted core from the cache when the other core
+          is mounted and its ID starts with the same digit.
+        pass_criteria:
+          - No system crash.
+          - Removing unmounted core finished with success.
+    """
+    with TestRun.step("Prepare devices."):
+        cache_device = TestRun.disks['cache']
+        cache_device.create_partitions([Size(50, Unit.MebiByte)])
+        cache_part = cache_device.partitions[0]
+        core_device = TestRun.disks['core']
+        core_device.create_partitions([Size(200, Unit.MebiByte)] * cores_amount)
+
+    with TestRun.step("Start cache."):
+        cache = casadm.start_cache(cache_part, force=True)
+
+    with TestRun.step("Add cores to cache and mount them except the first one."):
+        random_prefix = random.randint(1, 9)
+        random_interfix = random.randint(1, 9)
+
+        free_core = cache.add_core(core_device.partitions[0], random_prefix)
+        mounted_cores = []
+        for i, part in enumerate(core_device.partitions[1:]):
+            part.create_filesystem(Filesystem.xfs)
+            mounted_cores.append(cache.add_core(part, f"{random_prefix}{random_interfix}{i}"))
+            mounted_cores[i].mount(f"{mount_point}{cache.cache_id}-{mounted_cores[i].core_id}")
+
+    with TestRun.step("Remove the unmounted core."):
+        try:
+            cache.remove_core(free_core.core_id)
+        except CmdException as exc:
+            TestRun.fail(f"Cannot remove the unmounted core.\n{exc}")