Fuzzy tests for casadm 'io class list' command

Signed-off-by: Katarzyna Treder <katarzyna.treder@h-partners.com>

test/functional/tests/security/fuzzy/kernel/fuzzy_io_class/test_fuzzy_io_class_list_cache_id.py

@@ -1,20 +1,33 @@
 #
 # Copyright(c) 2022 Intel Corporation
+# Copyright(c) 2024 Huawei Technologies Co., Ltd.
 # SPDX-License-Identifier: BSD-3-Clause
 #
 
 import pytest
 
 from api.cas import casadm
-from api.cas.cache_config import CacheMode, CacheLineSize, CleaningPolicy, UnalignedIo, \
-    KernelParameters, UseIoScheduler
+from api.cas.cache_config import (
+    CacheMode,
+    CacheLineSize,
+    CleaningPolicy,
+    UnalignedIo,
+    KernelParameters,
+    UseIoScheduler,
+)
 from api.cas.casadm_params import OutputFormat
 from api.cas.cli import list_io_classes_cmd
 from core.test_run import TestRun
 from storage_devices.disk import DiskType, DiskTypeSet, DiskTypeLowerThan
 from test_tools.peach_fuzzer.peach_fuzzer import PeachFuzzer
-from tests.security.fuzzy.kernel.common.common import get_fuzz_config, prepare_cas_instance, \
-    run_cmd_and_validate
+from tests.security.fuzzy.kernel.common.common import (
+    get_fuzz_config,
+    prepare_cas_instance,
+    run_cmd_and_validate,
+)
+
+
+io_class_config_path = "/etc/opencas/ioclass-config.csv"
 
 
 @pytest.mark.require_disk("cache", DiskTypeSet([DiskType.optane, DiskType.nand]))
@@ -24,33 +37,49 @@ from tests.security.fuzzy.kernel.common.common import get_fuzz_config, prepare_c
 @pytest.mark.parametrizex("cleaning_policy", CleaningPolicy)
 @pytest.mark.parametrizex("unaligned_io", UnalignedIo)
 @pytest.mark.parametrizex("use_io_scheduler", UseIoScheduler)
-def test_fuzzy_io_class_list_cache_id(cache_mode, cache_line_size, cleaning_policy, unaligned_io,
-                                      use_io_scheduler):
+def test_fuzzy_io_class_list_cache_id(
+    cache_mode, cache_line_size, cleaning_policy, unaligned_io, use_io_scheduler
+):
     """
-        title: Fuzzy test for casadm list IO class command – cache id
-        description: Using Peach Fuzzer check Open CAS ability of handling wrong cache id in
-            ‘list IO class’ command.
-        pass_criteria:
-            - System did not crash
-            - Open CAS still works.
+    title: Fuzzy test for casadm list IO class command – cache id
+    description: |
+        Using Peach Fuzzer check Open CAS ability of handling wrong cache id in
+        'list IO class' command.
+    pass_criteria:
+      - System did not crash
+      - Open CAS still works.
     """
     with TestRun.step("Start cache and add core device"):
-        cache_disk = TestRun.disks['cache']
-        core_disk = TestRun.disks['core']
-        cache, core = prepare_cas_instance(cache_disk, core_disk, cache_mode, cache_line_size,
-                                           KernelParameters(unaligned_io, use_io_scheduler),
-                                           cleaning_policy)
+        cache_disk = TestRun.disks["cache"]
+        core_disk = TestRun.disks["core"]
+        cache, core = prepare_cas_instance(
+            cache_device=cache_disk,
+            core_device=core_disk,
+            cache_mode=cache_mode,
+            cache_line_size=cache_line_size,
+            kernel_params=KernelParameters(unaligned_io, use_io_scheduler),
+            cleaning_policy=cleaning_policy,
+        )
 
     with TestRun.step("Load default IO class configuration file"):
-        casadm.load_io_classes(cache.cache_id, '/etc/opencas/ioclass-config.csv')
+        casadm.load_io_classes(cache_id=cache.cache_id, file=io_class_config_path)
 
     with TestRun.step("Prepare PeachFuzzer"):
-        valid_values = [str(core.cache_id).encode('ascii')]
+        valid_values = [str(core.cache_id).encode("ascii")]
         PeachFuzzer.generate_config(get_fuzz_config("cache_id.yml"))
-        base_cmd = list_io_classes_cmd("{param}", OutputFormat.table.name).encode('ascii')
-        commands = PeachFuzzer.get_fuzzed_command(base_cmd, TestRun.usr.fuzzy_iter_count)
+        base_cmd = list_io_classes_cmd(
+            cache_id="{param}", output_format=OutputFormat.table.name
+        )
+        commands = PeachFuzzer.get_fuzzed_command(
+            command_template=base_cmd, count=TestRun.usr.fuzzy_iter_count
+        )
 
-    for index, cmd in TestRun.iteration(enumerate(commands),
-                                        f"Run command {TestRun.usr.fuzzy_iter_count} times"):
+    for index, cmd in TestRun.iteration(
+        enumerate(commands), f"Run command {TestRun.usr.fuzzy_iter_count} times"
+    ):
         with TestRun.step(f"Iteration {index + 1}"):
-            run_cmd_and_validate(cmd, "Cache_id", cmd.param in valid_values)
+            run_cmd_and_validate(
+                cmd=cmd,
+                value_name="Cache id",
+                is_valid=cmd.param in valid_values,
+            )

test/functional/tests/security/fuzzy/kernel/fuzzy_io_class/test_fuzzy_io_class_list_output_format.py

@@ -1,20 +1,33 @@
 #
 # Copyright(c) 2022 Intel Corporation
+# Copyright(c) 2024 Huawei Technologies Co., Ltd.
 # SPDX-License-Identifier: BSD-3-Clause
 #
 
 import pytest
 
 from api.cas import casadm
-from api.cas.cache_config import CacheMode, CacheLineSize, CleaningPolicy, UnalignedIo, \
-    KernelParameters, UseIoScheduler
+from api.cas.cache_config import (
+    CacheMode,
+    CacheLineSize,
+    CleaningPolicy,
+    UnalignedIo,
+    KernelParameters,
+    UseIoScheduler,
+)
 from api.cas.casadm_params import OutputFormat
 from api.cas.cli import list_io_classes_cmd
 from core.test_run import TestRun
 from storage_devices.disk import DiskType, DiskTypeSet, DiskTypeLowerThan
 from test_tools.peach_fuzzer.peach_fuzzer import PeachFuzzer
-from tests.security.fuzzy.kernel.common.common import get_fuzz_config, prepare_cas_instance, \
-    run_cmd_and_validate
+from tests.security.fuzzy.kernel.common.common import (
+    get_fuzz_config,
+    prepare_cas_instance,
+    run_cmd_and_validate,
+)
+
+
+io_class_config_path = "/etc/opencas/ioclass-config.csv"
 
 
 @pytest.mark.require_disk("cache", DiskTypeSet([DiskType.optane, DiskType.nand]))
@@ -24,33 +37,47 @@ from tests.security.fuzzy.kernel.common.common import get_fuzz_config, prepare_c
 @pytest.mark.parametrizex("cleaning_policy", CleaningPolicy)
 @pytest.mark.parametrizex("unaligned_io", UnalignedIo)
 @pytest.mark.parametrizex("use_io_scheduler", UseIoScheduler)
-def test_fuzzy_io_class_list_output_format(cache_mode, cache_line_size, cleaning_policy,
-                                           unaligned_io, use_io_scheduler):
+def test_fuzzy_io_class_list_output_format(
+    cache_mode, cache_line_size, cleaning_policy, unaligned_io, use_io_scheduler
+):
     """
-        title: Fuzzy test for casadm list IO class command – output format
-        description: Using Peach Fuzzer check Open CAS ability of handling wrong output format in
-            ‘list IO class’ command.
-        pass_criteria:
-            - System did not crash
-            - Open CAS still works.
+    title: Fuzzy test for casadm list IO class command – output format
+    description: |
+        Using Peach Fuzzer check Open CAS ability of handling wrong output format in
+        'list IO class' command.
+    pass_criteria:
+      - System did not crash
+      - Open CAS still works.
     """
     with TestRun.step("Start cache and add core device"):
-        cache_disk = TestRun.disks['cache']
-        core_disk = TestRun.disks['core']
-        cache, core = prepare_cas_instance(cache_disk, core_disk, cache_mode, cache_line_size,
-                                           KernelParameters(unaligned_io, use_io_scheduler),
-                                           cleaning_policy)
+        cache_disk = TestRun.disks["cache"]
+        core_disk = TestRun.disks["core"]
+        cache, core = prepare_cas_instance(
+            cache_device=cache_disk,
+            core_device=core_disk,
+            cache_mode=cache_mode,
+            cache_line_size=cache_line_size,
+            kernel_params=KernelParameters(unaligned_io, use_io_scheduler),
+            cleaning_policy=cleaning_policy,
+        )
 
     with TestRun.step("Load default IO class configuration file"):
-        casadm.load_io_classes(cache.cache_id, '/etc/opencas/ioclass-config.csv')
+        casadm.load_io_classes(cache_id=cache.cache_id, file=io_class_config_path)
 
     with TestRun.step("Prepare PeachFuzzer"):
-        valid_values = [e.name.encode('ascii') for e in list(OutputFormat)]
+        valid_values = [e.name.encode("ascii") for e in list(OutputFormat)]
         PeachFuzzer.generate_config(get_fuzz_config("output_format.yml"))
-        base_cmd = list_io_classes_cmd(str(core.cache_id), "{param}").encode('ascii')
-        commands = PeachFuzzer.get_fuzzed_command(base_cmd, TestRun.usr.fuzzy_iter_count)
+        base_cmd = list_io_classes_cmd(cache_id=str(core.cache_id), output_format="{param}")
+        commands = PeachFuzzer.get_fuzzed_command(
+            command_template=base_cmd, count=TestRun.usr.fuzzy_iter_count
+        )
 
-    for index, cmd in TestRun.iteration(enumerate(commands),
-                                        f"Run command {TestRun.usr.fuzzy_iter_count} times"):
+    for index, cmd in TestRun.iteration(
+        enumerate(commands), f"Run command {TestRun.usr.fuzzy_iter_count} times"
+    ):
         with TestRun.step(f"Iteration {index + 1}"):
-            run_cmd_and_validate(cmd, "Output_format", cmd.param in valid_values)
+            run_cmd_and_validate(
+                cmd=cmd,
+                value_name="Output format",
+                is_valid=cmd.param in valid_values,
+            )