kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: replace as <pointer> casts with safer alternatives

Browse Source 
`as` casts can change mutability, which quickly leads to undefined
behavior.

Signed-off-by: Julian Schindel <mail@arctic-alpaca.de>
This commit is contained in:
Julian Schindel
2026-04-29 21:55:06 +02:00
committed by Rob Bradford
parent c97d635d40
commit 032f29da29
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
performance-metrics/src/micro_bench_block.rs
View File

@@ -32,12 +32,12 @@ pub fn micro_bench_aio_drain(control: &PerformanceTestControl) -> f64 {
.create_async_io(num_ops as u32)
.expect("failed to create AIO context");
let buf = vec![0xA5u8; BLOCK_SIZE as usize];
let mut buf = vec![0xA5u8; BLOCK_SIZE as usize];
// Submit all writes.
for i in 0..num_ops {
let iovec = libc::iovec {
iov_base: buf.as_ptr() as *mut _,
iov_base: buf.as_mut_ptr().cast(),
iov_len: buf.len(),
};
aio.write_vectored((i as u64 * BLOCK_SIZE) as libc::off_t, &[iovec], i as u64)
@@ -378,7 +378,7 @@ pub fn micro_bench_qcow_batch_read(control: &PerformanceTestControl) -> f64 {
BatchRequest {
offset: (i as u64 * QCOW_CLUSTER_SIZE) as libc::off_t,
iovecs: vec![libc::iovec {
iov_base: slice.as_mut_ptr() as *mut libc::c_void,
iov_base: slice.as_mut_ptr().cast(),
iov_len: QCOW_CLUSTER_SIZE as usize,
}]
.into(),
@@ -565,15 +565,16 @@ pub fn micro_bench_qcow_batch_write(control: &PerformanceTestControl) -> f64 {
.create_async_io(num_ops as u32)
.expect("create_async_io failed");
let buf = vec![0xA5u8; num_ops * QCOW_CLUSTER_SIZE as usize];
let mut buf = vec![0xA5u8; num_ops * QCOW_CLUSTER_SIZE as usize];
let batch: Vec<BatchRequest> = (0..num_ops)
.map(|i| {
let slice = &buf[i * QCOW_CLUSTER_SIZE as usize..(i + 1) * QCOW_CLUSTER_SIZE as usize];
let slice =
&mut buf[i * QCOW_CLUSTER_SIZE as usize..(i + 1) * QCOW_CLUSTER_SIZE as usize];
BatchRequest {
offset: (i as u64 * QCOW_CLUSTER_SIZE) as libc::off_t,
iovecs: vec![libc::iovec {
iov_base: slice.as_ptr() as *mut libc::c_void,
iov_base: slice.as_mut_ptr().cast(),
iov_len: QCOW_CLUSTER_SIZE as usize,
}]
.into(),

4
performance-metrics/src/util.rs
View File

@@ -84,7 +84,7 @@ pub fn drain_completions(async_io: &mut dyn AsyncIo, count: usize) {
/// Build an iovec suitable for a read into `buf`.
pub fn read_iovec(buf: &mut [u8]) -> libc::iovec {
libc::iovec {
iov_base: buf.as_mut_ptr() as *mut libc::c_void,
iov_base: buf.as_mut_ptr().cast(),
iov_len: buf.len(),
}
}
@@ -92,7 +92,7 @@ pub fn read_iovec(buf: &mut [u8]) -> libc::iovec {
/// Build an iovec suitable for a write from `buf`.
pub fn write_iovec(buf: &[u8]) -> libc::iovec {
libc::iovec {
iov_base: buf.as_ptr() as *mut libc::c_void,
iov_base: buf.as_ptr().cast::<libc::c_void>().cast_mut(),
iov_len: buf.len(),
}
}