kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmm: use UAPI name for PIDTYPE_PID

Browse Source 
As far as I can tell, PIDTYPE_PID is a kernel-internal name, and
PR_SCHED_CORE_SCOPE_THREAD is the UAPI name.  There's no PIDTYPE_PID
in the UAPI headers, and the core scheduling documentation says that
the fourth prctl argument should be a "PR_SCHED_CORE_SCOPE_-prefixed
macro constant".

Link: https://www.kernel.org/doc/html/v6.19/admin-guide/hw-vuln/core-scheduling.html#usage
Fixes: 3f800d2bb ("vmm: Add core scheduling support for vCPU threads")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
This commit is contained in:
Alyssa Ross
2026-03-25 14:49:22 +01:00
committed by Rob Bradford
parent a8d962640f
commit 0b90180266
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
vmm/src/cpu.rs
View File

@@ -230,14 +230,22 @@ const PR_SCHED_CORE: libc::c_int = 62;
const PR_SCHED_CORE_GET: libc::c_int = 0;
const PR_SCHED_CORE_CREATE: libc::c_int = 1;
const PR_SCHED_CORE_SHARE_FROM: libc::c_int = 3;
const PIDTYPE_PID: libc::c_int = 0;
const PR_SCHED_CORE_SCOPE_THREAD: libc::c_int = 0;
/// Create a new unique core scheduling cookie for the current thread.
/// Silently succeeds on kernels that don't support PR_SCHED_CORE.
fn core_scheduling_create() -> Result<()> {
// SAFETY: prctl with PR_SCHED_CORE_CREATE on the current thread (pid=0).
// All arguments are valid constants. We check the return value.
let ret = unsafe { libc::prctl(PR_SCHED_CORE, PR_SCHED_CORE_CREATE, 0, PIDTYPE_PID, 0) };
let ret = unsafe {
libc::prctl(
PR_SCHED_CORE,
PR_SCHED_CORE_CREATE,
0,
PR_SCHED_CORE_SCOPE_THREAD,
0,
)
};
if ret == -1 {
let err = io::Error::last_os_error();
// EINVAL: kernel < 5.14 where PR_SCHED_CORE is unknown.
@@ -261,7 +269,15 @@ fn core_scheduling_create() -> Result<()> {
fn core_scheduling_share_from(tid: i32) -> Result<()> {
// SAFETY: prctl with PR_SCHED_CORE_SHARE_FROM targeting tid.
// All arguments are valid. We check the return value.
let ret = unsafe { libc::prctl(PR_SCHED_CORE, PR_SCHED_CORE_SHARE_FROM, tid, PIDTYPE_PID, 0) };
let ret = unsafe {
libc::prctl(
PR_SCHED_CORE,
PR_SCHED_CORE_SHARE_FROM,
tid,
PR_SCHED_CORE_SCOPE_THREAD,
0,
)
};
if ret == -1 {
let err = io::Error::last_os_error();
match err.raw_os_error() {
@@ -283,7 +299,7 @@ fn core_scheduling_cookie() -> u64 {
PR_SCHED_CORE,
PR_SCHED_CORE_GET,
0,
PIDTYPE_PID,
PR_SCHED_CORE_SCOPE_THREAD,
&mut cookie as *mut u64,
)
};