kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

performance-metrics: Refactor run() to use effective_control

Browse Source 
Consolidate override application into a single effective_control
variable built once before the test loop. This removes duplicated
timeout override logic from both warmup and measurement iterations.

Signed-off-by: Muminul Islam <muislam@microsoft.com>
This commit is contained in:
Muminul Islam
2026-04-01 18:31:20 -07:00
committed by Rob Bradford
parent 11623a2183
commit 4b4845eb4d
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
performance-metrics/src/main.rs
View File

@@ -282,15 +282,17 @@ impl PerformanceTest {
);
}
let effective_control = {
let mut control = self.control.clone();
if let Some(test_timeout) = overrides.test_timeout {
control.test_timeout = test_timeout;
}
control
};
// Run warmup iterations if configured (results discarded)
for _ in 0..self.control.warmup_iterations {
if let Some(test_timeout) = overrides.test_timeout {
let mut control: PerformanceTestControl = self.control.clone();
control.test_timeout = test_timeout;
let _ = (self.func_ptr)(&control);
} else {
let _ = (self.func_ptr)(&self.control);
}
let _ = (self.func_ptr)(&effective_control);
}
let mut metrics = Vec::new();
@@ -298,14 +300,7 @@ impl PerformanceTest {
.test_iterations
.unwrap_or(self.control.test_iterations)
{
// update the timeout in control if passed explicitly and run testcase with it
if let Some(test_timeout) = overrides.test_timeout {
let mut control: PerformanceTestControl = self.control.clone();
control.test_timeout = test_timeout;
metrics.push((self.func_ptr)(&control));
} else {
metrics.push((self.func_ptr)(&self.control));
}
metrics.push((self.func_ptr)(&effective_control));
}
let mean = (self.unit_adjuster)(mean(&metrics).unwrap());