kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

pci: msix: Reject mis-sized MSI-X table and PBA reads

Browse Source 
Replace assertions for incorrect access sizes with logged errors. The
write_table() method already handled it like this and this commit
extends the same pattern to read_table() and read_pba().

Signed-off-by: Rob Bradford <rbradford@meta.com>
This commit is contained in:
Rob Bradford
2026-06-17 19:43:57 +01:00
parent 427c4de928
commit 61193de6e3
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pci/src/msix.rs
View File

@@ -268,7 +268,14 @@ impl MsixConfig {
}
pub fn read_table(&self, offset: u64, data: &mut [u8]) {
assert!(data.len() == 4 || data.len() == 8);
if data.len() != 4 && data.len() != 8 {
error!(
"invalid MSI-X table read size: {} (allowed: 4 or 8)",
data.len()
);
data.fill(0xff);
return;
}
let index: usize = (offset / MSIX_TABLE_ENTRIES_MODULO) as usize;
let modulo_offset = offset % MSIX_TABLE_ENTRIES_MODULO;
@@ -423,7 +430,14 @@ impl MsixConfig {
}
pub fn read_pba(&mut self, offset: u64, data: &mut [u8]) {
assert!(data.len() == 4 || data.len() == 8);
if data.len() != 4 && data.len() != 8 {
error!(
"invalid MSI-X PBA read size: {} (allowed: 4 or 8)",
data.len()
);
data.fill(0xff);
return;
}
let index: usize = (offset / MSIX_PBA_ENTRIES_MODULO) as usize;
let modulo_offset = offset % MSIX_PBA_ENTRIES_MODULO;