kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: generic vhost-user: reject virtio device IDs that cannot work

Browse Source 
Some virtio devices cannot be implemented via vhost-user because they
require tight integration with the VMM.  This includes the IOMMU and
watchdog devices.

An attempt to create a generic vhost-user device with one of these IDs
is always either a bug or human error.  To aid debugging, return a
helpful error message rather than silently continuing.

Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
This commit is contained in:
Demi Marie Obenour
2026-02-13 16:45:10 -05:00
committed by Rob Bradford
parent 7ea1fa07a2
commit 989f3a3233
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
vmm/src/config.rs
View File

@@ -52,6 +52,11 @@ pub enum Error {
"Error parsing --generic-vhost-user: virtio ID {0:?} invalid (leading zeros or unknown string)"
)]
ParseGenericVhostUserVirtioIdInvalid(String),
/// Generic vhost-user virtio ID is unsupported
#[error(
"Error parsing --generic-vhost-user: device with virtio ID {0:?} cannot be implemented via vhost-user"
)]
ParseGenericVhostUserVirtioIdUnsupported(String),
/// Generic vhost-user socket is missing
#[error("Error parsing --generic-vhost-user: socket missing")]
ParseGenericVhostUserSockMissing,
@@ -1759,6 +1764,18 @@ impl GenericVhostUserConfig {
},
_ => return Err(Error::ParseGenericVhostUserVirtioIdInvalid(device_type_str)),
};
match device_type {
// vhost-user devices of these types definitely cannot work.
// Cloud Hypervisor needs to know if an IOMMU exists so that it
// can perform address translation, and a vhost-user device has
// no supported way to reset the guest.
VIRTIO_ID_WATCHDOG | VIRTIO_ID_IOMMU => {
return Err(Error::ParseGenericVhostUserVirtioIdUnsupported(
device_type_str,
));
}
_ => {}
}
let id = parser.get("id");
let pci_segment = parser
.convert("pci_segment")
@@ -3992,6 +4009,9 @@ id=\"{id}\",pci_segment={pci_segment},queue_sizes={queue_sizes}"
));
if pci_segment <= u16::MAX.into()
&& virtio_id <= u32::MAX.into()
&& virtio_id != u64::from(VIRTIO_ID_BALLOON)
&& virtio_id != u64::from(VIRTIO_ID_WATCHDOG)
&& virtio_id != u64::from(VIRTIO_ID_IOMMU)
&& queue_sizes.0.iter().all(|&f| f <= u16::MAX.into())
{
assert_eq!(