kata-containers/cloud-hypervisor
1
0
Fork 0
mirror of https://github.com/cloud-hypervisor/cloud-hypervisor.git synced 2026-08-05 02:19:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

vmm: call notify_guest_clock_paused for Hyper-V guests

Browse Source 
Previously, KVM_KVMCLOCK_CTRL was skipped when kvm_hyperv=on because
Windows does not use pvclock directly. However, KVM internally uses
pvclock data structures as the basis for computing the Hyper-V
Reference TSC page parameters. Not calling KVM_KVMCLOCK_CTRL means
there is no mechanism to signal time discontinuity to Windows guests
after pause/resume, contributing to multi-minute hangs.

Remove the kvm_hyperv guard so all guests receive the clock-paused
notification.

Signed-off-by: CMGS <ilskdw@gmail.com>
This commit is contained in:
CMGS
2026-03-31 06:13:58 +00:00
committed by Rob Bradford
parent 082fdc4d07
commit ca58685f4c
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
vmm/src/cpu.rs
View File

@@ -2637,16 +2637,16 @@ impl Pausable for CpuManager {
self.signal_vcpus()
.map_err(|e| MigratableError::Pause(anyhow!("Error signalling vCPUs: {e}")))?;
// Notify all guests (including Hyper-V / Windows) that the clock was
// paused. KVM_KVMCLOCK_CTRL updates internal KVM state that affects
// both pvclock (Linux) and the Hyper-V TSC reference page, so it must
// be called unconditionally.
#[cfg(all(feature = "kvm", target_arch = "x86_64"))]
for vcpu in self.vcpus.iter() {
let vcpu = vcpu.lock().unwrap();
if !self.config.kvm_hyperv {
vcpu.vcpu.notify_guest_clock_paused().map_err(|e| {
MigratableError::Pause(anyhow!(
"Could not notify guest it has been paused {e:?}"
))
})?;
}
vcpu.vcpu.notify_guest_clock_paused().map_err(|e| {
MigratableError::Pause(anyhow!("Could not notify guest it has been paused {e:?}"))
})?;
}
// The vCPU thread will change its paused state before parking, wait here for each