vmm: config: Reject invalid virtio queue sizes

The queue size must fit into a u16 and be a power of 2 according to the
spec.

Signed-off-by: Rob Bradford <rbradford@meta.com>

vmm/src/config.rs

@@ -33,6 +33,9 @@ use crate::vm_config::*;
 const MAX_NUM_PCI_SEGMENTS: u16 = 96;
 const MAX_IOMMU_ADDRESS_WIDTH_BITS: u8 = 64;
 
+// Maximum queue size is largest power of 2 that fits into a u16
+const VIRTIO_MAX_QUEUE_SIZE: u16 = 32768;
+
 #[cfg(all(feature = "kvm", target_arch = "x86_64"))]
 const MAX_SUPPORTED_CPUS: u32 = 8192;
 #[cfg(not(all(feature = "kvm", target_arch = "x86_64")))]
@@ -290,9 +293,12 @@ pub enum ValidationError {
     /// Insufficient vCPUs for queues
     #[error("Queue count ({0}) must not exceed boot vCPUs ({1})")]
     TooManyQueues(usize /* queues */, usize /* vCPUs */),
-    /// Invalid queue size
-    #[error("Queue size is smaller than {MINIMUM_BLOCK_QUEUE_SIZE}: {0}")]
+    /// Queue size is not a power of 2 within the spec-permitted range
+    #[error("Queue size must be a power of 2 no greater than {VIRTIO_MAX_QUEUE_SIZE}: {0}")]
     InvalidQueueSize(u16),
+    /// Block queue size too small to advertise a usable seg_max
+    #[error("Block queue size must be greater than {MINIMUM_BLOCK_QUEUE_SIZE}: {0}")]
+    BlockQueueSizeTooSmall(u16),
     /// Need shared memory for vfio-user
     #[error("Using user devices requires using shared memory or huge pages")]
     UserDevicesRequireSharedMemory,
@@ -454,6 +460,16 @@ fn validate_pci_device_id(device_id: u8) -> ValidationResult<()> {
     Ok(())
 }
 
+/// Reject a virtio queue size that is not a power of 2 as required by the
+/// spec. The `u16` type already handles the maximum queue size.
+fn validate_queue_size(queue_size: u16) -> ValidationResult<()> {
+    if !queue_size.is_power_of_two() {
+        return Err(ValidationError::InvalidQueueSize(queue_size));
+    }
+
+    Ok(())
+}
+
 pub type Result<T> = result::Result<T, Error>;
 
 pub struct VmParams<'a> {
@@ -1610,8 +1626,10 @@ impl DiskConfig {
             ));
         }
 
+        validate_queue_size(self.queue_size)?;
+
         if self.queue_size <= MINIMUM_BLOCK_QUEUE_SIZE {
-            return Err(ValidationError::InvalidQueueSize(self.queue_size));
+            return Err(ValidationError::BlockQueueSizeTooSmall(self.queue_size));
         }
 
         if self.vhost_user && self.pci_common.iommu {
@@ -1851,6 +1869,8 @@ impl NetConfig {
             ));
         }
 
+        validate_queue_size(self.queue_size)?;
+
         if self.vhost_user && self.pci_common.iommu {
             return Err(ValidationError::IommuNotSupported);
         }
@@ -2087,6 +2107,10 @@ impl GenericVhostUserConfig {
             return Err(ValidationError::IommuNotSupported);
         }
 
+        for &queue_size in &self.queue_sizes {
+            validate_queue_size(queue_size)?;
+        }
+
         self.pci_common.validate(vm_config)
     }
 }
@@ -2141,6 +2165,8 @@ impl FsConfig {
             ));
         }
 
+        validate_queue_size(self.queue_size)?;
+
         if self.pci_common.iommu {
             return Err(ValidationError::IommuNotSupported);
         }
@@ -5567,6 +5593,42 @@ id=\"{id}\",pci_segment={pci_segment},queue_sizes={queue_sizes}"
         still_valid_config.memory.shared = true;
         still_valid_config.validate().unwrap();
 
+        // A block queue size that is not a power of 2 is rejected.
+        let mut invalid_config = valid_config.clone();
+        invalid_config.disks = Some(vec![DiskConfig {
+            queue_size: 100,
+            ..disk_fixture()
+        }]);
+        assert_eq!(
+            invalid_config.validate(),
+            Err(ValidationError::InvalidQueueSize(100))
+        );
+
+        // A power-of-2 block queue size too small for a usable seg_max is
+        // rejected with the block-specific error.
+        let mut invalid_config = valid_config.clone();
+        invalid_config.disks = Some(vec![DiskConfig {
+            queue_size: MINIMUM_BLOCK_QUEUE_SIZE,
+            ..disk_fixture()
+        }]);
+        assert_eq!(
+            invalid_config.validate(),
+            Err(ValidationError::BlockQueueSizeTooSmall(
+                MINIMUM_BLOCK_QUEUE_SIZE
+            ))
+        );
+
+        // A net queue size that is not a power of 2 is rejected.
+        let mut invalid_config = valid_config.clone();
+        invalid_config.net = Some(vec![NetConfig {
+            queue_size: 100,
+            ..net_fixture()
+        }]);
+        assert_eq!(
+            invalid_config.validate(),
+            Err(ValidationError::InvalidQueueSize(100))
+        );
+
         let mut invalid_config = valid_config.clone();
         invalid_config.net = Some(vec![NetConfig {
             vhost_user: true,