Clean up after cherry-picking commits from firecracker

Signed-off-by: YUAN LYU <lyuyuan92@gmail.com>

Cargo.lock

@@ -6,16 +6,6 @@ version = "1.2.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "cf1de2fe8c75bc145a2f577add951f8134889b4795d47466a54a5c846d691693"
 
-[[package]]
-name = "epoll"
-version = "4.1.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "990bcfe26bea89669ede68c3f970f61d02568dbc8660317c98d805ea4e710685"
-dependencies = [
- "bitflags",
- "libc",
-]
-
 [[package]]
 name = "libc"
 version = "0.2.66"
@@ -26,5 +16,16 @@ checksum = "d515b1f41455adea1313a4a2ac8a8a477634fbae63cc6100e3aebb207ce61558"
 name = "micro_http"
 version = "0.1.0"
 dependencies = [
- "epoll",
+ "libc",
+ "vmm-sys-util",
+]
+
+[[package]]
+name = "vmm-sys-util"
+version = "0.8.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "01cf11afbc4ebc0d5c7a7748a77d19e2042677fc15faa2f4ccccb27c18a60605"
+dependencies = [
+ "bitflags",
+ "libc",
 ]

Cargo.toml

@@ -6,4 +6,5 @@ authors = ["Amazon Firecracker team <firecracker-devel@amazon.com>"]
 edition = "2018"
 
 [dependencies]
-epoll = ">=4.0.1"
+libc = ">=0.2.39"
+vmm-sys-util = ">=0.6.1"

src/common/headers.rs

@@ -534,7 +534,10 @@ mod tests {
                 b"Last-Modified: Tue, 15 Nov 1994 12:45:26 GMT\r\nContent-Length: -55\r\n\r\n"
             )
             .unwrap_err(),
-            RequestError::InvalidHeader
+            RequestError::HeaderError(HttpHeaderError::InvalidValue(
+                "Content-Length".to_string(),
+                " -55".to_string()
+            ))
         );
 
         let bytes: [u8; 10] = [130, 140, 150, 130, 140, 150, 130, 140, 150, 160];

src/common/mod.rs

@@ -134,6 +134,7 @@ impl Display for ConnectionError {
 
 /// Errors pertaining to `HttpRoute`.
 #[derive(Debug)]
+#[allow(dead_code)]
 pub enum RouteError {
     /// Handler for http routing path already exists.
     HandlerExist(String),

src/lib.rs

@@ -115,10 +115,10 @@ mod server;
 use crate::common::ascii;
 use crate::common::headers;
 
+pub use self::router::{EndpointHandler, HttpRoutes, RouteError};
+pub use crate::common::headers::{Encoding, Headers, MediaType};
+pub use crate::common::{Body, HttpHeaderError, Method, Version};
 pub use crate::connection::{ConnectionError, HttpConnection};
 pub use crate::request::{Request, RequestError};
 pub use crate::response::{Response, ResponseHeaders, StatusCode};
 pub use crate::server::{HttpServer, ServerError, ServerRequest, ServerResponse};
-
-pub use crate::common::headers::{Encoding, Headers, MediaType};
-pub use crate::common::{Body, HttpHeaderError, Method, Version};

src/server.rs

@@ -1,7 +1,6 @@
 // Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-use logger::error;
 use std::io::{Read, Write};
 use std::os::unix::io::AsRawFd;
 use std::os::unix::io::RawFd;
@@ -15,7 +14,7 @@ use crate::request::Request;
 use crate::response::{Response, StatusCode};
 use std::collections::HashMap;
 
-use utils::epoll;
+use vmm_sys_util::epoll;
 
 static SERVER_FULL_ERROR_MESSAGE: &[u8] = b"HTTP/1.1 503\r\n\
                                             Server: Firecracker API\r\n\
@@ -310,7 +309,7 @@ impl HttpServer {
         // current thread until at least one event is received.
         // The received notifications will then populate the `events` array with
         // `event_count` elements, where 1 <= event_count <= MAX_CONNECTIONS.
-        let event_count = match self.epoll.wait(MAX_CONNECTIONS, -1, &mut events[..]) {
+        let event_count = match self.epoll.wait(-1, &mut events[..]) {
             Ok(event_count) => event_count,
             Err(e) if e.raw_os_error() == Some(libc::EINTR) => 0,
             Err(e) => return Err(ServerError::IOError(e)),
@@ -403,11 +402,11 @@ impl HttpServer {
         }
 
         // Remove dead connections.
-        let epoll_fd = self.epoll_fd;
+        let epoll = &self.epoll;
         self.connections.retain(|rawfd, client_connection| {
             if client_connection.is_done() {
                 // The rawfd should have been registered to the epoll fd.
-                Self::epoll_del(epoll_fd, *rawfd).unwrap();
+                Self::epoll_del(epoll, *rawfd).unwrap();
                 false
             } else {
                 true
@@ -429,8 +428,6 @@ impl HttpServer {
                     if let ServerError::ConnectionError(ConnectionError::InvalidWrite) = e {
                         // Nothing is logged since an InvalidWrite means we have successfully
                         // flushed the connection
-                    } else {
-                        error!("Connection write error: {}", e);
                     }
                     break;
                 }
@@ -450,7 +447,7 @@ impl HttpServer {
     /// use std::os::unix::io::AsRawFd;
     ///
     /// use micro_http::{HttpServer, Response, StatusCode};
-    /// use utils::epoll;
+    /// use vmm_sys_util::epoll;
     ///
     /// // Create our epoll manager.
     /// let epoll = epoll::Epoll::new().unwrap();
@@ -476,7 +473,7 @@ impl HttpServer {
     /// // Control loop of the application.
     /// let mut events = Vec::with_capacity(10);
     /// loop {
-    ///     let num_ev = epoll.wait(10, -1, events.as_mut_slice());
+    ///     let num_ev = epoll.wait(-1, events.as_mut_slice());
     ///     for event in events {
     ///         match event.data() {
     ///             // The server notification.
@@ -596,14 +593,14 @@ impl HttpServer {
     }
 
     /// Removes a stream to the `epoll` notification structure.
-    fn epoll_del(epoll_fd: RawFd, stream_fd: RawFd) -> Result<()> {
-        epoll::ctl(
-            epoll_fd,
-            epoll::ControlOptions::EPOLL_CTL_DEL,
-            stream_fd,
-            epoll::Event::new(epoll::Events::EPOLLIN, stream_fd as u64),
-        )
-        .map_err(ServerError::IOError)
+    fn epoll_del(epoll: &epoll::Epoll, stream_fd: RawFd) -> Result<()> {
+        epoll
+            .ctl(
+                epoll::ControlOperation::Delete,
+                stream_fd,
+                epoll::EpollEvent::new(epoll::EventSet::IN, stream_fd as u64),
+            )
+            .map_err(ServerError::IOError)
     }
 }
 
@@ -615,7 +612,7 @@ mod tests {
     use std::os::unix::net::UnixStream;
 
     use crate::common::Body;
-    use utils::tempfile::TempFile;
+    use vmm_sys_util::tempfile::TempFile;
 
     fn get_temp_socket_file() -> TempFile {
         let mut path_to_socket = TempFile::new().unwrap();