kata-containers/s390-tools
1
0
Fork 0
mirror of https://github.com/ibm-s390-linux/s390-tools.git synced 2026-08-05 02:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

zipl: extract_signature: fix memory leak of @signature

Browse Source 
Fix memory leak @signature in case of an unsupported signature type.

Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
This commit is contained in:
Marc Hartmayer
2023-03-13 19:29:04 +01:00
committed by Steffen Eiden
parent 21dbbcfa56
commit 0e86da9d66
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
zipl/src/bootmap.c
View File

@@ -511,9 +511,6 @@ extract_signature(const char *filename, void **ret_signature,
memcpy(signature, buffer + size - signature_size - sizeof(*file_sig),
signature_size);
*ret_signature = signature;
sig_head->length = signature_size;
switch (file_sig->id_type) {
case PKEY_ID_PKCS7:
sig_head->format = PKCS7_FORMAT;
@@ -522,8 +519,12 @@ extract_signature(const char *filename, void **ret_signature,
error_text("Unsupported signature type %02x",
file_sig->id_type);
signature_size = 0;
free(signature);
goto out;
}
sig_head->length = signature_size;
*ret_signature = signature;
/* return size of signature and corresponding header */
signature_size += sizeof(*file_sig);
out: