kata-containers/s390-tools
1
0
Fork 0
mirror of https://github.com/ibm-s390-linux/s390-tools.git synced 2026-08-05 02:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

zpcictl: Replace strncpy() with util_strlcpy()

Browse Source 
Use util_strlcpy() to copy log data correctly and get rid of the
following GCC8 compile warning:

zpcictl.c: In function ‘sclp_issue_action’:
zpcictl.c:312:3: warning: ‘strncpy’ specified bound 4054 equals
destination size [-Wstringop-truncation]
   strncpy(report.data.log_data, sdata, sizeof(report.data.log_data));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
This commit is contained in:
Jan Höppner
2018-11-09 15:13:41 +01:00
parent 320a49fc1a
commit 10ce432196
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zpcictl/zpcictl.c
View File

@@ -309,7 +309,8 @@ static void sclp_issue_action(struct zpci_device *pdev, int action)
if (pdev->class == PCI_CLASS_NVME)
sdata = collect_smart_data(pdev);
if (sdata) {
strncpy(report.data.log_data, sdata, sizeof(report.data.log_data));
util_strlcpy(report.data.log_data, sdata,
sizeof(report.data.log_data));
free(sdata);
}
sysfs_write_data(&report, pdev->slot);