kata-containers/s390-tools
1
0
Fork 0
mirror of https://github.com/ibm-s390-linux/s390-tools.git synced 2026-08-05 02:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

libkmipclient: Fix findings from static code checker

Browse Source 
The Coverity static code checker found a few bugs in the libkmipclient
code, fix those.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
Reviewed-by: Joerg Schmidbauer <jschmidb@de.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
This commit is contained in:
Ingo Franzki
2025-05-15 16:58:33 +02:00
committed by Jan Höppner
parent ce997c6d01
commit 486882a4df
5 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libkmipclient/attribute.c
View File

@@ -2432,7 +2432,7 @@ out:
kmip_node_free(iv);
kmip_node_free(tag);
kmip_node_free(ffl);
kmip_node_free(ffl);
kmip_node_free(ifl);
kmip_node_free(cnt);
kmip_node_free(icv);
kmip_node_free(salt);

2
libkmipclient/kmip.c
View File

@@ -1471,7 +1471,7 @@ retry:
chain = SSL_get_peer_cert_chain(conn->plain_tls.ssl);
if (chain == NULL) {
kmip_debug(debug, "SSL_get_peer_cert_chain failed");
return -EIO;
rc = -EIO;
goto out;
}

2
libkmipclient/request.c
View File

@@ -210,6 +210,8 @@ struct kmip_node *kmip_new_request_header(const struct kmip_version *version,
out:
kmip_node_free(ver);
kmip_node_free(max);
kmip_node_free(ccorr);
kmip_node_free(scorr);
kmip_node_free(async);
kmip_node_free(err);
kmip_node_free(ord);

2
libkmipclient/response.c
View File

@@ -1369,7 +1369,7 @@ int kmip_get_get_response_payload(const struct kmip_node *node,
return 0;
error:
if (*unique_id != NULL) {
if (unique_id != NULL && *unique_id != NULL) {
kmip_node_free(*unique_id);
*unique_id = NULL;
}

1
libkmipclient/tls.c
View File

@@ -351,7 +351,6 @@ int kmip_connection_tls_init(struct kmip_connection *conn, bool debug)
if (tok == NULL) {
kmip_debug(debug, "malformed IPv6 address");
rc = -EINVAL;
free(hostname);
goto out;
}
tok++;