mirror of
https://github.com/ibm-s390-linux/s390-tools.git
synced 2026-08-05 02:14:52 +00:00
chpstat: Improve --cmg value parsing
Switch from atoi() to existing parse_int() helper function for parsing the integer --cmg argument to better handle invalid values such as numbers followed by an unsupported suffix (e.g. 1x). Reviewed-by: Jan Höppner <hoeppner@linux.ibm.com> Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com> Signed-off-by: Peter Oberparleiter <oberpar@linux.ibm.com> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
This commit is contained in:
committed by
Steffen Eiden
parent
30dc1a5ddd
commit
54e175a783
@@ -448,9 +448,11 @@ static void parse_cmgs(char *arg)
|
||||
{
|
||||
struct cmg_t *cmg_t;
|
||||
char *name;
|
||||
int cmg;
|
||||
|
||||
while ((name = strsep(&arg, ","))) {
|
||||
cmg_t = cmg_get(atoi(name));
|
||||
cmg = parse_int("cmg", name, 1, 255);
|
||||
cmg_t = cmg_get(cmg);
|
||||
if (!cmg_t)
|
||||
errx(EXIT_USAGE, "Unsupported CMG '%s'", name);
|
||||
cmg_t->selected = true;
|
||||
|
||||
Reference in New Issue
Block a user