kata-containers/s390-tools
1
0
Fork 0
mirror of https://github.com/ibm-s390-linux/s390-tools.git synced 2026-08-05 02:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

opticsmon: Fix wrong size check for OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET

Browse Source 
The code accesses OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET so the size needs
to be one larger for the LOS to be accessible.

Fixes: c34adb9cab ("opticsmon: Introduce opticsmon tool")
Reviewed-by: Jan Höppner <hoeppner@linux.ibm.com>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
This commit is contained in:
Niklas Schnelle
2026-04-30 17:13:16 +02:00
committed by Jan Höppner
parent 3696d6bd08
commit 8b38bf37b0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
opticsmon/optics_info.c
+1 -1
View File
@@ -66,7 +66,7 @@ bool optics_los_implemented(struct optics *oi)
} else if (type == OPTICS_TYPE_QSFP28) { } else if (type == OPTICS_TYPE_QSFP28) {
if (oi->size < OPTICS_QSFP28_LOS_OFFSET + 1) if (oi->size < OPTICS_QSFP28_LOS_OFFSET + 1)
return false; return false;
if (oi->size < OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET) if (oi->size < OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET + 1)
return false; return false;
implemented = oi->raw[OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET]; implemented = oi->raw[OPTICS_QSFP28_LOS_IMPLEMENTED_OFFSET];
/* /*