github/open-cas-linux
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[feat] Enhance cache cleaning policy configuration #1

Merged
td-zhangshun merged 2 commits from clean into v24.9-td 2025-04-17 08:10:22 +00:00
Conversation 4 Commits 2 Files Changed 4 +274 -7
td-zhangshun commented 2025-04-16 05:02:16 +00:00
Collaborator
Copy Link
No description provided.
👍 1
td-zhangshun added 2 commits 2025-04-16 05:02:17 +00:00
[fix] Enhance cache cleaning policy configuration 09764e0e15 
- Add set_param_cleaning_policy method for ACP and ALRU policies
- Add validation for wake-up and flush-max-buffers parameters
- Improve cache configuration to handle different cleaning policies
- Fix casctl stop with flush option for proper shutdown
[test] Add unit tests for ACP and ALRU cleaning policy parameters d3a71ae56f 
- Add tests for wake-up and flush-max-buffers parameter validation
- Test parameter boundary values and error conditions
- Cover parameter parsing from configuration strings
- Verify set_param_cleaning_policy commands construction
- Test proper handling of different cleaning policies in configure_cache

These tests ensure the proper validation and handling of cleaning policy
parameters introduced in the previous commits.
td-zhangshun changed title from [feat] Enhance cache cleaning policy configuration to WIP: [feat] Enhance cache cleaning policy configuration 2025-04-16 05:02:25 +00:00
td-zhangshun force-pushed clean from d3a71ae56f to 672ddb1a94 2025-04-16 05:04:17 +00:00 Compare
liyi commented 2025-04-16 05:17:05 +00:00
Owner
Copy Link

测试好了以后，可以直接和我的那个commit合并，控制commit数量在两个以内。

测试好了以后，可以直接和我的那个commit合并，控制commit数量在两个以内。
td-zhangshun force-pushed clean from 672ddb1a94 to 0ce2e344b0 2025-04-16 10:50:15 +00:00 Compare
td-zhangshun requested review from liyi 2025-04-16 10:52:21 +00:00
td-zhangshun changed title from WIP: [feat] Enhance cache cleaning policy configuration to [feat] Enhance cache cleaning policy configuration 2025-04-16 10:52:23 +00:00
td-zhangshun force-pushed clean from 0ce2e344b0 to aec8e7e31c 2025-04-16 10:57:22 +00:00 Compare
td-zhangshun force-pushed clean from aec8e7e31c to 5f0a32cddb 2025-04-16 10:59:21 +00:00 Compare
liyi approved these changes 2025-04-16 11:42:31 +00:00
liyi left a comment
Owner
Copy Link

lgtm

lgtm
td-zhangshun force-pushed clean from 5f0a32cddb to 02a209aff8 2025-04-17 06:23:04 +00:00 Compare
td-zhangshun commented 2025-04-17 06:25:38 +00:00
Author
Collaborator
Copy Link

测试没有问题了

image
image
image

测试没有问题了 ![image](/attachments/69e1d947-6440-41f3-9327-43a9b7cf91aa) <img width="609" alt="image" src="attachments/4e670d98-365b-4906-93a2-a9a6fd90ded3"> <img width="1680" alt="image" src="attachments/a1932922-7d38-494a-a7a5-635ea52fa51d">
image.png
3.9 MiB
image.png
720 KiB
image.png
353 KiB
image.png
237 KiB
image.png
td-zhangshun commented 2025-04-17 06:31:18 +00:00
Author
Collaborator
Copy Link
image
<img width="1680" alt="image" src="attachments/6e3e4cbe-fe9e-4c97-b9d7-3d8e31be7414">
image.png
1.3 MiB
td-zhangshun merged commit 02a209aff8 into v24.9-td 2025-04-17 08:10:22 +00:00
td-zhangshun deleted branch clean 2025-04-17 08:10:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
liyi
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jimlaren liyi maoziqiang td-zhangshun wanglei
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/open-cas-linux#1
Delete Branch "clean"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?